85294 2012-05-01 09:57:37 -0700 Use HashMap<OwnPtr> for CounterMap in RenderCounter 2012-05-02 12:34:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 igor.oliveira webkit-unassigned jchaffraix kling webkit.review.bot oldest_to_newest 613486 0 igor.oliveira 2012-05-01 09:57:37 -0700 Use HashMap<OwnPtr> for CounterMap in RenderCounter 613491 1 139643 igor.oliveira 2012-05-01 10:03:11 -0700 Created attachment 139643 Patch Proposed patch. 613507 2 139643 eric 2012-05-01 10:30:57 -0700 Comment on attachment 139643 Patch Seems reasonable. I believe it's safe to use an OwnPtr as a HashMap value. 613510 3 139643 webkit.review.bot 2012-05-01 10:39:30 -0700 Comment on attachment 139643 Patch Clearing flags on attachment: 139643 Committed r115736: <http://trac.webkit.org/changeset/115736> 613511 4 webkit.review.bot 2012-05-01 10:39:35 -0700 All reviewed patches have been landed. Closing bug. 614531 5 139643 darin 2012-05-02 12:34:39 -0700 Comment on attachment 139643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139643&action=review > Source/WebCore/rendering/RenderCounter.cpp:443 > nodeMap = new CounterMap; > - counterMaps().set(object, nodeMap); > + counterMaps().set(object, adoptPtr(nodeMap)); It would have been better to do a version of this where the adoptPtr and the new are on the same line of code. 139643 2012-05-01 10:03:11 -0700 2012-05-02 12:34:39 -0700 Patch 0001-Use-HashMap-OwnPtr-for-CounterMap-in-RenderCounter.patch text/plain 2729 igor.oliveira RnJvbSBiNTRhNGE0YTlhZjNiMTU5YzRlZTI1YWQzM2JjOTI2YmVkMDE4OWYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIE9saXZlaXJhIDxpZ29yLm9Ac2lzYS5zYW1zdW5nLmNv bT4KRGF0ZTogVHVlLCAxIE1heSAyMDEyIDA5OjU3OjUzIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0g VXNlIEhhc2hNYXA8T3duUHRyPiBmb3IgQ291bnRlck1hcCBpbiBSZW5kZXJDb3VudGVyCgotLS0K IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysr KysrKysrCiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291bnRlci5jcHAgfCAgICA3 ICsrKy0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggMzgyZWI5NS4uZjliOWYzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEyLTA1LTAxICBJZ29yIE9saXZlaXJhICA8aWdvci5vQHNpc2Euc2Ftc3VuZy5j b20+CisKKyAgICAgICAgVXNlIEhhc2hNYXA8T3duUHRyPiBmb3IgQ291bnRlck1hcCBpbiBSZW5k ZXJDb3VudGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04NTI5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckNvdW50ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAg ICAgIChXZWJDb3JlOjptYWtlQ291bnRlck5vZGUpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy Q291bnRlcjo6ZGVzdHJveUNvdW50ZXJOb2Rlcyk6CisKIDIwMTItMDUtMDEgIFBoaWxpcCBSb2dl cnMgIDxwZHJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBTa2lwIGJ1aWxkaW5nIGluc3RhbmNlIHRy ZWUgZm9yIGRpc2FsbG93ZWQgdGFyZ2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQ291bnRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Q291bnRlci5jcHAKaW5kZXggMDgwN2VhOS4uMjljMGYxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckNvdW50ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJDb3VudGVyLmNwcApAQCAtNDEsNyArNDEsNyBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogCiB0eXBlZGVmIEhhc2hNYXA8UmVm UHRyPEF0b21pY1N0cmluZ0ltcGw+LCBSZWZQdHI8Q291bnRlck5vZGU+ID4gQ291bnRlck1hcDsK LXR5cGVkZWYgSGFzaE1hcDxjb25zdCBSZW5kZXJPYmplY3QqLCBDb3VudGVyTWFwKj4gQ291bnRl ck1hcHM7Cit0eXBlZGVmIEhhc2hNYXA8Y29uc3QgUmVuZGVyT2JqZWN0KiwgT3duUHRyPENvdW50 ZXJNYXA+ID4gQ291bnRlck1hcHM7CiAKIHN0YXRpYyBDb3VudGVyTm9kZSogbWFrZUNvdW50ZXJO b2RlKFJlbmRlck9iamVjdCosIGNvbnN0IEF0b21pY1N0cmluZyYgaWRlbnRpZmllciwgYm9vbCBh bHdheXNDcmVhdGVDb3VudGVyKTsKIApAQCAtNDQwLDcgKzQ0MCw3IEBAIHN0YXRpYyBDb3VudGVy Tm9kZSogbWFrZUNvdW50ZXJOb2RlKFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25zdCBBdG9taWNT dHJpbmcmIGlkCiAgICAgICAgIG5vZGVNYXAgPSBjb3VudGVyTWFwcygpLmdldChvYmplY3QpOwog ICAgIGVsc2UgewogICAgICAgICBub2RlTWFwID0gbmV3IENvdW50ZXJNYXA7Ci0gICAgICAgIGNv dW50ZXJNYXBzKCkuc2V0KG9iamVjdCwgbm9kZU1hcCk7CisgICAgICAgIGNvdW50ZXJNYXBzKCku c2V0KG9iamVjdCwgYWRvcHRQdHIobm9kZU1hcCkpOwogICAgICAgICBvYmplY3QtPnNldEhhc0Nv dW50ZXJOb2RlTWFwKHRydWUpOwogICAgIH0KICAgICBub2RlTWFwLT5zZXQoaWRlbnRpZmllci5p bXBsKCksIG5ld05vZGUpOwpAQCAtNTYzLDE0ICs1NjMsMTMgQEAgdm9pZCBSZW5kZXJDb3VudGVy OjpkZXN0cm95Q291bnRlck5vZGVzKFJlbmRlck9iamVjdCogb3duZXIpCiAgICAgQ291bnRlck1h cHM6Oml0ZXJhdG9yIG1hcHNJdGVyYXRvciA9IG1hcHMuZmluZChvd25lcik7CiAgICAgaWYgKG1h cHNJdGVyYXRvciA9PSBtYXBzLmVuZCgpKQogICAgICAgICByZXR1cm47Ci0gICAgQ291bnRlck1h cCogbWFwID0gbWFwc0l0ZXJhdG9yLT5zZWNvbmQ7CisgICAgQ291bnRlck1hcCogbWFwID0gbWFw c0l0ZXJhdG9yLT5zZWNvbmQuZ2V0KCk7CiAgICAgQ291bnRlck1hcDo6Y29uc3RfaXRlcmF0b3Ig ZW5kID0gbWFwLT5lbmQoKTsKICAgICBmb3IgKENvdW50ZXJNYXA6OmNvbnN0X2l0ZXJhdG9yIGl0 ID0gbWFwLT5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKICAgICAgICAgQXRvbWljU3RyaW5n IGlkZW50aWZpZXIoaXQtPmZpcnN0LmdldCgpKTsKICAgICAgICAgZGVzdHJveUNvdW50ZXJOb2Rl V2l0aG91dE1hcFJlbW92YWwoaWRlbnRpZmllciwgaXQtPnNlY29uZC5nZXQoKSk7CiAgICAgfQog ICAgIG1hcHMucmVtb3ZlKG1hcHNJdGVyYXRvcik7Ci0gICAgZGVsZXRlIG1hcDsKICAgICBvd25l ci0+c2V0SGFzQ291bnRlck5vZGVNYXAoZmFsc2UpOwogfQogCi0tIAoxLjcuNS40Cgo=