85290 2012-05-01 09:22:23 -0700 [Chromium] Fix WebPrerender::referrer() thunk. 2012-05-01 11:22:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gavinp gavinp abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 613451 0 gavinp 2012-05-01 09:22:23 -0700 [Chromium] Fix WebPrerender::referrer() thunk. 613453 1 139638 gavinp 2012-05-01 09:23:51 -0700 Created attachment 139638 Patch 613454 2 gavinp 2012-05-01 09:25:14 -0700 Amazingly, this code built fine in my clang, but it caused much trouble in gcc. Abarth, WDYT? 613457 3 webkit.review.bot 2012-05-01 09:28:30 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 613458 4 webkit.review.bot 2012-05-01 09:28:53 -0700 Attachment 139638 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/Platform/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 613472 5 139641 gavinp 2012-05-01 09:39:21 -0700 Created attachment 139641 Patch 613478 6 gavinp 2012-05-01 09:42:37 -0700 webkit-patch is funny about changelogs and committed changes. This second upload should have a good patch. 613528 7 gavinp 2012-05-01 10:59:34 -0700 (note: this fix is in relation to bug 84880) 613534 8 139641 dglazkov 2012-05-01 11:02:23 -0700 Comment on attachment 139641 Patch doh. 613549 9 139641 webkit.review.bot 2012-05-01 11:22:31 -0700 Comment on attachment 139641 Patch Clearing flags on attachment: 139641 Committed r115739: <http://trac.webkit.org/changeset/115739> 613550 10 webkit.review.bot 2012-05-01 11:22:38 -0700 All reviewed patches have been landed. Closing bug. 139638 2012-05-01 09:23:51 -0700 2012-05-01 09:39:16 -0700 Patch bug-85290-20120501122349.patch text/plain 1360 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAxZjY0MzdmYzgwZGYz YTMzNWIyNjBiMTBhMmJhNDY4MTU3MjE4ZDg3Li41MjM5NDgzZmRkOWVkMzg5YWI1NWEzMmZkOTM4 MjIzM2MyYzJjYjM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wNS0wMSAg R2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggd2Vic3Ry aW5nIGNvbnN0cnVjdG9yCisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBi dWcgVVJMIChPT1BTISkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGNocm9taXVtL3B1YmxpYy9XZWJQcmVyZW5kZXIuaDoKKyAgICAgICAgKFdlYktp dDo6V2ViUHJlcmVuZGVyOjpyZWZlcnJlcik6CisKIDIwMTItMDQtMzAgIEdhdmluIFBldGVycyAg PGdhdmlucEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBBZGQgdGh1bmsgaGVh ZGVycyBmb3Igc3RhZ2luZyBQcmVyZW5kZXJpbmcgQVBJLgpkaWZmIC0tZ2l0IGEvU291cmNlL1Bs YXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJQcmVyZW5kZXIuaCBiL1NvdXJjZS9QbGF0Zm9ybS9j aHJvbWl1bS9wdWJsaWMvV2ViUHJlcmVuZGVyLmgKaW5kZXggM2U2MjEyMzEzYzQ3NmIzYjNhMDg3 ZWM4NWVhMzAxNTM1YzkzNTgwNC4uNDE3NGJmNDczODMzMGUwZmU4ZGVhN2YyMDNiZmRhN2IyZGQ0 MTFjNiAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJQcmVy ZW5kZXIuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlByZXJlbmRl ci5oCkBAIC01Niw3ICs1Niw3IEBAIHB1YmxpYzoKICAgICAgICAgdmlydHVhbCB+RXh0cmFEYXRh KCkgeyB9CiAgICAgfTsKICAgICBXZWJVUkwgdXJsKCkgY29uc3QgeyByZXR1cm4gV2ViVVJMKCk7 IH0KLSAgICBXZWJTdHJpbmcgcmVmZXJyZXIoKSBjb25zdCB7IHJldHVybiAiIjsgfQorICAgIFdl YlN0cmluZyByZWZlcnJlcigpIGNvbnN0IHsgcmV0dXJuIFdlYlN0cmluZygpOyB9CiAgICAgV2Vi UmVmZXJyZXJQb2xpY3kgcmVmZXJyZXJQb2xpY3koKSBjb25zdCB7IHJldHVybiBXZWJSZWZlcnJl clBvbGljeSgpOyB9CiAgICAgdm9pZCBzZXRFeHRyYURhdGEoRXh0cmFEYXRhKikgeyB9CiAgICAg Y29uc3QgRXh0cmFEYXRhKiBleHRyYURhdGEoKSBjb25zdCB7IHJldHVybiAwOyB9Cg== 139641 2012-05-01 09:39:21 -0700 2012-05-01 11:22:31 -0700 Patch bug-85290-20120501123920.patch text/plain 1380 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAxZjY0MzdmYzgwZGYz YTMzNWIyNjBiMTBhMmJhNDY4MTU3MjE4ZDg3Li5lOThiMmYzOGNkZTYxMDNjMzRkMzM3NjYwNGI3 OWJmNWQwODlmNTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNS0wMSAg R2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1d IEZpeCBXZWJQcmVyZW5kZXI6OnJlZmVycmVyKCkgdGh1bmsuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTI5MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dlYlByZXJlbmRl ci5oOgorICAgICAgICAoV2ViS2l0OjpXZWJQcmVyZW5kZXI6OnJlZmVycmVyKToKKwogMjAxMi0w NC0zMCAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hy b21pdW1dIEFkZCB0aHVuayBoZWFkZXJzIGZvciBzdGFnaW5nIFByZXJlbmRlcmluZyBBUEkuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlByZXJlbmRlci5o IGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJQcmVyZW5kZXIuaAppbmRleCAz ZTYyMTIzMTNjNDc2YjNiM2EwODdlYzg1ZWEzMDE1MzVjOTM1ODA0Li40MTc0YmY0NzM4MzMwZTBm ZThkZWE3ZjIwM2JmZGE3YjJkZDQxMWM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hy b21pdW0vcHVibGljL1dlYlByZXJlbmRlci5oCisrKyBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1 bS9wdWJsaWMvV2ViUHJlcmVuZGVyLmgKQEAgLTU2LDcgKzU2LDcgQEAgcHVibGljOgogICAgICAg ICB2aXJ0dWFsIH5FeHRyYURhdGEoKSB7IH0KICAgICB9OwogICAgIFdlYlVSTCB1cmwoKSBjb25z dCB7IHJldHVybiBXZWJVUkwoKTsgfQotICAgIFdlYlN0cmluZyByZWZlcnJlcigpIGNvbnN0IHsg cmV0dXJuICIiOyB9CisgICAgV2ViU3RyaW5nIHJlZmVycmVyKCkgY29uc3QgeyByZXR1cm4gV2Vi U3RyaW5nKCk7IH0KICAgICBXZWJSZWZlcnJlclBvbGljeSByZWZlcnJlclBvbGljeSgpIGNvbnN0 IHsgcmV0dXJuIFdlYlJlZmVycmVyUG9saWN5KCk7IH0KICAgICB2b2lkIHNldEV4dHJhRGF0YShF eHRyYURhdGEqKSB7IH0KICAgICBjb25zdCBFeHRyYURhdGEqIGV4dHJhRGF0YSgpIGNvbnN0IHsg cmV0dXJuIDA7IH0K