85279 2012-05-01 06:39:09 -0700 [GTK] Transparent Media controls timeline and panel 2012-07-28 06:09:28 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned cgarcia gustavo mrobinson pnormand oldest_to_newest 613368 0 pnormand 2012-05-01 06:39:09 -0700 RenderThemeGtk::initMediaColors() sets m_panelColor, m_sliderColor and m_sliderColor to transparent black... I suspect this might be the effect of the recent update of gtk+ from 3.0 to 3.4 in our JHBuild moduleset. 613377 1 pnormand 2012-05-01 07:25:09 -0700 Yep, reverting r114297 fixes the issue here. 613460 2 pnormand 2012-05-01 09:30:46 -0700 Carlos would you mind having a look at this issue? It's quite annoying. If a WebKit patch is needed it should also be cherry-picked in the stable branch if possible because this visual regression is quite annoying. 617615 3 cgarcia 2012-05-07 08:30:54 -0700 I can't reproduce it with gtk+ from current git master 622414 4 pnormand 2012-05-12 14:15:19 -0700 (In reply to comment #3) > I can't reproduce it with gtk+ from current git master So, what should we do then? Update our jhbuild's GTK+ version or find/backport the GTK+ commit that fixed the issue? I'm open to both options... 624361 5 gustavo 2012-05-15 12:02:31 -0700 I'm fine with upgrading gtk+ in our jhbuild, unless it'd make it impossible to build our jhbuild stuff in fairly recent distributions, which I doubt will be the case. 624364 6 mrobinson 2012-05-15 12:04:32 -0700 (In reply to comment #5) > I'm fine with upgrading gtk+ in our jhbuild, unless it'd make it impossible to build our jhbuild stuff in fairly recent distributions, which I doubt will be the case. The fix for this issue should probably be in WebKit as we need to work properly with all GTK+ versions that we support during configuration. 624371 7 gustavo 2012-05-15 12:12:26 -0700 We haven't really tried supporting all buggy versions of GTK+ or whatever else, specially bugs that come and go in a 1 release? =) 624373 8 mrobinson 2012-05-15 12:13:49 -0700 (In reply to comment #7) > We haven't really tried supporting all buggy versions of GTK+ or whatever else, specially bugs that come and go in a 1 release? =) Apologies! I misread this thread and understood falsely that the problem existed from 3.0 to 3.4. 659898 9 pnormand 2012-06-28 15:47:51 -0700 I locally tried updating up to gtk+ 3.5.6 and still not seeing my media controls panel and timeline bar. Carlos, are you sure this all works fine for you in gtk+ master? 660373 10 cgarcia 2012-06-29 04:57:26 -0700 Yes, I can see the media controls with both MiniBrowser and GtkLauncher. 660467 11 pnormand 2012-06-29 07:38:57 -0700 (In reply to comment #10) > Yes, I can see the media controls with both MiniBrowser and GtkLauncher. Can you attach a screenshot please? Just to make sure we're on the same page. 680681 12 154957 pnormand 2012-07-27 08:29:05 -0700 Created attachment 154957 Patch 681399 13 154957 pnormand 2012-07-28 06:09:22 -0700 Comment on attachment 154957 Patch Clearing flags on attachment: 154957 Committed r123959: <http://trac.webkit.org/changeset/123959> 681400 14 pnormand 2012-07-28 06:09:28 -0700 All reviewed patches have been landed. Closing bug. 154957 2012-07-27 08:29:05 -0700 2012-07-28 06:09:22 -0700 Patch Patch.patch text/plain 2914 pnormand RnJvbSAwNzBkMGQwZmVjNmY0ODI5Zjg2Mzc2MTMxMDQ2MDUwZjYzYTIzZjAxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDI3IEp1bCAyMDEyIDE3OjI2OjI4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g UGF0Y2gKCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysK IFRvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMgfCAgIDI0ICsrKysrKysrKysrKysrKysrKysrKysr KwogMiBmaWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvVG9vbHMv Q2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDUwNTM4NjcuLjA0MmE1ZjIgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NCBAQAorMjAxMi0wNy0yNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gVHJhbnNwYXJlbnQgTWVkaWEgY29udHJvbHMgdGltZWxpbmUgYW5k IHBhbmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NTI3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog Z3RrL2poYnVpbGQubW9kdWxlczogUHJvdmlkZSBnbm9tZS10aGVtZXMtc3RhbmRhcmQgYnVpbGQK KyAgICAgICAgc3VwcG9ydCwgdGhpcyBpcyBuZWNlc3Nhcnkgc28gdGhlIG1lZGlhIGNvbnRyb2xz IHBhbmVsIGNvbG9ycyBhcmUKKyAgICAgICAgcHJvcGVybHkgaW5pdGlhbGl6ZWQgZnJvbSB0aGUg R1RLKyB0aGVtZS4KKwogMjAxMi0wNy0yNyAgWW91bmdUYWVjayBTb25nICA8eW91bmd0YWVjay5z b25nQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtXSzJdW0VGTF0gQWRkIGFuIEFDQ0VMRVJBVEVE X0NPTVBPU0lUSU5HIGltcGxlbWVudGF0aW9uIGZvciBFZmwgV2ViS2l0MgpkaWZmIC0tZ2l0IGEv VG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5k ZXggODEzMjJmMjUuLjg0MTM5MjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVs ZXMKKysrIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwpAQCAtMTUsNiArMTUsNyBAQAogICAg ICAgPGRlcCBwYWNrYWdlPSJnbGliIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWItbmV0d29y a2luZyIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJnbm9tZS1pY29uLXRoZW1lIi8+CisgICAgICA8 ZGVwIHBhY2thZ2U9Imdub21lLXRoZW1lcy1zdGFuZGFyZCIvPgogICAgICAgPGRlcCBwYWNrYWdl PSJsaWJzb3VwIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImF0LXNwaTItY29yZSIvPgogICAgICAg PGRlcCBwYWNrYWdlPSJhdC1zcGkyLWF0ayIvPgpAQCAtMTAwLDYgKzEwMSwxNyBAQAogICAgICAg ICAgICAgbWQ1c3VtPSIxYzE4NmY5OTAzYTIwZTk2NTg3YjlhZmIyNzk0NGI0MCIvPgogICA8L2F1 dG90b29scz4KIAorICA8YXV0b3Rvb2xzIGlkPSJsaWJyc3ZnIiBhdXRvZ2VuLXNoPSJjb25maWd1 cmUiCisgICAgICAgICAgICAgYXV0b2dlbmFyZ3M9Ii0tZGlzYWJsZS1pbnRyb3NwZWN0aW9uIC0t ZW5hYmxlLXBpeGJ1Zi1sb2FkZXIgLS1kaXNhYmxlLWd0ay10aGVtZSI+CisgICAgPGRlcGVuZGVu Y2llcz4KKyAgICAgIDxkZXAgcGFja2FnZT0iZ2RrLXBpeGJ1ZiIvPgorICAgIDwvZGVwZW5kZW5j aWVzPgorICAgIDxicmFuY2ggbW9kdWxlPSIvcHViL0dOT01FL3NvdXJjZXMvbGlicnN2Zy8yLjM2 L2xpYnJzdmctMi4zNi4xLnRhci54eiIgdmVyc2lvbj0iMi4zNi4xIgorICAgICAgICAgICAgcmVw bz0iZnRwLmdub21lLm9yZyIKKyAgICAgICAgICAgIGhhc2g9InNoYTI1Njo3ODZiOTVlMWEwOTEz NzVjNWVmMjk5N2EyMWM2OWZmMjRkNzA3N2FmZWZmMTgxOTczNTVmNTRkOWRjYmNkOGM1IgorICAg ICAgICAgICAgbWQ1c3VtPSI4OWQ0ODNmMzBhN2M3NzI0NWI3ZWUwMmZhYWVhNWE1YSIvPgorICA8 L2F1dG90b29scz4KKwogICA8YXV0b3Rvb2xzIGlkPSJwYW5nbyIKICAgICAgICAgICAgICBhdXRv Z2VuYXJncz0iLS1kaXNhYmxlLWludHJvc3BlY3Rpb24iPgogICAgIDxkZXBlbmRlbmNpZXM+CkBA IC0xODYsNiArMTk4LDE4IEBACiAgICAgPC9icmFuY2g+CiAgIDwvYXV0b3Rvb2xzPgogCisgIDxh dXRvdG9vbHMgaWQ9Imdub21lLXRoZW1lcy1zdGFuZGFyZCIgYXV0b2dlbi1zaD0iY29uZmlndXJl Ij4KKyAgICA8ZGVwZW5kZW5jaWVzPgorICAgICAgPGRlcCBwYWNrYWdlPSJndGsrIi8+CisgICAg ICA8ZGVwIHBhY2thZ2U9ImxpYnJzdmciLz4KKyAgICA8L2RlcGVuZGVuY2llcz4KKyAgICA8YnJh bmNoIG1vZHVsZT0icHViL0dOT01FL3NvdXJjZXMvZ25vbWUtdGhlbWVzLXN0YW5kYXJkLzMuNC9n bm9tZS10aGVtZXMtc3RhbmRhcmQtMy40LjAudGFyLnh6IiB2ZXJzaW9uPSIzLjQuMCIKKyAgICAg ICAgICAgIHJlcG89ImZ0cC5nbm9tZS5vcmciCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6NmM4 NTA1NmRiMTZiNzQ4YTE0YzQxMjU1NDM3MWEyMmYwOTZiOTgxZDJlY2EzYWUzZDY5MjJhNDM1ZDQz YjBmZCIKKyAgICAgICAgICAgIG1kNXN1bT0iMDQ2YTEyMmE0MjMxYzdmN2ZjODA1YjA1MmI0NDk4 Y2UiPgorICAgIDwvYnJhbmNoPgorICA8L2F1dG90b29scz4KKwogICA8YXV0b3Rvb2xzIGlkPSJh dC1zcGkyLWNvcmUiIAogICAgICAgICAgICAgIGF1dG9nZW5hcmdzPSItLWRpc2FibGUtaW50cm9z cGVjdGlvbiI+CiAgICAgPGJyYW5jaCBtb2R1bGU9InB1Yi9HTk9NRS9zb3VyY2VzL2F0LXNwaTIt Y29yZS8yLjIvYXQtc3BpMi1jb3JlLTIuMi4xLnRhci54eiIgdmVyc2lvbj0iMi4yLjEiCi0tIAox LjcuMTAuNA==