85276 2012-05-01 05:49:09 -0700 PNGImageDecoder: Handle interlace buffer allocation failure 2012-05-03 19:25:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon eric webkit.review.bot oldest_to_newest 613353 0 noel.gordon 2012-05-01 05:49:09 -0700 PNGImageDEcoder: Handle interlace buffer allocation failure 613354 1 139617 noel.gordon 2012-05-01 05:50:15 -0700 Created attachment 139617 Patch 613880 2 139617 eric 2012-05-01 19:12:39 -0700 Comment on attachment 139617 Patch Do we have an image we can test this with? It seems if we keep maintaining a PNG decoder (which we really *don't* want to do as a project), we will need to come up with a testing harness and a corpus of a bunch of broken png files. :( 613887 3 noel.gordon 2012-05-01 19:24:15 -0700 No, no test image sorry. Agree we need to come up with a better test suite. 613888 4 noel.gordon 2012-05-01 19:28:29 -0700 So it's impractical to test this with our current technology, but the plan is to move towards using pngsuite for testing our decoder, which should catch issues like this one. http://www.schaik.com/pngsuite 613889 5 139617 eric 2012-05-01 19:29:21 -0700 Comment on attachment 139617 Patch OK. 613912 6 139617 webkit.review.bot 2012-05-01 20:19:48 -0700 Comment on attachment 139617 Patch Clearing flags on attachment: 139617 Committed r115784: <http://trac.webkit.org/changeset/115784> 613913 7 webkit.review.bot 2012-05-01 20:19:59 -0700 All reviewed patches have been landed. Closing bug. 615058 8 noel.gordon 2012-05-02 23:55:43 -0700 (In reply to comment #4) > So it's impractical to test this with our current technology, but the plan is to move towards using pngsuite for testing our decoder, which should catch issues like this one. http://www.schaik.com/pngsuite "may help catch issues like this one", filed bug 85460 615904 9 noel.gordon 2012-05-03 19:25:51 -0700 Closed bug 85460 (too much broken style bot noise). Filed bug 85567. 139617 2012-05-01 05:50:15 -0700 2012-05-01 20:19:48 -0700 Patch bug-85276-20120501225013.patch text/plain 3269 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTg3NzQ0MGUwYTdjYjM3 NjM4ZjVhYzBjZDQ4NzJjYTk3YmIzZDUyZS4uMzMxZDA3ZjUyZTRiOGMzMGNmZGQ5MmNhMTRhMzZm Nzk5MzAyMjYxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTAxICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBQTkdJbWFnZURlY29k ZXI6IEhhbmRsZSBpbnRlcmxhY2UgYnVmZmVyIGFsbG9jYXRpb24gZmFpbHVyZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUyNzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vdCBz b21ldGhpbmcgd2UgY2FuIGVhc2lseSB0ZXN0IChtYWxsb2MgZmFpbHVyZSkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9wbmcvUE5HSW1hZ2VEZWNvZGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlBOR0ltYWdlRGVjb2Rlcjo6cm93QXZhaWxhYmxlKTogQ2hlY2sgaW50ZXJs YWNlIGJ1ZmZlciBhbGxvY2F0aW9ucworICAgICAgICBhbmQgYmFpbCB2aWEgbG9uZ2ptcCBvbiBm YWlsdXJlLiBOb3RlIFBOR19JTlRFUkxBQ0VfQURBTTcgaXMgdGhlIG9ubHkgbGlicG5nCisgICAg ICAgIHN1cHBvcnRlZCBpbnRlcmxhY2UgdHlwZSBzbyB0ZXN0IGZvciBpdCBleHBsaWNpdGx5Lgor CiAyMDEyLTA1LTAxICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIEVhcmx5LW91dCBmb3Igc3VidHJhY3RpbmcgYSBub24taW50ZXJzZWN0aW5nIHJlZ2lvbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcG5nL1BO R0ltYWdlRGVjb2Rlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVy cy9wbmcvUE5HSW1hZ2VEZWNvZGVyLmNwcAppbmRleCBiY2NhNDc0MDE0NWQzNTY3MGNmMWNjMmJm NDRkYTBkN2Y4ODFiNzFlLi45NDZkOGVjZjAwYzY1YTkzY2U5NDllMDE4ZjBhNWY5ODMwNzE1MGNl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9wbmcv UE5HSW1hZ2VEZWNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1k ZWNvZGVycy9wbmcvUE5HSW1hZ2VEZWNvZGVyLmNwcApAQCAtMzYxLDE5ICszNjEsMjcgQEAgdm9p ZCBQTkdJbWFnZURlY29kZXI6OnJvd0F2YWlsYWJsZSh1bnNpZ25lZCBjaGFyKiByb3dCdWZmZXIs IHVuc2lnbmVkIHJvd0luZGV4LAogICAgIC8vIEluaXRpYWxpemUgdGhlIGZyYW1lYnVmZmVyIGlm IG5lZWRlZC4KICAgICBJbWFnZUZyYW1lJiBidWZmZXIgPSBtX2ZyYW1lQnVmZmVyQ2FjaGVbMF07 CiAgICAgaWYgKGJ1ZmZlci5zdGF0dXMoKSA9PSBJbWFnZUZyYW1lOjpGcmFtZUVtcHR5KSB7Cisg ICAgICAgIHBuZ19zdHJ1Y3RwIHBuZyA9IG1fcmVhZGVyLT5wbmdQdHIoKTsKICAgICAgICAgaWYg KCFidWZmZXIuc2V0U2l6ZShzY2FsZWRTaXplKCkud2lkdGgoKSwgc2NhbGVkU2l6ZSgpLmhlaWdo dCgpKSkgewotICAgICAgICAgICAgbG9uZ2ptcChKTVBCVUYobV9yZWFkZXItPnBuZ1B0cigpKSwg MSk7CisgICAgICAgICAgICBsb25nam1wKEpNUEJVRihwbmcpLCAxKTsKICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgfQorCisgICAgICAgIGlmIChQTkdfSU5URVJMQUNFX0FEQU03ID09IHBu Z19nZXRfaW50ZXJsYWNlX3R5cGUocG5nLCBtX3JlYWRlci0+aW5mb1B0cigpKSkgeworICAgICAg ICAgICAgaW50IGJ5dGVzUGVyUGl4ZWwgPSBtX3JlYWRlci0+aGFzQWxwaGEoKSA/IDQgOiAzOwor ICAgICAgICAgICAgbV9yZWFkZXItPmNyZWF0ZUludGVybGFjZUJ1ZmZlcihieXRlc1BlclBpeGVs ICogc2l6ZSgpLndpZHRoKCkgKiBzaXplKCkuaGVpZ2h0KCkpOworICAgICAgICAgICAgaWYgKCFt X3JlYWRlci0+aW50ZXJsYWNlQnVmZmVyKCkpIHsKKyAgICAgICAgICAgICAgICBsb25nam1wKEpN UEJVRihwbmcpLCAxKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9Cisg ICAgICAgIH0KKwogICAgICAgICBidWZmZXIuc2V0U3RhdHVzKEltYWdlRnJhbWU6OkZyYW1lUGFy dGlhbCk7CiAgICAgICAgIGJ1ZmZlci5zZXRIYXNBbHBoYShmYWxzZSk7CiAgICAgICAgIGJ1ZmZl ci5zZXRDb2xvclByb2ZpbGUobV9jb2xvclByb2ZpbGUpOwogCiAgICAgICAgIC8vIEZvciBQTkdz LCB0aGUgZnJhbWUgYWx3YXlzIGZpbGxzIHRoZSBlbnRpcmUgaW1hZ2UuCiAgICAgICAgIGJ1ZmZl ci5zZXRPcmlnaW5hbEZyYW1lUmVjdChJbnRSZWN0KEludFBvaW50KCksIHNpemUoKSkpOwotCi0g ICAgICAgIGlmIChwbmdfZ2V0X2ludGVybGFjZV90eXBlKG1fcmVhZGVyLT5wbmdQdHIoKSwgbV9y ZWFkZXItPmluZm9QdHIoKSkgIT0gUE5HX0lOVEVSTEFDRV9OT05FKQotICAgICAgICAgICAgbV9y ZWFkZXItPmNyZWF0ZUludGVybGFjZUJ1ZmZlcigobV9yZWFkZXItPmhhc0FscGhhKCkgPyA0IDog MykgKiBzaXplKCkud2lkdGgoKSAqIHNpemUoKS5oZWlnaHQoKSk7CiAgICAgfQogCiAgICAgaWYg KCFyb3dCdWZmZXIpCkBAIC00MTEsOCArNDE5LDggQEAgdm9pZCBQTkdJbWFnZURlY29kZXI6OnJv d0F2YWlsYWJsZSh1bnNpZ25lZCBjaGFyKiByb3dCdWZmZXIsIHVuc2lnbmVkIHJvd0luZGV4LAog ICAgIGJvb2wgaGFzQWxwaGEgPSBtX3JlYWRlci0+aGFzQWxwaGEoKTsKICAgICB1bnNpZ25lZCBj b2xvckNoYW5uZWxzID0gaGFzQWxwaGEgPyA0IDogMzsKICAgICBwbmdfYnl0ZXAgcm93OwotICAg IHBuZ19ieXRlcCBpbnRlcmxhY2VCdWZmZXIgPSBtX3JlYWRlci0+aW50ZXJsYWNlQnVmZmVyKCk7 Ci0gICAgaWYgKGludGVybGFjZUJ1ZmZlcikgeworCisgICAgaWYgKHBuZ19ieXRlcCBpbnRlcmxh Y2VCdWZmZXIgPSBtX3JlYWRlci0+aW50ZXJsYWNlQnVmZmVyKCkpIHsKICAgICAgICAgcm93ID0g aW50ZXJsYWNlQnVmZmVyICsgKHJvd0luZGV4ICogY29sb3JDaGFubmVscyAqIHNpemUoKS53aWR0 aCgpKTsKICAgICAgICAgcG5nX3Byb2dyZXNzaXZlX2NvbWJpbmVfcm93KHBuZywgcm93LCByb3dC dWZmZXIpOwogICAgIH0gZWxzZQo=