85271 2012-05-01 02:55:56 -0700 [Chromium] Regression r113405 ContextMenuImpl does not set misspelled word 2012-05-01 04:17:32 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 hbono webkit-unassigned morrita tkent webkit.review.bot oldest_to_newest 613318 0 hbono 2012-05-01 02:55:56 -0700 Greetings, Sorry for my stupid request. My WebKit change r113405 (*1) has a bonehead mistake that it sets 'range->text()' to misspelledWord instead of calling selectMisspelledWord(). Unfortunately, this code causes a serious inconsistency that it sets empty text to misspelledWord when a user enables asynchronous spellchecking and right-clicks a misspelled word without manually selecting it. Is it possible to replace this 'range-text()' with 'selectMispelledWord()' for consistency with the behavior of synchronous spellchecking? (*1) http://trac.webkit.org/changeset/113405 Regards, Hironori Bono 613324 1 139606 hbono 2012-05-01 03:32:58 -0700 Created attachment 139606 Quick fix v1 Greetings, Would it be possible to review this patch? Regards, Hironori Bono 613326 2 139606 tkent 2012-05-01 03:37:49 -0700 Comment on attachment 139606 Quick fix v1 Looks reasonable. 613335 3 139606 webkit.review.bot 2012-05-01 04:17:27 -0700 Comment on attachment 139606 Quick fix v1 Clearing flags on attachment: 139606 Committed r115718: <http://trac.webkit.org/changeset/115718> 613336 4 webkit.review.bot 2012-05-01 04:17:32 -0700 All reviewed patches have been landed. Closing bug. 139606 2012-05-01 03:32:58 -0700 2012-05-01 04:17:27 -0700 Quick fix v1 issue86271-patch0.txt text/plain 1582 hbono SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTU3MTYpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA1LTAxICBIaXJvbm9yaSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFtDaHJvbWl1bV0gUmVncmVzc2lvbiByMTEzNDA1IENvbnRleHRNZW51SW1wbCBkb2Vz IG5vdCBzZXQgYSBtaXNzcGVsbGVkIHdvcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg1MjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgY2FsbHMgc2VsZWN0TWlzc3BlbGxlZFdvcmQo KSB0byBnZXQgYSBtaXNzcGVsbGVkIHdvcmQgc28gQ2hyb21lIGNhbgorICAgICAgICBzZXQgdGhl IG1pc3NwZWxsZWRXb3JkIHZhcmlhYmxlIHdpdGhvdXQgc2VsZWN0aW5nIHRleHQuCisKKyAgICAg ICAgKiBzcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29u dGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcyk6CisKIDIw MTItMDQtMzAgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtD aHJvbWl1bS9XaW5kb3dzXSBBZGQgTG9jYWxpemVkRGF0ZVdpbgpJbmRleDogU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCShyZXZp c2lvbiAxMTU3MDEpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNs aWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTAsNyArMjkwLDcgQEAgUGxhdGZvcm1N ZW51RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGllbgogICAgICAgICAgICAgICAgICAgICB9CiAg ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGRhdGEuZGljdGlvbmFyeVN1Z2dlc3Rp b25zID0gc3VnZ2VzdGlvbnM7Ci0gICAgICAgICAgICAgICAgZGF0YS5taXNzcGVsbGVkV29yZCA9 IHJhbmdlLT50ZXh0KCk7CisgICAgICAgICAgICAgICAgZGF0YS5taXNzcGVsbGVkV29yZCA9IHNl bGVjdE1pc3NwZWxsZWRXb3JkKGRlZmF1bHRNZW51LCBzZWxlY3RlZEZyYW1lKTsKICAgICAgICAg ICAgIH0KICAgICAgICAgfSBlbHNlIGlmIChtX3dlYlZpZXctPmZvY3VzZWRXZWJDb3JlRnJhbWUo KS0+ZWRpdG9yKCktPmlzQ29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkKCkpIHsKICAgICAg ICAgICAgIGRhdGEuaXNTcGVsbENoZWNraW5nRW5hYmxlZCA9IHRydWU7Cg==