<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>85263</bug_id>
          
          <creation_ts>2012-04-30 22:59:10 -0700</creation_ts>
          <short_desc>[Meta][Shadow DOM] Early Summer Refactoring.</short_desc>
          <delta_ts>2012-08-09 19:19:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>77608</dependson>
    
    <dependson>79220</dependson>
    
    <dependson>85265</dependson>
    
    <dependson>85970</dependson>
    
    <dependson>86064</dependson>
    
    <dependson>86427</dependson>
    
    <dependson>87216</dependson>
    
    <dependson>87223</dependson>
          <blocked>72352</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Hajime Morrita">morrita</reporter>
          <assigned_to name="Hajime Morrita">morrita</assigned_to>
          <cc>dglazkov</cc>
    
    <cc>hayato</cc>
    
    <cc>shinyak</cc>
    
    <cc>tasak</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>613252</commentid>
    <comment_count>0</comment_count>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2012-04-30 22:59:10 -0700</bug_when>
    <thetext>The talk at contributor&apos;s meeting force us to realize that
the current shadow DOM implementation needs to be understandable and explainable rather than something black magic.
I talked Dimitri and made up an initial plan. I won&apos;t file bugs for each until we actually start working 
since the list is more like rough thoughts than real bugs to fix.

----
Relatively Solid takes (will be attacked at first):

- Rename ShadowTree to something more mindful: ElementShadow?
- Simplify API surface on ShadowTree(will be renamed)
  - This will take a few takes.
- Renaming objects around HTMLContentElement for picking more spec-like terms:
  - HTMLContentSelection     -&gt; ShadowDistributedNode // This should be killed eventually.
  - HTMLContentSelectionList -&gt; ShadowDistributedNodeList
  - HTMLContentSelector      -&gt; ShadowNodeDistributor
- Split node distribution out from the attachment/detachment.
- Encapsulate tree stack operations by introducing ShadowTreeStack over DoublyLinkedList.
- Eliminate &quot;right children&quot; names if there are any.

Rather rough ideas:

- Eliminate RefPtr from selection to kill potential cycle.
- Simplify NodeRenderingContext by ensuring that the node attachment to start from the Shadow host.
  - We can employ global stack to pass around the &quot;rendering context&quot; of shadow dom then.
- Optimize memory usage.
  - Reduce the number of NodeRareaData instances
  - Eliminate extra pointers (including turning doubly-linked list to singly-linked).
  - Kill HTMLContentSelection</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>692110</commentid>
    <comment_count>1</comment_count>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2012-08-09 19:19:58 -0700</bug_when>
    <thetext>Looks like all subbugs are closed. closing this - The summer has come.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>