85258 2012-04-30 21:15:40 -0700 Early-out for subtracting a non-intersecting region 2012-05-02 12:27:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj andersca backer darin enne jamesr piman vangelis webkit.review.bot oldest_to_newest 613218 0 danakj 2012-04-30 21:15:40 -0700 Early-out for subtracting a non-intersecting region 613219 1 139578 danakj 2012-04-30 21:20:02 -0700 Created attachment 139578 Patch 613313 2 139578 morrita 2012-05-01 02:05:59 -0700 Comment on attachment 139578 Patch Harvest all low hanging fruits!! 613315 3 139578 webkit.review.bot 2012-05-01 02:14:28 -0700 Comment on attachment 139578 Patch Clearing flags on attachment: 139578 Committed r115716: <http://trac.webkit.org/changeset/115716> 613316 4 webkit.review.bot 2012-05-01 02:14:33 -0700 All reviewed patches have been landed. Closing bug. 613606 5 darin 2012-05-01 13:14:18 -0700 Is this change for better performance or is it related to correctness? If it’s for better performance, what test demonstrates the improvement? How good is the improvement? 613618 6 danakj 2012-05-01 13:32:20 -0700 It is for performance, if you subtract a Region that does not intersect, you would make a memcpy of the orignal region. Region copies are showing themselves to be very costly, you can see some backstory here https://bugs.webkit.org/show_bug.cgi?id=81076 I must confess I'm not sure what you mean by a test though, we use unit tests and layout tests to verify correctness, but I've never been asked to write a test to show performance differences. 613619 7 darin 2012-05-01 13:37:02 -0700 Most performance-driven changes include information about some kind of performance test and data about the results before and after the code change. I can find you examples if you haven’t seen that in the WebKit project before. 613624 8 danakj 2012-05-01 13:43:53 -0700 Sure, I'd love a good example, thanks. 614526 9 darin 2012-05-02 12:27:05 -0700 I’m not sure these are the best examples, but three I found with a quick search are these: http://trac.webkit.org/changeset/114912 http://trac.webkit.org/changeset/114351 http://trac.webkit.org/changeset/112387 139578 2012-04-30 21:20:02 -0700 2012-05-01 02:14:28 -0700 Patch bug-85258-20120501002001.patch text/plain 1439 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDE1N2Q2YzA2MDA2YzNm ZjE3NzY1NWI0YmZmMTNmYTViNWFlNzVmYi4uZWZmOWJiYWVlYmUyODI3ZGI3ZDk3ZTA2NWRmNTVj NzU5NmIyODcwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTMwICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEVhcmx5LW91dCBmb3Ig c3VidHJhY3RpbmcgYSBub24taW50ZXJzZWN0aW5nIHJlZ2lvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUyNTgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHaXZlbiByZWdpb25zIEEgYW5kIEIsIGlmIHRo ZSBib3VuZHMgb2YgdGhlIHJlZ2lvbnMgZG8gbm90IGludGVyc2VjdCwKKyAgICAgICAgdGhlbiB0 aGUgcmVnaW9ucyB0aGVtc2VsdmVzIGRvIG5vdCBpbnRlcnNlY3QuIElmIHRoZSBpbnRlcnNlY3Rp b24gb2YKKyAgICAgICAgQSBhbmQgQiBpcyBlbXB0eSwgdGhlbiBBIHN1YnRyYWN0IEIgPT0gQS4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1JlZ2lvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZWdpb246OnN1YnRyYWN0KToKKwogMjAxMi0wNC0zMCAgTmF0ZSBDaGFwaW4gIDxqYXBo ZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1vdmUgbW9yZSBvZiBjb21taXR0aW5nIGFuZCBz dGFydGluZyB0byB3cml0ZSBhIERvY3VtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9SZWdpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvUmVnaW9uLmNwcAppbmRleCA1ZjI5ZGU3NTkxZTUwZThjYTQ3NmRlMjZjMTBkMzA2N2U3 YjA1ODQ0Li5jNGQyZjU2MDA1ZDBiYmM4ZTVlZDFkNzQxNDI3OTNkYzVlZjA4MmM4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9SZWdpb24uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1JlZ2lvbi5jcHAKQEAgLTUwNSw2ICs1MDUs OCBAQCB2b2lkIFJlZ2lvbjo6c3VidHJhY3QoY29uc3QgUmVnaW9uJiByZWdpb24pCiB7CiAgICAg aWYgKHJlZ2lvbi5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKKyAgICBpZiAoIW1fYm91bmRz LmludGVyc2VjdHMocmVnaW9uLm1fYm91bmRzKSkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgU2hh cGUgc3VidHJhY3RlZFNoYXBlID0gU2hhcGU6OnN1YnRyYWN0U2hhcGVzKG1fc2hhcGUsIHJlZ2lv bi5tX3NoYXBlKTsKIAo=