85257 2012-04-30 21:10:50 -0700 [chromium] Avoid extra Region copies in CCOcclusionTracker 2012-05-02 14:09:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85297 1 danakj danakj backer cc-bugs enne jamesr piman vangelis webkit.review.bot oldest_to_newest 613216 0 danakj 2012-04-30 21:10:50 -0700 [chromium] Avoid extra Region copies in CCOcclusionTracker 613217 1 139577 danakj 2012-04-30 21:13:58 -0700 Created attachment 139577 Patch 614628 2 139577 enne 2012-05-02 13:52:46 -0700 Comment on attachment 139577 Patch R=me. 614655 3 139577 webkit.review.bot 2012-05-02 14:09:02 -0700 Comment on attachment 139577 Patch Clearing flags on attachment: 139577 Committed r115886: <http://trac.webkit.org/changeset/115886> 614657 4 webkit.review.bot 2012-05-02 14:09:07 -0700 All reviewed patches have been landed. Closing bug. 139577 2012-04-30 21:13:58 -0700 2012-05-02 14:09:02 -0700 Patch bug-85257-20120501001356.patch text/plain 5923 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDE1N2Q2YzA2MDA2YzNm ZjE3NzY1NWI0YmZmMTNmYTViNWFlNzVmYi4uODY4NWRiNWVjYzhkYzMxZDg2OWIwMTFiNTU5ZWJk OWU3ZTczZjJmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA0LTMwICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQXZv aWQgZXh0cmEgUmVnaW9uIGNvcGllcyBpbiBDQ09jY2x1c2lvblRyYWNrZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MjU3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVhZCBvZiBtYWtpbmcgYSBS ZWdpb24gZm9yIGVhY2ggbGF5ZXIgYW5kIHRoZW4gdW5pdGluZyB0aGUgcmVnaW9uCisgICAgICAg IHdpdGggdGhlIGN1cnJlbnQgb2NjbHVzaW9uLCBkaXJlY3RseSBhZGQgdGhlIHJlY3RzIGZvciB0 aGUgZ2l2ZW4gbGF5ZXIKKyAgICAgICAgdG8gdGhlIGN1cnJlbnQgb2NjbHVzaW9uLgorCisgICAg ICAgIFdoZW4gc3VidHJhY3RpbmcgYSByZWdpb24gZnJvbSBhIHJlY3QsIGp1c3Qgc3VidHJhY3Qg dGhlIHJlZ2lvbgorICAgICAgICBkaXJlY3RseSBpbnN0ZWFkIG9mIGNvbXB1dGluZyB0aGUgaW50 ZXJzZWN0aW5nIHJlZ2lvbi4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NPY2NsdXNpb25UcmFj a2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmFkZE9jY2x1c2lvbkJlaGluZExheWVyKToKKyAg ICAgICAgKFdlYkNvcmU6Ojo6bWFya09jY2x1ZGVkQmVoaW5kTGF5ZXIpOgorICAgICAgICAoV2Vi Q29yZTo6cmVjdFN1YnRyYWN0UmVnaW9uKToKKwogMjAxMi0wNC0zMCAgTmF0ZSBDaGFwaW4gIDxq YXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1vdmUgbW9yZSBvZiBjb21taXR0aW5nIGFu ZCBzdGFydGluZyB0byB3cml0ZSBhIERvY3VtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ09jY2x1c2lvblRyYWNrZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NPY2NsdXNpb25U cmFja2VyLmNwcAppbmRleCA0NGE2OGJhNTIxNDA5MjA5MmJjNjBmYWU0MDRkYWNiOTNmOWQ5Mjky Li5hY2IxZmJiMDUyZTZmMTE3ZTRlNWNjMjA5MjBlNmY2YmFmNmUxY2MyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ09jY2x1c2lvblRy YWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L2NjL0NDT2NjbHVzaW9uVHJhY2tlci5jcHAKQEAgLTIyNiw3ICsyMjYsNyBAQCBzdGF0aWMgaW5s aW5lIFRyYW5zZm9ybWF0aW9uTWF0cml4IGNvbnRlbnRUb1RhcmdldFN1cmZhY2VUcmFuc2Zvcm0o Y29uc3QgTGF5ZXJUeQogCiAvLyBGSVhNRTogUmVtb3ZlIHVzZVBhaW50VHJhY2tpbmcgd2hlbiBw YWludCB0cmFja2luZyBpcyBvbiBmb3IgcGFpbnQgY3VsbGluZy4KIHRlbXBsYXRlPHR5cGVuYW1l IExheWVyVHlwZT4KLXN0YXRpYyBpbmxpbmUgUmVnaW9uIGNvbXB1dGVPY2NsdXNpb25CZWhpbmRM YXllcihjb25zdCBMYXllclR5cGUqIGxheWVyLCBjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYg dHJhbnNmb3JtLCBjb25zdCBSZWdpb24mIG9wYXF1ZUNvbnRlbnRzLCBjb25zdCBJbnRSZWN0JiBz Y2lzc29yUmVjdCwgYm9vbCB1c2VQYWludFRyYWNraW5nKQorc3RhdGljIGlubGluZSB2b2lkIGFk ZE9jY2x1c2lvbkJlaGluZExheWVyKFJlZ2lvbiYgcmVnaW9uLCBjb25zdCBMYXllclR5cGUqIGxh eWVyLCBjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgdHJhbnNmb3JtLCBjb25zdCBSZWdpb24m IG9wYXF1ZUNvbnRlbnRzLCBjb25zdCBJbnRSZWN0JiBzY2lzc29yUmVjdCwgYm9vbCB1c2VQYWlu dFRyYWNraW5nKQogewogICAgIEFTU0VSVChsYXllci0+dmlzaWJsZUxheWVyUmVjdCgpLmNvbnRh aW5zKG9wYXF1ZUNvbnRlbnRzLmJvdW5kcygpKSk7CiAKQEAgLTIzNCwyMCArMjM0LDE3IEBAIHN0 YXRpYyBpbmxpbmUgUmVnaW9uIGNvbXB1dGVPY2NsdXNpb25CZWhpbmRMYXllcihjb25zdCBMYXll clR5cGUqIGxheWVyLCBjb25zdCBUCiAgICAgRmxvYXRRdWFkIHZpc2libGVUcmFuc2Zvcm1lZFF1 YWQgPSBDQ01hdGhVdGlsOjptYXBRdWFkKHRyYW5zZm9ybSwgRmxvYXRRdWFkKGxheWVyLT52aXNp YmxlTGF5ZXJSZWN0KCkpLCBjbGlwcGVkKTsKICAgICAvLyBGSVhNRTogRmluZCBhIHJlY3QgaW50 ZXJpb3IgdG8gZWFjaCB0cmFuc2Zvcm1lZCBxdWFkLgogICAgIGlmIChjbGlwcGVkIHx8ICF2aXNp YmxlVHJhbnNmb3JtZWRRdWFkLmlzUmVjdGlsaW5lYXIoKSkKLSAgICAgICAgcmV0dXJuIFJlZ2lv bigpOworICAgICAgICByZXR1cm47CiAKLSAgICBSZWdpb24gdHJhbnNmb3JtZWRPcGFxdWVDb250 ZW50czsKLSAgICBpZiAodXNlUGFpbnRUcmFja2luZyAmJiB0cmFuc2Zvcm0uaXNJZGVudGl0eSgp KQotICAgICAgICB0cmFuc2Zvcm1lZE9wYXF1ZUNvbnRlbnRzID0gb3BhcXVlQ29udGVudHM7Ci0g ICAgZWxzZSBpZiAodXNlUGFpbnRUcmFja2luZykgeworICAgIGlmICh1c2VQYWludFRyYWNraW5n KSB7CiAgICAgICAgIFZlY3RvcjxJbnRSZWN0PiBjb250ZW50UmVjdHMgPSBvcGFxdWVDb250ZW50 cy5yZWN0cygpOwogICAgICAgICAvLyBXZSB2ZXJpZnkgdGhhdCB0aGUgcG9zc2libGUgYm91bmRz IG9mIHRoaXMgcmVnaW9uIGFyZSBub3QgY2xpcHBlZCBhYm92ZSwgc28gd2UgY2FuIHVzZSBtYXBS ZWN0KCkgc2FmZWx5IGhlcmUuCi0gICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgY29udGVu dFJlY3RzLnNpemUoKTsgKytpKQotICAgICAgICAgICAgdHJhbnNmb3JtZWRPcGFxdWVDb250ZW50 cy51bml0ZShlbmNsb3NlZEludFJlY3QodHJhbnNmb3JtLm1hcFJlY3QoRmxvYXRSZWN0KGNvbnRl bnRSZWN0c1tpXSkpKSk7CisgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgY29udGVudFJl Y3RzLnNpemUoKTsgKytpKSB7CisgICAgICAgICAgICBJbnRSZWN0IHRyYW5zZm9ybWVkUmVjdCA9 IGVuY2xvc2VkSW50UmVjdCh0cmFuc2Zvcm0ubWFwUmVjdChGbG9hdFJlY3QoY29udGVudFJlY3Rz W2ldKSkpOworICAgICAgICAgICAgdHJhbnNmb3JtZWRSZWN0LmludGVyc2VjdChzY2lzc29yUmVj dCk7CisgICAgICAgICAgICByZWdpb24udW5pdGUodHJhbnNmb3JtZWRSZWN0KTsKKyAgICAgICAg fQogICAgIH0KLQotICAgIHRyYW5zZm9ybWVkT3BhcXVlQ29udGVudHMuaW50ZXJzZWN0KHNjaXNz b3JSZWN0KTsKLSAgICByZXR1cm4gdHJhbnNmb3JtZWRPcGFxdWVDb250ZW50czsKIH0KIAogdGVt cGxhdGU8dHlwZW5hbWUgTGF5ZXJUeXBlLCB0eXBlbmFtZSBSZW5kZXJTdXJmYWNlVHlwZT4KQEAg LTI2Nyw3ICsyNjQsNyBAQCB2b2lkIENDT2NjbHVzaW9uVHJhY2tlckJhc2U8TGF5ZXJUeXBlLCBS ZW5kZXJTdXJmYWNlVHlwZT46Om1hcmtPY2NsdWRlZEJlaGluZExheQogCiAgICAgSW50UmVjdCBz Y2lzc29ySW5UYXJnZXQgPSBsYXllclNjaXNzb3JSZWN0SW5UYXJnZXRTdXJmYWNlKGxheWVyKTsK ICAgICBpZiAobGF5ZXJUcmFuc2Zvcm1zVG9UYXJnZXRLbm93bihsYXllcikpCi0gICAgICAgIG1f c3RhY2subGFzdCgpLm9jY2x1c2lvbkluVGFyZ2V0LnVuaXRlKGNvbXB1dGVPY2NsdXNpb25CZWhp bmRMYXllcjxMYXllclR5cGU+KGxheWVyLCBjb250ZW50VG9UYXJnZXRTdXJmYWNlVHJhbnNmb3Jt PExheWVyVHlwZT4obGF5ZXIpLCBvcGFxdWVDb250ZW50cywgc2Npc3NvckluVGFyZ2V0LCBtX3Vz ZVBhaW50VHJhY2tpbmcpKTsKKyAgICAgICAgYWRkT2NjbHVzaW9uQmVoaW5kTGF5ZXI8TGF5ZXJU eXBlPihtX3N0YWNrLmxhc3QoKS5vY2NsdXNpb25JblRhcmdldCwgbGF5ZXIsIGNvbnRlbnRUb1Rh cmdldFN1cmZhY2VUcmFuc2Zvcm08TGF5ZXJUeXBlPihsYXllciksIG9wYXF1ZUNvbnRlbnRzLCBz Y2lzc29ySW5UYXJnZXQsIG1fdXNlUGFpbnRUcmFja2luZyk7CiAKICAgICAvLyBXZSBtdXN0IGNs aXAgdGhlIG9jY2x1c2lvbiB3aXRoaW4gdGhlIGxheWVyJ3Mgc2Npc3NvckluVGFyZ2V0IHdpdGhp biBzY3JlZW4gc3BhY2UgYXMgd2VsbC4gSWYgdGhlIHNjaXNzb3IgcmVjdCBjYW4ndCBiZSBtb3Zl ZCB0byBzY3JlZW4gc3BhY2UgYW5kCiAgICAgLy8gcmVtYWluIHJlY3RpbGluZWFyLCB0aGVuIHdl IGRvbid0IGFkZCBhbnkgb2NjbHVzaW9uIGluIHNjcmVlbiBzcGFjZS4KQEAgLTI4MCw3ICsyNzcs NyBAQCB2b2lkIENDT2NjbHVzaW9uVHJhY2tlckJhc2U8TGF5ZXJUeXBlLCBSZW5kZXJTdXJmYWNl VHlwZT46Om1hcmtPY2NsdWRlZEJlaGluZExheQogICAgICAgICBpZiAoY2xpcHBlZCB8fCAhc2Np c3NvckluU2NyZWVuUXVhZC5pc1JlY3RpbGluZWFyKCkpCiAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgIEludFJlY3Qgc2Npc3NvckluU2NyZWVuUmVjdCA9IGludGVyc2VjdGlvbihtX3NjaXNz b3JSZWN0SW5TY3JlZW5TcGFjZSwgZW5jbG9zZWRJbnRSZWN0KHNjaXNzb3JJblNjcmVlblF1YWQu Ym91bmRpbmdCb3goKSkpOwotICAgICAgICBtX3N0YWNrLmxhc3QoKS5vY2NsdXNpb25JblNjcmVl bi51bml0ZShjb21wdXRlT2NjbHVzaW9uQmVoaW5kTGF5ZXI8TGF5ZXJUeXBlPihsYXllciwgY29u dGVudFRvU2NyZWVuU3BhY2VUcmFuc2Zvcm08TGF5ZXJUeXBlPihsYXllciksIG9wYXF1ZUNvbnRl bnRzLCBzY2lzc29ySW5TY3JlZW5SZWN0LCBtX3VzZVBhaW50VHJhY2tpbmcpKTsKKyAgICAgICAg YWRkT2NjbHVzaW9uQmVoaW5kTGF5ZXI8TGF5ZXJUeXBlPihtX3N0YWNrLmxhc3QoKS5vY2NsdXNp b25JblNjcmVlbiwgbGF5ZXIsIGNvbnRlbnRUb1NjcmVlblNwYWNlVHJhbnNmb3JtPExheWVyVHlw ZT4obGF5ZXIpLCBvcGFxdWVDb250ZW50cywgc2Npc3NvckluU2NyZWVuUmVjdCwgbV91c2VQYWlu dFRyYWNraW5nKTsKICAgICB9CiB9CiAKQEAgLTMxNSwxNCArMzEyLDggQEAgYm9vbCBDQ09jY2x1 c2lvblRyYWNrZXJCYXNlPExheWVyVHlwZSwgUmVuZGVyU3VyZmFjZVR5cGU+OjpvY2NsdWRlZChj b25zdCBMYXllclQKIHN0YXRpYyBpbmxpbmUgSW50UmVjdCByZWN0U3VidHJhY3RSZWdpb24oY29u c3QgSW50UmVjdCYgcmVjdCwgY29uc3QgUmVnaW9uJiByZWdpb24pCiB7CiAgICAgUmVnaW9uIHJl Y3RSZWdpb24ocmVjdCk7Ci0gICAgUmVnaW9uIGludGVyc2VjdFJlZ2lvbihpbnRlcnNlY3QocmVn aW9uLCByZWN0UmVnaW9uKSk7Ci0KLSAgICBpZiAoaW50ZXJzZWN0UmVnaW9uLmlzRW1wdHkoKSkK LSAgICAgICAgcmV0dXJuIHJlY3Q7Ci0KLSAgICByZWN0UmVnaW9uLnN1YnRyYWN0KGludGVyc2Vj dFJlZ2lvbik7Ci0gICAgSW50UmVjdCBib3VuZHNSZWN0ID0gcmVjdFJlZ2lvbi5ib3VuZHMoKTsK LSAgICByZXR1cm4gYm91bmRzUmVjdDsKKyAgICByZWN0UmVnaW9uLnN1YnRyYWN0KHJlZ2lvbik7 CisgICAgcmV0dXJuIHJlY3RSZWdpb24uYm91bmRzKCk7CiB9CiAKIHN0YXRpYyBpbmxpbmUgSW50 UmVjdCBjb21wdXRlVW5vY2NsdWRlZENvbnRlbnRSZWN0KGNvbnN0IEludFJlY3QmIGNvbnRlbnRS ZWN0LCBjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgY29udGVudFNwYWNlVHJhbnNmb3JtLCBj b25zdCBJbnRSZWN0JiBzY2lzc29yUmVjdCwgY29uc3QgUmVnaW9uJiBvY2NsdXNpb24pCg==