85245 2012-04-30 16:29:06 -0700 [chromium] CCDamageTrackerTest.verifyDamageForPerspectiveClippedLayer needs to be cleaner 2012-06-04 15:27:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85241 1 danakj shawnsingh danakj enne jamesr webkit.review.bot oldest_to_newest 613052 0 danakj 2012-04-30 16:29:06 -0700 Claim: // The expected damage should cover the entire root surface (500x500), but we don't // care whether the damage rect was clamped or is larger than the surface for this test. FloatRect rootDamageRect = root->renderSurface()->damageTracker()->currentDamageRect(); But it tests the rootDamageRect's width/height only. The following fails: EXPECT_LE(rootDamageRect.x(), 0); EXPECT_LE(rootDamageRect.y(), 0); EXPECT_GE(rootDamageRect.maxX(), 500); EXPECT_GE(rootDamageRect.maxY(), 500); It seems to actually end up with a damage rect that is very large and with its bottom right corner at 0,0. I am not sure if this is wrong, though it smells a bit weird to me. But the test does not seem to be testing what it actually claims - that the damage covers the root surface. 639517 1 shawnsingh 2012-06-01 10:48:30 -0700 (In reply to comment #0) > Claim: > // The expected damage should cover the entire root surface (500x500), but we don't > // care whether the damage rect was clamped or is larger than the surface for this test. > FloatRect rootDamageRect = root->renderSurface()->damageTracker()->currentDamageRect(); > > But it tests the rootDamageRect's width/height only. The following fails: > > EXPECT_LE(rootDamageRect.x(), 0); > EXPECT_LE(rootDamageRect.y(), 0); > EXPECT_GE(rootDamageRect.maxX(), 500); > EXPECT_GE(rootDamageRect.maxY(), 500); > > It seems to actually end up with a damage rect that is very large and with its bottom right corner at 0,0. I am not sure if this is wrong, though it smells a bit weird to me. But the test does not seem to be testing what it actually claims - that the damage covers the root surface. So I added those two lines, and it seems to work correctly. Can you please double-check what it is you felt might be wrong? In the mean-time, I'll use this bug to submit a quick and trivial patch to add those two lines, because I agree they should be there. 639522 2 danakj 2012-06-01 10:54:02 -0700 I added a printf and get this [ RUN ] CCDamageTrackerTest.verifyDamageForPerspectiveClippedLayer rootDamageRect -15099999.000000 -10000000.000000 15099996.000000 10000000.000000 The damage rect is not intersecting with the root at all, as its maxY is 0. 639544 3 shawnsingh 2012-06-01 11:30:58 -0700 OK, I looked at it in detail and found the following: The test was testing what it needed to, so nothing was really wrong. However, it was certainly confusing and misleading, and I don't understand why I had written it that way when I originally wrote it. So I'm about to submit a patch that fixes it to be a little bit more intuitive (as much as this perspective stuff can be...) and changed the bug title to reflect the actual problem. Thanks Dana! 639547 4 145342 shawnsingh 2012-06-01 11:34:21 -0700 Created attachment 145342 Patch 639553 5 145342 danakj 2012-06-01 11:38:18 -0700 Comment on attachment 145342 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145342&action=review Good stuff! > Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:366 > + FloatRect damageWeCareAbout = FloatRect(FloatPoint::zero(), FloatSize(500, 500)); > + rootDamageRect.intersect(damageWeCareAbout); > + EXPECT_FLOAT_RECT_EQ(damageWeCareAbout, rootDamageRect); What about EXPECT_TRUE(rootdamageRect.contains(rootRect))? I think that's what we're doing in 2 lines here? 639554 6 shawnsingh 2012-06-01 11:39:39 -0700 (In reply to comment #5) > (From update of attachment 145342 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145342&action=review > > Good stuff! > > > Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:366 > > + FloatRect damageWeCareAbout = FloatRect(FloatPoint::zero(), FloatSize(500, 500)); > > + rootDamageRect.intersect(damageWeCareAbout); > > + EXPECT_FLOAT_RECT_EQ(damageWeCareAbout, rootDamageRect); > > What about EXPECT_TRUE(rootdamageRect.contains(rootRect))? I think that's what we're doing in 2 lines here? sure, sounds even better. 639556 7 145344 shawnsingh 2012-06-01 11:41:42 -0700 Created attachment 145344 Patch 640794 8 shawnsingh 2012-06-04 13:20:14 -0700 James could you please review this? Thanks in advance. 640832 9 145344 jamesr 2012-06-04 14:20:59 -0700 Comment on attachment 145344 Patch R=me 640833 10 145344 shawnsingh 2012-06-04 14:22:26 -0700 Comment on attachment 145344 Patch Thanks! 640900 11 145344 webkit.review.bot 2012-06-04 15:27:04 -0700 Comment on attachment 145344 Patch Clearing flags on attachment: 145344 Committed r119432: <http://trac.webkit.org/changeset/119432> 640901 12 webkit.review.bot 2012-06-04 15:27:08 -0700 All reviewed patches have been landed. Closing bug. 145342 2012-06-01 11:34:21 -0700 2012-06-01 11:41:39 -0700 Patch bug-85245-20120601113420.patch text/plain 3361 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDkzNjFhNDg1YjhmYjUxZDBiZTcwYjhhZDdmZTg1ZDZlNTM1NGU0NjAuLmM2ZGRkMDEyOGNhNTdi ZTFlZWZmMjY2YWI5Nzg2OGVmNzM5MTUwNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDYtMDEgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBDQ0RhbWFnZVRyYWNrZXJUZXN0LnZlcmlm eURhbWFnZUZvclBlcnNwZWN0aXZlQ2xpcHBlZExheWVyIG5lZWRzIHRvIGJlIGNsZWFuZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MjQ1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlZCBDQ0Rh bWFnZVRyYWNrZXJUZXN0LnZlcmlmeURhbWFnZUZvclBlcnNwZWN0aXZlQ2xpcHBlZExheWVyCisg ICAgICAgIHNvIHRoYXQgdGhlIHRlc3QgaXMgY2xlYXJlciBhbmQgY2xlYW5lci4gVGhlIG9yaWdp bmFsIHRlc3Qgd2FzCisgICAgICAgIGNvdmVyaW5nIHdoYXQgaXQgbmVlZGVkLCBidXQgaW4gYSBj b25mdXNpbmcgYW5kIG5vdC1zby1wcmFjdGljYWwKKyAgICAgICAgd2F5LiBUaGlzIHBhdGNoIGFk ZHMgY29tbWVudHMgYW5kIHBlcmZvcm1zIGEgdGlnaHRlciB0ZXN0IHNvIHRoYXQKKyAgICAgICAg dGhlIGludGVudCBpcyBhIGJpdCBtb3JlIGNsZWFyLgorCisgICAgICAgICogdGVzdHMvQ0NEYW1h Z2VUcmFja2VyVGVzdC5jcHA6CisgICAgICAgIChXZWJLaXRUZXN0czo6VEVTVF9GKToKKwogMjAx Mi0wNi0wMSAgUGV0ZXIgQmV2ZXJsb28gIDxwZXRlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZC4gIFJvbGxlZCBERVBTLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9DQ0RhbWFnZVRyYWNrZXJUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvQ0NEYW1hZ2VUcmFja2VyVGVzdC5jcHAKaW5kZXggNTZkODVmYWZhOWZkN2I5YWM3 ZjJmMjcyOGQ2Y2FmNjdiNzk2YWIxMy4uNjcxODI0OGQxYTA1Y2MyMWZkOTBmMjMzNmRlYzA1Yjhl N2I0OWU0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0RhbWFn ZVRyYWNrZXJUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDRGFt YWdlVHJhY2tlclRlc3QuY3BwCkBAIC0zMjYsMTUgKzMyNiwxNyBAQCBURVNUX0YoQ0NEYW1hZ2VU cmFja2VyVGVzdCwgdmVyaWZ5RGFtYWdlRm9yUGVyc3BlY3RpdmVDbGlwcGVkTGF5ZXIpCiAgICAg Ly8gdHJhY2tlZCBwcm9wZXJseS4KICAgICAvLwogICAgIC8vIFRoZSB0cmFuc2Zvcm0gaXMgY29u c3RydWN0ZWQgc28gdGhhdCBpZiB3IDwgMCBjbGlwcGluZyBpcyBub3QgcGVyZm9ybWVkLCB0aGUK LSAgICAvLyBpbmNvcnJlY3QgcmVjdCB3aWxsIGJlIHZlcnkgc21hbGwsIHNwZWNpZmljYWxseTog cG9zaXRpb24gKC0zLjE1MzQ0OCwgLTIuNzUwNjI4KSBhbmQgc2l6ZSA4LjU0ODY4OSB4IDUuNjYx MzgzLgotICAgIC8vIEluc3RlYWQsIHRoZSBjb3JyZWN0bHkgdHJhbnNmb3JtZWQgcmVjdCBzaG91 bGQgYWN0dWFsbHkgYmUgdmVyeSBodWdlIChpLmUuIGluIHRoZW9yeSwgaW5maW5pdGUpCisgICAg Ly8gaW5jb3JyZWN0IHJlY3Qgd2lsbCBiZSB2ZXJ5IHNtYWxsLCBzcGVjaWZpY2FsbHk6IHBvc2l0 aW9uICg1MDAuOTcyNTA0LCA0OTguNTQ0NjE3KSBhbmQgc2l6ZSAwLjA1NjYxMCB4IDIuOTEwNzY3 LgorICAgIC8vIEluc3RlYWQsIHRoZSBjb3JyZWN0bHkgdHJhbnNmb3JtZWQgcmVjdCBzaG91bGQg YWN0dWFsbHkgYmUgdmVyeSBodWdlIChpLmUuIGluIHRoZW9yeSwgLWluZmluaXR5IG9uIHRoZSBs ZWZ0KSwKKyAgICAvLyBhbmQgcG9zaXRpb25lZCBzbyB0aGF0IHRoZSByaWdodC1tb3N0IGJvdW5k IHJlY3Qgd2lsbCBiZSBhcHByb3hpbWF0ZWx5IDUwMSB1bml0cyBpbiByb290IHN1cmZhY2Ugc3Bh Y2UuCisgICAgLy8KIAogICAgIE93blB0cjxDQ0xheWVySW1wbD4gcm9vdCA9IGNyZWF0ZUFuZFNl dFVwVGVzdFRyZWVXaXRoT25lU3VyZmFjZSgpOwogICAgIENDTGF5ZXJJbXBsKiBjaGlsZCA9IHJv b3QtPmNoaWxkcmVuKClbMF0uZ2V0KCk7CiAKICAgICBXZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeCB0 cmFuc2Zvcm07CisgICAgdHJhbnNmb3JtLnRyYW5zbGF0ZTNkKDUwMCwgNTAwLCAwKTsKICAgICB0 cmFuc2Zvcm0uYXBwbHlQZXJzcGVjdGl2ZSgxKTsKLSAgICB0cmFuc2Zvcm0udHJhbnNsYXRlM2Qo LTE1MCwgLTUwLCAwKTsKICAgICB0cmFuc2Zvcm0ucm90YXRlM2QoMCwgNDUsIDApOwogICAgIHRy YW5zZm9ybS50cmFuc2xhdGUzZCgtNTAsIC01MCwgMCk7CiAKQEAgLTM1Nyw5ICszNTksMTEgQEAg VEVTVF9GKENDRGFtYWdlVHJhY2tlclRlc3QsIHZlcmlmeURhbWFnZUZvclBlcnNwZWN0aXZlQ2xp cHBlZExheWVyKQogCiAgICAgLy8gVGhlIGV4cGVjdGVkIGRhbWFnZSBzaG91bGQgY292ZXIgdGhl IGVudGlyZSByb290IHN1cmZhY2UgKDUwMHg1MDApLCBidXQgd2UgZG9uJ3QKICAgICAvLyBjYXJl IHdoZXRoZXIgdGhlIGRhbWFnZSByZWN0IHdhcyBjbGFtcGVkIG9yIGlzIGxhcmdlciB0aGFuIHRo ZSBzdXJmYWNlIGZvciB0aGlzIHRlc3QuCisgICAgLy8gVG8gdGVzdCBlaXRoZXIgY2FzZSBjb3Jy ZWN0bHksIHdlIGNsYW1wIHRoZSBhY3R1YWwgZGFtYWdlIHRvIHRoZSBkYW1hZ2Ugd2UgY2FyZSBh Ym91dC4KICAgICBGbG9hdFJlY3Qgcm9vdERhbWFnZVJlY3QgPSByb290LT5yZW5kZXJTdXJmYWNl KCktPmRhbWFnZVRyYWNrZXIoKS0+Y3VycmVudERhbWFnZVJlY3QoKTsKLSAgICBFWFBFQ1RfR0Uo cm9vdERhbWFnZVJlY3Qud2lkdGgoKSwgNTAwKTsKLSAgICBFWFBFQ1RfR0Uocm9vdERhbWFnZVJl Y3QuaGVpZ2h0KCksIDUwMCk7CisgICAgRmxvYXRSZWN0IGRhbWFnZVdlQ2FyZUFib3V0ID0gRmxv YXRSZWN0KEZsb2F0UG9pbnQ6Onplcm8oKSwgRmxvYXRTaXplKDUwMCwgNTAwKSk7CisgICAgcm9v dERhbWFnZVJlY3QuaW50ZXJzZWN0KGRhbWFnZVdlQ2FyZUFib3V0KTsKKyAgICBFWFBFQ1RfRkxP QVRfUkVDVF9FUShkYW1hZ2VXZUNhcmVBYm91dCwgcm9vdERhbWFnZVJlY3QpOwogfQogCiBURVNU X0YoQ0NEYW1hZ2VUcmFja2VyVGVzdCwgdmVyaWZ5RGFtYWdlRm9yQmx1cnJlZFN1cmZhY2UpCg== 145344 2012-06-01 11:41:42 -0700 2012-06-04 15:27:04 -0700 Patch bug-85245-20120601114141.patch text/plain 3213 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDkzNjFhNDg1YjhmYjUxZDBiZTcwYjhhZDdmZTg1ZDZlNTM1NGU0NjAuLmM2ZGRkMDEyOGNhNTdi ZTFlZWZmMjY2YWI5Nzg2OGVmNzM5MTUwNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDYtMDEgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBDQ0RhbWFnZVRyYWNrZXJUZXN0LnZlcmlm eURhbWFnZUZvclBlcnNwZWN0aXZlQ2xpcHBlZExheWVyIG5lZWRzIHRvIGJlIGNsZWFuZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MjQ1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlZCBDQ0Rh bWFnZVRyYWNrZXJUZXN0LnZlcmlmeURhbWFnZUZvclBlcnNwZWN0aXZlQ2xpcHBlZExheWVyCisg ICAgICAgIHNvIHRoYXQgdGhlIHRlc3QgaXMgY2xlYXJlciBhbmQgY2xlYW5lci4gVGhlIG9yaWdp bmFsIHRlc3Qgd2FzCisgICAgICAgIGNvdmVyaW5nIHdoYXQgaXQgbmVlZGVkLCBidXQgaW4gYSBj b25mdXNpbmcgYW5kIG5vdC1zby1wcmFjdGljYWwKKyAgICAgICAgd2F5LiBUaGlzIHBhdGNoIGFk ZHMgY29tbWVudHMgYW5kIHBlcmZvcm1zIGEgdGlnaHRlciB0ZXN0IHNvIHRoYXQKKyAgICAgICAg dGhlIGludGVudCBpcyBhIGJpdCBtb3JlIGNsZWFyLgorCisgICAgICAgICogdGVzdHMvQ0NEYW1h Z2VUcmFja2VyVGVzdC5jcHA6CisgICAgICAgIChXZWJLaXRUZXN0czo6VEVTVF9GKToKKwogMjAx Mi0wNi0wMSAgUGV0ZXIgQmV2ZXJsb28gIDxwZXRlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZC4gIFJvbGxlZCBERVBTLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9DQ0RhbWFnZVRyYWNrZXJUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvQ0NEYW1hZ2VUcmFja2VyVGVzdC5jcHAKaW5kZXggNTZkODVmYWZhOWZkN2I5YWM3 ZjJmMjcyOGQ2Y2FmNjdiNzk2YWIxMy4uNjFlMmNlNzVlODNkN2Y0Y2RjMGYwZjgwNjY3NGVhODRk NmQ1N2QyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0RhbWFn ZVRyYWNrZXJUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDRGFt YWdlVHJhY2tlclRlc3QuY3BwCkBAIC0zMjYsMTUgKzMyNiwxNyBAQCBURVNUX0YoQ0NEYW1hZ2VU cmFja2VyVGVzdCwgdmVyaWZ5RGFtYWdlRm9yUGVyc3BlY3RpdmVDbGlwcGVkTGF5ZXIpCiAgICAg Ly8gdHJhY2tlZCBwcm9wZXJseS4KICAgICAvLwogICAgIC8vIFRoZSB0cmFuc2Zvcm0gaXMgY29u c3RydWN0ZWQgc28gdGhhdCBpZiB3IDwgMCBjbGlwcGluZyBpcyBub3QgcGVyZm9ybWVkLCB0aGUK LSAgICAvLyBpbmNvcnJlY3QgcmVjdCB3aWxsIGJlIHZlcnkgc21hbGwsIHNwZWNpZmljYWxseTog cG9zaXRpb24gKC0zLjE1MzQ0OCwgLTIuNzUwNjI4KSBhbmQgc2l6ZSA4LjU0ODY4OSB4IDUuNjYx MzgzLgotICAgIC8vIEluc3RlYWQsIHRoZSBjb3JyZWN0bHkgdHJhbnNmb3JtZWQgcmVjdCBzaG91 bGQgYWN0dWFsbHkgYmUgdmVyeSBodWdlIChpLmUuIGluIHRoZW9yeSwgaW5maW5pdGUpCisgICAg Ly8gaW5jb3JyZWN0IHJlY3Qgd2lsbCBiZSB2ZXJ5IHNtYWxsLCBzcGVjaWZpY2FsbHk6IHBvc2l0 aW9uICg1MDAuOTcyNTA0LCA0OTguNTQ0NjE3KSBhbmQgc2l6ZSAwLjA1NjYxMCB4IDIuOTEwNzY3 LgorICAgIC8vIEluc3RlYWQsIHRoZSBjb3JyZWN0bHkgdHJhbnNmb3JtZWQgcmVjdCBzaG91bGQg YWN0dWFsbHkgYmUgdmVyeSBodWdlIChpLmUuIGluIHRoZW9yeSwgLWluZmluaXR5IG9uIHRoZSBs ZWZ0KSwKKyAgICAvLyBhbmQgcG9zaXRpb25lZCBzbyB0aGF0IHRoZSByaWdodC1tb3N0IGJvdW5k IHJlY3Qgd2lsbCBiZSBhcHByb3hpbWF0ZWx5IDUwMSB1bml0cyBpbiByb290IHN1cmZhY2Ugc3Bh Y2UuCisgICAgLy8KIAogICAgIE93blB0cjxDQ0xheWVySW1wbD4gcm9vdCA9IGNyZWF0ZUFuZFNl dFVwVGVzdFRyZWVXaXRoT25lU3VyZmFjZSgpOwogICAgIENDTGF5ZXJJbXBsKiBjaGlsZCA9IHJv b3QtPmNoaWxkcmVuKClbMF0uZ2V0KCk7CiAKICAgICBXZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeCB0 cmFuc2Zvcm07CisgICAgdHJhbnNmb3JtLnRyYW5zbGF0ZTNkKDUwMCwgNTAwLCAwKTsKICAgICB0 cmFuc2Zvcm0uYXBwbHlQZXJzcGVjdGl2ZSgxKTsKLSAgICB0cmFuc2Zvcm0udHJhbnNsYXRlM2Qo LTE1MCwgLTUwLCAwKTsKICAgICB0cmFuc2Zvcm0ucm90YXRlM2QoMCwgNDUsIDApOwogICAgIHRy YW5zZm9ybS50cmFuc2xhdGUzZCgtNTAsIC01MCwgMCk7CiAKQEAgLTM1OCw4ICszNjAsOCBAQCBU RVNUX0YoQ0NEYW1hZ2VUcmFja2VyVGVzdCwgdmVyaWZ5RGFtYWdlRm9yUGVyc3BlY3RpdmVDbGlw cGVkTGF5ZXIpCiAgICAgLy8gVGhlIGV4cGVjdGVkIGRhbWFnZSBzaG91bGQgY292ZXIgdGhlIGVu dGlyZSByb290IHN1cmZhY2UgKDUwMHg1MDApLCBidXQgd2UgZG9uJ3QKICAgICAvLyBjYXJlIHdo ZXRoZXIgdGhlIGRhbWFnZSByZWN0IHdhcyBjbGFtcGVkIG9yIGlzIGxhcmdlciB0aGFuIHRoZSBz dXJmYWNlIGZvciB0aGlzIHRlc3QuCiAgICAgRmxvYXRSZWN0IHJvb3REYW1hZ2VSZWN0ID0gcm9v dC0+cmVuZGVyU3VyZmFjZSgpLT5kYW1hZ2VUcmFja2VyKCktPmN1cnJlbnREYW1hZ2VSZWN0KCk7 Ci0gICAgRVhQRUNUX0dFKHJvb3REYW1hZ2VSZWN0LndpZHRoKCksIDUwMCk7Ci0gICAgRVhQRUNU X0dFKHJvb3REYW1hZ2VSZWN0LmhlaWdodCgpLCA1MDApOworICAgIEZsb2F0UmVjdCBkYW1hZ2VX ZUNhcmVBYm91dCA9IEZsb2F0UmVjdChGbG9hdFBvaW50Ojp6ZXJvKCksIEZsb2F0U2l6ZSg1MDAs IDUwMCkpOworICAgIEVYUEVDVF9UUlVFKHJvb3REYW1hZ2VSZWN0LmNvbnRhaW5zKGRhbWFnZVdl Q2FyZUFib3V0KSk7CiB9CiAKIFRFU1RfRihDQ0RhbWFnZVRyYWNrZXJUZXN0LCB2ZXJpZnlEYW1h Z2VGb3JCbHVycmVkU3VyZmFjZSkK