85240 2012-04-30 15:32:24 -0700 ScrollingCoordinator::requestScrollPositionUpdate should not update the main frame scroll position 2012-09-26 18:27:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca jamesr thorton tonikitoo webkit.review.bot oldest_to_newest 613011 0 andersca 2012-04-30 15:32:24 -0700 ScrollingCoordinator::requestScrollPositionUpdate should not update the main frame scroll position 613015 1 139531 andersca 2012-04-30 15:37:25 -0700 Created attachment 139531 Patch 613021 2 andersca 2012-04-30 15:41:50 -0700 Committed r115681: <http://trac.webkit.org/changeset/115681> 139531 2012-04-30 15:37:25 -0700 2012-04-30 15:38:57 -0700 Patch bug-85240-20120430153913.patch text/plain 6769 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1Njc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGU1NGJkYmQ4YTg5NjYz ZjllNmI0YjQ4NGY0YzQ0NzM3OGM3M2Y3Yy4uY2Y3ZjdjMjZjNWFkYzBhOTE2ODA0MzU0MDk5Y2Y2 ZWIzMDRmMzNmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA0LTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgU2Nyb2xsaW5nQ29v cmRpbmF0b3I6OnJlcXVlc3RTY3JvbGxQb3NpdGlvblVwZGF0ZSBzaG91bGQgbm90IHVwZGF0ZSB0 aGUgbWFpbiBmcmFtZSBzY3JvbGwgcG9zaXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MjQwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTI4 NjYwOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgY2FsbCB0byB1cGRhdGVNYWluRnJhbWVTY3JvbGxQb3NpdGlvbiB3YXMgYWRkZWQgdG8gbWFr ZSB0aGUgV2ViS2l0MiBmaW5kIG92ZXJsYXkgd29yaywgc2luY2UgaXQgcmVsaWVzCisgICAgICAg IG9uIHNjcm9sbCBwb3NpdGlvbiB1cGRhdGVzIGJlaW5nIHN5bmNocm9ub3VzLiBDaGFuZ2UgdGhl IGZpbmQgY29kZSBpbiBXZWJLaXQyIHRvIGhhbmRsZSBhc3luY2hyb25vdXMgc2Nyb2xsCisgICAg ICAgIHBvc2l0aW9uIHVwZGF0ZXMgYW5kIHJlbW92ZSB0aGUgY2FsbCB0byB1cGRhdGVNYWluRnJh bWVTY3JvbGxQb3NpdGlvbi4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nv b3JkaW5hdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpy ZXF1ZXN0U2Nyb2xsUG9zaXRpb25VcGRhdGUpOgorCisyMDEyLTA0LTMwICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIGEgd2F5IHRvIGFzeW5jaHJv bm91c2x5IGNhbGwgYSBmdW5jdGlvbiBvbmNlIHRoZSBzY3JvbGwgcG9zaXRpb24gb2YgYSBwYWdl IGhhcyBiZWVuIHVwZGF0ZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg1MjM3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1MWI5MmZkNTQ0YTNhZjQ4ODFmZWQyZjM2 NzY0MTVjZDg1ZWVjZjQ5Li4yZjE0MWUzMGU2ZmQyZGYxOWY4YzYzMDIyMjE4MDZjNjYwNmQyODkz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTItMDQtMzAgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBTY3JvbGxpbmdDb29yZGluYXRvcjo6 cmVxdWVzdFNjcm9sbFBvc2l0aW9uVXBkYXRlIHNob3VsZCBub3QgdXBkYXRlIHRoZSBtYWluIGZy YW1lIHNjcm9sbCBwb3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODUyNDAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExMjg2NjA5PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBmaW5kIG1h Y2hpbmVyeSBzaG91bGQgY29wZSB3aXRoIGFzeW5jaHJvbm91cyBzY3JvbGwgcG9zaXRpb24gdXBk YXRlcy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5jcHA6 CisgICAgICAgIChXZWJLaXQ6OkZpbmRDb250cm9sbGVyOjp1cGRhdGVGaW5kVUlBZnRlclBhZ2VT Y3JvbGwpOgorICAgICAgICBTcGxpdCB0aGUgY29kZSB0aGF0IGhhbmRsZXMgdXBkYXRpbmcgdGhl IGZpbmQgaW5kaWNhdG9yIGFuZCBmaW5kIG92ZXJsYXkgb3V0IGludG8gYSBzZXBhcmF0ZSBmdW5j dGlvbi4KKworICAgICAgICAoV2ViS2l0OjpGaW5kQ29udHJvbGxlcjo6ZmluZFN0cmluZyk6Cisg ICAgICAgIENhbGwgdXBkYXRlRmluZFVJQWZ0ZXJQYWdlU2Nyb2xsIG9uY2Ugd2Uga25vdyB0aGF0 IHRoZSBzY3JvbGwgcG9zaXRpb24gaGFzIGJlZW4gdXBkYXRlZC4KKworMjAxMi0wNC0zMCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCBhIHdheSB0 byBhc3luY2hyb25vdXNseSBjYWxsIGEgZnVuY3Rpb24gb25jZSB0aGUgc2Nyb2xsIHBvc2l0aW9u IG9mIGEgcGFnZSBoYXMgYmVlbiB1cGRhdGVkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NTIzNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKaW5kZXggYmNmYmRhNDhhODk3 OWIwMWQ4MzM1YWUwMTkxZjQ4N2Y0NWU1YTVlMi4uMjgwZjY5ZmY0YTNjZWFkZGY4NjY5MjAzNWYw MGQ1MmM4MmI4ZDNmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcv U2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xs aW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcApAQCAtMjI0LDEzICsyMjQsMTAgQEAgYm9vbCBT Y3JvbGxpbmdDb29yZGluYXRvcjo6cmVxdWVzdFNjcm9sbFBvc2l0aW9uVXBkYXRlKEZyYW1lVmll dyogZnJhbWVWaWV3LCBjb24KICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAjaWYgRU5BQkxFKFRI UkVBREVEX1NDUk9MTElORykKLSAgICAvLyBVcGRhdGUgdGhlIG1haW4gZnJhbWUgc2Nyb2xsIHBv c2l0aW9uIGxvY2FsbHkgYmVmb3JlIGFza2luZyB0aGUgc2Nyb2xsaW5nIHRocmVhZCB0byBzY3Jv bGwsCi0gICAgLy8gc2luY2UgRnJhbWVWaWV3IGV4cGVjdHMgc2Nyb2xsIHBvc2l0aW9uIHVwZGF0 ZXMgdG8gaGFwcGVuIHN5bmNocm9ub3VzbHkuCi0gICAgdXBkYXRlTWFpbkZyYW1lU2Nyb2xsUG9z aXRpb24oc2Nyb2xsUG9zaXRpb24pOwotCiAgICAgaWYgKGZyYW1lVmlldy0+ZnJhbWUoKS0+ZG9j dW1lbnQoKS0+aW5QYWdlQ2FjaGUoKSkgewogICAgICAgICAvLyBJZiB0aGlzIGZyYW1lIHZpZXcn cyBkb2N1bWVudCBpcyBiZWluZyBwdXQgaW50byB0aGUgcGFnZSBjYWNoZSwgd2UgZG9uJ3Qgd2Fu dCB0byB1cGRhdGUgb3VyCi0gICAgICAgIC8vIG1haW4gZnJhbWUgc2Nyb2xsIHBvc2l0aW9uLgor ICAgICAgICAvLyBtYWluIGZyYW1lIHNjcm9sbCBwb3NpdGlvbi4gSnVzdCBsZXQgdGhlIEZyYW1l VmlldyB0aGluayB0aGF0IHdlIGRpZC4KKyAgICAgICAgdXBkYXRlTWFpbkZyYW1lU2Nyb2xsUG9z aXRpb24oc2Nyb2xsUG9zaXRpb24pOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxl ci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZENvbnRyb2xsZXIu Y3BwCmluZGV4IGUyOThlOWYzM2Y3NmIxNjkzZDczMjBkNGY4YzRlNjhkMmQ5NWFlMzMuLjQ5MThk ZGUzNmE5NDdiODNiZDQyYjQ2NzJhMjBiZDllY2ZlOGU2NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmNwcApAQCAtMzMsNiAr MzMsNyBAQAogI2luY2x1ZGUgIldlYlBhZ2VQcm94eU1lc3NhZ2VzLmgiCiAjaW5jbHVkZSAiV2Vi UHJvY2Vzcy5oIgogI2luY2x1ZGUgPFdlYkNvcmUvRG9jdW1lbnRNYXJrZXJDb250cm9sbGVyLmg+ CisjaW5jbHVkZSA8V2ViQ29yZS9GbG9hdFF1YWQuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0ZvY3Vz Q29udHJvbGxlci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRnJhbWUuaD4KICNpbmNsdWRlIDxXZWJD b3JlL0ZyYW1lVmlldy5oPgpAQCAtODksMTIgKzkwLDggQEAgc3RhdGljIEZyYW1lKiBmcmFtZVdp dGhTZWxlY3Rpb24oUGFnZSogcGFnZSkKICAgICByZXR1cm4gMDsKIH0KIAotdm9pZCBGaW5kQ29u dHJvbGxlcjo6ZmluZFN0cmluZyhjb25zdCBTdHJpbmcmIHN0cmluZywgRmluZE9wdGlvbnMgb3B0 aW9ucywgdW5zaWduZWQgbWF4TWF0Y2hDb3VudCkKK3ZvaWQgRmluZENvbnRyb2xsZXI6OnVwZGF0 ZUZpbmRVSUFmdGVyUGFnZVNjcm9sbChib29sIGZvdW5kLCBjb25zdCBTdHJpbmcmIHN0cmluZywg RmluZE9wdGlvbnMgb3B0aW9ucywgdW5zaWduZWQgbWF4TWF0Y2hDb3VudCkKIHsKLSAgICBtX3dl YlBhZ2UtPmNvcmVQYWdlKCktPnVubWFya0FsbFRleHRNYXRjaGVzKCk7Ci0KLSAgICBib29sIGZv dW5kID0gbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5maW5kU3RyaW5nKHN0cmluZywgY29yZShvcHRp b25zKSk7Ci0KICAgICBGcmFtZSogc2VsZWN0ZWRGcmFtZSA9IGZyYW1lV2l0aFNlbGVjdGlvbiht X3dlYlBhZ2UtPmNvcmVQYWdlKCkpOwogCiAgICAgYm9vbCBzaG91bGRTaG93T3ZlcmxheSA9IGZh bHNlOwpAQCAtMTQxLDE5ICsxMzgsMjcgQEAgdm9pZCBGaW5kQ29udHJvbGxlcjo6ZmluZFN0cmlu Zyhjb25zdCBTdHJpbmcmIHN0cmluZywgRmluZE9wdGlvbnMgb3B0aW9ucywgdW5zaWcKICAgICAg ICAgfQogICAgICAgICAKICAgICAgICAgQVNTRVJUKCFtX2ZpbmRQYWdlT3ZlcmxheSk7Ci0gICAg ICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICBpZiAoIW1fZmluZFBhZ2VPdmVybGF5KSB7Ci0gICAg ICAgIFJlZlB0cjxQYWdlT3ZlcmxheT4gZmluZFBhZ2VPdmVybGF5ID0gUGFnZU92ZXJsYXk6OmNy ZWF0ZSh0aGlzKTsKLSAgICAgICAgbV9maW5kUGFnZU92ZXJsYXkgPSBmaW5kUGFnZU92ZXJsYXku Z2V0KCk7Ci0gICAgICAgIG1fd2ViUGFnZS0+aW5zdGFsbFBhZ2VPdmVybGF5KGZpbmRQYWdlT3Zl cmxheS5yZWxlYXNlKCkpOwogICAgIH0gZWxzZSB7Ci0gICAgICAgIC8vIFRoZSBwYWdlIG92ZXJs YXkgbmVlZHMgdG8gYmUgcmVwYWludGVkLgotICAgICAgICBtX2ZpbmRQYWdlT3ZlcmxheS0+c2V0 TmVlZHNEaXNwbGF5KCk7CisgICAgICAgIGlmICghbV9maW5kUGFnZU92ZXJsYXkpIHsKKyAgICAg ICAgICAgIFJlZlB0cjxQYWdlT3ZlcmxheT4gZmluZFBhZ2VPdmVybGF5ID0gUGFnZU92ZXJsYXk6 OmNyZWF0ZSh0aGlzKTsKKyAgICAgICAgICAgIG1fZmluZFBhZ2VPdmVybGF5ID0gZmluZFBhZ2VP dmVybGF5LmdldCgpOworICAgICAgICAgICAgbV93ZWJQYWdlLT5pbnN0YWxsUGFnZU92ZXJsYXko ZmluZFBhZ2VPdmVybGF5LnJlbGVhc2UoKSk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAg ICAvLyBUaGUgcGFnZSBvdmVybGF5IG5lZWRzIHRvIGJlIHJlcGFpbnRlZC4KKyAgICAgICAgICAg IG1fZmluZFBhZ2VPdmVybGF5LT5zZXROZWVkc0Rpc3BsYXkoKTsKKyAgICAgICAgfQogICAgIH0K IH0KIAordm9pZCBGaW5kQ29udHJvbGxlcjo6ZmluZFN0cmluZyhjb25zdCBTdHJpbmcmIHN0cmlu ZywgRmluZE9wdGlvbnMgb3B0aW9ucywgdW5zaWduZWQgbWF4TWF0Y2hDb3VudCkKK3sKKyAgICBt X3dlYlBhZ2UtPmNvcmVQYWdlKCktPnVubWFya0FsbFRleHRNYXRjaGVzKCk7CisKKyAgICBib29s IGZvdW5kID0gbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5maW5kU3RyaW5nKHN0cmluZywgY29yZShv cHRpb25zKSk7CisKKyAgICBtX3dlYlBhZ2UtPmRyYXdpbmdBcmVhKCktPmRpc3BhdGNoQWZ0ZXJF bnN1cmluZ1VwZGF0ZWRTY3JvbGxQb3NpdGlvbihiaW5kKCZGaW5kQ29udHJvbGxlcjo6dXBkYXRl RmluZFVJQWZ0ZXJQYWdlU2Nyb2xsLCB0aGlzLCBmb3VuZCwgc3RyaW5nLCBvcHRpb25zLCBtYXhN YXRjaENvdW50KSk7Cit9CisKIHZvaWQgRmluZENvbnRyb2xsZXI6OmhpZGVGaW5kVUkoKQogewog ICAgIGlmIChtX2ZpbmRQYWdlT3ZlcmxheSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmgKaW5kZXggMTk5NDYwYTBkYzZjOWI3MzI3N2Nh YjlmYWM3ZDVhOTNiZjc5MzQxOC4uZTA3MGI2YjczNzEwMTRjMDRiNjkxNzcwMTA4MDQ0ODhmMjBi ZmYxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRD b250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRD b250cm9sbGVyLmgKQEAgLTcwLDcgKzcwLDggQEAgcHJpdmF0ZToKICAgICBWZWN0b3I8V2ViQ29y ZTo6SW50UmVjdD4gcmVjdHNGb3JUZXh0TWF0Y2hlcygpOwogICAgIGJvb2wgdXBkYXRlRmluZElu ZGljYXRvcihXZWJDb3JlOjpGcmFtZSogc2VsZWN0ZWRGcmFtZSwgYm9vbCBpc1Nob3dpbmdPdmVy bGF5LCBib29sIHNob3VsZEFuaW1hdGUgPSB0cnVlKTsKIAotcHJpdmF0ZToKKyAgICB2b2lkIHVw ZGF0ZUZpbmRVSUFmdGVyUGFnZVNjcm9sbChib29sIGZvdW5kLCBjb25zdCBTdHJpbmcmLCBGaW5k T3B0aW9ucywgdW5zaWduZWQgbWF4TWF0Y2hDb3VudCk7CisKICAgICBXZWJQYWdlKiBtX3dlYlBh Z2U7CiAgICAgUGFnZU92ZXJsYXkqIG1fZmluZFBhZ2VPdmVybGF5OwogCg==