85208 2012-04-30 10:46:24 -0700 REGRESSION(r115594): Caused 10 plus tests crash on Win/Linux debug (Requested by zhenyao on #webkit). 2017-07-18 08:27:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 84908 1 webkit.review.bot webkit.review.bot haraken oldest_to_newest 612740 0 webkit.review.bot 2012-04-30 10:46:24 -0700 http://trac.webkit.org/changeset/115594 broke the build: Caused 10 plus tests crash on Win/Linux debug (Requested by zhenyao on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 612741 1 139474 webkit.review.bot 2012-04-30 10:47:01 -0700 Created attachment 139474 ROLLOUT of r115594 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 612748 2 ojan 2012-04-30 10:51:09 -0700 Can you list which tests it caused to crash? Or point to the build where it failed? We expect this assert to get hit since it points out a known bug. So, the right thing is probably to just mark the tests as crashing in debug. 612754 3 haraken 2012-04-30 10:55:24 -0700 (In reply to comment #2) > Can you list which tests it caused to crash? Or point to the build where it failed? We expect this assert to get hit since it points out a known bug. So, the right thing is probably to just mark the tests as crashing in debug. Yes! We want to know it! For the time being, I landed a patch to remove ASSERT() from the code to avoid the crashes. 139474 2012-04-30 10:47:01 -0700 2012-04-30 10:54:41 -0700 ROLLOUT of r115594 bug-85208-20120430175042.patch text/plain 3170 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWExMDZlZjcyZTk2NzBh YzliZTYwZTI4ZDIyNjMyNmM4YmQ0Y2U4OC4uNWI1MjFjOGM3ODk2OWI0NGJmMDNiNDg3NTI2MzFi OWFlM2YwOGEwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTMwICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTE1NTk0LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMTU1OTQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg1MjA4CisKKyAgICAgICAgQ2F1c2VkIDEwIHBsdXMgdGVzdHMgY3Jhc2ggb24g V2luL0xpbnV4IGRlYnVnIChSZXF1ZXN0ZWQgYnkKKyAgICAgICAgemhlbnlhbyBvbiAjd2Via2l0 KS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6VjhMYXp5RXZlbnRMaXN0ZW5lcjo6VjhMYXp5RXZlbnRMaXN0ZW5lcik6 CisgICAgICAgIChXZWJDb3JlOjpWOExhenlFdmVudExpc3RlbmVyOjpwcmVwYXJlTGlzdGVuZXJP YmplY3QpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuaDoKKyAg ICAgICAgKFY4TGF6eUV2ZW50TGlzdGVuZXIpOgorCiAyMDEyLTA0LTMwICBUb21teSBXaWRlbmZs eWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQSTogQ2hh bmdlIExvY2FsTWVkaWFTdHJlYW06OnN0b3AgdG8gYmUgc3luY2hyb25vdXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKaW5kZXggOTY0 NjA0NmJmNTdkYmEwNWEwOTQ3ZTdkZmY3MjBmYjg5NjM5NGQ1Ni4uZTYzNDYxM2I2NTMzMDQ0NDFm ODk5ZTMyNGUyM2M1NDI1NGM0NTg2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKQEAgLTU5LDkgKzU5LDYgQEAgVjhMYXp5RXZl bnRMaXN0ZW5lcjo6VjhMYXp5RXZlbnRMaXN0ZW5lcihjb25zdCBBdG9taWNTdHJpbmcmIGZ1bmN0 aW9uTmFtZSwgY29uc3QKICAgICAsIG1fc291cmNlVVJMKHNvdXJjZVVSTCkKICAgICAsIG1fbm9k ZShub2RlKQogICAgICwgbV9wb3NpdGlvbihwb3NpdGlvbikKLSNpZm5kZWYgTkRFQlVHCi0gICAg LCBtX3ByZXBhcmVkKGZhbHNlKQotI2VuZGlmCiB7CiB9CiAKQEAgLTIxOSwyMCArMjE2LDExIEBA IHZvaWQgVjhMYXp5RXZlbnRMaXN0ZW5lcjo6cHJlcGFyZUxpc3RlbmVyT2JqZWN0KFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQpCiAKICAgICB3cmFwcGVkRnVuY3Rpb24tPlNldE5hbWUo djg6OlN0cmluZzo6TmV3KGZyb21XZWJDb3JlU3RyaW5nKG1fZnVuY3Rpb25OYW1lKSwgbV9mdW5j dGlvbk5hbWUubGVuZ3RoKCkpKTsKIAotICAgIC8vIEZJWE1FOiBSZW1vdmUgbV9wcmVwYXJlZCBh bmQgdGhlIGZvbGxvd2luZyBjb21tZW50LW91dHMuCi0gICAgLy8gU2VlIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTE1MiBmb3IgbW9yZSBkZXRhaWxzLgotI2lmbmRl ZiBOREVCVUcKLSAgICAvLyBDaGVja3MgaWYgdGhlIHNlY29uZCBwYXJzaW5nIG5ldmVyIGhhcHBl bnMuIEN1cnJlbnRseSB0aGUgc2Vjb25kIHBhcnNpbmcgY2FuIGhhcHBlbgotICAgIC8vIGluIGEg cG9wdXAgd2luZG93LgotICAgIEFTU0VSVCghbV9wcmVwYXJlZCk7Ci0gICAgbV9wcmVwYXJlZCA9 IHRydWU7Ci0jZW5kaWYKLSAgICAvLyBDb21tZW50cyBvdXQgdGhlIGZvbGxvd2luZyBjb2RlIHNp bmNlIHRoZSBzZWNvbmQgcGFyc2luZyBjYW4gaGFwcGVuLgotICAgIC8vIC8vIFNpbmNlIHdlIG9u bHkgcGFyc2Ugb25jZSwgdGhlcmUncyBubyBuZWVkIHRvIGtlZXAgZGF0YSB1c2VkIGZvciBwYXJz aW5nIGFyb3VuZCBhbnltb3JlLgotICAgIC8vIG1fZnVuY3Rpb25OYW1lID0gU3RyaW5nKCk7Ci0g ICAgLy8gbV9jb2RlID0gU3RyaW5nKCk7Ci0gICAgLy8gbV9ldmVudFBhcmFtZXRlck5hbWUgPSBT dHJpbmcoKTsKLSAgICAvLyBtX3NvdXJjZVVSTCA9IFN0cmluZygpOworICAgIC8vIFNpbmNlIHdl IG9ubHkgcGFyc2Ugb25jZSwgdGhlcmUncyBubyBuZWVkIHRvIGtlZXAgZGF0YSB1c2VkIGZvciBw YXJzaW5nIGFyb3VuZCBhbnltb3JlLgorICAgIG1fZnVuY3Rpb25OYW1lID0gU3RyaW5nKCk7Cisg ICAgbV9jb2RlID0gU3RyaW5nKCk7CisgICAgbV9ldmVudFBhcmFtZXRlck5hbWUgPSBTdHJpbmco KTsKKyAgICBtX3NvdXJjZVVSTCA9IFN0cmluZygpOwogCiAgICAgc2V0TGlzdGVuZXJPYmplY3Qo d3JhcHBlZEZ1bmN0aW9uKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 TGF6eUV2ZW50TGlzdGVuZXIuaAppbmRleCBjMDdjMjM3MWJhNDIyMzllMTFkOTUxMmEzM2I3Zjli ZTVlOTFjMTAxLi4zMzVlMjFkNzMyN2NkZTNlN2I3NDQ1NWM0MmRhNzRmZGNiMmJlMWYxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOExhenlFdmVudExpc3RlbmVyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5oCkBA IC03NSw5ICs3NSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgU3RyaW5nIG1fc291 cmNlVVJMOwogICAgICAgICBOb2RlKiBtX25vZGU7CiAgICAgICAgIFRleHRQb3NpdGlvbiBtX3Bv c2l0aW9uOwotI2lmbmRlZiBOREVCVUcKLSAgICAgICAgYm9vbCBtX3ByZXBhcmVkOwotI2VuZGlm CiAgICAgfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=