85201 2012-04-30 08:39:38 -0700 [chromium] Add WebDocument::referrerPolicy() which wraps the same method on Document 2012-05-02 14:39:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 612660 0 jochen 2012-04-30 08:39:38 -0700 [chromium] Check whether a frame with a document exists before querying its referrer policy 612661 1 139456 jochen 2012-04-30 08:39:54 -0700 Created attachment 139456 Patch 614392 2 139456 fishd 2012-05-02 10:07:55 -0700 Comment on attachment 139456 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139456&action=review > Source/WebKit/chromium/src/WebFrameImpl.cpp:601 > + if (m_frame && m_frame->document()) This doesn't seem quite right. WebFrameImpl methods normally assume that m_frame is non-null. See all the other methods that just use m_frame without null checking it. We similarly have methods that assume m_frame->document() will be non-null, although many functions do null test document(). I think the right solution is actually to move referrerPolicy() to WebDocument since it is really a property of the Document instead of the Frame. 614568 3 139863 jochen 2012-05-02 12:59:55 -0700 Created attachment 139863 Patch 614570 4 webkit.review.bot 2012-05-02 13:02:09 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 614678 5 139863 webkit.review.bot 2012-05-02 14:39:24 -0700 Comment on attachment 139863 Patch Clearing flags on attachment: 139863 Committed r115889: <http://trac.webkit.org/changeset/115889> 614679 6 webkit.review.bot 2012-05-02 14:39:29 -0700 All reviewed patches have been landed. Closing bug. 139456 2012-04-30 08:39:54 -0700 2012-05-02 12:59:46 -0700 Patch bug-85201-20120430173952.patch text/plain 1491 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGUyZmJiYjUyNmNiOTgyM2ZhZWFjOWRlODI4YWNhM2M3ZmZhMzMyN2EuLjU2ZjAzNGVhZjYwMDIy YWEzNWRhZWI1Y2IxYjNmNmU2MTIxMmIwN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDQtMzAgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBDaGVjayB3aGV0aGVyIGEgZnJhbWUgd2l0 aCBhIGRvY3VtZW50IGV4aXN0cyBiZWZvcmUgcXVlcnlpbmcgaXRzIHJlZmVycmVyIHBvbGljeQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUyMDEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9XZWJG cmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OnJlZmVycmVyUG9s aWN5KToKKwogMjAxMi0wNC0yNSAgSWFuIFZvbGxpY2sgIDx2b2xsaWNrQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbY2hyb21pdW1dIERvIG5vdCBjbG9iYmVyIHN5bmNocm9uaXplZCBzdGFydCB0 aW1lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1w bC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCmluZGV4 IGMyNmZmOGM5YTBlNmI2ODFkYTc3ZDE3NzFhZTMzMzNhMTZjOGFhNWEuLmQ3NmVkNTZmYTUyMTY4 NmEzYzAxNTNkNzhhYmJkOGE4ZjQ1OGNlYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcApAQCAtNTk4LDcgKzU5OCw5IEBAIFdlYlZlY3RvcjxXZWJJY29u VVJMPiBXZWJGcmFtZUltcGw6Omljb25VUkxzKGludCBpY29uVHlwZXMpIGNvbnN0CiAKIFdlYlJl ZmVycmVyUG9saWN5IFdlYkZyYW1lSW1wbDo6cmVmZXJyZXJQb2xpY3koKSBjb25zdAogewotICAg IHJldHVybiBzdGF0aWNfY2FzdDxXZWJSZWZlcnJlclBvbGljeT4obV9mcmFtZS0+ZG9jdW1lbnQo KS0+cmVmZXJyZXJQb2xpY3koKSk7CisgICAgaWYgKG1fZnJhbWUgJiYgbV9mcmFtZS0+ZG9jdW1l bnQoKSkKKyAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFdlYlJlZmVycmVyUG9saWN5PihtX2Zy YW1lLT5kb2N1bWVudCgpLT5yZWZlcnJlclBvbGljeSgpKTsKKyAgICByZXR1cm4gV2ViUmVmZXJy ZXJQb2xpY3lEZWZhdWx0OwogfQogCiBXZWJTaXplIFdlYkZyYW1lSW1wbDo6c2Nyb2xsT2Zmc2V0 KCkgY29uc3QK 139863 2012-05-02 12:59:55 -0700 2012-05-02 14:39:24 -0700 Patch bug-85201-20120502215954.patch text/plain 2554 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDEyNGZiMDhhNDcwZjEwZjc2NmY5MGUxYTM4Nzg2ZjdjNGM3N2Q4MTkuLjJjNDk4YTg3Y2M1ZDc4 YmYzNWY2YWUxM2Q4M2E2YzRkNjc2OGFjYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDUtMDIgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgV2ViRG9jdW1lbnQ6OnJlZmVycmVy UG9saWN5KCkgd2hpY2ggd3JhcHMgdGhlIHNhbWUgbWV0aG9kIG9uIERvY3VtZW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTIwMQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVtYmVkZGVycyBzaG91bGQg dXNlIHdlYkZyYW1lLT5kb2N1bWVudCgpLT5yZWZlcnJlclBvbGljeSgpIGluc3RlYWQgb2Ygd2Vi RnJhbWUtPnJlZmVycmVyUG9saWN5KCkuIFRoZSBsYXR0ZXIgd2lsbCBiZSByZW1vdmVkIHNvb24u CisKKyAgICAgICAgKiBwdWJsaWMvV2ViRG9jdW1lbnQuaDoKKyAgICAgICAgKFdlYkRvY3VtZW50 KToKKyAgICAgICAgKiBzcmMvV2ViRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJE b2N1bWVudDo6cmVmZXJyZXJQb2xpY3kpOgorICAgICAgICAoV2ViS2l0KToKKwogMjAxMi0wNS0w MiAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBUeXBlRXJyb3I6IENhbm5vdCBjYWxsIG1ldGhvZCAnY3JlYXRlTGl2ZUxvY2F0 aW9uJyBvZiB1bmRlZmluZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYkRvY3VtZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1 bWVudC5oCmluZGV4IDY3MjVlNzllMWQ3ZThlMWJiMjY4OTg2YTZhNWQ1MzViNGRkZTc4NjMuLjZj MGRmMzFiY2JjNjE0ZmFiMjJkNjNjNGViY2IyYWU1NmMxMTBiODQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaApAQCAtMzMsNiArMzMsNyBAQAogCiAjaW5j bHVkZSAiV2ViTm9kZS5oIgogI2luY2x1ZGUgIldlYlNlY3VyaXR5T3JpZ2luLmgiCisjaW5jbHVk ZSAicGxhdGZvcm0vV2ViUmVmZXJyZXJQb2xpY3kuaCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJW ZWN0b3IuaCIKIAogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgpAQCAtMTAxLDYgKzEwMiw3IEBA IHB1YmxpYzoKICAgICBXRUJLSVRfRVhQT1JUIHZvaWQgY2FuY2VsRnVsbFNjcmVlbigpOwogICAg IFdFQktJVF9FWFBPUlQgV2ViRWxlbWVudCBmdWxsU2NyZWVuRWxlbWVudCgpIGNvbnN0OwogICAg IFdFQktJVF9FWFBPUlQgV2ViRE9NRXZlbnQgY3JlYXRlRXZlbnQoY29uc3QgV2ViU3RyaW5nJiBl dmVudFR5cGUpOworICAgIFdFQktJVF9FWFBPUlQgV2ViUmVmZXJyZXJQb2xpY3kgcmVmZXJyZXJQ b2xpY3koKSBjb25zdDsKIAogICAgIC8vIEFjY2Vzc2liaWxpdHkgc3VwcG9ydC4gVGhlc2UgbWV0 aG9kcyBzaG91bGQgb25seSBiZSBjYWxsZWQgb24gdGhlCiAgICAgLy8gdG9wLWxldmVsIGRvY3Vt ZW50LCBiZWNhdXNlIG9uZSBhY2Nlc3NpYmlsaXR5IGNhY2hlIHNwYW5zIGFsbCBvZgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCmluZGV4IGIyZTViNDgyYWUyMzFm ZjVhNmFkMzI0ZTA5OGNjOWViNmU3OTY1OTcuLjExNjM5NTY2YzY3MDE1ZmVlODAxYWZkZTgzZjYy Y2QyYzFmNWE4ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRv Y3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEb2N1bWVudC5j cHAKQEAgLTIwOSw2ICsyMDksMTEgQEAgV2ViRE9NRXZlbnQgV2ViRG9jdW1lbnQ6OmNyZWF0ZUV2 ZW50KGNvbnN0IFdlYlN0cmluZyYgZXZlbnRUeXBlKQogICAgIHJldHVybiBldmVudDsKIH0KIAor V2ViUmVmZXJyZXJQb2xpY3kgV2ViRG9jdW1lbnQ6OnJlZmVycmVyUG9saWN5KCkgY29uc3QKK3sK KyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8V2ViUmVmZXJyZXJQb2xpY3k+KGNvbnN0VW53cmFwPERv Y3VtZW50PigpLT5yZWZlcnJlclBvbGljeSgpKTsKK30KKwogV2ViQWNjZXNzaWJpbGl0eU9iamVj dCBXZWJEb2N1bWVudDo6YWNjZXNzaWJpbGl0eU9iamVjdCgpIGNvbnN0CiB7CiAgICAgY29uc3Qg RG9jdW1lbnQqIGRvY3VtZW50ID0gY29uc3RVbndyYXA8RG9jdW1lbnQ+KCk7Cg==