85174 2012-04-30 03:35:23 -0700 Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests 2013-04-09 17:06:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 88526 1 pfeldman kinuko abarth alecflett dimich eric fishd haraken japhet jianli jochen jsbell kinuko levin li.yin mjs sam webkit.review.bot oldest_to_newest 612529 0 pfeldman 2012-04-30 03:35:23 -0700 fast/files/blob-constructor.html = CRASH fast/dom/HTMLAnchorElement/anchor-download-unset.html = TIMEOUT fast/filesystem/file-writer-gc-blob.html = TIMEOUT fast/filesystem/workers/file-writer-gc-blob.html = TEXT fast/filesystem/workers/file-writer-sync-truncate-extend.html http/tests/security/filesystem-iframe-from-remote.html = TEXT storage/indexeddb/noblobs.html = TEXT 612530 1 pfeldman 2012-04-30 03:54:55 -0700 http://trac.webkit.org/changeset/115582 https://bugs.webkit.org/show_bug.cgi?id=84555 612851 2 eric 2012-04-30 12:09:56 -0700 Why not CC the authors of that change? 623224 3 jsbell 2012-05-14 12:42:28 -0700 FYI, alecflett@ updated the storage/indexeddb/noblobs.html test in r116337 to use the new Blob() constructor, but didn't remove the expectations line. I'll do so now. 640271 4 li.yin 2012-06-03 19:38:08 -0700 The root cause of fast/files/blob-constructor.html = CRASH is http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp#L129 EXCEPTION_BLOCK(String, stringValue, toWebCoreString(item->ToString())); should be EXCEPTION_BLOCK(String, stringValue, toWebCoreString(item)); 640274 5 li.yin 2012-06-03 19:42:21 -0700 In the fast/files/script-tests/blob-constructor.js var throwingObj = { toString: function() { throw "Error"; } }; shouldThrow("new Blob([throwingObj])", "'Error'"); results in chromium DumpRenderTree crash. 640278 6 li.yin 2012-06-03 19:52:36 -0700 Fixing the blob-constructor.html crash is only the first step to remove it from chromium test_expectations.txt. There are some gaps with JS binding. 1. shouldThrow("new Blob([], {endings:throwingObj})", "'Error'"); 2. shouldThrow("new Blob([], {endings:throwingObj1, type:throwingObj2})", "'Error 1'"); 3. shouldThrow("new Blob([], {type:throwingObj2, endings:throwingObj1})", "'Error 1'"); 4. shouldBe("window.Blob.length", "2"); It seems that Dictionary willn't throw exception. Both of tryCatchEndings.HasCaught() and tryCatchType.HasCaught() return 0. 640301 7 kinuko 2012-06-03 21:47:19 -0700 > Fixing the blob-constructor.html crash is only the first step to remove it from chromium test_expectations.txt. > There are some gaps with JS binding. > 1. shouldThrow("new Blob([], {endings:throwingObj})", "'Error'"); > 2. shouldThrow("new Blob([], {endings:throwingObj1, type:throwingObj2})", "'Error 1'"); > 3. shouldThrow("new Blob([], {type:throwingObj2, endings:throwingObj1})", "'Error 1'"); > 4. shouldBe("window.Blob.length", "2"); > > It seems that Dictionary willn't throw exception. > Both of tryCatchEndings.HasCaught() and tryCatchType.HasCaught() return 0. Thanks for digging this, I'd like to take a look at the binding part... 640436 8 145548 kinuko 2012-06-04 02:53:38 -0700 Created attachment 145548 Patch 640453 9 145548 haraken 2012-06-04 03:48:10 -0700 Comment on attachment 145548 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145548&action=review > Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp:119 > - String originArg = v8ValueToWebCoreString(args[4]); > - String lastEventIdArg = v8ValueToWebCoreString(args[5]); > + EXCEPTION_BLOCK(String, originArg, v8ValueToWebCoreString(args[4])); > + EXCEPTION_BLOCK(String, lastEventIdArg, v8ValueToWebCoreString(args[5])); It seems that this is not the only place where we need to fix. For example, toWebCoreStringWithNullCheck() is used in V8DOMformDataCustom.cpp without being surrounded by EXCEPTION_BLOCK. Anyone: BTW, isn't there any way to nest TryCatches? As far as I see v8.h and api.cc, it seems that we can register only one TryCatch handler per Isolate, which means that TryCatches are not nest-able. But in that case what is TryCatch::ReThrow() for? 640552 10 kinuko 2012-06-04 07:10:10 -0700 Ok it looks at least EWS test passes with this approach. (In reply to comment #9) > > Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp:119 > > - String originArg = v8ValueToWebCoreString(args[4]); > > - String lastEventIdArg = v8ValueToWebCoreString(args[5]); > > + EXCEPTION_BLOCK(String, originArg, v8ValueToWebCoreString(args[4])); > > + EXCEPTION_BLOCK(String, lastEventIdArg, v8ValueToWebCoreString(args[5])); > > It seems that this is not the only place where we need to fix. For example, toWebCoreStringWithNullCheck() is used in V8DOMformDataCustom.cpp without being surrounded by EXCEPTION_BLOCK. Thanks, I'll wait a bit more to see if anyone has better idea about nested TryCatch handling before converting all those callsites. > Anyone: BTW, isn't there any way to nest TryCatches? As far as I see v8.h and api.cc, it seems that we can register only one TryCatch handler per Isolate, which means that TryCatches are not nest-able. But in that case what is TryCatch::ReThrow() for? As he wrote v8::TryCatch doesn't look nestable to me, but I want to make sure if this assumption is correct and if it's intended behavior. Does anyone know? 641215 11 145702 kinuko 2012-06-04 23:32:59 -0700 Created attachment 145702 Crash Fix Fixing CRASH bug first h. (Thanks to Li Yin) 641238 12 kinuko 2012-06-05 00:16:53 -0700 (In reply to comment #11) > Created an attachment (id=145702) [details] > Crash Fix > > Fixing CRASH bug first. (Thanks to Li Yin) The new patch only fixes the CRASH part to start with. Can someone take a look at it? (I'll continue fixing the Text mismatches, but the crash one looks worst) 641276 13 145702 haraken 2012-06-05 01:14:13 -0700 Comment on attachment 145702 Crash Fix View in context: https://bugs.webkit.org/attachment.cgi?id=145702&action=review OK, let's land this patch first, and then investigate the nested TryCatch issues. > Source/WebCore/ChangeLog:8 > + Fixes CRASH error for string arguments. (Still has TEXT mismatch problems) Would you elaborate the explanation? 641320 14 kinuko 2012-06-05 01:53:44 -0700 (In reply to comment #13) > (From update of attachment 145702 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145702&action=review > > OK, let's land this patch first, and then investigate the nested TryCatch issues. > > > Source/WebCore/ChangeLog:8 > > + Fixes CRASH error for string arguments. (Still has TEXT mismatch problems) > > Would you elaborate the explanation? Thanks. Will be adding description like below: + This fixes a crash problem which could happen when the constructor is + given an array which contains String-type item(s). + There're still some Text mismatches between v8 results and + JSC results, most of them are v8 not throwing exception + when it is given an object whose toString() method throws + exception. (The issue will be addresse in a separate patch.) 641321 15 haraken 2012-06-05 01:54:45 -0700 (In reply to comment #14) > Thanks. Will be adding description like below: > > + This fixes a crash problem which could happen when the constructor is > + given an array which contains String-type item(s). > + There're still some Text mismatches between v8 results and > + JSC results, most of them are v8 not throwing exception > + when it is given an object whose toString() method throws > + exception. (The issue will be addresse in a separate patch.) Sounds good! 641389 16 kinuko 2012-06-05 03:57:21 -0700 Committed r119479: <http://trac.webkit.org/changeset/119479> 641438 17 kinuko 2012-06-05 05:01:55 -0700 (More patches to come) 641721 18 kinuko 2012-06-05 10:59:44 -0700 v8::TryCatch issue: http://code.google.com/p/v8/issues/detail?id=2166 650223 19 haraken 2012-06-15 08:45:04 -0700 (In reply to comment #18) > v8::TryCatch issue: http://code.google.com/p/v8/issues/detail?id=2166 It is now fixed! 673647 20 haraken 2012-07-19 10:33:47 -0700 (In reply to comment #19) > (In reply to comment #18) > > v8::TryCatch issue: http://code.google.com/p/v8/issues/detail?id=2166 > > It is now fixed! Unfortunately it is now reverted. I discussed the TryCatch bug with the V8 team, and it will take more time to fix it. (The original fix worked fine if all the nested TryCatch objects exist on V8 stack, but didn't work if any TryCatch object exists on heap.) 872409 21 schenney 2013-04-09 17:06:07 -0700 Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests. 145548 2012-06-04 02:53:38 -0700 2012-06-04 23:32:53 -0700 Patch bug-85174-20120604185337.patch text/plain 8413 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjFkM2NmMTY1OTYyM2Mw Y2I5ODhkMmY4NGQxNzkyNmM1MDhlMWRjYy4uNTlhNzEyMGQzNGJlMTViOGYyZmQyMTY3MDJlZmI5 NTRiYjk2NGZiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA2LTA0ICBLaW51 a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaHJvbWl1bSB0ZXN0 czogIkFkZCBzdXBwb3J0IGZvciB0aGUgQmxvYiBjb25zdHJ1Y3RvciIgW3IxMTU1ODJdIHJlZ3Jl c3NlZCBibG9iIGxheW91dCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODUxNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDaGFuZ2luZyB2OFZhbHVlVG9XZWJDb3JlU3RyaW5nIHRvIHRocm93IGFu IGV4Y2VwdGlvbiB3aGVuCisgICAgICAgIGltcGwtPnRvU3RyaW5nKCkgdGhyb3dzIG9uZSBzbyB0 aGF0IHdlIGNhbiBjYXRjaCB0aGUgZXhjZXB0aW9uIGF0CisgICAgICAgIHRoZSB2ZXJ5IG91dGVy IGxheWVyIChpLmUuIGluIHRoZSBiaW5kaW5nIGNvZGUpIHJhdGhlciB0aGFuIGluIGFuCisgICAg ICAgIGludGVybmFsIHV0aWxpdHkgcm91dGluZS4KKworICAgICAgICBUZXN0OiBmYXN0L2ZpbGVz L2Jsb2ItY29uc3RydWN0b3IuaHRtbAorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5n LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnY4Tm9uU3RyaW5nVmFsdWVUb1dlYkNvcmVTdHJpbmcp OgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5oOgorICAgICAgICAoV2ViQ29yZSk6 CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4QmxvYkN1c3RvbS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpWOEJsb2I6OmNvbnN0cnVjdG9yQ2FsbGJhY2spOgorICAgICAgICAqIGJpbmRp bmdzL3Y4L2N1c3RvbS9WOE1lc3NhZ2VFdmVudEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpWOE1lc3NhZ2VFdmVudDo6aW5pdE1lc3NhZ2VFdmVudENhbGxiYWNrKToKKwogMjAxMi0wNS0z MCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExODk4Ni4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEJpbmRpbmcuY3BwCmluZGV4IDZlMDM2YWNlN2IyM2FlNmNmN2Q4NWUyMjNkYjc3OTVkZTY4 NmYzODYuLjI0MDllYTU3ZGYwYWMxZDBiZGY2OWYzODg0YjE2ZTNlMjgyYmU2YzQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcApAQCAtNDAxLDIwICs0MDEsMTMgQEAg U3RyaW5nIHY4Tm9uU3RyaW5nVmFsdWVUb1dlYkNvcmVTdHJpbmcodjg6OkhhbmRsZTx2ODo6VmFs dWU+IG9iamVjdCkKICAgICBpZiAob2JqZWN0LT5Jc0ludDMyKCkpCiAgICAgICAgIHJldHVybiBp bnQzMlRvV2ViQ29yZVN0cmluZyhvYmplY3QtPkludDMyVmFsdWUoKSk7CiAKLSAgICB2ODo6VHJ5 Q2F0Y2ggYmxvY2s7CiAgICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiB2OFN0cmluZyA9IG9iamVj dC0+VG9TdHJpbmcoKTsKICAgICAvLyBIYW5kbGUgdGhlIGNhc2Ugd2hlcmUgYW4gZXhjZXB0aW9u IGlzIHRocm93biBhcyBwYXJ0IG9mIGludm9raW5nIHRvU3RyaW5nIG9uIHRoZSBvYmplY3QuCi0g ICAgaWYgKGJsb2NrLkhhc0NhdWdodCgpKSB7Ci0gICAgICAgIHRocm93RXJyb3IoYmxvY2suRXhj ZXB0aW9uKCkpOwotICAgICAgICByZXR1cm4gU3RyaW5nSW1wbDo6ZW1wdHkoKTsKLSAgICB9Ci0g ICAgLy8gVGhpcyBwYXRoIGlzIHVuZXhwZWN0ZWQuICBIb3dldmVyIHRoZXJlIGlzIGh5cG90aGVz aXMgdGhhdCBpdAotICAgIC8vIG1pZ2h0IGJlIGNvbWJpbmF0aW9uIG9mIHY4IGFuZCB2OCBiaW5k aW5ncyBidWdzLiAgRm9yIG5vdwotICAgIC8vIGp1c3QgYmFpbG91dCBhcyB3ZSdsbCBjcmFzaCBp ZiBhdHRlbXB0IHRvIGNvbnZlcnQgZW1wdHkgaGFuZGxlIGludG8gYSBzdHJpbmcuCi0gICAgaWYg KHY4U3RyaW5nLklzRW1wdHkoKSkgewotICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKwor ICAgIC8vIENoZWNrIGZvciBlbXB0eSBoYW5kbGVzIHRvIGhhbmRsZSB0aGUgY2FzZSB3aGVyZSBh biBleGNlcHRpb24gaXMgdGhyb3duCisgICAgLy8gYXMgcGFydCBvZiBpbnZva2luZyB0b1N0cmlu ZyBvbiB0aGUgb2JqZWN0LgorICAgIGlmICh2OFN0cmluZy5Jc0VtcHR5KCkpCiAgICAgICAgIHJl dHVybiBTdHJpbmdJbXBsOjplbXB0eSgpOwotICAgIH0KICAgICByZXR1cm4gdjhTdHJpbmdUb1dl YkNvcmVTdHJpbmc8U3RyaW5nPih2OFN0cmluZywgRG9Ob3RFeHRlcm5hbGl6ZSk7CiB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKaW5kZXggM2YzNDI0OWI0ZTA2NzExNGMx NTNiYjUyZjdmZTI4ZDRkNmY3NjJhZS4uYTZhMTliZTBjMGJjYWRiYzVmNmY5ZWQ2YzgwZDc4ZjUw NWJiZjRiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5n LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTI1OSw2 ICsyNTksOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgLy8gQ29udmVydCB2OCB0eXBlcyB0 byBhIFdURjo6U3RyaW5nLiBJZiB0aGUgVjggc3RyaW5nIGlzIG5vdCBhbHJlYWR5CiAgICAgLy8g YW4gZXh0ZXJuYWwgc3RyaW5nIHRoZW4gaXQgaXMgdHJhbnNmb3JtZWQgaW50byBhbiBleHRlcm5h bCBzdHJpbmcgYXQgdGhpcwogICAgIC8vIHBvaW50IHRvIGF2b2lkIHJlcGVhdGVkIGNvbnZlcnNp b25zLgorICAgIC8vIE5vdGUgdGhhdCB0aGlzIGNvdWxkIHRocm93IGFuIGV4Y2VwdGlvbiBpZiB0 aGUgaW1wbGVtZW50YXRpb24ncworICAgIC8vIHRvU3RyaW5nKCkgdGhyb3dzIGl0LgogICAgIGlu bGluZSBTdHJpbmcgdjhTdHJpbmdUb1dlYkNvcmVTdHJpbmcodjg6OkhhbmRsZTx2ODo6U3RyaW5n PiB2OFN0cmluZykKICAgICB7CiAgICAgICAgIHJldHVybiB2OFN0cmluZ1RvV2ViQ29yZVN0cmlu ZzxTdHJpbmc+KHY4U3RyaW5nLCBFeHRlcm5hbGl6ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhCbG9iQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEJsb2JDdXN0b20uY3BwCmluZGV4IGM5NjliMDMzYWU1YTRl Zjg0Yjc0MDNhNDA1YjIxZjUxZDdjNjA1ODcuLjE3NTY2YzgxYjkxOTliNTRhODA1ZjljZTliYmM3 NjE3YmY1OTdhZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOEJsb2JDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOEJsb2JDdXN0b20uY3BwCkBAIC0xMjYsNyArMTI2LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFs dWU+IFY4QmxvYjo6Y29uc3RydWN0b3JDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdz KQogICAgICAgICAgICAgQVNTRVJUKGJsb2IpOwogICAgICAgICAgICAgYmxvYkJ1aWxkZXItPmFw cGVuZChibG9iKTsKICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIEVYQ0VQVElPTl9CTE9D SyhTdHJpbmcsIHN0cmluZ1ZhbHVlLCB0b1dlYkNvcmVTdHJpbmcoaXRlbS0+VG9TdHJpbmcoKSkp OworICAgICAgICAgICAgRVhDRVBUSU9OX0JMT0NLKFN0cmluZywgc3RyaW5nVmFsdWUsIHRvV2Vi Q29yZVN0cmluZyhpdGVtKSk7CiAgICAgICAgICAgICBibG9iQnVpbGRlci0+YXBwZW5kKHN0cmlu Z1ZhbHVlLCBlbmRpbmdzLCBBU1NFUlRfTk9fRVhDRVBUSU9OKTsKICAgICAgICAgfQogICAgIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE1lc3NhZ2VF dmVudEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhNZXNz YWdlRXZlbnRDdXN0b20uY3BwCmluZGV4IDc3YmEzZjI2NmJhZGM3M2I1MmZhMGY4OTRiODcwMWRk ZjhlZDM0OTAuLjQ3YTMzMzQxMzNmYmJkYWM3MTczYzgxODQ1NTk3OTQ2MDIwY2ZjNmMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE1lc3NhZ2VFdmVudEN1 c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TWVzc2Fn ZUV2ZW50Q3VzdG9tLmNwcApAQCAtMzYsNiArMzYsNyBAQAogCiAjaW5jbHVkZSAiVjhBcnJheUJ1 ZmZlci5oIgogI2luY2x1ZGUgIlY4QmluZGluZy5oIgorI2luY2x1ZGUgIlY4QmluZGluZ01hY3Jv cy5oIgogI2luY2x1ZGUgIlY4QmxvYi5oIgogI2luY2x1ZGUgIlY4RE9NV2luZG93LmgiCiAjaW5j bHVkZSAiVjhNZXNzYWdlUG9ydC5oIgpAQCAtMTE0LDggKzExNSw4IEBAIHY4OjpIYW5kbGU8djg6 OlZhbHVlPiBWOE1lc3NhZ2VFdmVudDo6aW5pdE1lc3NhZ2VFdmVudENhbGxiYWNrKGNvbnN0IHY4 OjpBcmd1bWVuCiAgICAgYm9vbCBjYW5CdWJibGVBcmcgPSBhcmdzWzFdLT5Cb29sZWFuVmFsdWUo KTsKICAgICBib29sIGNhbmNlbGFibGVBcmcgPSBhcmdzWzJdLT5Cb29sZWFuVmFsdWUoKTsKICAg ICBTY3JpcHRWYWx1ZSBkYXRhQXJnID0gU2NyaXB0VmFsdWUoYXJnc1szXSk7Ci0gICAgU3RyaW5n IG9yaWdpbkFyZyA9IHY4VmFsdWVUb1dlYkNvcmVTdHJpbmcoYXJnc1s0XSk7Ci0gICAgU3RyaW5n IGxhc3RFdmVudElkQXJnID0gdjhWYWx1ZVRvV2ViQ29yZVN0cmluZyhhcmdzWzVdKTsKKyAgICBF WENFUFRJT05fQkxPQ0soU3RyaW5nLCBvcmlnaW5BcmcsIHY4VmFsdWVUb1dlYkNvcmVTdHJpbmco YXJnc1s0XSkpOworICAgIEVYQ0VQVElPTl9CTE9DSyhTdHJpbmcsIGxhc3RFdmVudElkQXJnLCB2 OFZhbHVlVG9XZWJDb3JlU3RyaW5nKGFyZ3NbNV0pKTsKIAogICAgIERPTVdpbmRvdyogc291cmNl QXJnID0gMDsKICAgICBpZiAoYXJnc1s2XS0+SXNPYmplY3QoKSkgewpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGVlZDU0YmM4 Zjk3MDFlZmU4MGY0OTlmZDE3ZmI5ZGY1NjJjNjA3ODcuLjdiMWVlODA0NmRiMzE4YWEyNDZkYzEw ZjQ3MTY0MWEwMjU2NjA0MDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNi0wNCAgS2lu dWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2hyb21pdW0gdGVz dHM6ICJBZGQgc3VwcG9ydCBmb3IgdGhlIEJsb2IgY29uc3RydWN0b3IiIFtyMTE1NTgyXSByZWdy ZXNzZWQgYmxvYiBsYXlvdXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg1MTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVtb3ZpbmcgYmxvYi1jb25zdHJ1Y3Rvci5odG1sIGZyb20gdGVzdF9l eHBlY3RhdGlvbnMudHh0LgorICAgICAgICBBbHNvIHJlbW92ZXMgQmxvYi5sZW5ndGggPT0gMiB0 ZXN0IHNpbmNlIHRoZSBjb25zdHJ1Y3RvciBsZW5ndGggdGVzdHMKKyAgICAgICAgc2VlbSB0byBi ZSBnYXRoZXJlZCBpbiBhIGNlbnRyYWwgdGVzdDogZmFzdC9qcy9jb25zdHJ1Y3Rvci1sZW5ndGgu aHRtbC4KKworICAgICAgICAqIGZhc3QvZmlsZXMvYmxvYi1jb25zdHJ1Y3Rvci1leHBlY3RlZC50 eHQ6CisgICAgICAgICogZmFzdC9maWxlcy9zY3JpcHQtdGVzdHMvYmxvYi1jb25zdHJ1Y3Rvci5q czoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisK IDIwMTItMDUtMzAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTg5ODYuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2Jsb2ItY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvZmFzdC9maWxlcy9ibG9iLWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dAppbmRleCA0 NzBiNTkxNmNlNjEzZjlmMTM2ZTZhMTRiN2YyZDJiMWY5OTJjMDM5Li4xM2NhZmQ5NGQ5OTQyODNj MTZhYzA4NDVlNDQwNWMxNGNhOWZhOGQ5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zp bGVzL2Jsb2ItY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv ZmlsZXMvYmxvYi1jb25zdHJ1Y3Rvci1leHBlY3RlZC50eHQKQEAgLTQyLDcgKzQyLDYgQEAgUEFT UyAobmV3IEJsb2IoW10sIC9hYmMvKSkgaW5zdGFuY2VvZiB3aW5kb3cuQmxvYiBpcyB0cnVlCiBQ QVNTIChuZXcgQmxvYihbXSwgZnVuY3Rpb24gKCkge30pKSBpbnN0YW5jZW9mIHdpbmRvdy5CbG9i IGlzIHRydWUKIFBBU1MgKG5ldyBCbG9iKFtdLCB7dHlwZTondGV4dC9odG1sJ30pKS50eXBlIGlz ICd0ZXh0L2h0bWwnCiBQQVNTIChuZXcgQmxvYihbXSwge3R5cGU6J3RleHQvaHRtbCd9KSkuc2l6 ZSBpcyAwCi1QQVNTIHdpbmRvdy5CbG9iLmxlbmd0aCBpcyAyCiBQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZmlsZXMvc2NyaXB0LXRlc3RzL2Jsb2ItY29uc3RydWN0b3IuanMgYi9MYXlvdXRUZXN0cy9m YXN0L2ZpbGVzL3NjcmlwdC10ZXN0cy9ibG9iLWNvbnN0cnVjdG9yLmpzCmluZGV4IDE1NGJhMGZl ZjBmNzdhZjU1NTgyMDA0MWRkNjliYjIxOTcwMzU5ZDUuLmEzODNjYWQ3YmNmMDZhOTA1Yjg0NDhl OTdjZTU3YjM0MTZkNTdmNzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZmlsZXMvc2Ny aXB0LXRlc3RzL2Jsb2ItY29uc3RydWN0b3IuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxl cy9zY3JpcHQtdGVzdHMvYmxvYi1jb25zdHJ1Y3Rvci5qcwpAQCAtNjAsNiArNjAsMyBAQCBzaG91 bGRCZVRydWUoIihuZXcgQmxvYihbXSwgZnVuY3Rpb24gKCkge30pKSBpbnN0YW5jZW9mIHdpbmRv dy5CbG9iIik7CiAvLyBUZXN0IHRoYXQgdGhlIHR5cGUvc2l6ZSBpcyBjb3JyZWN0bHkgYWRkZWQg dG8gdGhlIEJsb2IKIHNob3VsZEJlKCIobmV3IEJsb2IoW10sIHt0eXBlOid0ZXh0L2h0bWwnfSkp LnR5cGUiLCAiJ3RleHQvaHRtbCciKTsKIHNob3VsZEJlKCIobmV3IEJsb2IoW10sIHt0eXBlOid0 ZXh0L2h0bWwnfSkpLnNpemUiLCAiMCIpOwotCi0vLyBPZGRzIGFuZCBlbmRzCi1zaG91bGRCZSgi d2luZG93LkJsb2IubGVuZ3RoIiwgIjIiKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCBlOWE3MDk4Mzk3MmYxMzdkNjY0 Y2Y1NmI1MTBkMTZmZmFmY2IzNDY2Li5iNjIzMDlkYTRjMDA4Zjk2YTAyOTU1YWFjYjNlYjYyNmI0 NGI5NTY5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4 cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9l eHBlY3RhdGlvbnMudHh0CkBAIC0zNjA5LDcgKzM2MDksNiBAQCBCVUdXSzg1MDkwIERFQlVHIFNM T1cgOiBmYXN0L2pzL2RmZy11aW50MTZhcnJheS5odG1sID0gUEFTUwogQlVHV0s4NTA5MCBERUJV RyBTTE9XIDogZmFzdC9qcy9kZmctdWludDhhcnJheS5odG1sID0gUEFTUwogQlVHV0s4NTEwNiBT TE9XIDogdGFibGVzL21vemlsbGEvb3RoZXIvc2xhc2hsb2dvLmh0bWwgPSBQQVNTCiAKLUJVR1dL ODUxNzQgOiBmYXN0L2ZpbGVzL2Jsb2ItY29uc3RydWN0b3IuaHRtbCA9IENSQVNICiBCVUdXSzg1 MTc0IDogZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWRvd25sb2FkLXVuc2V0Lmh0 bWwgPSBUSU1FT1VUCiBCVUdXSzg1MTc0IDogZmFzdC9maWxlc3lzdGVtL2ZpbGUtd3JpdGVyLWdj LWJsb2IuaHRtbCA9IFRJTUVPVVQKIEJVR1dLODUxNzQgOiBmYXN0L2ZpbGVzeXN0ZW0vd29ya2Vy cy9maWxlLXdyaXRlci1nYy1ibG9iLmh0bWwgPSBURVhUCg== 145702 2012-06-04 23:32:59 -0700 2012-06-05 01:14:13 -0700 Crash Fix bug-85174-20120605153258.patch text/plain 3173 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFiZjdjMmEyYTBjMTZj NTNjNTRhZjQ5NzYzNjkxMDJhODQyMTBlOS4uNjAxZTZlODVjNTM2ZTY4ODE4MGZlMTI1MjZkNWZj NzNmMTFmMzkwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTA0ICBLaW51 a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaHJvbWl1bSB0ZXN0 czogIkFkZCBzdXBwb3J0IGZvciB0aGUgQmxvYiBjb25zdHJ1Y3RvciIgW3IxMTU1ODJdIHJlZ3Jl c3NlZCBibG9iIGxheW91dCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODUxNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXhlcyBDUkFTSCBlcnJvciBmb3Igc3RyaW5nIGFyZ3VtZW50cy4gKFN0 aWxsIGhhcyBURVhUIG1pc21hdGNoIHByb2JsZW1zKQorCisgICAgICAgIFRlc3Q6IGZhc3QvZmls ZXMvYmxvYi1jb25zdHJ1Y3Rvci5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20v VjhCbG9iQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4QmxvYjo6Y29uc3RydWN0b3JD YWxsYmFjayk6CisKIDIwMTItMDYtMDMgIERvbWluaWMgQ29vbmV5ICA8ZG9taW5pY2NAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIEV2ZW50VGFyZ2V0LmlkbCBzaG91bGQgZ2VuZXJhdGUgSlMgYmlu ZGluZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEJs b2JDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4QmxvYkN1 c3RvbS5jcHAKaW5kZXggYzk2OWIwMzNhZTVhNGVmODRiNzQwM2E0MDViMjFmNTFkN2M2MDU4Ny4u MTc1NjZjODFiOTE5OWI1NGE4MDVmOWNlOWJiYzc2MTdiZjU5N2FlZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4QmxvYkN1c3RvbS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4QmxvYkN1c3RvbS5jcHAKQEAgLTEyNiw3 ICsxMjYsNyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhCbG9iOjpjb25zdHJ1Y3RvckNhbGxi YWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiAgICAgICAgICAgICBBU1NFUlQoYmxvYik7 CiAgICAgICAgICAgICBibG9iQnVpbGRlci0+YXBwZW5kKGJsb2IpOwogICAgICAgICB9IGVsc2Ug ewotICAgICAgICAgICAgRVhDRVBUSU9OX0JMT0NLKFN0cmluZywgc3RyaW5nVmFsdWUsIHRvV2Vi Q29yZVN0cmluZyhpdGVtLT5Ub1N0cmluZygpKSk7CisgICAgICAgICAgICBFWENFUFRJT05fQkxP Q0soU3RyaW5nLCBzdHJpbmdWYWx1ZSwgdG9XZWJDb3JlU3RyaW5nKGl0ZW0pKTsKICAgICAgICAg ICAgIGJsb2JCdWlsZGVyLT5hcHBlbmQoc3RyaW5nVmFsdWUsIGVuZGluZ3MsIEFTU0VSVF9OT19F WENFUFRJT04pOwogICAgICAgICB9CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGVjYTc3ZGI5Zjg4ZTVkYjUyNjky MmZlZGE1YTRjZDQ3YTQ5NmQwM2YuLjEwMTFhZGJkYmFmODUzM2IwMjA0MDVlOGM2NjZiMWU0MmNh YjRkOGMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wNi0wNCAgS2ludWtvIFlhc3VkYSAg PGtpbnVrb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2hyb21pdW0gdGVzdHM6ICJBZGQgc3Vw cG9ydCBmb3IgdGhlIEJsb2IgY29uc3RydWN0b3IiIFtyMTE1NTgyXSByZWdyZXNzZWQgYmxvYiBs YXlvdXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg1MTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ2hhbmdpbmcgYmxvYi1jb25zdHJ1Y3Rvci5odG1sIGxhYmVsIGZyb20gQ1JBU0ggdG8gVEVY VC4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIw MTItMDYtMDMgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCByZWJhc2xpbmUgZm9yIHRyYW5zZm9ybXMvM2QgdGVzdCBjYXNlcy4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDlj OWE1YTZkMzIwZjdiYzdlMGM3YjVkN2Q2MjE4MmY0MzFiZDU0YzMuLjg2OTAyZDA4OTg3YmJkMzBj MGJiMWM2NjlmYmQ0MTZlMTc3YmI2NjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vVGVzdEV4cGVjdGF0aW9ucwpAQCAtMzYxMiw3ICszNjEyLDcgQEAgQlVHV0s4NTA5MCBE RUJVRyBTTE9XIDogZmFzdC9qcy9kZmctdWludDE2YXJyYXkuaHRtbCA9IFBBU1MKIEJVR1dLODUw OTAgREVCVUcgU0xPVyA6IGZhc3QvanMvZGZnLXVpbnQ4YXJyYXkuaHRtbCA9IFBBU1MKIEJVR1dL ODUxMDYgU0xPVyA6IHRhYmxlcy9tb3ppbGxhL290aGVyL3NsYXNobG9nby5odG1sID0gUEFTUwog Ci1CVUdXSzg1MTc0IDogZmFzdC9maWxlcy9ibG9iLWNvbnN0cnVjdG9yLmh0bWwgPSBDUkFTSAor QlVHV0s4NTE3NCA6IGZhc3QvZmlsZXMvYmxvYi1jb25zdHJ1Y3Rvci5odG1sID0gVEVYVAogQlVH V0s4NTE3NCA6IGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1kb3dubG9hZC11bnNl dC5odG1sID0gVElNRU9VVAogQlVHV0s4NTE3NCA6IGZhc3QvZmlsZXN5c3RlbS9maWxlLXdyaXRl ci1nYy1ibG9iLmh0bWwgPSBUSU1FT1VUCiBCVUdXSzg1MTc0IDogZmFzdC9maWxlc3lzdGVtL3dv cmtlcnMvZmlsZS13cml0ZXItZ2MtYmxvYi5odG1sID0gVEVYVAo=