85172 2012-04-30 03:04:47 -0700 Remove custom bindings code in JSHTMLCollectionCustom.cpp for HTMLPropertiesCollection. 2012-04-30 11:23:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85216 1 arko arko abarth haraken ojan webkit.review.bot oldest_to_newest 612523 0 arko 2012-04-30 03:04:47 -0700 Remove custom bindings code in JSHTMLCollectionCustom.cpp for HTMLPropertiesCollection. We should use [JSGenerateToJSObject] in HTMLPropertiesCollection.idl, so that it can generate toJS() in JSHTMLPropertiesCollection.cpp automatically. 612525 1 139428 arko 2012-04-30 03:14:15 -0700 Created attachment 139428 Patch 612567 2 139428 haraken 2012-04-30 06:06:23 -0700 Comment on attachment 139428 Patch toJS() is generated into the generated code, and toJS() still exists in JSHTMLCollectionCustom.cpp. Won't it cause toJS() redefinition? 612568 3 arko 2012-04-30 06:17:22 -0700 (In reply to comment #2) > (From update of attachment 139428 [details]) > toJS() is generated into the generated code, and toJS() still exists in JSHTMLCollectionCustom.cpp. Won't it cause toJS() redefinition? We are adding [JSGenerateToJSObject] in HTMLPropertiesCollection.idl, so it will generate toJS() in JSHTMLPropertiesCollection.cpp not in JSHTMLCollection.cpp. So it will not complain for redefination. I have also compiled the code changes in my local system. Its working as expected. 612600 4 139428 haraken 2012-04-30 07:09:52 -0700 Comment on attachment 139428 Patch Thanks for the clarification. 612608 5 139428 arko 2012-04-30 07:15:12 -0700 Comment on attachment 139428 Patch Thanks haraken for the review. 612644 6 139428 webkit.review.bot 2012-04-30 08:13:53 -0700 Comment on attachment 139428 Patch Clearing flags on attachment: 139428 Committed r115638: <http://trac.webkit.org/changeset/115638> 612645 7 webkit.review.bot 2012-04-30 08:14:01 -0700 All reviewed patches have been landed. Closing bug. 139428 2012-04-30 03:14:15 -0700 2012-04-30 08:13:53 -0700 Patch patch_85172.diff text/plain 2324 arko SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTYxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTMwICBBcmtvIFNh aGEgIDxhcmtvQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBSZW1vdmUgY3VzdG9tIGJpbmRpbmdz IGNvZGUgaW4gSlNIVE1MQ29sbGVjdGlvbkN1c3RvbS5jcHAgZm9yIEhUTUxQcm9wZXJ0aWVzQ29s bGVjdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg1MTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIFtKU0dlbmVyYXRlVG9KU09iamVjdF0gaW4gSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uLmlk bCwgc28gdGhhdCBpdCBjYW4gZ2VuZXJhdGUgdG9KUygpCisgICAgICAgIGluIEpTSFRNTFByb3Bl cnRpZXNDb2xsZWN0aW9uLmNwcCBhdXRvbWF0aWNhbGx5LgorCisgICAgICAgICogYmluZGluZ3Mv anMvSlNIVE1MQ29sbGVjdGlvbkN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b0pTKToK KyAgICAgICAgKiBodG1sL0hUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbi5pZGw6CisKIDIwMTItMDQt MjkgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVpbGQg Zml4IGZvciBMb2NhbGl6ZWREYXRlTWFjLm1tCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0hUTUxDb2xsZWN0aW9uQ3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0hUTUxDb2xsZWN0aW9uQ3VzdG9tLmNwcAkocmV2aXNpb24gMTE1 NjE5KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MQ29sbGVjdGlvbkN1c3Rv bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzLDExICszMyw2IEBACiAjaW5jbHVkZSA8d3RmL1Zl Y3Rvci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0F0b21pY1N0cmluZy5oPgogCi0jaWYgRU5BQkxF KE1JQ1JPREFUQSkKLSNpbmNsdWRlICJIVE1MUHJvcGVydGllc0NvbGxlY3Rpb24uaCIKLSNpbmNs dWRlICJKU0hUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbi5oIgotI2VuZGlmCi0KIHVzaW5nIG5hbWVz cGFjZSBKU0M7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTkxLDExICs4Niw2IEBAIEpTVmFs dWUgdG9KUyhFeGVjU3RhdGUqIGV4ZWMsIEpTRE9NR2xvYmEKICAgICAgICAgY2FzZSBEb2NBbGw6 CiAgICAgICAgICAgICB3cmFwcGVyID0gQ1JFQVRFX0RPTV9XUkFQUEVSKGV4ZWMsIGdsb2JhbE9i amVjdCwgSFRNTEFsbENvbGxlY3Rpb24sIGNvbGxlY3Rpb24pOwogICAgICAgICAgICAgYnJlYWs7 Ci0jaWYgRU5BQkxFKE1JQ1JPREFUQSkKLSAgICAgICAgY2FzZSBJdGVtUHJvcGVydGllczoKLSAg ICAgICAgICAgIHdyYXBwZXIgPSBDUkVBVEVfRE9NX1dSQVBQRVIoZXhlYywgZ2xvYmFsT2JqZWN0 LCBIVE1MUHJvcGVydGllc0NvbGxlY3Rpb24sIGNvbGxlY3Rpb24pOwotICAgICAgICAgICAgYnJl YWs7Ci0jZW5kaWYKICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIHdyYXBwZXIgPSBDUkVB VEVfRE9NX1dSQVBQRVIoZXhlYywgZ2xvYmFsT2JqZWN0LCBIVE1MQ29sbGVjdGlvbiwgY29sbGVj dGlvbik7CiAgICAgICAgICAgICBicmVhazsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TFByb3BlcnRpZXNDb2xsZWN0aW9uLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbi5pZGwJKHJldmlzaW9uIDExNTYxOSkKKysrIFNv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uLmlkbAkod29ya2luZyBj b3B5KQpAQCAtMzIsNiArMzIsNyBAQCBtb2R1bGUgaHRtbCB7CiAKICAgICBpbnRlcmZhY2UgWwog ICAgICAgICBDb25kaXRpb25hbD1NSUNST0RBVEEsCisgICAgICAgIEpTR2VuZXJhdGVUb0pTT2Jq ZWN0LAogICAgICAgICBJbmRleGVkR2V0dGVyLAogICAgICAgICBOYW1lZEdldHRlcgogICAgIF0g SFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uIDogSFRNTENvbGxlY3Rpb24gewo=