8517 2006-04-21 08:24:54 -0700 change DerivedSources.make to use VPATH consistently 2006-04-23 15:41:01 -0700 1 1 1 Unclassified WebKit Platform 420+ PC Linux RESOLVED FIXED P4 Trivial --- 8515 1 mike.emmel webkit-unassigned oldest_to_newest 40030 0 mike.emmel 2006-04-21 08:24:54 -0700 Make all pathes relative to $(WebCore) in DerivedSource.make 40031 1 7872 mike.emmel 2006-04-21 08:26:12 -0700 Created attachment 7872 patch to add WebCore variable 40046 2 7872 ggaren 2006-04-21 11:29:41 -0700 Comment on attachment 7872 patch to add WebCore variable r=me 40064 3 7872 eric 2006-04-21 14:26:22 -0700 Comment on attachment 7872 patch to add WebCore variable This should not be necessary. the VPATH variable should take care of this... 40088 4 7872 darin 2006-04-21 22:23:18 -0700 Comment on attachment 7872 patch to add WebCore variable This is not a good idea. VPATH is supposed to handle this. Please don't land this change until we understand why that's not working. 40090 5 mike.emmel 2006-04-21 22:36:21 -0700 (In reply to comment #4) > (From update of attachment 7872 [edit]) > This is not a good idea. VPATH is supposed to handle this. Please don't land > this change until we understand why that's not working. > It works its just at one point when I made the patch all paths were not relative I don't think the makefile actually worked at that time it does now. With that said all paths are not relative in the make file for example ksvgcssvalues.h : $(WebCore)/ksvg2/scripts/cssmakevalues $(WebCore)/css/CSSValue So its a mix of relative paths using the VPATH and some that don't. I went the route of all absolute which I can understand not using but we should make it all relative or all absolute not a mix 40099 6 7894 mike.emmel 2006-04-21 23:20:22 -0700 Created attachment 7894 Patch to make more paths use VPATH This patch makes the makefile more consitent in its use of VPATH. Note VPATH works with the latest version in SVN the orginal patch was made agianst and older version of the file that had several problems. 40173 7 7894 mjs 2006-04-22 12:52:09 -0700 Comment on attachment 7894 Patch to make more paths use VPATH r=me 7872 2006-04-21 08:26:12 -0700 2006-04-21 22:23:18 -0700 patch to add WebCore variable DerivedSources.patch text/plain 2057 mike.emmel SW5kZXg6IERlcml2ZWRTb3VyY2VzLm1ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gRGVyaXZlZFNvdXJjZXMu bWFrZQkocmV2aXNpb24gMTM5OTYpCisrKyBEZXJpdmVkU291cmNlcy5tYWtlCSh3b3JraW5nIGNv cHkpCkBAIC04NywzNyArODcsMzcgQEAgYWxsIDogXAogCiAjIENTUyBwcm9wZXJ0eSBuYW1lcyBh bmQgdmFsdWUga2V5d29yZHMKIAotQ1NTUHJvcGVydHlOYW1lcy5oIDogY3NzL0NTU1Byb3BlcnR5 TmFtZXMuaW4gY3NzL21ha2Vwcm9wCitDU1NQcm9wZXJ0eU5hbWVzLmggOiAkKFdlYkNvcmUpL2Nz cy9DU1NQcm9wZXJ0eU5hbWVzLmluICQoV2ViQ29yZSkvY3NzL21ha2Vwcm9wCiAJY2F0ICQ8ID4g Q1NTUHJvcGVydHlOYW1lcy5pbgogCXNoICIkKFdlYkNvcmUpL2Nzcy9tYWtlcHJvcCIKIAotQ1NT VmFsdWVLZXl3b3Jkcy5oIDogY3NzL0NTU1ZhbHVlS2V5d29yZHMuaW4gY3NzL21ha2V2YWx1ZXMK K0NTU1ZhbHVlS2V5d29yZHMuaCA6ICQoV2ViQ29yZSkvY3NzL0NTU1ZhbHVlS2V5d29yZHMuaW4g JChXZWJDb3JlKS9jc3MvbWFrZXZhbHVlcwogCWNhdCAkPCA+IENTU1ZhbHVlS2V5d29yZHMuaW4K IAlzaCAiJChXZWJDb3JlKS9jc3MvbWFrZXZhbHVlcyIKIAogIyBET0NUWVBFIHN0cmluZ3MKIAot RG9jVHlwZVN0cmluZ3MuY3BwIDogaHRtbC9Eb2NUeXBlU3RyaW5ncy5ncGVyZgorRG9jVHlwZVN0 cmluZ3MuY3BwIDogJChXZWJDb3JlKS9odG1sL0RvY1R5cGVTdHJpbmdzLmdwZXJmCiAJZ3BlcmYg LUNFb3QgLUwgQU5TSS1DIC1rICIqIiAtTiBmaW5kRG9jdHlwZUVudHJ5IC1GICxQdWJJREluZm86 OmVBbG1vc3RTdGFuZGFyZHMsUHViSURJbmZvOjplQWxtb3N0U3RhbmRhcmRzICQ8ID4gJEAKIAog IyBIVE1MIGVudGl0eSBuYW1lcwogCi1IVE1MRW50aXR5TmFtZXMuYyA6IGh0bWwvSFRNTEVudGl0 eU5hbWVzLmdwZXJmCitIVE1MRW50aXR5TmFtZXMuYyA6ICQoV2ViQ29yZSkvaHRtbC9IVE1MRW50 aXR5TmFtZXMuZ3BlcmYKIAlncGVyZiAtYSAtTCBBTlNJLUMgLUMgLUcgLWMgLW8gLXQgLWsgJyon IC1OIGZpbmRFbnRpdHkgLUQgLXMgMiAkPCA+ICRACiAKICMgY29sb3IgbmFtZXMKIAotQ29sb3JE YXRhLmMgOiBwbGF0Zm9ybS9Db2xvckRhdGEuZ3BlcmYKK0NvbG9yRGF0YS5jIDogJChXZWJDb3Jl KS9wbGF0Zm9ybS9Db2xvckRhdGEuZ3BlcmYKIAlncGVyZiAtQ0RFb3QgLUwgQU5TSS1DIC1rICcq JyAtTiBmaW5kQ29sb3IgLUQgLXMgMiAkPCA+ICRACiAKICMgQ1NTIHRva2VuaXplcgogCi10b2tl bml6ZXIuY3BwIDogY3NzL3Rva2VuaXplci5mbGV4IGNzcy9tYWtldG9rZW5pemVyCit0b2tlbml6 ZXIuY3BwIDogJChXZWJDb3JlKS9jc3MvdG9rZW5pemVyLmZsZXggJChXZWJDb3JlKS9jc3MvbWFr ZXRva2VuaXplcgogCWZsZXggLXQgJDwgfCBwZXJsICQoV2ViQ29yZSkvY3NzL21ha2V0b2tlbml6 ZXIgPiAkQAogCiAjIENTUyBncmFtbWFyCiAKLUNTU0dyYW1tYXIuY3BwIDogY3NzL0NTU0dyYW1t YXIueQorQ1NTR3JhbW1hci5jcHAgOiAkKFdlYkNvcmUpL2Nzcy9DU1NHcmFtbWFyLnkKIAliaXNv biAtZCAtcCBjc3N5eSAkPCAtbyAkQAogCXRvdWNoIENTU0dyYW1tYXIuY3BwLmgKIAl0b3VjaCBD U1NHcmFtbWFyLmhwcApAQCAtMTMyLDcgKzEzMiw3IEBAIFVzZXJBZ2VudFN0eWxlU2hlZXRzLmgg OiBjc3MvbWFrZS1jc3MtZmkKIAogIyBjaGFyYWN0ZXIgc2V0IG5hbWUgdGFibGUKIAotQ2hhcnNl dERhdGEuY3BwIDogcGxhdGZvcm0vbWFrZS1jaGFyc2V0LXRhYmxlLnBsIHBsYXRmb3JtL2NoYXJh Y3Rlci1zZXRzLnR4dCAkKEVOQ09ESU5HU19GSUxFKQorQ2hhcnNldERhdGEuY3BwIDogJChXZWJD b3JlKS9wbGF0Zm9ybS9tYWtlLWNoYXJzZXQtdGFibGUucGwgJChXZWJDb3JlKS9wbGF0Zm9ybS9j aGFyYWN0ZXItc2V0cy50eHQgJChFTkNPRElOR1NfRklMRSkKIAkkXiAkKEVOQ09ESU5HU19QUkVG SVgpID4gJEAKIAogIyBsb29rdXAgdGFibGVzIGZvciBvbGQtc3R5bGUgSmF2YVNjcmlwdCBiaW5k aW5ncwo= 7894 2006-04-21 23:20:22 -0700 2006-04-22 12:52:09 -0700 Patch to make more paths use VPATH DerivedSource.patch text/plain 2765 mike.emmel SW5kZXg6IERlcml2ZWRTb3VyY2VzLm1ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gRGVyaXZlZFNvdXJjZXMu bWFrZQkocmV2aXNpb24gMTQwMDEpCisrKyBEZXJpdmVkU291cmNlcy5tYWtlCSh3b3JraW5nIGNv cHkpCkBAIC0xNDgsMjMgKzE0OCwyMyBAQAogCiAjIFNWRyB0YWcgYW5kIGF0dHJpYnV0ZSBuYW1l cwogCi1TVkdOYW1lcy5jcHAgOiAkKFdlYkNvcmUpL2tzdmcyL3NjcmlwdHMvbWFrZV9uYW1lcy5w bCAkKFdlYkNvcmUpL2tzdmcyL3N2Zy9zdmd0YWdzLmluICQoV2ViQ29yZSkva3N2ZzIvc3ZnL3N2 Z2F0dHJzLmluCitTVkdOYW1lcy5jcHAgOiBrc3ZnMi9zY3JpcHRzL21ha2VfbmFtZXMucGwga3N2 ZzIvc3ZnL3N2Z3RhZ3MuaW4ga3N2ZzIvc3ZnL3N2Z2F0dHJzLmluCiAJJDwgLS10YWdzICQoV2Vi Q29yZSkva3N2ZzIvc3ZnL3N2Z3RhZ3MuaW4gLS1hdHRycyAkKFdlYkNvcmUpL2tzdmcyL3N2Zy9z dmdhdHRycy5pbiBcCiAgICAgICAgICAgICAtLW5hbWVzcGFjZSBTVkcgLS1jcHBOYW1lc3BhY2Ug V2ViQ29yZSAtLW5hbWVzcGFjZVVSSSAiaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIC0tZmFj dG9yeSAtLWF0dHJzTnVsbE5hbWVzcGFjZSAtLW91dHB1dCAuCiAKLVhMaW5rTmFtZXMuY3BwIDog JChXZWJDb3JlKS9rc3ZnMi9zY3JpcHRzL21ha2VfbmFtZXMucGwgJChXZWJDb3JlKS9rc3ZnMi9t aXNjL3hsaW5rYXR0cnMuaW4KK1hMaW5rTmFtZXMuY3BwIDoga3N2ZzIvc2NyaXB0cy9tYWtlX25h bWVzLnBsIGtzdmcyL21pc2MveGxpbmthdHRycy5pbgogCSQ8IC0tYXR0cnMgJChXZWJDb3JlKS9r c3ZnMi9taXNjL3hsaW5rYXR0cnMuaW4gXAogICAgICAgICAgICAgLS1uYW1lc3BhY2UgWExpbmsg LS1jcHBOYW1lc3BhY2UgV2ViQ29yZSAtLW5hbWVzcGFjZVVSSSAiaHR0cDovL3d3dy53My5vcmcv MTk5OS94bGluayIgLS1vdXRwdXQgLgogCXRvdWNoICQoV2ViQ29yZSkvV2ViQ29yZStTVkcvWExp bmtOYW1lc1dyYXBwZXIuY3BwCiAKICMgU1ZHIENTUyBwcm9wZXJ0eSBuYW1lcyBhbmQgdmFsdWUg a2V5d29yZHMKIAota3N2Z2Nzc3Byb3BlcnRpZXMuaCA6ICQoV2ViQ29yZSkva3N2ZzIvc2NyaXB0 cy9jc3NtYWtlcHJvcHMgJChXZWJDb3JlKS9jc3MvQ1NTUHJvcGVydHlOYW1lcy5pbiAkKFdlYkNv cmUpL2tzdmcyL2Nzcy9DU1NQcm9wZXJ0eU5hbWVzLmluCitrc3ZnY3NzcHJvcGVydGllcy5oIDog a3N2ZzIvc2NyaXB0cy9jc3NtYWtlcHJvcHMgY3NzL0NTU1Byb3BlcnR5TmFtZXMuaW4ga3N2ZzIv Y3NzL0NTU1Byb3BlcnR5TmFtZXMuaW4KIAlpZiBzb3J0ICQoV2ViQ29yZSkvY3NzL0NTU1Byb3Bl cnR5TmFtZXMuaW4gJChXZWJDb3JlKS9rc3ZnMi9jc3MvQ1NTUHJvcGVydHlOYW1lcy5pbiB8IHVu aXEgLWQgfCBncmVwIC1FICdeW14jXSc7IHRoZW4gZWNobyAnRHVwbGljYXRlIHZhbHVlISc7IGV4 aXQgMTsgZmkKIAljYXQgJChXZWJDb3JlKS9rc3ZnMi9jc3MvQ1NTUHJvcGVydHlOYW1lcy5pbiA+ IGtzdmdjc3Nwcm9wZXJ0aWVzLmluCiAJJChXZWJDb3JlKS9rc3ZnMi9zY3JpcHRzL2Nzc21ha2Vw cm9wcyAtbiBTVkcgLWYga3N2Z2Nzc3Byb3BlcnRpZXMuaW4KIAota3N2Z2Nzc3ZhbHVlcy5oIDog JChXZWJDb3JlKS9rc3ZnMi9zY3JpcHRzL2Nzc21ha2V2YWx1ZXMgJChXZWJDb3JlKS9jc3MvQ1NT VmFsdWVLZXl3b3Jkcy5pbiAkKFdlYkNvcmUpL2tzdmcyL2Nzcy9DU1NWYWx1ZUtleXdvcmRzLmlu Citrc3ZnY3NzdmFsdWVzLmggOiBrc3ZnMi9zY3JpcHRzL2Nzc21ha2V2YWx1ZXMgY3NzL0NTU1Zh bHVlS2V5d29yZHMuaW4ga3N2ZzIvY3NzL0NTU1ZhbHVlS2V5d29yZHMuaW4KIAlpZiBzb3J0ICQo V2ViQ29yZSkvY3NzL0NTU1ZhbHVlS2V5d29yZHMuaW4gJChXZWJDb3JlKS9rc3ZnMi9jc3MvQ1NT VmFsdWVLZXl3b3Jkcy5pbiB8IHVuaXEgLWQgfCBncmVwIC1FICdeW14jXSc7IHRoZW4gZWNobyAn RHVwbGljYXRlIHZhbHVlISc7IGV4aXQgMTsgZmkKIAkjIExvd2VyIGNhc2UgYWxsIHRoZSB2YWx1 ZXMsIGFzIENTUyB2YWx1ZXMgYXJlIGNhc2UtaW5zZW5zaXRpdmUKIAlwZXJsIC1uZSAncHJpbnQg bGMnICQoV2ViQ29yZSkva3N2ZzIvY3NzL0NTU1ZhbHVlS2V5d29yZHMuaW4gPiBrc3ZnY3NzdmFs dWVzLmluCkBAIC0xNzMsMTEgKzE3MywxMSBAQAogIyBuZXctc3R5bGUgSmF2YVNjcmlwdCBiaW5k aW5ncwogCiBKU19CSU5ESU5HU19TQ1JJUFRTID0gXAotICAgICQoV2ViQ29yZSkvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtIFwKLSAgICAkKFdlYkNvcmUpL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckpTLnBtIFwKLSAgICAkKFdlYkNvcmUpL2JpbmRpbmdzL3NjcmlwdHMv SURMUGFyc2VyLnBtIFwKLSAgICAkKFdlYkNvcmUpL2JpbmRpbmdzL3NjcmlwdHMvSURMU3RydWN0 dXJlLnBtIFwKLSAgICAkKFdlYkNvcmUpL2JpbmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmluZGlu Z3MucGwgXAorICAgIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbSBcCisgICAgYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gXAorICAgIGJpbmRpbmdzL3NjcmlwdHMv SURMUGFyc2VyLnBtIFwKKyAgICBiaW5kaW5ncy9zY3JpcHRzL0lETFN0cnVjdHVyZS5wbSBcCisg ICAgYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy5wbCBcCiAjCiAKIEpTJS5oIDog JS5pZGwgJChKU19CSU5ESU5HU19TQ1JJUFRTKQo=