85169 2012-04-29 22:28:57 -0700 [EFL] Default values for ewk_view video tracks settings should be documented 2012-05-18 13:35:33 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 612492 0 cdumez 2012-04-29 22:28:57 -0700 The default values for video tracks settings in ewk_view (captions, subtitles, text descriptions) are not documented. It should be mentioned in the documentation that those settings are disabled by default. 612493 1 139419 cdumez 2012-04-29 22:33:21 -0700 Created attachment 139419 Patch 612498 2 139419 gyuyoung.kim 2012-04-29 23:23:16 -0700 Comment on attachment 139419 Patch Looks fine. 612616 3 139419 rakuco 2012-04-30 07:28:51 -0700 Comment on attachment 139419 Patch Could you mention the defaults in the getters as well? 612658 4 cdumez 2012-04-30 08:38:48 -0700 (In reply to comment #3) > (From update of attachment 139419 [details]) > Could you mention the defaults in the getters as well? Do you mean the setters? Somehow, it feels weird to me to provide default values in the setters documentation. This is why my patch updates the documentation for the getters only. 612764 5 rakuco 2012-04-30 11:04:47 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 139419 [details] [details]) > > Could you mention the defaults in the getters as well? > > Do you mean the setters? Somehow, it feels weird to me to provide default values in the setters documentation. This is why my patch updates the documentation for the getters only. Oops, I was confused by the function names the review page showed (it showed the setters, so I thought you had not documented the getters). 613864 6 gyuyoung.kim 2012-05-01 18:48:15 -0700 LGTM again. 628005 7 139419 webkit.review.bot 2012-05-18 13:35:27 -0700 Comment on attachment 139419 Patch Clearing flags on attachment: 139419 Committed r117617: <http://trac.webkit.org/changeset/117617> 628006 8 webkit.review.bot 2012-05-18 13:35:33 -0700 All reviewed patches have been landed. Closing bug. 139419 2012-04-29 22:33:21 -0700 2012-05-18 13:35:27 -0700 Patch 85169_vtt_settings.patch text/plain 2088 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA0MDVmMmNlLi5kZDU0NmZhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDQtMjkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhl LmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBEZWZhdWx0IHZhbHVlcyBmb3IgZXdr X3ZpZXcgdmlkZW8gdHJhY2tzIHNldHRpbmdzIHNob3VsZCBiZSBkb2N1bWVudGVkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTE2OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvY3VtZW50IGRlZmF1bHQg dmFsdWVzIGZvciB2aWRlbyB0cmFja3Mgc2V0dGluZ3MgaW4gZXdrX3ZpZXcuCisKKyAgICAgICAg KiBld2svZXdrX3ZpZXcuaDoKKwogMjAxMi0wNC0yNyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlz dG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIFJlc291cmNlRXJyb3IgZG9t YWluIG5lZWRzIHRvIGJlIHByb3Blcmx5IHNldCBpbiBGcmFtZUxvYWRlckNsaWVudApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmggYi9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXcuaAppbmRleCA4NTIzZWM2Li42NTM1MDIzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3ZpZXcuaApAQCAtMjUwMCw2ICsyNTAwLDggQEAgRUFQSSB2b2lkIGV3a192aWV3X3NldHRp bmdfZW5hYmxlX3hzc19hdWRpdG9yX3NldChFdmFzX09iamVjdCAqbywgRWluYV9Cb29sIGVuYWIK IC8qKgogICogUmV0dXJucyB3aGV0aGVyIHZpZGVvIGNhcHRpb25zIGRpc3BsYXkgZmVhdHVyZSBp cyBlbmFibGVkLgogICoKKyAqIFZpZGVvIGNhcHRpb25zIGRpc3BsYXkgaXMgZGlzYWJsZWQgYnkg ZGVmYXVsdC4KKyAqCiAgKiBAcGFyYW0gbyB2aWV3IG9iamVjdCB0byBxdWVyeSB3aGV0aGVyIHZp ZGVvIGNhcHRpb25zIGRpc3BsYXkgZmVhdHVyZSBpcyBlbmFibGVkLgogICoKICAqIEByZXR1cm4g QGMgRUlOQV9UUlVFIGlmIHRoZSB2aWRlbyBjYXB0aW9ucyBkaXNwbGF5IGZlYXR1cmUgaXMgZW5h YmxlZCwKQEAgLTI1MjEsNiArMjUyMyw4IEBAIEVBUEkgdm9pZCBld2tfdmlld19zZXR0aW5nX3No b3VsZF9kaXNwbGF5X2NhcHRpb25zX3NldChFdmFzX09iamVjdCAqbywgRWluYV9Cb29sCiAvKioK ICAqIFJldHVybnMgd2hldGhlciB2aWRlbyBzdWJ0aXRsZXMgZGlzcGxheSBmZWF0dXJlIGlzIGVu YWJsZWQuCiAgKgorICogVmlkZW8gc3VidGl0bGVzIGRpc3BsYXkgaXMgZGlzYWJsZWQgYnkgZGVm YXVsdC4KKyAqCiAgKiBAcGFyYW0gbyB2aWV3IG9iamVjdCB0byBxdWVyeSB3aGV0aGVyIHZpZGVv IHN1YnRpdGxlcyBkaXNwbGF5IGZlYXR1cmUgaXMgZW5hYmxlZC4KICAqCiAgKiBAcmV0dXJuIEBj IEVJTkFfVFJVRSBpZiB0aGUgdmlkZW8gc3VidGl0bGVzIGRpc3BsYXkgZmVhdHVyZSBpcyBlbmFi bGVkLApAQCAtMjU0Miw2ICsyNTQ2LDggQEAgRUFQSSB2b2lkIGV3a192aWV3X3NldHRpbmdfc2hv dWxkX2Rpc3BsYXlfc3VidGl0bGVzX3NldChFdmFzX09iamVjdCAqbywgRWluYV9Cb28KIC8qKgog ICogUmV0dXJucyB3aGV0aGVyIHZpZGVvIHRleHQgZGVzY3JpcHRpb25zIGRpc3BsYXkgZmVhdHVy ZSBpcyBlbmFibGVkLgogICoKKyAqIFZpZGVvIHRleHQgZGVzY3JpcHRpb25zIGRpc3BsYXkgaXMg ZGlzYWJsZWQgYnkgZGVmYXVsdC4KKyAqCiAgKiBAcGFyYW0gbyB2aWV3IG9iamVjdCB0byBxdWVy eSB3aGV0aGVyIHZpZGVvIHRleHQgZGVzY3JpcHRpb25zIGRpc3BsYXkgZmVhdHVyZSBpcyBlbmFi bGVkLgogICoKICAqIEByZXR1cm4gQGMgRUlOQV9UUlVFIGlmIHRoZSB2aWRlbyB0ZXh0IGRlc2Ny aXB0aW9ucyBkaXNwbGF5IGZlYXR1cmUgaXMgZW5hYmxlZCwK