85165 2012-04-29 19:06:24 -0700 Predicted types should know about arguments 2012-05-20 04:17:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 612476 0 fpizlo 2012-04-29 19:06:24 -0700 And they should be able to distinguish between the arguments from the current frame and arguments from other frames. Value profiling can't distinguish that, but prediction propagation and CFA can. Patch forthcoming. 612478 1 139413 fpizlo 2012-04-29 19:08:14 -0700 Created attachment 139413 the patch 612487 2 fpizlo 2012-04-29 19:52:19 -0700 Landed in http://trac.webkit.org/changeset/115604 628567 3 fpizlo 2012-05-20 04:17:24 -0700 Merged in http://trac.webkit.org/changeset/117707 139413 2012-04-29 19:08:14 -0700 2012-04-29 19:30:42 -0700 the patch predictarguments_patch_1.diff text/plain 7482 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE1NjAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEyLTA0LTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UHJlZGljdGVkIHR5cGVzIHNob3VsZCBrbm93IGFib3V0IGFyZ3VtZW50cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUxNjUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJ5dGVjb2RlL1ByZWRpY3RlZFR5 cGUuY3BwOgorICAgICAgICAoSlNDOjpwcmVkaWN0aW9uVG9TdHJpbmcpOgorICAgICAgICAoSlND OjpwcmVkaWN0aW9uVG9BYmJyZXZpYXRlZFN0cmluZyk6CisgICAgICAgIChKU0M6OnByZWRpY3Rp b25Gcm9tQ2xhc3NJbmZvKToKKyAgICAgICAgKiBieXRlY29kZS9QcmVkaWN0ZWRUeXBlLmg6Cisg ICAgICAgIChKU0MpOgorICAgICAgICAoSlNDOjppc015QXJndW1lbnRzUHJlZGljdGlvbik6Cisg ICAgICAgIChKU0M6OmlzQXJndW1lbnRzUHJlZGljdGlvbik6CisKIDIwMTItMDQtMjggIEZpbGlw IFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBCeXRlY29tcGlsZXIgc2hvdWxk IGVtaXQgdHJpdmlhbGx5IGZld2VyIGp1bXBzIGluIGxvb3BzCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvUHJlZGljdGVkVHlwZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1ByZWRpY3RlZFR5cGUuY3BwCShyZXZpc2lvbiAxMTU2 MDIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUHJlZGljdGVkVHlwZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDEx IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMSwg MjAxMiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRp b24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAg KiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5n IGNvbmRpdGlvbnMKQEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNs dWRlICJQcmVkaWN0ZWRUeXBlLmgiCiAKKyNpbmNsdWRlICJBcmd1bWVudHMuaCIKICNpbmNsdWRl ICJKU0FycmF5LmgiCiAjaW5jbHVkZSAiSlNCeXRlQXJyYXkuaCIKICNpbmNsdWRlICJKU0Z1bmN0 aW9uLmgiCkBAIC0xMjMsNiArMTI0LDE2IEBAIGNvbnN0IGNoYXIqIHByZWRpY3Rpb25Ub1N0cmlu ZyhQcmVkaWN0ZWQKICAgICBlbHNlCiAgICAgICAgIGlzVG9wID0gZmFsc2U7CiAgICAgCisgICAg aWYgKHZhbHVlICYgUHJlZGljdE15QXJndW1lbnRzKQorICAgICAgICBwdHIuc3RyY2F0KCJNeWFy Z3VtZW50cyIpOworICAgIGVsc2UKKyAgICAgICAgaXNUb3AgPSBmYWxzZTsKKyAgICAKKyAgICBp ZiAodmFsdWUgJiBQcmVkaWN0Rm9yZWlnbkFyZ3VtZW50cykKKyAgICAgICAgcHRyLnN0cmNhdCgi Rm9yZWlnbmFyZ3VtZW50cyIpOworICAgIGVsc2UKKyAgICAgICAgaXNUb3AgPSBmYWxzZTsKKyAg ICAKICAgICBpZiAodmFsdWUgJiBQcmVkaWN0U3RyaW5nKQogICAgICAgICBwdHIuc3RyY2F0KCJT dHJpbmciKTsKICAgICBlbHNlCkBAIC0xOTQsNiArMjA1LDEwIEBAIGNvbnN0IGNoYXIqIHByZWRp Y3Rpb25Ub0FiYnJldmlhdGVkU3RyaW4KICAgICAgICAgcmV0dXJuICI8RmxvYXQzMmFycmF5PiI7 CiAgICAgaWYgKGlzRmxvYXQ2NEFycmF5UHJlZGljdGlvbihwcmVkaWN0aW9uKSkKICAgICAgICAg cmV0dXJuICI8RmxvYXQ2NGFycmF5PiI7CisgICAgaWYgKGlzTXlBcmd1bWVudHNQcmVkaWN0aW9u KHByZWRpY3Rpb24pKQorICAgICAgICByZXR1cm4gIjxNeWFyZ3VtZW50cz4iOworICAgIGlmIChp c0FyZ3VtZW50c1ByZWRpY3Rpb24ocHJlZGljdGlvbikpCisgICAgICAgIHJldHVybiAiPEFyZ3Vt ZW50cz4iOwogICAgIGlmIChpc09iamVjdFByZWRpY3Rpb24ocHJlZGljdGlvbikpCiAgICAgICAg IHJldHVybiAiPE9iamVjdD4iOwogICAgIGlmIChpc0NlbGxQcmVkaWN0aW9uKHByZWRpY3Rpb24p KQpAQCAtMjIyLDYgKzIzNyw5IEBAIFByZWRpY3RlZFR5cGUgcHJlZGljdGlvbkZyb21DbGFzc0lu Zm8oY28KICAgICBpZiAoY2xhc3NJbmZvID09ICZKU1N0cmluZzo6c19pbmZvKQogICAgICAgICBy ZXR1cm4gUHJlZGljdFN0cmluZzsKICAgICAKKyAgICBpZiAoY2xhc3NJbmZvID09ICZBcmd1bWVu dHM6OnNfaW5mbykKKyAgICAgICAgcmV0dXJuIFByZWRpY3RBcmd1bWVudHM7IC8vIENhbm5vdCBk aXN0aW5ndWlzaCBiZXR3ZWVuIE15QXJndW1lbnRzIGFuZCBGb3JlaWduQXJndW1lbnRzIGF0IHRo aXMgc3RhZ2UuIFRoYXQgaGFwcGVucyBpbiB0aGUgZmxvdyBhbmFseXNpcy4KKyAgICAKICAgICBp ZiAoY2xhc3NJbmZvLT5pc1N1YkNsYXNzT2YoJkpTRnVuY3Rpb246OnNfaW5mbykpCiAgICAgICAg IHJldHVybiBQcmVkaWN0RnVuY3Rpb247CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29kZS9QcmVkaWN0ZWRUeXBlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL1ByZWRpY3RlZFR5cGUuaAkocmV2aXNpb24gMTE1NjAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1ByZWRpY3RlZFR5cGUuaAkod29ya2luZyBjb3B5KQpA QCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTEgQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDExLCAyMDEyIEFwcGxlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNv dXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwg YXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAt NTAsMTcgKzUwLDIwIEBAIHN0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBlIFByZWRpY3RVaW50MTYK IHN0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBlIFByZWRpY3RVaW50MzJBcnJheSAgICAgICA9IDB4 MDAwMDA0MDA7IC8vIEl0J3MgZGVmaW5pdGVseSBhbiBVaW50MzJBcnJheSBvciBvbmUgb2YgaXRz IHN1YmNsYXNzZXMuCiBzdGF0aWMgY29uc3QgUHJlZGljdGVkVHlwZSBQcmVkaWN0RmxvYXQzMkFy cmF5ICAgICAgPSAweDAwMDAwODAwOyAvLyBJdCdzIGRlZmluaXRlbHkgYW4gVWludDE2QXJyYXkg b3Igb25lIG9mIGl0cyBzdWJjbGFzc2VzLgogc3RhdGljIGNvbnN0IFByZWRpY3RlZFR5cGUgUHJl ZGljdEZsb2F0NjRBcnJheSAgICAgID0gMHgwMDAwMTAwMDsgLy8gSXQncyBkZWZpbml0ZWx5IGFu IFVpbnQxNkFycmF5IG9yIG9uZSBvZiBpdHMgc3ViY2xhc3Nlcy4KLXN0YXRpYyBjb25zdCBQcmVk aWN0ZWRUeXBlIFByZWRpY3RPYmplY3RPdGhlciAgICAgICA9IDB4MDAwMDIwMDA7IC8vIEl0J3Mg ZGVmaW5pdGVseSBhbiBvYmplY3QgYnV0IG5vdCBKU0ZpbmFsT2JqZWN0LCBKU0FycmF5LCBKU0J5 dGVBcnJheSwgb3IgSlNGdW5jdGlvbi4KLXN0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBlIFByZWRp Y3RPYmplY3RNYXNrICAgICAgICA9IDB4MDAwMDNmZmY7IC8vIEJpdG1hc2sgdXNlZCBmb3IgdGVz dGluZyBmb3IgYW55IGtpbmQgb2Ygb2JqZWN0IHByZWRpY3Rpb24uCi1zdGF0aWMgY29uc3QgUHJl ZGljdGVkVHlwZSBQcmVkaWN0U3RyaW5nICAgICAgICAgICAgPSAweDAwMDA0MDAwOyAvLyBJdCdz IGRlZmluaXRlbHkgYSBKU1N0cmluZy4KLXN0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBlIFByZWRp Y3RDZWxsT3RoZXIgICAgICAgICA9IDB4MDAwMDgwMDA7IC8vIEl0J3MgZGVmaW5pdGVseSBhIEpT Q2VsbCBidXQgbm90IGEgc3ViY2xhc3Mgb2YgSlNPYmplY3QgYW5kIGRlZmluaXRlbHkgbm90IGEg SlNTdHJpbmcuCi1zdGF0aWMgY29uc3QgUHJlZGljdGVkVHlwZSBQcmVkaWN0Q2VsbCAgICAgICAg ICAgICAgPSAweDAwMDBmZmZmOyAvLyBJdCdzIGRlZmluaXRlbHkgYSBKU0NlbGwuCi1zdGF0aWMg Y29uc3QgUHJlZGljdGVkVHlwZSBQcmVkaWN0SW50MzIgICAgICAgICAgICAgPSAweDAwMDEwMDAw OyAvLyBJdCdzIGRlZmluaXRlbHkgYW4gSW50MzIuCi1zdGF0aWMgY29uc3QgUHJlZGljdGVkVHlw ZSBQcmVkaWN0RG91YmxlUmVhbCAgICAgICAgPSAweDAwMDIwMDAwOyAvLyBJdCdzIGRlZmluaXRl bHkgYSBub24tTmFOIGRvdWJsZS4KLXN0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBlIFByZWRpY3RE b3VibGVOYU4gICAgICAgICA9IDB4MDAwNDAwMDA7IC8vIEl0J3MgZGVmaW5pdGVseSBhIE5hTi4K LXN0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBlIFByZWRpY3REb3VibGUgICAgICAgICAgICA9IDB4 MDAwNjAwMDA7IC8vIEl0J3MgZWl0aGVyIGEgbm9uLU5hTiBvciBhIE5hTiBkb3VibGUuCi1zdGF0 aWMgY29uc3QgUHJlZGljdGVkVHlwZSBQcmVkaWN0TnVtYmVyICAgICAgICAgICAgPSAweDAwMDcw MDAwOyAvLyBJdCdzIGVpdGhlciBhbiBJbnQzMiBvciBhIERvdWJsZS4KLXN0YXRpYyBjb25zdCBQ cmVkaWN0ZWRUeXBlIFByZWRpY3RCb29sZWFuICAgICAgICAgICA9IDB4MDAwODAwMDA7IC8vIEl0 J3MgZGVmaW5pdGVseSBhIEJvb2xlYW4uCitzdGF0aWMgY29uc3QgUHJlZGljdGVkVHlwZSBQcmVk aWN0TXlBcmd1bWVudHMgICAgICAgPSAweDAwMDAyMDAwOyAvLyBJdCdzIGRlZmluaXRlbHkgYW4g QXJndW1lbnRzIG9iamVjdCwgYW5kIGl0J3MgZGVmaW5pdGVseSB0aGUgb25lIGZvciBteSBjdXJy ZW50IGZyYW1lLgorc3RhdGljIGNvbnN0IFByZWRpY3RlZFR5cGUgUHJlZGljdEZvcmVpZ25Bcmd1 bWVudHMgID0gMHgwMDAwNDAwMDsgLy8gSXQncyBkZWZpbml0ZWx5IGFuIEFyZ3VtZW50cyBvYmpl Y3QsIGFuZCBpdCdzIGRlZmluaXRlbHkgbm90IG1pbmUuCitzdGF0aWMgY29uc3QgUHJlZGljdGVk VHlwZSBQcmVkaWN0QXJndW1lbnRzICAgICAgICAgPSAweDAwMDA2MDAwOyAvLyBJdCdzIGRlZmlu aXRlbHkgYW4gQXJndW1lbnRzIG9iamVjdC4KK3N0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBlIFBy ZWRpY3RPYmplY3RPdGhlciAgICAgICA9IDB4MDAwMDgwMDA7IC8vIEl0J3MgZGVmaW5pdGVseSBh biBvYmplY3QgYnV0IG5vdCBKU0ZpbmFsT2JqZWN0LCBKU0FycmF5LCBKU0J5dGVBcnJheSwgb3Ig SlNGdW5jdGlvbi4KK3N0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBlIFByZWRpY3RPYmplY3RNYXNr ICAgICAgICA9IDB4MDAwMGZmZmY7IC8vIEJpdG1hc2sgdXNlZCBmb3IgdGVzdGluZyBmb3IgYW55 IGtpbmQgb2Ygb2JqZWN0IHByZWRpY3Rpb24uCitzdGF0aWMgY29uc3QgUHJlZGljdGVkVHlwZSBQ cmVkaWN0U3RyaW5nICAgICAgICAgICAgPSAweDAwMDEwMDAwOyAvLyBJdCdzIGRlZmluaXRlbHkg YSBKU1N0cmluZy4KK3N0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBlIFByZWRpY3RDZWxsT3RoZXIg ICAgICAgICA9IDB4MDAwMjAwMDA7IC8vIEl0J3MgZGVmaW5pdGVseSBhIEpTQ2VsbCBidXQgbm90 IGEgc3ViY2xhc3Mgb2YgSlNPYmplY3QgYW5kIGRlZmluaXRlbHkgbm90IGEgSlNTdHJpbmcuCitz dGF0aWMgY29uc3QgUHJlZGljdGVkVHlwZSBQcmVkaWN0Q2VsbCAgICAgICAgICAgICAgPSAweDAw MDNmZmZmOyAvLyBJdCdzIGRlZmluaXRlbHkgYSBKU0NlbGwuCitzdGF0aWMgY29uc3QgUHJlZGlj dGVkVHlwZSBQcmVkaWN0SW50MzIgICAgICAgICAgICAgPSAweDAwODAwMDAwOyAvLyBJdCdzIGRl ZmluaXRlbHkgYW4gSW50MzIuCitzdGF0aWMgY29uc3QgUHJlZGljdGVkVHlwZSBQcmVkaWN0RG91 YmxlUmVhbCAgICAgICAgPSAweDAxMDAwMDAwOyAvLyBJdCdzIGRlZmluaXRlbHkgYSBub24tTmFO IGRvdWJsZS4KK3N0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBlIFByZWRpY3REb3VibGVOYU4gICAg ICAgICA9IDB4MDIwMDAwMDA7IC8vIEl0J3MgZGVmaW5pdGVseSBhIE5hTi4KK3N0YXRpYyBjb25z dCBQcmVkaWN0ZWRUeXBlIFByZWRpY3REb3VibGUgICAgICAgICAgICA9IDB4MDMwMDAwMDA7IC8v IEl0J3MgZWl0aGVyIGEgbm9uLU5hTiBvciBhIE5hTiBkb3VibGUuCitzdGF0aWMgY29uc3QgUHJl ZGljdGVkVHlwZSBQcmVkaWN0TnVtYmVyICAgICAgICAgICAgPSAweDAzODAwMDAwOyAvLyBJdCdz IGVpdGhlciBhbiBJbnQzMiBvciBhIERvdWJsZS4KK3N0YXRpYyBjb25zdCBQcmVkaWN0ZWRUeXBl IFByZWRpY3RCb29sZWFuICAgICAgICAgICA9IDB4MDQwMDAwMDA7IC8vIEl0J3MgZGVmaW5pdGVs eSBhIEJvb2xlYW4uCiBzdGF0aWMgY29uc3QgUHJlZGljdGVkVHlwZSBQcmVkaWN0T3RoZXIgICAg ICAgICAgICAgPSAweDA4MDAwMDAwOyAvLyBJdCdzIGRlZmluaXRlbHkgbm9uZSBvZiB0aGUgYWJv dmUuCiBzdGF0aWMgY29uc3QgUHJlZGljdGVkVHlwZSBQcmVkaWN0VG9wICAgICAgICAgICAgICAg PSAweDBmZmZmZmZmOyAvLyBJdCBjYW4gYmUgYW55IG9mIHRoZSBhYm92ZS4KIHN0YXRpYyBjb25z dCBQcmVkaWN0ZWRUeXBlIFByZWRpY3RFbXB0eSAgICAgICAgICAgICA9IDB4MTAwMDAwMDA7IC8v IEl0J3MgZGVmaW5pdGVseSBhbiBlbXB0eSB2YWx1ZSBtYXJrZXIuCkBAIC0yMDUsNiArMjA4LDE2 IEBAIGlubGluZSBib29sIGlzQXJyYXlPck90aGVyUHJlZGljdGlvbihQcmUKICAgICByZXR1cm4g ISEodmFsdWUgJiAoUHJlZGljdEFycmF5IHwgUHJlZGljdE90aGVyKSkgJiYgISh2YWx1ZSAmIH4o UHJlZGljdEFycmF5IHwgUHJlZGljdE90aGVyKSk7CiB9CiAKK2lubGluZSBib29sIGlzTXlBcmd1 bWVudHNQcmVkaWN0aW9uKFByZWRpY3RlZFR5cGUgdmFsdWUpCit7CisgICAgcmV0dXJuIHZhbHVl ID09IFByZWRpY3RNeUFyZ3VtZW50czsKK30KKworaW5saW5lIGJvb2wgaXNBcmd1bWVudHNQcmVk aWN0aW9uKFByZWRpY3RlZFR5cGUgdmFsdWUpCit7CisgICAgcmV0dXJuICEhdmFsdWUgJiYgKHZh bHVlICYgUHJlZGljdEFyZ3VtZW50cykgPT0gdmFsdWU7Cit9CisKIGlubGluZSBib29sIGlzSW50 MzJQcmVkaWN0aW9uKFByZWRpY3RlZFR5cGUgdmFsdWUpCiB7CiAgICAgcmV0dXJuIHZhbHVlID09 IFByZWRpY3RJbnQzMjsK