8514 2006-04-21 07:26:01 -0700 Web Inspector hides when the app is in the background 2006-04-22 16:44:38 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 420+ Mac OS X 10.4 RESOLVED FIXED P2 Minor --- 1 matt timothy oldest_to_newest 40023 0 matt 2006-04-21 07:26:01 -0700 Often when I am debugging my own app, I keep the same web page open in Safari with the Web Inspector open. This way I can easily inspect the same DOM that I am stepping through in the debugger. However, it is annoying that that window hides itself when Safari is not at the front as I have to keep switching between the debugger in XCode and Safari. Therefore I have created a patch which adds a 'Hides in Background' option to the pop-up menu show in the top-right corner of the Inspector. 40024 1 7869 matt 2006-04-21 07:29:06 -0700 Created attachment 7869 Adds a 'Hides in Background' menu item to the Web Inspector window 40084 2 7869 darin 2006-04-21 22:07:10 -0700 Comment on attachment 7869 Adds a 'Hides in Background' menu item to the Web Inspector window Do we really need a menu item for this? Can't we just decide which way it should work? 40085 3 darin 2006-04-21 22:07:51 -0700 I'm thinking it's better to just change the setting to not hide in background. We should ask Tim Hatcher what he thinks. 40109 4 hyatt 2006-04-21 23:59:58 -0700 I personally think the default should be not to hide. I can't stand that behavior in "debugging" windows like the Snippet Editor and the Web Inspector, since often you need to look at them while bringing another app to the front. 40137 5 matt 2006-04-22 03:20:43 -0700 I did consider just setting it to not hide, but maybe some people like the behaviour. Personally I would default it to not hiding, but keep the menu in case people need it to for some reason. Its not as if it takes up any extra space in the UI 40176 6 mjs 2006-04-22 13:15:53 -0700 I agree that we should just change the behavior to not hide in the background. That seems better than the menu. I don't think there's a great need to offer the hiding behavior as well. 40190 7 7869 darin 2006-04-22 14:37:56 -0700 Comment on attachment 7869 Adds a 'Hides in Background' menu item to the Web Inspector window We have consensus now that we want to turn hidesOnDeactivate off completely rather than adding a menu item. Also need a change log entry. 40198 8 7917 timothy 2006-04-22 16:32:56 -0700 Created attachment 7917 New patch Makes the inspector not hide in the background. Since the inspector is a floating panel we need to call setFloatingPanel:NO when the app is switching into the background. Then call setFloatingPanel:YES when the app is activated again. Withouth this the inspector would float above all applications. 40199 9 7917 eric 2006-04-22 16:43:12 -0700 Comment on attachment 7917 New patch Looks fine. r=me. 40200 10 timothy 2006-04-22 16:44:38 -0700 Landed in r14020. 7869 2006-04-21 07:29:06 -0700 2006-04-22 16:32:56 -0700 Adds a 'Hides in Background' menu item to the Web Inspector window MyExcellentPatch.txt text/plain 1133 matt SW5kZXg6IFdlYktpdC9XZWJJbnNwZWN0b3IvV2ViSW5zcGVjdG9yLm0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L1dlYkluc3BlY3Rvci9XZWJJbnNwZWN0b3IubQkocmV2aXNpb24gMTM5ODYpCisrKyBX ZWJLaXQvV2ViSW5zcGVjdG9yL1dlYkluc3BlY3Rvci5tCSh3b3JraW5nIGNvcHkpCkBAIC0zMDMs NiArMzAzLDEzIEBAIHN0YXRpYyBOU01hcFRhYmxlICpsYXN0Q2hpbGRJZ25vcmluZ1doaXQKICAg ICBbaXRlbSBzZXRBY3Rpb246QHNlbGVjdG9yKF90b2dnbGVJZ25vcmVXaGl0ZXNwYWNlOildOwog ICAgIFtpdGVtIHNldFN0YXRlOl9wcml2YXRlLT5pZ25vcmVXaGl0ZXNwYWNlXTsKICAgICBbbWVu dSBhZGRJdGVtOml0ZW1dOworICAgIAorICAgIGl0ZW0gPSBbW1tOU01lbnVJdGVtIGFsbG9jXSBp bml0XSBhdXRvcmVsZWFzZV07CisgICAgW2l0ZW0gc2V0VGl0bGU6QCJIaWRlcyBpbiBCYWNrZ3Jv dW5kIl07CisgICAgW2l0ZW0gc2V0VGFyZ2V0OnNlbGZdOworICAgIFtpdGVtIHNldEFjdGlvbjpA c2VsZWN0b3IoX3RvZ2dsZUhpZGVzSW5CYWNrZ3JvdW5kOildOworICAgIFtpdGVtIHNldFN0YXRl Oltbc2VsZiB3aW5kb3ddIGhpZGVzT25EZWFjdGl2YXRlXV07CisgICAgW21lbnUgYWRkSXRlbTpp dGVtXTsKIAogICAgIFtOU01lbnUgcG9wVXBDb250ZXh0TWVudTptZW51IHdpdGhFdmVudDpbW3Nl bGYgd2luZG93XSBjdXJyZW50RXZlbnRdIGZvclZpZXc6X3ByaXZhdGUtPndlYlZpZXddOwogICAg IFttZW51IHJlbGVhc2VdOwpAQCAtNTA4LDYgKzUxNSwxMSBAQCBzdGF0aWMgTlNNYXBUYWJsZSAq bGFzdENoaWxkSWdub3JpbmdXaGl0CiAgICAgW3NlbGYgX3VwZGF0ZVRyZWVTY3JvbGxiYXJdOwog fQogCistIChJQkFjdGlvbilfdG9nZ2xlSGlkZXNJbkJhY2tncm91bmQ6KGlkKXNlbmRlcgorewor ICAgIFtbc2VsZiB3aW5kb3ddIHNldEhpZGVzT25EZWFjdGl2YXRlOiFbW3NlbGYgd2luZG93XSBo aWRlc09uRGVhY3RpdmF0ZV1dOworfQorCiAtICh2b2lkKV9oaWdobGlnaHROb2RlOihET01Ob2Rl ICopbm9kZQogewogICAgIGlmIChfcHJpdmF0ZS0+Y3VycmVudEhpZ2hsaWdodCkgewo= 7917 2006-04-22 16:32:56 -0700 2006-04-22 16:43:12 -0700 New patch 8514.patch text/plain 3610 timothy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDE5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDYtMDQt MjIgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFy d2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUxNAorICAgICAgICBCdWcgODUxNDogV2ViIEluc3Bl Y3RvciBoaWRlcyB3aGVuIHRoZSBhcHAgaXMgaW4gdGhlIGJhY2tncm91bmQKKworICAgICAgICBN YWtlcyB0aGUgaW5zcGVjdG9yIG5vdCBoaWRlIGluIHRoZSBiYWNrZ3JvdW5kLiBTaW5jZSB0aGUg aW5zcGVjdG9yIGlzIGEgZmxvYXRpbmcgcGFuZWwKKyAgICAgICAgd2UgbmVlZCB0byBjYWxsIHNl dEZsb2F0aW5nUGFuZWw6Tk8gd2hlbiB0aGUgYXBwIGlzIHN3aXRjaGluZyBpbnRvIHRoZSBiYWNr Z3JvdW5kLiBUaGVuCisgICAgICAgIGNhbGwgc2V0RmxvYXRpbmdQYW5lbDpZRVMgd2hlbiB0aGUg YXBwIGlzIGFjdGl2YXRlZCBhZ2Fpbi4gV2l0aG91dCB0aGlzIHRoZSBpbnNwZWN0b3IKKyAgICAg ICAgd291bGQgZmxvYXQgYWJvdmUgYWxsIGFwcGxpY2F0aW9ucy4KKworICAgICAgICAqIFdlYklu c3BlY3Rvci9XZWJJbnNwZWN0b3IubToKKyAgICAgICAgKC1bTlNXaW5kb3cgd2luZG93XSk6IHNl dEhpZGVzT25EZWFjdGl2YXRlOk5PCisgICAgICAgICgtW05TV2luZG93IHdpbmRvd1dpbGxDbG9z ZTpdKTogZGVyZXNpc2VyIGFwcGxpY3Rpb24gYWN0aXZlIG5vdGlmaWNhdGlvbnMKKyAgICAgICAg KC1bTlNXaW5kb3cgc2hvd1dpbmRvdzpdKTogcmVnaXN0ZXIgZm9yIGFwcGxpY3Rpb24gYWN0aXZl IG5vdGlmaWNhdGlvbnMKKyAgICAgICAgKC1bV2ViSW5zcGVjdG9yIF9hcHBsaWNhdGlvbldpbGxS ZXNpZ25BY3RpdmVdKTogc2V0RmxvYXRpbmdQYW5lbDpOTworICAgICAgICAoLVtXZWJJbnNwZWN0 b3IgX2FwcGxpY2F0aW9uRGlkQmVjb21lQWN0aXZlXSk6IHNldEZsb2F0aW5nUGFuZWw6WUVTCisK IDIwMDYtMDQtMjEgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhcmluLgpJbmRleDogV2ViSW5zcGVjdG9yL1dlYkluc3BlY3Rvci5tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkluc3BlY3Rvci9XZWJJbnNwZWN0b3IubQkocmV2aXNpb24gMTQwMTkp CisrKyBXZWJJbnNwZWN0b3IvV2ViSW5zcGVjdG9yLm0JKHdvcmtpbmcgY29weSkKQEAgLTExMyw2 ICsxMTMsNyBAQCBzdGF0aWMgTlNNYXBUYWJsZSAqbGFzdENoaWxkSWdub3JpbmdXaGl0CiAgICAg ICAgIFt3aW5kb3cgc2V0RmxvYXRpbmdQYW5lbDpZRVNdOwogICAgICAgICBbd2luZG93IHNldFJl bGVhc2VkV2hlbkNsb3NlZDpZRVNdOwogICAgICAgICBbd2luZG93IHNldE1vdmFibGVCeVdpbmRv d0JhY2tncm91bmQ6WUVTXTsKKyAgICAgICAgW3dpbmRvdyBzZXRIaWRlc09uRGVhY3RpdmF0ZTpO T107CiAgICAgICAgIFt3aW5kb3cgc2V0RGVsZWdhdGU6c2VsZl07CiAgICAgICAgIFt3aW5kb3cg c2V0TWluU2l6ZTpOU01ha2VTaXplKDI4MC4wLCA0NTAuMCldOwogCkBAIC0xMzgsNiArMTM5LDgg QEAgc3RhdGljIE5TTWFwVGFibGUgKmxhc3RDaGlsZElnbm9yaW5nV2hpdAogCiAtICh2b2lkKXdp bmRvd1dpbGxDbG9zZTooTlNOb3RpZmljYXRpb24gKilub3RpZmljYXRpb24KIHsKKyAgICBbW05T Tm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIHJlbW92ZU9ic2VydmVyOnNlbGYgbmFt ZTpOU0FwcGxpY2F0aW9uV2lsbFJlc2lnbkFjdGl2ZU5vdGlmaWNhdGlvbiBvYmplY3Q6bmlsXTsK KyAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIHJlbW92ZU9ic2VydmVy OnNlbGYgbmFtZTpOU0FwcGxpY2F0aW9uRGlkQmVjb21lQWN0aXZlTm90aWZpY2F0aW9uIG9iamVj dDpuaWxdOwogICAgIFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gcmVtb3Zl T2JzZXJ2ZXI6c2VsZiBuYW1lOldlYk5vZGVIaWdobGlnaHRFeHBpcmVkTm90aWZpY2F0aW9uIG9i amVjdDpuaWxdOwogICAgIFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gcmVt b3ZlT2JzZXJ2ZXI6c2VsZiBuYW1lOk5TVmlld0ZyYW1lRGlkQ2hhbmdlTm90aWZpY2F0aW9uIG9i amVjdDpuaWxdOwogICAgIFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gcmVt b3ZlT2JzZXJ2ZXI6c2VsZiBuYW1lOk5TU3lzdGVtQ29sb3JzRGlkQ2hhbmdlTm90aWZpY2F0aW9u IG9iamVjdDpuaWxdOwpAQCAtMTUwLDYgKzE1Myw4IEBAIHN0YXRpYyBOU01hcFRhYmxlICpsYXN0 Q2hpbGRJZ25vcmluZ1doaXQKIHsKICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRD ZW50ZXJdIGFkZE9ic2VydmVyOnNlbGYgc2VsZWN0b3I6QHNlbGVjdG9yKF9ub2RlSGlnaGxpZ2h0 RXhwaXJlZDopIG5hbWU6V2ViTm9kZUhpZ2hsaWdodEV4cGlyZWROb3RpZmljYXRpb24gb2JqZWN0 Om5pbF07CiAgICAgW1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSBhZGRPYnNl cnZlcjpzZWxmIHNlbGVjdG9yOkBzZWxlY3RvcihfdXBkYXRlU3lzdGVtQ29sb3JzKSBuYW1lOk5T U3lzdGVtQ29sb3JzRGlkQ2hhbmdlTm90aWZpY2F0aW9uIG9iamVjdDpuaWxdOworICAgIFtbTlNO b3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gYWRkT2JzZXJ2ZXI6c2VsZiBzZWxlY3Rv cjpAc2VsZWN0b3IoX2FwcGxpY2F0aW9uV2lsbFJlc2lnbkFjdGl2ZSkgbmFtZTpOU0FwcGxpY2F0 aW9uV2lsbFJlc2lnbkFjdGl2ZU5vdGlmaWNhdGlvbiBvYmplY3Q6bmlsXTsKKyAgICBbW05TTm90 aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIGFkZE9ic2VydmVyOnNlbGYgc2VsZWN0b3I6 QHNlbGVjdG9yKF9hcHBsaWNhdGlvbkRpZEJlY29tZUFjdGl2ZSkgbmFtZTpOU0FwcGxpY2F0aW9u RGlkQmVjb21lQWN0aXZlTm90aWZpY2F0aW9uIG9iamVjdDpuaWxdOwogCiAgICAgW3NlbGYgX3Vw ZGF0ZV07CiAgICAgW3NlbGYgX3VwZGF0ZVN5c3RlbUNvbG9yc107CkBAIC03NDYsNiArNzUxLDE2 IEBAIHN0YXRpYyBOU01hcFRhYmxlICpsYXN0Q2hpbGRJZ25vcmluZ1doaXQKICAgICBbc3R5bGUg c2V0VGV4dENvbnRlbnQ6c3R5bGVUZXh0XTsKIH0KIAorLSAodm9pZClfYXBwbGljYXRpb25XaWxs UmVzaWduQWN0aXZlCit7CisgICAgWyhOU1BhbmVsICopW3NlbGYgd2luZG93XSBzZXRGbG9hdGlu Z1BhbmVsOk5PXTsKK30KKworLSAodm9pZClfYXBwbGljYXRpb25EaWRCZWNvbWVBY3RpdmUKK3sK KyAgICBbKE5TUGFuZWwgKilbc2VsZiB3aW5kb3ddIHNldEZsb2F0aW5nUGFuZWw6WUVTXTsKK30K KwogI3ByYWdtYSBtYXJrIC0KIAogKyAoQk9PTClpc1NlbGVjdG9yRXhjbHVkZWRGcm9tV2ViU2Ny aXB0OihTRUwpYVNlbGVjdG9yCg==