85115 2012-04-27 18:05:15 -0700 Remove SHADER_COMPILER constant 2012-04-27 20:20:14 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr abarth dino gman jamesr ojan webkit.review.bot zmo oldest_to_newest 612054 0 kbr 2012-04-27 18:05:15 -0700 The SHADER_COMPILER constant was removed from the WebGL spec some time ago, but its removal wasn't verified by the conformance suite. It is being now, and needs to be removed from WebKit's implementation. 612056 1 139312 kbr 2012-04-27 18:07:50 -0700 Created attachment 139312 Patch 612058 2 139312 darin 2012-04-27 18:12:32 -0700 Comment on attachment 139312 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139312&action=review > LayoutTests/fast/canvas/webgl/constants.html:449 > +NUM_COMPRESSED_TEXTURE_FORMATS : 0x86A2, > +FIXED : 0x140C, > +ACTIVE_UNIFORM_MAX_LENGTH : 0x8B87, > +ACTIVE_ATTRIBUTE_MAX_LENGTH : 0x8B8A, > +EXTENSIONS : 0x1F03, > +INFO_LOG_LENGTH : 0x8B84, > +SHADER_SOURCE_LENGTH : 0x8B88, > +SHADER_COMPILER : 0x8DFA, > +SHADER_BINARY_FORMATS : 0x8DF8, > +NUM_SHADER_BINARY_FORMATS : 0x8DF9, Heh, it’s funny to have the actual values here for the removed constants. 612059 3 kbr 2012-04-27 18:19:20 -0700 (In reply to comment #2) > Heh, it’s funny to have the actual values here for the removed constants. Yeah, maybe that was dumb of me... 612111 4 139312 webkit.review.bot 2012-04-27 20:20:09 -0700 Comment on attachment 139312 Patch Clearing flags on attachment: 139312 Committed r115531: <http://trac.webkit.org/changeset/115531> 612112 5 webkit.review.bot 2012-04-27 20:20:14 -0700 All reviewed patches have been landed. Closing bug. 139312 2012-04-27 18:07:50 -0700 2012-04-27 20:20:09 -0700 Patch bug-85115-20120427180749.patch text/plain 4890 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZhY2NmMTJhMzdkYmFi ZDU1MmY2YjQ2ODgxOGEwYmNkNWEzYjg3ZC4uMTQ2YWY0NWRmNDExZGZhOTBkZmRiYjAyMDIwYWYx ODUzNmNmNGYxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTI3ICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZW1vdmUgU0hBREVSX0NP TVBJTEVSIGNvbnN0YW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04NTExNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZWQgY29uc3RhbnQgd2hpY2ggd2FzIHByZXZpb3VzbHkgcmVtb3ZlZCBmcm9t IHNwZWMuIFVwZGF0ZWQKKyAgICAgICAgbGF5b3V0IHRlc3QgYW5kIGV4cGVjdGVkIHJlc3VsdHMu CisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaWRsOgorCiAy MDEyLTA0LTI3ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbQ2hyb21pdW1dIENhbGwgbG93TWVtb3J5VXNhZ2VNQiBkaXJlY3RseQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGwKaW5kZXgg MWNkOTk0MTMyZDkyMjViNGRkM2VlYjA2M2NjZmE1MjJiZTFhMGE5NC4uOWYwODkzZmUzNTVhNTQ5 ZDYyNzNhZDFjMWEwZWQzZGEwZDk4OGE3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaWRsCkBAIC0zODQsNyArMzg0LDYgQEAg bW9kdWxlIGh0bWwgewogCiAgICAgICAgIC8qIFNoYWRlciBTb3VyY2UgKi8KICAgICAgICAgY29u c3QgdW5zaWduZWQgaW50IENPTVBJTEVfU1RBVFVTICAgICAgICAgICAgICAgICA9IDB4OEI4MTsK LSAgICAgICAgY29uc3QgdW5zaWduZWQgaW50IFNIQURFUl9DT01QSUxFUiAgICAgICAgICAgICAg ICA9IDB4OERGQTsKIAogICAgICAgICAvKiBTaGFkZXIgUHJlY2lzaW9uLVNwZWNpZmllZCBUeXBl cyAqLwogICAgICAgICBjb25zdCB1bnNpZ25lZCBpbnQgTE9XX0ZMT0FUICAgICAgICAgICAgICAg ICAgICAgID0gMHg4REYwOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDJlZDMzYjhhNDBkMzcyNGZjODEyYzJmYWUxOTVlYjdh ZWIyMDI5NjUuLjA0ODFjOGRiYmY5OGJhZjhkMWQ5Yzc1ZGExZGYxZTM3OTQ4OTMxZGEgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNC0yNyAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIFNIQURFUl9DT01QSUxFUiBjb25zdGFudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUxMTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY2FudmFzL3dl YmdsL2NvbnN0YW50cy1leHBlY3RlZC50eHQ6IFVwZGF0ZWQgZXhwZWN0ZWQgcmVzdWx0cy4KKyAg ICAgICAgKiBmYXN0L2NhbnZhcy93ZWJnbC9jb25zdGFudHMuaHRtbDogU3luY2VkIHRlc3Qgd2l0 aCBLaHJvbm9zIHJlcG9zaXRvcnkuCisKIDIwMTItMDQtMjcgIFlpIFNoZW4gIDx5aS40LnNoZW5A bm9raWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04oMTEzNzIzKTogUHJlc3NpbmcgZW50ZXIg aW4gdGhpcyBsaXN0IGV4YW1wbGUgZGVsZXRlcyB0aGUgd2hvbGUgbGlzdApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvY29uc3RhbnRzLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2NvbnN0YW50cy1leHBlY3RlZC50eHQKaW5kZXgg ODJkMjc5YzZlZTAxZDk1YzkyYWIwZTEyZWE2MWQzNjk3YjgxOTZiMi4uZGQ5NTRkOTEzYjQ2NjE2 YTdiNDE4MGEzODg2MDMxM2IyY2VkYzMwNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvd2ViZ2wvY29uc3RhbnRzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2NhbnZhcy93ZWJnbC9jb25zdGFudHMtZXhwZWN0ZWQudHh0CkBAIC01LDYgKzUsNyBAQCBPbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURQogCiBDYW52YXMuZ2V0Q29udGV4dAogUEFTUyBBbGwgV2ViR0wg Y29uc3RhbnRzIGZvdW5kIHRvIGhhdmUgY29ycmVjdCB2YWx1ZXMuCitQQVNTIEFsbCBjb25zdGFu dHMgcmVtb3ZlZCBmcm9tIFdlYkdMIHNwZWMgd2VyZSBhYnNlbnQgZnJvbSBXZWJHTCBjb250ZXh0 LgogCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2NvbnN0YW50cy5odG1sIGIvTGF5b3V0VGVzdHMvZmFz dC9jYW52YXMvd2ViZ2wvY29uc3RhbnRzLmh0bWwKaW5kZXggZjM2YzViZmNjMWU0ZDAxMzYzMmU0 NWJkYzViYTQ4OGZlZDUzNDgwZC4uNzVjMDkwMzFmYWQ5ZWI0ZjYyZTMyMjU0YzUxNzQ2MjU2MzAz NGMxYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvY29uc3RhbnRz Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvY29uc3RhbnRzLmh0bWwK QEAgLTM3Miw3ICszNzIsNiBAQCBWRVJURVhfQVRUUklCX0FSUkFZX0JVRkZFUl9CSU5ESU5HIDog MHg4ODlGLAogICAgIAogICAgIC8qIFNoYWRlciBTb3VyY2UgKi8KIENPTVBJTEVfU1RBVFVTICAg ICAgICAgICAgICAgICA6IDB4OEI4MSwKLVNIQURFUl9DT01QSUxFUiAgICAgICAgICAgICAgICA6 IDB4OERGQSwKICAgICAKICAgICAvKiBTaGFkZXIgUHJlY2lzaW9uLVNwZWNpZmllZCBUeXBlcyAq LwogTE9XX0ZMT0FUICAgICAgICAgICAgICAgICAgICAgIDogMHg4REYwLApAQCAtNDM2LDEwICs0 MzUsMzMgQEAgVU5QQUNLX0NPTE9SU1BBQ0VfQ09OVkVSU0lPTl9XRUJHTCA6IDB4OTI0MywKIEJS T1dTRVJfREVGQVVMVF9XRUJHTCAgICAgICAgICAgICAgOiAweDkyNDQKIH07CiAKKy8vIENvbnN0 YW50cyByZW1vdmVkIGZyb20gdGhlIFdlYkdMIHNwZWMgY29tcGFyZWQgdG8gRVMgMi4wCit2YXIg cmVtb3ZlZENvbnN0YW50cyA9IHsKK05VTV9DT01QUkVTU0VEX1RFWFRVUkVfRk9STUFUUyA6IDB4 ODZBMiwKK0ZJWEVEICAgICAgICAgICAgICAgICAgICAgICAgICA6IDB4MTQwQywKK0FDVElWRV9V TklGT1JNX01BWF9MRU5HVEggICAgICA6IDB4OEI4NywKK0FDVElWRV9BVFRSSUJVVEVfTUFYX0xF TkdUSCAgICA6IDB4OEI4QSwKK0VYVEVOU0lPTlMgICAgICAgICAgICAgICAgICAgICA6IDB4MUYw MywKK0lORk9fTE9HX0xFTkdUSCAgICAgICAgICAgICAgICA6IDB4OEI4NCwKK1NIQURFUl9TT1VS Q0VfTEVOR1RIICAgICAgICAgICA6IDB4OEI4OCwKK1NIQURFUl9DT01QSUxFUiAgICAgICAgICAg ICAgICA6IDB4OERGQSwKK1NIQURFUl9CSU5BUllfRk9STUFUUyAgICAgICAgICA6IDB4OERGOCwK K05VTV9TSEFERVJfQklOQVJZX0ZPUk1BVFMgICAgICA6IDB4OERGOSwKK307CisKIGZ1bmN0aW9u IGFzc2VydFByb3BlcnR5KHYsIHApIHsKLSAgaWYgKHZbcF0gPT0gbnVsbCkgeworICBpZiAocCBp biB2KSB7CisgICAgcmV0dXJuIHRydWU7CisgIH0gZWxzZSB7CiAgICAgdGVzdEZhaWxlZCgiUHJv cGVydHkgZG9lcyBub3QgZXhpc3Q6ICIgKyBwKQogICAgIHJldHVybiBmYWxzZTsKKyAgfQorfQor CitmdW5jdGlvbiBhc3NlcnROb1Byb3BlcnR5KHYsIHApIHsKKyAgaWYgKHAgaW4gdikgeworICAg IHRlc3RGYWlsZWQoIlByb3BlcnR5IGlzIGRlZmluZWQgYW5kIHNob3VsZCBub3QgYmU6ICIgKyBw KQorICAgIHJldHVybiBmYWxzZTsKICAgfSBlbHNlIHsKICAgICByZXR1cm4gdHJ1ZTsKICAgfQpA QCAtNDY0LDYgKzQ4NiwxNCBAQCBmb3IgKHZhciBpIGluIGNvbnN0YW50cykgewogaWYgKHBhc3Nl ZCkgewogICB0ZXN0UGFzc2VkKCJBbGwgV2ViR0wgY29uc3RhbnRzIGZvdW5kIHRvIGhhdmUgY29y cmVjdCB2YWx1ZXMuIik7CiB9CitwYXNzZWQgPSB0cnVlOworZm9yICh2YXIgaSBpbiByZW1vdmVk Q29uc3RhbnRzKSB7CisgIHZhciByID0gYXNzZXJ0Tm9Qcm9wZXJ0eShnbCwgaSk7CisgIHBhc3Nl ZCA9IHBhc3NlZCAmJiByOworfQoraWYgKHBhc3NlZCkgeworICB0ZXN0UGFzc2VkKCJBbGwgY29u c3RhbnRzIHJlbW92ZWQgZnJvbSBXZWJHTCBzcGVjIHdlcmUgYWJzZW50IGZyb20gV2ViR0wgY29u dGV4dC4iKTsKK30KIHZhciBleHRlbmRlZCA9IGZhbHNlOwogZm9yICh2YXIgaSBpbiBnbCkgewog ICBpZiAoaS5tYXRjaCgvXlteYS16XS8pICYmIGNvbnN0YW50c1tpXSA9PSBudWxsKSB7CkBAIC00 NzgsOCArNTA4LDYgQEAgZm9yICh2YXIgaSBpbiBnbCkgewogZGVidWcoIiIpOwogPC9zY3JpcHQ+ CiA8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3Jp cHQ+Ci08c2NyaXB0PgotPC9zY3JpcHQ+CiAKIDwvYm9keT4KIDwvaHRtbD4K