85105 2012-04-27 15:49:09 -0700 Fullscreen pop-up logic restored to using processingUserGesture. [Regression] 2012-05-01 21:27:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 scheib scheib abarth apavlov inferno jer.noble webkit.review.bot oldest_to_newest 611963 0 scheib 2012-04-27 15:49:09 -0700 Fullscreen pop-up logic restored to using processingUserGesture. 611970 1 139297 scheib 2012-04-27 16:00:14 -0700 Created attachment 139297 Patch 612011 2 139297 jer.noble 2012-04-27 16:37:56 -0700 Comment on attachment 139297 Patch This change looks good to me. The mismatch between domWindow->allowPopups() and the spec is well documented in this new comment. 612012 3 139297 jer.noble 2012-04-27 16:37:57 -0700 Comment on attachment 139297 Patch This change looks good to me. The mismatch between domWindow->allowPopups() and the spec is well documented in this new comment. 613951 4 139297 webkit.review.bot 2012-05-01 21:27:32 -0700 Comment on attachment 139297 Patch Clearing flags on attachment: 139297 Committed r115792: <http://trac.webkit.org/changeset/115792> 613952 5 webkit.review.bot 2012-05-01 21:27:46 -0700 All reviewed patches have been landed. Closing bug. 139297 2012-04-27 16:00:14 -0700 2012-05-01 21:27:32 -0700 Patch bug-85105-20120427160012.patch text/plain 2588 scheib U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUyMjY2MGEzMDI3ZDAw NzBjNWMxMGU1MTIzYWI4ZWM1MTI4MTI4Yi4uYzA5MWQxMTNlMGMwMjQzMWZmYTQ3ODhhOGFhYTNj NzMwNDUwNzJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA0LTI3ICBWaW5j ZW50IFNjaGVpYiAgPHNjaGVpYkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRnVsbHNjcmVlbiBw b3AtdXAgbG9naWMgcmVzdG9yZWQgdG8gdXNpbmcgcHJvY2Vzc2luZ1VzZXJHZXN0dXJlLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUxMDUKKworICAg ICAgICBXZWJLaXQgd2FzIHJlY2VudGx5IHVwZGF0ZWQgdG8gdGhlIG5ldyBGdWxsc2NyZWVuIEFQ SToKKyAgICAgICAgaHR0cDovL2R2Y3MudzMub3JnL2hnL2Z1bGxzY3JlZW4vcmF3LWZpbGUvdGlw L092ZXJ2aWV3Lmh0bWwjYXBpCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzExMTAyOAorCisgICAgICAgIFRoaXMgY2hhbmdlIHJldmVydHMgYmFjayB0byB1c2luZyBw cm9jZXNzaW5nVXNlckdlc3R1cmUoKSBpbnN0ZWFkCisgICAgICAgIG9mIERPTVdpbmRvdzo6YWxs b3dQb3BVcCgpLiBUaGlzIGZpeGVzIGluY29ycmVjdCBiZWhhdmlvciBpbgorICAgICAgICBhdCBs ZWFzdCB0aGUgQ2hyb21pdW0gcG9ydCBhbmQgaXMgY29uc2lzdGVudCB3aXRoIHRoZSBjaXRlZAor ICAgICAgICBkZWZpbml0aW9uIG9mICJhbGxvd2VkIHRvIHNob3cgYSBwb3AtdXAiOgorICAgICAg ICAgIEFuIGFsZ29yaXRobSBpcyBhbGxvd2VkIHRvIHNob3cgYSBwb3AtdXAgaWYsIGluIHRoZSB0 YXNrIGluIHdoaWNoIHRoZSBhbGdvcml0aG0gaXMgcnVubmluZywgZWl0aGVyOgorICAgICAgICAg IC0gYW4gYWN0aXZhdGlvbiBiZWhhdmlvciBpcyBjdXJyZW50bHkgYmVpbmcgcHJvY2Vzc2VkIHdo b3NlIGNsaWNrIGV2ZW50IHdhcyB0cnVzdGVkLCBvcgorICAgICAgICAgIC0gdGhlIGV2ZW50IGxp c3RlbmVyIGZvciBhIHRydXN0ZWQgY2xpY2sgZXZlbnQgaXMgYmVpbmcgaGFuZGxlZC4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMu CisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnQ6OnJlcXVlc3RGdWxsU2NyZWVuRm9yRWxlbWVudCk6CisKIDIwMTItMDQtMjcgIFphbiBEb2Jl cnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAgICAgICBbR3RrXVtET00gQmluZGlu Z3NdIENvbmRpdGlvbmFsIHN0cmluZyBpbiBpbXBsZW1lbnRhdGlvbiBmaWxlIGdlbmVyYXRlZCBp biB3cm9uZyBwbGFjZSBhZnRlciAxMTM0NTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGUy ZGFiNTQ5OGZmMzJkNmVmNWQ5NTg3ZmNhNzA4MzUxMzZjNTVjMzAuLjllNTFhYzBiMDQyMjM5ZmJh ZGRlOTc0MTEyOGU1ODQyNDhmNzVmZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNTI5 OSw4ICs1Mjk5LDExIEBAIHZvaWQgRG9jdW1lbnQ6OnJlcXVlc3RGdWxsU2NyZWVuRm9yRWxlbWVu dChFbGVtZW50KiBlbGVtZW50LCB1bnNpZ25lZCBzaG9ydCBmbGFnCiAgICAgICAgIGlmIChkZXNj ZW5kZW50SGFzTm9uRW1wdHlTdGFjayAmJiAhaW5MZWdhY3lNb3ppbGxhTW9kZSkKICAgICAgICAg ICAgIGJyZWFrOwogCi0gICAgICAgIC8vIFRoaXMgYWxnb3JpdGhtIGlzIG5vdCBhbGxvd2VkIHRv IHNob3cgYSBwb3AtdXAuCi0gICAgICAgIGlmICghZG9tV2luZG93KCktPmFsbG93UG9wVXAoKSkK KyAgICAgICAgLy8gVGhpcyBhbGdvcml0aG0gaXMgbm90IGFsbG93ZWQgdG8gc2hvdyBhIHBvcC11 cDoKKyAgICAgICAgLy8gICBBbiBhbGdvcml0aG0gaXMgYWxsb3dlZCB0byBzaG93IGEgcG9wLXVw IGlmLCBpbiB0aGUgdGFzayBpbiB3aGljaCB0aGUgYWxnb3JpdGhtIGlzIHJ1bm5pbmcsIGVpdGhl cjoKKyAgICAgICAgLy8gICAtIGFuIGFjdGl2YXRpb24gYmVoYXZpb3IgaXMgY3VycmVudGx5IGJl aW5nIHByb2Nlc3NlZCB3aG9zZSBjbGljayBldmVudCB3YXMgdHJ1c3RlZCwgb3IKKyAgICAgICAg Ly8gICAtIHRoZSBldmVudCBsaXN0ZW5lciBmb3IgYSB0cnVzdGVkIGNsaWNrIGV2ZW50IGlzIGJl aW5nIGhhbmRsZWQuCisgICAgICAgIGlmICghU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2luZ1Vz ZXJHZXN0dXJlKCkpCiAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICAvLyBUaGVyZSBpcyBh IHByZXZpb3VzbHktZXN0YWJsaXNoZWQgdXNlciBwcmVmZXJlbmNlLCBzZWN1cml0eSByaXNrLCBv ciBwbGF0Zm9ybSBsaW1pdGF0aW9uLgo=