8510 2006-04-21 00:11:40 -0700 submit event doesn't bubble - it's supposed to. 2006-04-22 00:29:39 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED EasyFix P2 Normal --- 1 mjs ggaren oldest_to_newest 40014 0 mjs 2006-04-21 00:11:40 -0700 Here's a simple test case: <div onsubmit="alert('submit')"> <form action="?foo"> <input type="submit"> The alert fires in other browsers. I suspect this is just a matter of changing false to true on this line of HTMLFormElement.cpp: if ( dispatchHTMLEvent(submitEvent,false,true) && !m_doingsubmit ) 40058 1 ggaren 2006-04-21 12:56:41 -0700 I'm on it. 40066 2 7885 ggaren 2006-04-21 14:42:26 -0700 Created attachment 7885 Fix 40074 3 7885 sullivan 2006-04-21 16:29:24 -0700 Comment on attachment 7885 Fix nice and simple 40120 4 ggaren 2006-04-22 00:29:39 -0700 Landed. 7885 2006-04-21 14:42:26 -0700 2006-04-21 16:29:24 -0700 Fix patch-onsubmit.txt text/plain 4813 ggaren SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0MDAxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDYtMDQtMjEgIEdlb2ZmcmV5IEdhcmVuICA8 Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICAtIExheW91dCB0ZXN0IGZvciBodHRwOi8vYnVn emlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTg1MTAKKyAgICAgICAgc3VibWl0 IGV2ZW50IGRvZXNuJ3QgYnViYmxlIC0gaXQncyBzdXBwb3NlZCB0by4KKworICAgICAgICAqIGZh c3QvZXZlbnRzL29uc3VibWl0LWJ1YmJsaW5nLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZmFzdC9ldmVudHMvb25zdWJtaXQtYnViYmxpbmcuaHRtbDogQWRkZWQuCisKIDIwMDYtMDQt MjEgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZGluZyBhIGZl dyBtb3JlIGJhY2tncm91bmQtc2l6ZSB0ZXN0cyB0aGF0IGluY2x1ZGUgYmFja2dyb3VuZC0KSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL29uc3VibWl0LWJ1YmJsaW5nLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9vbnN1Ym1pdC1idWJibGlu Zy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9v bnN1Ym1pdC1idWJibGluZy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNSBA QAorVGhpcyBwYWdlIHRlc3RzIHdoZXRoZXIgdGhlIGZvcm0gJ3N1Ym1pdCcgZXZlbnQgYnViYmxl cyB0byBjb250YWluaW5nIGVsZW1lbnRzLiBJZiBpdCBwYXNzZXMsIHlvdSdsbCBzZWUgYSAnUEFT UycgbWVzc2FnZSBiZWxvdy4KKworUEFTUzogY29udGFpbmluZyBlbGVtZW50IGRpdjIgY2F1Z2h0 IHN1Ym1pdCBldmVudAorUEFTUzogY29udGFpbmluZyBlbGVtZW50IGRpdjEgY2F1Z2h0IHN1Ym1p dCBldmVudAorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9vbnN1Ym1pdC1idWJibGlu Zy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL29uc3VibWl0LWJ1 YmJsaW5nLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9vbnN1 Ym1pdC1idWJibGluZy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUyIEBACis8aHRtbD4K KzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHByaW50KG1lc3NhZ2UsIGNvbG9yKSAKK3sKKyAg ICB2YXIgcGFyYWdyYXBoID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgcGFy YWdyYXBoLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2UpKTsKKyAg ICBwYXJhZ3JhcGguc3R5bGUuZm9udEZhbWlseSA9ICJtb25vc3BhY2UiOworICAgIGlmIChjb2xv cikKKyAgICAgICAgcGFyYWdyYXBoLnN0eWxlLmNvbG9yID0gY29sb3I7CisgICAgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5hcHBlbmRDaGlsZChwYXJhZ3JhcGgpOworfQorCitm dW5jdGlvbiB0ZXN0KCkgCit7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikK KyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisKKyAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnZGl2MScpLm9uc3VibWl0ID0gZnVuY3Rpb24gKCkgeyAKKyAg ICAgICAgcGFzcyh0aGlzLmlkKTsgCisgICAgICAgIHJldHVybiBmYWxzZTsgLy8gcmV0dXJuaW5n IGZhbHNlIGNhbmNlbHMgZm9ybSBzdWJtaXNzaW9uCisgICAgfTsKKyAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgnaW5wdXQxJykuY2xpY2soKTsKK30KKworZnVuY3Rpb24gcGFzcyhpZCkKK3sK KyAgICBwcmludCgiUEFTUzogY29udGFpbmluZyBlbGVtZW50ICIgKyBpZCArICIgY2F1Z2h0IHN1 Ym1pdCBldmVudCIsICJncmVlbiIpOworfQorCitmdW5jdGlvbiBmYWlsKCkKK3sKKyAgICBwcmlu dCgiRkFJTDogY29udGFpbmluZyBlbGVtZW50IGRpZCBub3QgY2FuY2VsIHN1Ym1pdCBldmVudCIs ICJyZWQiKTsKK30KKworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InRlc3QoKTsi PgorPHA+VGhpcyBwYWdlIHRlc3RzIHdoZXRoZXIgdGhlIGZvcm0gJ3N1Ym1pdCcgZXZlbnQgYnVi YmxlcyB0byBjb250YWluaW5nIGVsZW1lbnRzLgorICAgSWYgaXQgcGFzc2VzLCB5b3UnbGwgc2Vl ICdQQVNTJyBtZXNzYWdlcyBiZWxvdy48L3A+Cis8aHI+Cis8ZGl2IGlkPSdjb25zb2xlJz48L2Rp dj4KKzxkaXYgaWQ9ImRpdjEiPgorICAgIDxkaXYgaWQ9ImRpdjIiIG9uc3VibWl0PSJwYXNzKHRo aXMuaWQpOyI+CisgICAgICAgIDxmb3JtIGlkPSJmb3JtMSIgYWN0aW9uPSJqYXZhc2NyaXB0OmZh aWwoKTsiPiA8IS0tIG9ubHkgZXhlY3V0ZXMgaWYgZm9ybSBzdWJtaXRzIC0tPgorICAgICAgICAg ICAgPGlucHV0IGlkPSJpbnB1dDEiIHR5cGU9InN1Ym1pdCI+CisgICAgICAgIDwvZm9ybT4KKyAg ICA8L2Rpdj4KKzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9odG1sL0hU TUxFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3Bw CShyZXZpc2lvbiAxNDAwMSkKKysrIFdlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTIwNSw3ICsyMDUsOSBAQCB2b2lkIEhUTUxFbGVtZW50OjpwYXJzZU1hcHBl ZEF0dHJpYnV0ZShNCiAgICAgICAgIHNldEhUTUxFdmVudExpc3RlbmVyKGRyYWdlbmRFdmVudCwg YXR0cik7CiAgICAgfSBlbHNlIGlmIChhdHRyLT5uYW1lKCkgPT0gb25zZWxlY3RzdGFydEF0dHIp IHsKICAgICAgICAgc2V0SFRNTEV2ZW50TGlzdGVuZXIoc2VsZWN0c3RhcnRFdmVudCwgYXR0cik7 Ci0gICAgfSAKKyAgICB9IGVsc2UgaWYgKGF0dHItPm5hbWUoKSA9PSBvbnN1Ym1pdEF0dHIpIHsK KyAgICAgICAgc2V0SFRNTEV2ZW50TGlzdGVuZXIoc3VibWl0RXZlbnQsIGF0dHIpOworICAgIH0K IH0KIAogU3RyaW5nIEhUTUxFbGVtZW50Ojppbm5lckhUTUwoKSBjb25zdApJbmRleDogV2ViQ29y ZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hU TUxGb3JtRWxlbWVudC5jcHAJKHJldmlzaW9uIDE0MDAxKQorKysgV2ViQ29yZS9odG1sL0hUTUxG b3JtRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxMCwxMiArMzEwLDEyIEBAIGJvb2wg SFRNTEZvcm1FbGVtZW50OjpwcmVwYXJlU3VibWl0KCkKICAgICBtX2luc3VibWl0ID0gdHJ1ZTsK ICAgICBtX2RvaW5nc3VibWl0ID0gZmFsc2U7CiAKLSAgICBpZiAoIGRpc3BhdGNoSFRNTEV2ZW50 KHN1Ym1pdEV2ZW50LGZhbHNlLHRydWUpICYmICFtX2RvaW5nc3VibWl0ICkKKyAgICBpZiAoZGlz cGF0Y2hIVE1MRXZlbnQoc3VibWl0RXZlbnQsIHRydWUsIHRydWUpICYmICFtX2RvaW5nc3VibWl0 KQogICAgICAgICBtX2RvaW5nc3VibWl0ID0gdHJ1ZTsKIAogICAgIG1faW5zdWJtaXQgPSBmYWxz ZTsKIAotICAgIGlmICggbV9kb2luZ3N1Ym1pdCApCisgICAgaWYgKG1fZG9pbmdzdWJtaXQpCiAg ICAgICAgIHN1Ym1pdCh0cnVlKTsKIAogICAgIHJldHVybiBtX2RvaW5nc3VibWl0OwpJbmRleDog V2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlz aW9uIDE0MDAxKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsNSAr MSwxOSBAQAogMjAwNi0wNC0yMSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgog CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gRml4ZWQg aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD04NTEwCisgICAg ICAgIHN1Ym1pdCBldmVudCBkb2Vzbid0IGJ1YmJsZSAtIGl0J3Mgc3VwcG9zZWQgdG8uCisKKyAg ICAgICAgKiBodG1sL0hUTUxFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbGVt ZW50OjpwYXJzZU1hcHBlZEF0dHJpYnV0ZSk6IEFkZGVkIHJlY29nbml0aW9uIGZvciB0aGUKKyAg ICAgICAgb25zdWJtaXQgYXR0cmlidXRlLCBzbyBlbGVtZW50cyBjYW4gdXNlIGl0CisgICAgICAg ICogaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1F bGVtZW50OjpwcmVwYXJlU3VibWl0KTogQ2hhbmdlZCBidWJibGluZyBhdHRyaWJ1dGUKKyAgICAg ICAgdG8gJ3RydWUnCisKKzIwMDYtMDQtMjEgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxl LmNvbT4KKwogICAgICAgICAtIEFuZCBhZ2Fpbi4KIAogICAgICAgICAqIFdlYkNvcmUudmNwcm9q L1dlYkNvcmUvV2ViQ29yZS52Y3Byb2o6Cg==