85099 2012-04-27 14:19:52 -0700 Removed the sole use of Weak<Unknown> 2012-04-27 14:45:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oldest_to_newest 611895 0 ggaren 2012-04-27 14:19:52 -0700 Removed the sole use of Weak<Unknown> 611899 1 139279 ggaren 2012-04-27 14:28:43 -0700 Created attachment 139279 Patch 611904 2 139279 sam 2012-04-27 14:34:31 -0700 Comment on attachment 139279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139279&action=review > Source/WebCore/ChangeLog:21 > + Since no clients actually want these behaviors, it's hard to tell if > + they're the right behaviors, and it's not worth the implementation > + complexity. If we come up with a client that wants these behaviors, we > + can always revisit this. Good. 611916 3 ggaren 2012-04-27 14:45:17 -0700 Committed r115496: <http://trac.webkit.org/changeset/115496> 139279 2012-04-27 14:28:43 -0700 2012-04-27 14:34:30 -0700 Patch bug-85099-20120427142842.patch text/plain 5128 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTQ5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM3IEBACis7MjAxMi0wNC0yNyAgR2VvZmZy ZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZWQgdGhlIHNvbGUg dXNlIG9mIFdlYWs8VW5rbm93bj4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg1MDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIHNlbWFudGljcyBhbmQgaW1wbGVtZW50YXRpb24gb2YgV2VhazxVbmtu b3duPiBhcmUgdW5jbGVhciBiZWNhdXNlOgorICAgICAgICAgICAgLSBTaG91bGQgeW91IGNhbGwg YSBmaW5hbGl6ZXIgZm9yIGEgbm9uLUdDIHRoaW5neT8gSWYgc28sIHdoZW4/CisKKyAgICAgICAg ICAgICAgICAqIFBvc3NpYmxlIGFuc3dlcjogTm8uCisKKyAgICAgICAgICAgIC0gSWYgV2Vha0lt cGxzIGZvciBHQyB0aGluZ2llcyBsaXZlIHdpdGggdGhlIEdDIHRoaW5naWVzIGluIHRoZQorICAg ICAgICAgICAgICBoZWFwLCB3aGVyZSBkbyBXZWFrSW1wbHMgZm9yIG5vbi1HQyB0aGluZ2llcyBs aXZlPworCisgICAgICAgICAgICAgICAgKiBQb3NzaWJsZSBhbnN3ZXI6IERpcmVjdGx5IGluIHRo ZSBXZWFrPFQ+LgorCisgICAgICAgIFNpbmNlIG5vIGNsaWVudHMgYWN0dWFsbHkgd2FudCB0aGVz ZSBiZWhhdmlvcnMsIGl0J3MgaGFyZCB0byB0ZWxsIGlmCisgICAgICAgIHRoZXkncmUgdGhlIHJp Z2h0IGJlaGF2aW9ycywgYW5kIGl0J3Mgbm90IHdvcnRoIHRoZSBpbXBsZW1lbnRhdGlvbgorICAg ICAgICBjb21wbGV4aXR5LiBJZiB3ZSBjb21lIHVwIHdpdGggYSBjbGllbnQgdGhhdCB3YW50cyB0 aGVzZSBiZWhhdmlvcnMsIHdlCisgICAgICAgIGNhbiBhbHdheXMgcmV2aXNpdCB0aGlzLgorCisg ICAgICAgICogYmluZGluZ3MvanMvSlNOb2RlRmlsdGVyQ29uZGl0aW9uLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkpTTm9kZUZpbHRlckNvbmRpdGlvbjo6SlNOb2RlRmlsdGVyQ29uZGl0aW9uKTog SnVzdCBsZWF2ZSBvdXIKKyAgICAgICAgZmlsdGVyIE5VTEwgaWYgaXQncyBub3QgYW4gb2JqZWN0 IC0tIHRoYXQncyBhIGJldHRlciB3YXkgdG8gaW5kaWNhdGUKKyAgICAgICAgIm5vdCBhIHZhbGlk IGZpbHRlciBvYmplY3QiLgorCisgICAgICAgIChXZWJDb3JlOjpKU05vZGVGaWx0ZXJDb25kaXRp b246OmFjY2VwdE5vZGUpOiBGaXhlZCB1cCBzb21lIG5hbWluZyB0bworICAgICAgICBjbGFyaWZ5 IHRoYXQgdGhlIG9iamVjdCB3ZSdyZSB3b3JraW5nIHdpdGggaXMgbm90IG5lY2Vzc2FyaWx5IGEg ZnVuY3Rpb24uCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU05vZGVGaWx0ZXJDb25kaXRpb24u aDoKKyAgICAgICAgKEpTTm9kZUZpbHRlckNvbmRpdGlvbik6IFVzZSBXZWFrPEpTT2JqZWN0Piwg c2luY2UgdGhhdCBtb3JlIGNsb3NlbHkKKyAgICAgICAgbWF0Y2hlcyB3aGF0IHdlJ3JlIHRyeWlu ZyB0byBkby4KKwogMjAxMi0wNC0yNyAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTU0ODQuCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU05vZGVGaWx0ZXJDb25kaXRpb24uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTm9kZUZpbHRlckNvbmRp dGlvbi5jcHAJKHJldmlzaW9uIDExNTQ1MikKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTTm9kZUZpbHRlckNvbmRpdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0LDMyICszNCwz MCBAQCB1c2luZyBuYW1lc3BhY2UgSlNDOwogQVNTRVJUX0NMQVNTX0ZJVFNfSU5fQ0VMTChKU05v ZGVGaWx0ZXJDb25kaXRpb24pOwogCiBKU05vZGVGaWx0ZXJDb25kaXRpb246OkpTTm9kZUZpbHRl ckNvbmRpdGlvbihKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEsIE5vZGVGaWx0ZXIqIG93bmVyLCBK U1ZhbHVlIGZpbHRlcikKLSAgICA6IG1fZmlsdGVyKGdsb2JhbERhdGEsIGZpbHRlciwgJm1fd2Vh a093bmVyLCBvd25lcikKIHsKKyAgICBpZiAoIWZpbHRlci5pc09iamVjdCgpKQorICAgICAgICBy ZXR1cm47CisgICAgbV9maWx0ZXIgPSBQYXNzV2VhazxKU09iamVjdD4oZ2xvYmFsRGF0YSwganND YXN0PEpTT2JqZWN0Kj4oZmlsdGVyKSwgJm1fd2Vha093bmVyLCBvd25lcik7CiB9CiAKIHNob3J0 IEpTTm9kZUZpbHRlckNvbmRpdGlvbjo6YWNjZXB0Tm9kZShKU0M6OkV4ZWNTdGF0ZSogZXhlYywg Tm9kZSogZmlsdGVyTm9kZSkgY29uc3QKIHsKICAgICBKU0xvY2sgbG9jayhTaWxlbmNlQXNzZXJ0 aW9uc09ubHkpOwogCi0gICAgaWYgKCFtX2ZpbHRlciB8fCAhbV9maWx0ZXItPmlzT2JqZWN0KCkp CisgICAgaWYgKCFtX2ZpbHRlcikKICAgICAgICAgcmV0dXJuIE5vZGVGaWx0ZXI6OkZJTFRFUl9B Q0NFUFQ7CiAKLSAgIC8vIFRoZSBleGVjIGFyZ3VtZW50IGhlcmUgc2hvdWxkIG9ubHkgYmUgbnVs bCBpZiB0aGlzIHdhcyBjYWxsZWQgZnJvbSBhCi0gICAvLyBub24tSmF2YVNjcmlwdCBsYW5ndWFn ZSwgYW5kIHRoaXMgaXMgYSBKYXZhU2NyaXB0IGZpbHRlciwgYW5kIHRoZSBkb2N1bWVudAotICAg Ly8gaW4gcXVlc3Rpb24gaXMgbm90IGFzc29jaWF0ZWQgd2l0aCB0aGUgZnJhbWUuIEluIHRoYXQg Y2FzZSwgd2UncmUgZ29pbmcgdG8KLSAgIC8vIGJlaGF2ZSBpbmNvcnJlY3RseSwgYW5kIGp1c3Qg cmVqZWN0IG5vZGVzIGluc3RlYWQgb2YgY2FsbGluZyB0aGUgZmlsdGVyIGZ1bmN0aW9uLgotICAg Ly8gVG8gZml4IHRoYXQgd2UnZCBuZWVkIHRvIGNvbWUgdXAgd2l0aCBhIHdheSB0byBmaW5kIGEg c3VpdGFibGUgSmF2YVNjcmlwdAotICAgLy8gZXhlY3V0aW9uIGNvbnRleHQgZm9yIHRoZSBmaWx0 ZXIgZnVuY3Rpb24gdG8gcnVuIGluLgorICAgIC8vIEV4ZWMgaXMgbnVsbCBpZiB3ZSd2ZSBiZWVu IGNhbGxlZCBmcm9tIGEgbm9uLUphdmFTY3JpcHQgbGFuZ3VhZ2UgYW5kIHRoZSBkb2N1bWVudAor ICAgIC8vIGlzIG5vIGxvbmdlciBhYmxlIHRvIHJ1biBKYXZhU2NyaXB0IChlLmcuLCBpdCdzIGRp c2Nvbm5lY3RlZCBmcm9tIGl0cyBmcmFtZSkuCiAgICAgaWYgKCFleGVjKQogICAgICAgICByZXR1 cm4gTm9kZUZpbHRlcjo6RklMVEVSX1JFSkVDVDsKIAotICAgIEpTVmFsdWUgZnVuY3Rpb24gPSBt X2ZpbHRlci5nZXQoKTsKKyAgICBKU1ZhbHVlIGZpbHRlciA9IG1fZmlsdGVyLmdldCgpOwogICAg IENhbGxEYXRhIGNhbGxEYXRhOwotICAgIENhbGxUeXBlIGNhbGxUeXBlID0gZ2V0Q2FsbERhdGEo ZnVuY3Rpb24sIGNhbGxEYXRhKTsKKyAgICBDYWxsVHlwZSBjYWxsVHlwZSA9IGdldENhbGxEYXRh KGZpbHRlciwgY2FsbERhdGEpOwogICAgIGlmIChjYWxsVHlwZSA9PSBDYWxsVHlwZU5vbmUpIHsK LSAgICAgICAgZnVuY3Rpb24gPSBtX2ZpbHRlci5nZXQoKS5nZXQoZXhlYywgSWRlbnRpZmllcihl eGVjLCAiYWNjZXB0Tm9kZSIpKTsKLSAgICAgICAgY2FsbFR5cGUgPSBnZXRDYWxsRGF0YShmdW5j dGlvbiwgY2FsbERhdGEpOworICAgICAgICBmaWx0ZXIgPSBmaWx0ZXIuZ2V0KGV4ZWMsIElkZW50 aWZpZXIoZXhlYywgImFjY2VwdE5vZGUiKSk7CisgICAgICAgIGNhbGxUeXBlID0gZ2V0Q2FsbERh dGEoZmlsdGVyLCBjYWxsRGF0YSk7CiAgICAgICAgIGlmIChjYWxsVHlwZSA9PSBDYWxsVHlwZU5v bmUpIHsKICAgICAgICAgICAgIHRocm93RXJyb3IoZXhlYywgY3JlYXRlVHlwZUVycm9yKGV4ZWMs ICJOb2RlRmlsdGVyIG9iamVjdCBkb2VzIG5vdCBoYXZlIGFuIGFjY2VwdE5vZGUgZnVuY3Rpb24i KSk7CiAgICAgICAgICAgICByZXR1cm4gTm9kZUZpbHRlcjo6RklMVEVSX1JFSkVDVDsKQEAgLTcz LDcgKzcxLDcgQEAgc2hvcnQgSlNOb2RlRmlsdGVyQ29uZGl0aW9uOjphY2NlcHROb2RlKAogICAg IGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkKICAgICAgICAgcmV0dXJuIE5vZGVGaWx0ZXI6OkZJ TFRFUl9SRUpFQ1Q7CiAKLSAgICBKU1ZhbHVlIHJlc3VsdCA9IEpTTWFpblRocmVhZEV4ZWNTdGF0 ZTo6Y2FsbChleGVjLCBmdW5jdGlvbiwgY2FsbFR5cGUsIGNhbGxEYXRhLCBtX2ZpbHRlci5nZXQo KSwgYXJncyk7CisgICAgSlNWYWx1ZSByZXN1bHQgPSBKU01haW5UaHJlYWRFeGVjU3RhdGU6OmNh bGwoZXhlYywgZmlsdGVyLCBjYWxsVHlwZSwgY2FsbERhdGEsIG1fZmlsdGVyLmdldCgpLCBhcmdz KTsKICAgICBpZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpCiAgICAgICAgIHJldHVybiBOb2RlRmls dGVyOjpGSUxURVJfUkVKRUNUOwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U05vZGVGaWx0ZXJDb25kaXRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU05vZGVGaWx0ZXJDb25kaXRpb24uaAkocmV2aXNpb24gMTE1NDUyKQorKysgU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNOb2RlRmlsdGVyQ29uZGl0aW9uLmgJKHdvcmtpbmcg Y29weSkKQEAgLTQ2LDcgKzQ2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAg dmlydHVhbCBib29sIGlzUmVhY2hhYmxlRnJvbU9wYXF1ZVJvb3RzKEpTQzo6SGFuZGxlPEpTQzo6 VW5rbm93bj4sIHZvaWQqIGNvbnRleHQsIEpTQzo6U2xvdFZpc2l0b3ImKTsKICAgICAgICAgfTsK ICAgICAgICAgV2Vha093bmVyIG1fd2Vha093bmVyOwotICAgICAgICBtdXRhYmxlIEpTQzo6V2Vh azxKU0M6OlVua25vd24+IG1fZmlsdGVyOworICAgICAgICBtdXRhYmxlIEpTQzo6V2VhazxKU0M6 OkpTT2JqZWN0PiBtX2ZpbHRlcjsKICAgICB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==