85096 2012-04-27 13:38:07 -0700 [Texmap] Leaves demo: wrong geometry when opacity animation kicks in 2012-04-29 08:19:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noam noam joone.hur jturcotte mrobinson webkit.review.bot oldest_to_newest 611854 0 noam 2012-04-27 13:38:07 -0700 [Texmap] Leaves demo: wrong geometry when opacity animation kicks in 611857 1 139262 noam 2012-04-27 13:41:57 -0700 Created attachment 139262 Patch 611881 2 139262 jturcotte 2012-04-27 14:04:46 -0700 Comment on attachment 139262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139262&action=review > Source/WebCore/ChangeLog:11 > + intermediate surfaces for preserves-3d. Also, we should multiply the compensation > + transform (options.transform) before we multiply the current item's transform, otherwise > + the transform-origin is incorrect. The order of option.transform vs. m_transform.combined() didn't change in the code, only the order of options.offset changed, so maybe the changelog should be updated? > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:-153 > - TransformationMatrix(options.transform) > - .multiply(m_transform.combined()) > - .translate(options.offset.width(), options.offset.height()); The same order is present at the end of paintRecursive, should it be updated as well? 611946 3 139291 noam 2012-04-27 15:32:11 -0700 Created attachment 139291 Patch 612430 4 139291 webkit.review.bot 2012-04-29 08:19:30 -0700 Comment on attachment 139291 Patch Clearing flags on attachment: 139291 Committed r115596: <http://trac.webkit.org/changeset/115596> 612431 5 webkit.review.bot 2012-04-29 08:19:35 -0700 All reviewed patches have been landed. Closing bug. 139262 2012-04-27 13:41:57 -0700 2012-04-27 15:32:03 -0700 Patch bug-85096-20120427134155.patch text/plain 2959 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDI4ZTBlOGJlODkyODkz NzdmYmFmODQ4MzUxNzc1ZjNhOGVjZWVjNC4uYjlhNmVlYWJiNjhkZTRiMjhmNmIxMTEzYjBjYmEz MjUwMmY4NjhkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTA0LTI3ICBObydh bSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CiAKKyAgICAgICAgW1RleG1h cF0gTGVhdmVzIGRlbW86IHdyb25nIGdlb21ldHJ5IHdoZW4gb3BhY2l0eSBhbmltYXRpb24ga2lj a3MgaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1 MDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug c2hvdWxkIHVzZSBjb21iaW5lZCgpIGluc3RlYWQgb2YgY29tYmluZWRGb3JDaGlsZHJlbigpIHNp bmNlIHdlIGRvbid0IGFsbG93CisgICAgICAgIGludGVybWVkaWF0ZSBzdXJmYWNlcyBmb3IgcHJl c2VydmVzLTNkLiBBbHNvLCB3ZSBzaG91bGQgbXVsdGlwbHkgdGhlIGNvbXBlbnNhdGlvbgorICAg ICAgICB0cmFuc2Zvcm0gKG9wdGlvbnMudHJhbnNmb3JtKSBiZWZvcmUgd2UgbXVsdGlwbHkgdGhl IGN1cnJlbnQgaXRlbSdzIHRyYW5zZm9ybSwgb3RoZXJ3aXNlCisgICAgICAgIHRoZSB0cmFuc2Zv cm0tb3JpZ2luIGlzIGluY29ycmVjdC4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIGNv bXBvc2l0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5 ZXI6OnBhaW50U2VsZik6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnBh aW50UmVjdXJzaXZlKToKKworMjAxMi0wNC0yNyAgTm8nYW0gUm9zZW50aGFsICA8bm9hbS5yb3Nl bnRoYWxAbm9raWEuY29tPgorCiAgICAgICAgIFtUZXhtYXBdIEZhbGxpbmcgbGVhdmVzIGRlbW8g bWlzc2luZyBvcGFjaXR5IGZhZGUgb3V0IGFuaW1hdGlvbgogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM2OTEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVy LmNwcAppbmRleCA5YWMzM2RkNzAyNmVmOWQyZjg1NzVjZTZlN2VhNGRhYTM2YWVkOTNiLi41NzM4 MzRmOGU0NmE1YjhhNDdmYzIzOGVmMmZmOGRiMmVjYzA4M2YyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl ckxheWVyLmNwcApAQCAtMTQ3LDEwICsxNDcsMTAgQEAgdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6 OnBhaW50KCkKIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpwYWludFNlbGYoY29uc3QgVGV4dHVy ZU1hcHBlclBhaW50T3B0aW9ucyYgb3B0aW9ucykKIHsKICAgICAvLyBXZSBhcHBseSB0aGUgZm9s bG93aW5nIHRyYW5zZm9ybSB0byBjb21wZW5zYXRlIGZvciBwYWludGluZyBpbnRvIGEgc3VyZmFj ZSwgYW5kIHRoZW4gYXBwbHkgdGhlIG9mZnNldCBzbyB0aGF0IHRoZSBwYWludGluZyBmaXRzIGlu IHRoZSB0YXJnZXQgcmVjdC4KLSAgICBUcmFuc2Zvcm1hdGlvbk1hdHJpeCB0cmFuc2Zvcm0gPQot ICAgICAgICAgICAgVHJhbnNmb3JtYXRpb25NYXRyaXgob3B0aW9ucy50cmFuc2Zvcm0pCi0gICAg ICAgICAgICAubXVsdGlwbHkobV90cmFuc2Zvcm0uY29tYmluZWQoKSkKLSAgICAgICAgICAgIC50 cmFuc2xhdGUob3B0aW9ucy5vZmZzZXQud2lkdGgoKSwgb3B0aW9ucy5vZmZzZXQuaGVpZ2h0KCkp OworICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IHRyYW5zZm9ybTsKKyAgICB0cmFuc2Zvcm0udHJh bnNsYXRlKG9wdGlvbnMub2Zmc2V0LndpZHRoKCksIG9wdGlvbnMub2Zmc2V0LmhlaWdodCgpKTsK KyAgICB0cmFuc2Zvcm0ubXVsdGlwbHkob3B0aW9ucy50cmFuc2Zvcm0pOworICAgIHRyYW5zZm9y bS5tdWx0aXBseShtX3RyYW5zZm9ybS5jb21iaW5lZCgpKTsKIAogICAgIGZsb2F0IG9wYWNpdHkg PSBvcHRpb25zLm9wYWNpdHk7CiAgICAgUmVmUHRyPEJpdG1hcFRleHR1cmU+IG1hc2sgPSBvcHRp b25zLm1hc2s7CkBAIC0zMTksOCArMzE5LDcgQEAgdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBh aW50UmVjdXJzaXZlKGNvbnN0IFRleHR1cmVNYXBwZXJQYWludE9wdGlvbnMmIG9wdGlvbnMKICAg ICBvcHRpb25zLnRleHR1cmVNYXBwZXItPmJpbmRTdXJmYWNlKHN1cmZhY2UuZ2V0KCkpOwogICAg IHBhaW50T3B0aW9ucy5vcGFjaXR5ID0gMTsKIAotICAgIC8vIFdlIGhhdmUgdG8gdXNlIGNvbWJp bmVkRm9yQ2hpbGRyZW4oKSBhbmQgbm90IGNvbWJpbmVkKCksIG90aGVyd2lzZSBwcmVzZXJ2ZS0z RCBkb2Vzbid0IHdvcmsuCi0gICAgcGFpbnRPcHRpb25zLnRyYW5zZm9ybSA9IG1fdHJhbnNmb3Jt LmNvbWJpbmVkRm9yQ2hpbGRyZW4oKS5pbnZlcnNlKCk7CisgICAgcGFpbnRPcHRpb25zLnRyYW5z Zm9ybSA9IG1fdHJhbnNmb3JtLmNvbWJpbmVkKCkuaW52ZXJzZSgpOwogICAgIHBhaW50T3B0aW9u cy5vZmZzZXQgPSAtSW50U2l6ZShzdXJmYWNlUmVjdC54KCksIHN1cmZhY2VSZWN0LnkoKSk7CiAK ICAgICBwYWludFNlbGZBbmRDaGlsZHJlbldpdGhSZXBsaWNhKHBhaW50T3B0aW9ucyk7Cg== 139291 2012-04-27 15:32:11 -0700 2012-04-29 08:19:30 -0700 Patch bug-85096-20120427153209.patch text/plain 3651 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDI4ZTBlOGJlODkyODkz NzdmYmFmODQ4MzUxNzc1ZjNhOGVjZWVjNC4uMTAzODdkMzhmY2ZkZjg5MjAyMmM4YjMxNmM3ZTU5 YzEwMDc2OWEwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTA0LTI3ICBObydh bSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CiAKKyAgICAgICAgW1RleG1h cF0gTGVhdmVzIGRlbW86IHdyb25nIGdlb21ldHJ5IHdoZW4gb3BhY2l0eSBhbmltYXRpb24ga2lj a3MgaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1 MDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug c2hvdWxkIHVzZSBjb21iaW5lZCgpIGluc3RlYWQgb2YgY29tYmluZWRGb3JDaGlsZHJlbigpIHNp bmNlIHdlIGRvbid0IGFsbG93CisgICAgICAgIGludGVybWVkaWF0ZSBzdXJmYWNlcyBmb3IgcHJl c2VydmVzLTNkLiBBbHNvLCB3ZSBzaG91bGQgYXBwbHkgdGhlIG9mZnNldCBiZWZvcmUKKyAgICAg ICAgbXVsdGlwbHlpbmcgdGhlIHRyYW5zZm9ybXMsIG90aGVyd2lzZSB0aGUgdHJhbnNmb3JtLW9y aWdpbiBpcyBpbmNvcnJlY3QuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyBjb21wb3Np dGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl TWFwcGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlckxheWVyOjpw YWludFNlbGYpOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlckxheWVyOjpwYWludFJl Y3Vyc2l2ZSk6CisKKzIwMTItMDQtMjcgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFs QG5va2lhLmNvbT4KKwogICAgICAgICBbVGV4bWFwXSBGYWxsaW5nIGxlYXZlcyBkZW1vIG1pc3Np bmcgb3BhY2l0eSBmYWRlIG91dCBhbmltYXRpb24KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNjkxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAK aW5kZXggOWFjMzNkZDcwMjZlZjlkMmY4NTc1Y2U2ZTdlYTRkYWEzNmFlZDkzYi4uNDBiMjkxNTU0 YjE5ZWFjYzA2MGExMjRmZjBhYmNjODBlYWFiOTVjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXll ci5jcHAKQEAgLTE0NywxMCArMTQ3LDEwIEBAIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpwYWlu dCgpCiB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnRTZWxmKGNvbnN0IFRleHR1cmVNYXBw ZXJQYWludE9wdGlvbnMmIG9wdGlvbnMpCiB7CiAgICAgLy8gV2UgYXBwbHkgdGhlIGZvbGxvd2lu ZyB0cmFuc2Zvcm0gdG8gY29tcGVuc2F0ZSBmb3IgcGFpbnRpbmcgaW50byBhIHN1cmZhY2UsIGFu ZCB0aGVuIGFwcGx5IHRoZSBvZmZzZXQgc28gdGhhdCB0aGUgcGFpbnRpbmcgZml0cyBpbiB0aGUg dGFyZ2V0IHJlY3QuCi0gICAgVHJhbnNmb3JtYXRpb25NYXRyaXggdHJhbnNmb3JtID0KLSAgICAg ICAgICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4KG9wdGlvbnMudHJhbnNmb3JtKQotICAgICAgICAg ICAgLm11bHRpcGx5KG1fdHJhbnNmb3JtLmNvbWJpbmVkKCkpCi0gICAgICAgICAgICAudHJhbnNs YXRlKG9wdGlvbnMub2Zmc2V0LndpZHRoKCksIG9wdGlvbnMub2Zmc2V0LmhlaWdodCgpKTsKKyAg ICBUcmFuc2Zvcm1hdGlvbk1hdHJpeCB0cmFuc2Zvcm07CisgICAgdHJhbnNmb3JtLnRyYW5zbGF0 ZShvcHRpb25zLm9mZnNldC53aWR0aCgpLCBvcHRpb25zLm9mZnNldC5oZWlnaHQoKSk7CisgICAg dHJhbnNmb3JtLm11bHRpcGx5KG9wdGlvbnMudHJhbnNmb3JtKTsKKyAgICB0cmFuc2Zvcm0ubXVs dGlwbHkobV90cmFuc2Zvcm0uY29tYmluZWQoKSk7CiAKICAgICBmbG9hdCBvcGFjaXR5ID0gb3B0 aW9ucy5vcGFjaXR5OwogICAgIFJlZlB0cjxCaXRtYXBUZXh0dXJlPiBtYXNrID0gb3B0aW9ucy5t YXNrOwpAQCAtMzE5LDggKzMxOSw3IEBAIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpwYWludFJl Y3Vyc2l2ZShjb25zdCBUZXh0dXJlTWFwcGVyUGFpbnRPcHRpb25zJiBvcHRpb25zCiAgICAgb3B0 aW9ucy50ZXh0dXJlTWFwcGVyLT5iaW5kU3VyZmFjZShzdXJmYWNlLmdldCgpKTsKICAgICBwYWlu dE9wdGlvbnMub3BhY2l0eSA9IDE7CiAKLSAgICAvLyBXZSBoYXZlIHRvIHVzZSBjb21iaW5lZEZv ckNoaWxkcmVuKCkgYW5kIG5vdCBjb21iaW5lZCgpLCBvdGhlcndpc2UgcHJlc2VydmUtM0QgZG9l c24ndCB3b3JrLgotICAgIHBhaW50T3B0aW9ucy50cmFuc2Zvcm0gPSBtX3RyYW5zZm9ybS5jb21i aW5lZEZvckNoaWxkcmVuKCkuaW52ZXJzZSgpOworICAgIHBhaW50T3B0aW9ucy50cmFuc2Zvcm0g PSBtX3RyYW5zZm9ybS5jb21iaW5lZCgpLmludmVyc2UoKTsKICAgICBwYWludE9wdGlvbnMub2Zm c2V0ID0gLUludFNpemUoc3VyZmFjZVJlY3QueCgpLCBzdXJmYWNlUmVjdC55KCkpOwogCiAgICAg cGFpbnRTZWxmQW5kQ2hpbGRyZW5XaXRoUmVwbGljYShwYWludE9wdGlvbnMpOwpAQCAtMzM0LDEw ICszMzMsMTEgQEAgdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50UmVjdXJzaXZlKGNvbnN0 IFRleHR1cmVNYXBwZXJQYWludE9wdGlvbnMmIG9wdGlvbnMKICNlbmRpZgogCiAgICAgb3B0aW9u cy50ZXh0dXJlTWFwcGVyLT5iaW5kU3VyZmFjZShvcHRpb25zLnN1cmZhY2UuZ2V0KCkpOwotICAg IFRyYW5zZm9ybWF0aW9uTWF0cml4IHRhcmdldFRyYW5zZm9ybSA9Ci0gICAgICAgICAgICBUcmFu c2Zvcm1hdGlvbk1hdHJpeChvcHRpb25zLnRyYW5zZm9ybSkKLSAgICAgICAgICAgICAgICAubXVs dGlwbHkobV90cmFuc2Zvcm0uY29tYmluZWQoKSkKLSAgICAgICAgICAgICAgICAudHJhbnNsYXRl KG9wdGlvbnMub2Zmc2V0LndpZHRoKCksIG9wdGlvbnMub2Zmc2V0LmhlaWdodCgpKTsKKyAgICBU cmFuc2Zvcm1hdGlvbk1hdHJpeCB0YXJnZXRUcmFuc2Zvcm07CisgICAgdGFyZ2V0VHJhbnNmb3Jt LnRyYW5zbGF0ZShvcHRpb25zLm9mZnNldC53aWR0aCgpLCBvcHRpb25zLm9mZnNldC5oZWlnaHQo KSk7CisgICAgdGFyZ2V0VHJhbnNmb3JtLm11bHRpcGx5KG9wdGlvbnMudHJhbnNmb3JtKTsKKyAg ICB0YXJnZXRUcmFuc2Zvcm0ubXVsdGlwbHkobV90cmFuc2Zvcm0uY29tYmluZWQoKSk7CisKICAg ICBvcHRpb25zLnRleHR1cmVNYXBwZXItPmRyYXdUZXh0dXJlKCpzdXJmYWNlLmdldCgpLCBzdXJm YWNlUmVjdCwgdGFyZ2V0VHJhbnNmb3JtLCBvcGFjaXR5LCBtYXNrVGV4dHVyZS5nZXQoKSk7CiB9 CiAK