85088 2012-04-27 11:50:35 -0700 [Qt][WK2] Don't call syncRemoteContents from WebLayerTreeRenderer::paintToCurrentGLContext 2012-04-27 16:48:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned jturcotte menard noam webkit.review.bot zoltan oldest_to_newest 611744 0 yael 2012-04-27 11:50:35 -0700 It has recently moved to QQuickWebPage::updatePaintNode. 611769 1 139245 yael 2012-04-27 12:08:33 -0700 Created attachment 139245 Patch. 611777 2 139245 jturcotte 2012-04-27 12:28:07 -0700 Comment on attachment 139245 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=139245&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:786 > + > + // Ensure that updatePaintNode is always called before painting. > + pageView->update(); This change should go in your fixed element patch and not here, since it is the one that is going to add code in updatePaintNode that must be called when the viewport move. 611789 3 yael 2012-04-27 12:48:42 -0700 (In reply to comment #2) > (From update of attachment 139245 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=139245&action=review > > > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:786 > > + > > + // Ensure that updatePaintNode is always called before painting. > > + pageView->update(); > > This change should go in your fixed element patch and not here, since it is the one that is going to add code in updatePaintNode that must be called when the viewport move. Existing fixed position tests are breaking without this change. I cannot remove syncRemoteContents without adding this. 611793 4 139245 noam 2012-04-27 12:57:05 -0700 Comment on attachment 139245 Patch. LGTM, I agree with yael's comment. 612019 5 139245 webkit.review.bot 2012-04-27 16:48:15 -0700 Comment on attachment 139245 Patch. Clearing flags on attachment: 139245 Committed r115515: <http://trac.webkit.org/changeset/115515> 612020 6 webkit.review.bot 2012-04-27 16:48:19 -0700 All reviewed patches have been landed. Closing bug. 139245 2012-04-27 12:08:33 -0700 2012-04-27 16:48:14 -0700 Patch. 85088.patch text/plain 2347 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTQ2MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTI3ICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdW1dLMl0gRG9uJ3Qg Y2FsbCBzeW5jUmVtb3RlQ29udGVudHMgZnJvbSBXZWJMYXllclRyZWVSZW5kZXJlcjo6cGFpbnRU b0N1cnJlbnRHTENvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg1MDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVtb3ZlIHRoZSBjYWxsIHRvIHN5bmNSZW1vdGVDb250ZW50cyBmcm9tIFdlYkxh eWVyVHJlZVJlbmRlcmVyOjpwYWludFRvQ3VycmVudEdMQ29udGV4dCwKKyAgICAgICAgc2luY2Ug aXQgd2FzIG1vdmVkIHRvIFFRdWlja1dlYlBhZ2U6OnVwZGF0ZVBhaW50Tm9kZS4KKyAgICAgICAg VG8gbWFrZSBzdXJlIHRoYXQgd2UgYWx3YXlzIHN5bmMgYmVmb3JlIHBhaW50aW5nLCB0aGlzIHBh dGNoIGFsc28gY2FsbHMgcGFnZS0+dXBkYXRlKCkKKyAgICAgICAgd2hlbiB0aGUgdmlld3BvcnQg Y2hhbmdlcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6 CisgICAgICAgIChRUXVpY2tXZWJWaWV3RmxpY2thYmxlUHJpdmF0ZTo6X3FfY29udGVudFZpZXdw b3J0Q2hhbmdlZCk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYkxheWVyVHJlZVJlbmRlcmVyLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViTGF5ZXJUcmVlUmVuZGVyZXI6OnBhaW50VG9DdXJyZW50 R0xDb250ZXh0KToKKwogMjAxMi0wNC0yNyAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBBZGQgbmV3IEVOQUJMRV9MSU5LX1BSRVJFTkRFUiBkZWZpbmUgdG8g Y29udHJvbCB0aGUgUHJlcmVuZGVyaW5nIEFQSQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYkxheWVyVHJlZVJlbmRlcmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViTGF5ZXJUcmVlUmVuZGVyZXIuY3BwCShyZXZpc2lvbiAxMTUzMjcpCisr KyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViTGF5ZXJUcmVlUmVuZGVyZXIuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMDksNyArMTA5LDYgQEAgdm9pZCBXZWJMYXllclRyZWVSZW5kZXJlcjo6 cGFpbnRUb0N1cnJlbgogICAgICAgICBtX3RleHR1cmVNYXBwZXIgPSBUZXh0dXJlTWFwcGVyOjpj cmVhdGUoVGV4dHVyZU1hcHBlcjo6T3BlbkdMTW9kZSk7CiAgICAgQVNTRVJUKG1fdGV4dHVyZU1h cHBlci0+YWNjZWxlcmF0aW9uTW9kZSgpID09IFRleHR1cmVNYXBwZXI6Ok9wZW5HTE1vZGUpOwog Ci0gICAgc3luY1JlbW90ZUNvbnRlbnQoKTsKICAgICBhZGp1c3RQb3NpdGlvbkZvckZpeGVkTGF5 ZXJzKCk7CiAgICAgR3JhcGhpY3NMYXllciogY3VycmVudFJvb3RMYXllciA9IHJvb3RMYXllcigp OwogICAgIGlmICghY3VycmVudFJvb3RMYXllcikKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAkocmV2aXNpb24gMTE1MzI3KQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNzgxLDYgKzc4MSw5IEBAIHZvaWQgUVF1aWNrV2ViVmlld0ZsaWNrYWJs ZVByaXZhdGU6Ol9xX2MKICAgICBmbG9hdCBzY2FsZSA9IHBhZ2VWaWV3LT5jb250ZW50c1NjYWxl KCk7CiAKICAgICBkcmF3aW5nQXJlYS0+c2V0VmlzaWJsZUNvbnRlbnRzUmVjdCh2aXNpYmxlUmVj dCwgc2NhbGUsIHRyYWplY3RvcnlWZWN0b3IpOworCisgICAgLy8gRW5zdXJlIHRoYXQgdXBkYXRl UGFpbnROb2RlIGlzIGFsd2F5cyBjYWxsZWQgYmVmb3JlIHBhaW50aW5nLgorICAgIHBhZ2VWaWV3 LT51cGRhdGUoKTsKIH0KIAogdm9pZCBRUXVpY2tXZWJWaWV3RmxpY2thYmxlUHJpdmF0ZTo6X3Ff c3VzcGVuZCgpCg==