85065 2012-04-27 07:54:12 -0700 [Gtk][DOM Bindings] Conditional string in implementation file generated in wrong place after 113450 2012-04-27 09:26:33 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan abarth haraken japhet mrobinson webkit.review.bot oldest_to_newest 611490 0 zan 2012-04-27 07:54:12 -0700 In revision 113450[1] the conditional string in implementation file was moved above the inclusion of WebCore (and other) headers. This reverts the reverse changes that were made in revision 111914, making builds again prone towards failure when disabling specific features (Geolocation for instance). [1] http://trac.webkit.org/changeset/113450 [2] http://trac.webkit.org/changeset/111914 611498 1 139202 zan 2012-04-27 07:59:58 -0700 Created attachment 139202 Patch 611575 2 139202 zan 2012-04-27 09:26:26 -0700 Comment on attachment 139202 Patch Clearing flags on attachment: 139202 Committed r115438: <http://trac.webkit.org/changeset/115438> 611576 3 zan 2012-04-27 09:26:33 -0700 All reviewed patches have been landed. Closing bug. 139202 2012-04-27 07:59:58 -0700 2012-04-27 09:26:26 -0700 Patch bug-85065-20120427165956.patch text/plain 4947 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE1M2I5ZmUzOTBlNzhk ZTFkNmVjMDU1ZGQ5ODAyN2FlMGJiMmU2NS4uM2NjZTFmYWViZDQ4NDQyOWQ2NTA5OWVjMWRmMmYx Y2JkOGVhODNiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA0LTI3ICBaYW4g RG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAgW0d0a11bRE9NIEJp bmRpbmdzXSBDb25kaXRpb25hbCBzdHJpbmcgaW4gaW1wbGVtZW50YXRpb24gZmlsZSBnZW5lcmF0 ZWQgaW4gd3JvbmcgcGxhY2UgYWZ0ZXIgMTEzNDUwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTA2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFB1dCB0aGUgY29uZGl0aW9uIHN0cmluZyBpbiBpbXBsZW1l bnRhdGlvbiBmaWxlIGFmdGVyIHRoZSBoZWFkZXIgaW5jbHVzaW9ucy4gVGhpcyBlbnN1cmVzCisg ICAgICAgIHRoYXQgYnVpbGQgZXJyb3JzIGRvIG5vdCBvY2N1ciB3aGVuIGRpc2FibGluZyB0aGUg ZnV0dXJlIHRoYXQgYXBwbGllcyB0byB0aGUgY29uZGl0aW9uIHN0cmluZworICAgICAgICBiZWNh dXNlIG9mIFdlYkNvcmUgb2JqZWN0cyBhbmQgbWV0aG9kcyB0aGF0IGFyZSBzdGlsbCBpbiB1c2Ug ZGVzcGl0ZSB0aGUgZmVhdHVyZSBiZWluZyBkaXNhYmxlZC4KKworICAgICAgICBObyBuZXcgdGVz dHMgLSBjb3ZlcmVkIGJ5IGJpbmRpbmdzIHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbToKKyAgICAgICAgKFdyaXRlRGF0YSk6CisgICAg ICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdENhbGxiYWNr LmNwcDogUmViYXNlbGluZSBnZW5lcmF0ZWQgcmVzdWx0cy4KKyAgICAgICAgKiBiaW5kaW5ncy9z Y3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0SW50ZXJmYWNlLmNwcDogRGl0dG8uCisg ICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdFNlcmlh bGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFjZS5jcHA6IERpdHRvLgorCiAyMDEyLTA0LTI3ICBOaWtv bGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIEZpeCByZXBl dGl0aW9ucyAmIGJ5IGFuaW1hdGlvbiBzdXBwb3J0IGZvciBTVkdBbmltYXRlVHJhbnNmb3JtRWxl bWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yR09iamVjdC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvckdPYmplY3QucG0KaW5kZXggNzM1MjIxYWUxMWVhNzQ5ODE5YWJiZjdlM2NlNWY5N2Ux ZTA5YzAyYS4uMjkzYzQ5OGY4NWE4NmNlZWIxOTBiNzAxMzMxOWMwOTM3Y2IzZDBhNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVj dC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JH T2JqZWN0LnBtCkBAIC0xNDEzLDcgKzE0MTMsNiBAQCBFT0YKICAgICBwcmludCBJTVBMIEBjUHJl Zml4OwogICAgIHByaW50IElNUEwgIiNpbmNsdWRlIFwiY29uZmlnLmhcIlxuIjsKICAgICBwcmlu dCBJTVBMICIjaW5jbHVkZSBcIiRpbnN0YWxsZWRIZWFkZXJGaWxlbmFtZVwiXG5cbiI7Ci0gICAg cHJpbnQgSU1QTCAiI2lmICR7Y29uZGl0aW9uYWxTdHJpbmd9XG5cbiIgaWYgJGNvbmRpdGlvbmFs U3RyaW5nOwogCiAgICAgIyBSZW1vdmUgdGhlIGltcGxlbWVudGF0aW9uIGhlYWRlciBmcm9tIHRo ZSBsaXN0IG9mIGluY2x1ZGVkIGZpbGVzLgogICAgICVpbmNsdWRlc0NvcHkgPSAlaW1wbEluY2x1 ZGVzOwpAQCAtMTQyMyw2ICsxNDIyLDcgQEAgRU9GCiAgICAgcHJpbnQgSU1QTCAiI2luY2x1ZGUg PGdsaWItb2JqZWN0Lmg+XG4iOwogICAgIHByaW50IElNUEwgIiNpbmNsdWRlIDx3dGYvR2V0UHRy Lmg+XG4iOwogICAgIHByaW50IElNUEwgIiNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+XG5cbiI7Cisg ICAgcHJpbnQgSU1QTCAiI2lmICR7Y29uZGl0aW9uYWxTdHJpbmd9XG5cbiIgaWYgJGNvbmRpdGlv bmFsU3RyaW5nOwogCiAgICAgcHJpbnQgSU1QTCAibmFtZXNwYWNlIFdlYktpdCB7XG5cbiI7CiAg ICAgcHJpbnQgSU1QTCBAY0JvZHlQcml2OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdENhbGxiYWNrLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RD YWxsYmFjay5jcHAKaW5kZXggOWRiNzcwNDlkZDMwZDJmYTk3YWJiYjM0NzVjN2FhZjI5ODdjYzM0 NS4uNWNiMjFmZWM1MzFjOTAxOWQ3OTQ3YmM5ZjIwOTkyZTQzOWVkMmE4MiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVz dENhbGxiYWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3Qv R09iamVjdC9XZWJLaXRET01UZXN0Q2FsbGJhY2suY3BwCkBAIC0yMSw4ICsyMSw2IEBACiAjaW5j bHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiV2ViS2l0RE9NVGVzdENhbGxiYWNrLmgiCiAKLSNp ZiBFTkFCTEUoU1FMX0RBVEFCQVNFKQotCiAjaW5jbHVkZSAiRE9NT2JqZWN0Q2FjaGUuaCIKICNp bmNsdWRlICJFeGNlcHRpb25Db2RlLmgiCiAjaW5jbHVkZSAiSlNNYWluVGhyZWFkRXhlY1N0YXRl LmgiCkBAIC00OSw2ICs0Nyw4IEBACiAjaW5jbHVkZSA8d3RmL0dldFB0ci5oPgogI2luY2x1ZGUg PHd0Zi9SZWZQdHIuaD4KIAorI2lmIEVOQUJMRShTUUxfREFUQUJBU0UpCisKIG5hbWVzcGFjZSBX ZWJLaXQgewogCiBXZWJLaXRET01UZXN0Q2FsbGJhY2sqIGtpdChXZWJDb3JlOjpUZXN0Q2FsbGJh Y2sqIG9iaikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVz dC9HT2JqZWN0L1dlYktpdERPTVRlc3RJbnRlcmZhY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdEludGVyZmFjZS5jcHAKaW5k ZXggMDFhYjJiMzc5NDY4MzI2ZGFlNjdlZTgwYzQ2ODhlNTMxYzQyNTQxMi4uNTExOTI2YjVkMjY5 Y2ZhYzA4NTFmMjI5MzRkOTVlOTk1MzNlN2Y2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdEludGVyZmFjZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0 RE9NVGVzdEludGVyZmFjZS5jcHAKQEAgLTIxLDggKzIxLDYgQEAKICNpbmNsdWRlICJjb25maWcu aCIKICNpbmNsdWRlICJXZWJLaXRET01UZXN0SW50ZXJmYWNlLmgiCiAKLSNpZiBFTkFCTEUoQ29u ZGl0aW9uMSkgfHwgRU5BQkxFKENvbmRpdGlvbjIpCi0KICNpbmNsdWRlICJET01PYmplY3RDYWNo ZS5oIgogI2luY2x1ZGUgIkV4Y2VwdGlvbkNvZGUuaCIKICNpbmNsdWRlICJKU01haW5UaHJlYWRF eGVjU3RhdGUuaCIKQEAgLTQ0LDYgKzQyLDggQEAKICNpbmNsdWRlIDx3dGYvR2V0UHRyLmg+CiAj aW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogCisjaWYgRU5BQkxFKENvbmRpdGlvbjEpIHx8IEVOQUJM RShDb25kaXRpb24yKQorCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogV2ViS2l0RE9NVGVzdEludGVy ZmFjZSoga2l0KFdlYkNvcmU6OlRlc3RJbnRlcmZhY2UqIG9iaikKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RTZXJp YWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUlu dGVyZmFjZS5jcHAKaW5kZXggYzc2NDI1NDgyN2E5ODI5ZGMzNWM3MTgzZGIxMzJlZjU2N2FhODY5 Mi4uMzI1Y2M4NmQwNzFlNzY4YzU2ZGU0ODUxM2U0YzM1Y2I1M2M1Y2ZlNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVz dFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdFNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZUludGVyZmFjZS5jcHAKQEAgLTIxLDggKzIxLDYgQEAKICNpbmNsdWRlICJjb25maWcu aCIKICNpbmNsdWRlICJXZWJLaXRET01UZXN0U2VyaWFsaXplZFNjcmlwdFZhbHVlSW50ZXJmYWNl LmgiCiAKLSNpZiBFTkFCTEUoQ29uZGl0aW9uMSkgfHwgRU5BQkxFKENvbmRpdGlvbjIpCi0KICNp bmNsdWRlICJET01PYmplY3RDYWNoZS5oIgogI2luY2x1ZGUgIkV4Y2VwdGlvbkNvZGUuaCIKICNp bmNsdWRlICJKU01haW5UaHJlYWRFeGVjU3RhdGUuaCIKQEAgLTQ1LDYgKzQzLDggQEAKICNpbmNs dWRlIDx3dGYvR2V0UHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogCisjaWYgRU5BQkxF KENvbmRpdGlvbjEpIHx8IEVOQUJMRShDb25kaXRpb24yKQorCiBuYW1lc3BhY2UgV2ViS2l0IHsK IAogV2ViS2l0RE9NVGVzdFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFjZSoga2l0KFdlYkNv cmU6OlRlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2UqIG9iaikK