<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>85058</bug_id>
          
          <creation_ts>2012-04-27 06:10:08 -0700</creation_ts>
          <short_desc>[EFL][DRT] ewk_view_paint_contents may trigger assertion failure</short_desc>
          <delta_ts>2012-05-10 09:53:25 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dominik Röttsches (drott)">d-r</reporter>
          <assigned_to name="Dominik Röttsches (drott)">d-r</assigned_to>
          <cc>eric</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jungjik.lee</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>mrobinson</cc>
    
    <cc>pnormand</cc>
    
    <cc>rakuco</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>t.morawski</cc>
    
    <cc>tmpsantos</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>611427</commentid>
    <comment_count>0</comment_count>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-04-27 06:10:08 -0700</bug_when>
    <thetext>We&apos;re running into an assertion failure in
WebCore::FrameView::paintContents
ASSERTION FAILED: !needsLayout()

when running media/media-fragments/ tests.

ewk_view_paint resolves that by calling

    if (view-&gt;needsLayout())
        view-&gt;forceLayout();

So we should probably do that in ewk_view_paint_contents, too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>611432</commentid>
    <comment_count>1</comment_count>
      <attachid>139185</attachid>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-04-27 06:18:42 -0700</bug_when>
    <thetext>Created attachment 139185
Don&apos;t go into painting without layout</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614159</commentid>
    <comment_count>2</comment_count>
      <attachid>139185</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-05-02 03:51:31 -0700</bug_when>
    <thetext>Comment on attachment 139185
Don&apos;t go into painting without layout

View in context: https://bugs.webkit.org/attachment.cgi?id=139185&amp;action=review

&gt; Source/WebKit/efl/ewk/ewk_view.cpp:2740
&gt; +        view-&gt;forceLayout();

I&apos;m wondering whether we should call forceLayout(). As you know, there is view-&gt;layout().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614163</commentid>
    <comment_count>3</comment_count>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-05-02 04:01:31 -0700</bug_when>
    <thetext>They are identical - forceLayout calls layout internally - and I don&apos;t see any deprecation warning in FrameView.h. I am using forceLayout for consistency with ewk_view_paint: forceLayout is used there. So, looks okay to you?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614175</commentid>
    <comment_count>4</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2012-05-02 04:31:29 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; They are identical - forceLayout calls layout internally - and I don&apos;t see any deprecation warning in FrameView.h. I am using forceLayout for consistency with ewk_view_paint: forceLayout is used there. So, looks okay to you?

I think that we should investigate this more.

If contents is dynamic, each tile may render different layout for ewk_view_pre_render.
ewk_view_pre_render make several tiles render on idle time.

Add jungjik in CCs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614180</commentid>
    <comment_count>5</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-05-02 04:49:50 -0700</bug_when>
    <thetext>I think we should avoid unneeded layout operation. Because, layout cost is expensive.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614198</commentid>
    <comment_count>6</comment_count>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-05-02 05:13:13 -0700</bug_when>
    <thetext>Sure, but it&apos;s not unneeded here - since without a layout we run into the assertion failure, so clearly something is wrong. 
Jungjik, Ryuan - which direction do you think we should look to investigate this, any pointers? Which component should have done the layout before we actually get to ewk_view_paint_contents and run into the assertion failure?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620481</commentid>
    <comment_count>7</comment_count>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-05-10 05:11:38 -0700</bug_when>
    <thetext>The media fragment tests are constructed in a way that they quickly iterate through a number of fragment suffixes that they append to the media URL. After each test, they add elements to the DOM to report the result of the test case using .innerHTML which goes through the parser and ends up adding child elements to the DOM.

We hit the assertion failure because of a race condition. Idle-repainting of EFL fights with the scheduleRelayout() timer that is triggered by the addChild insertion.

HTMLConstructionSite::executeTask gets to
 task.parent-&gt;parserAddChild(task.child.get());

that triggers as a child note insertion notification in:
ChildNodeInsertionNotifier::notifyInsertedIntoDocument

which in turn triggers a
        view-&gt;scheduleRelayout();

in HTMLBodyElement::didNotifyDescendantInseretions.
which has the following interesting fixme:
    // FIXME: This call to scheduleRelayout should not be needed here.
    // But without it we hang during WebKit tests; need to fix that and remove this.

Now, if the EFL idle tiling repainting timer is triggered first, we arrive in ewk_view_paint_contents without having done a relayout. 

So, I would conclude, it&apos;s safe to do a layout here if needed to avoid this assertion failure.
  if (view-&gt;needsLayout())
      view-&gt;forceLayout();

Since a relayout would be done anyway if the scheduleRelayout timer would fire first before we get to idle.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620501</commentid>
    <comment_count>8</comment_count>
      <attachid>141154</attachid>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-05-10 05:35:49 -0700</bug_when>
    <thetext>Created attachment 141154
Updated, rebased patch.

Updated changelog to include reason for why assertion is hit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620507</commentid>
    <comment_count>9</comment_count>
      <attachid>141154</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2012-05-10 05:52:23 -0700</bug_when>
    <thetext>Comment on attachment 141154
Updated, rebased patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=141154&amp;action=review

&gt; Source/WebKit/efl/ewk/ewk_view.cpp:2810
&gt; +    if (view-&gt;needsLayout())
&gt; +        view-&gt;forceLayout();

To me this looks like using too strong a force. Why don&apos;t you call view-&gt;updateLayoutAndStyleIfNeededRecursive() unconditionally instead?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620568</commentid>
    <comment_count>10</comment_count>
      <attachid>141165</attachid>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-05-10 07:27:49 -0700</bug_when>
    <thetext>Created attachment 141165
Updated, review comment addressed.

Using less force, Luke. Thanks, kov!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620569</commentid>
    <comment_count>11</comment_count>
      <attachid>141165</attachid>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-05-10 07:28:41 -0700</bug_when>
    <thetext>Comment on attachment 141165
Updated, review comment addressed.

Clearing flags, forgot something.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620579</commentid>
    <comment_count>12</comment_count>
      <attachid>141170</attachid>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-05-10 07:49:46 -0700</bug_when>
    <thetext>Created attachment 141170
Updated again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620580</commentid>
    <comment_count>13</comment_count>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-05-10 07:53:32 -0700</bug_when>
    <thetext>Thought about it again - updateLayoutAndStyleIfNeededRecursive() does nothing else than if(needsLayout()) layout() as well. We don&apos;t actually need to update style, I believe. We just need to protect against the race condition where the idle timer tries to repaint first before layoutTimerFired is called, so this conditional layout() call should be enough here. To make it sound less forceful, I call the layout() function, which is equivalent.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620594</commentid>
    <comment_count>14</comment_count>
      <attachid>141174</attachid>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-05-10 08:11:51 -0700</bug_when>
    <thetext>Created attachment 141174
Updated patch

Following reviewer&apos;s advice here and finally using updateLayoutAndStyleIfNeededRecursive() - thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620654</commentid>
    <comment_count>15</comment_count>
      <attachid>141174</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-10 09:53:18 -0700</bug_when>
    <thetext>Comment on attachment 141174
Updated patch

Clearing flags on attachment: 141174

Committed r116656: &lt;http://trac.webkit.org/changeset/116656&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620655</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-10 09:53:25 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>139185</attachid>
            <date>2012-04-27 06:18:42 -0700</date>
            <delta_ts>2012-05-10 05:35:38 -0700</delta_ts>
            <desc>Don&apos;t go into painting without layout</desc>
            <filename>bug85058.patch</filename>
            <type>text/plain</type>
            <size>2764</size>
            <attacher name="Dominik Röttsches (drott)">d-r</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA2ZjVjOTE3Li5hNTgzOWEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDQt
MjcgIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90dHNjaGVzQGxpbnV4LmludGVsLmNv
bT4KKworICAgICAgICBbRUZMXVtEUlRdIGV3a192aWV3X3BhaW50X2NvbnRlbnRzIG1heSB0cmln
Z2VyIGFzc2VydGlvbiBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD04NTA1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIFVuc2tpcHBpbmcgbWVkaWEtZnJhZ21lbnRzIHRoYXQgcGFzcyBhZnRlciB0
aGUgYXNzZXJ0aW9uIGZhaWx1cmUgd2FzIGZpeGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZWZs
L1NraXBwZWQ6CisKIDIwMTItMDQtMjcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2Fs
aWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIEdUSyB0ZXN0X2V4cGVjdGF0aW9ucyB1cGRh
dGUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91
dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCmluZGV4IGU4MWVhZGMuLjkxZTY5NjkgMTAwNjQ0
Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3Rz
L3BsYXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC0xMjQ2LDE2ICsxMjQ2LDYgQEAgbWVkaWEvbWVkaWEt
ZnVsbHNjcmVlbi1ub3QtaW4tZG9jdW1lbnQuaHRtbAogbWVkaWEvbWVkaWEtY29udHJvbGxlci1w
bGF5YmFjay5odG1sCiBtZWRpYS9tZWRpYS1lbGVtZW50LXBsYXktYWZ0ZXItZW9zLmh0bWwKIG1l
ZGlhL21lZGlhLWV4dGVuc2lvbi13aXRoLWZyYWdtZW50Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdt
ZW50cy9UQzAwMDEtVEMwMDA5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwMTAtVEMw
MDE5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwMjAtVEMwMDI5Lmh0bWwKLW1lZGlh
L21lZGlhLWZyYWdtZW50cy9UQzAwMzAtVEMwMDM5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50
cy9UQzAwNDAtVEMwMDQ5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwNTAtVEMwMDU5
Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwNjAtVEMwMDY5Lmh0bWwKLW1lZGlhL21l
ZGlhLWZyYWdtZW50cy9UQzAwNzAtVEMwMDc5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9U
QzAwODAtVEMwMDg5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwOTAtVEMwMDk5Lmh0
bWwKIG1lZGlhL21lZGlhLWluaXRpYWxUaW1lLmh0bWwKIG1lZGlhL21lZGlhLWxvYWQtZXZlbnQu
aHRtbAogbWVkaWEvbWVkaWEtc3RhcnRUaW1lLmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL
aXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAzNGU4
YjEzLi42MmQ3MmQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysr
IGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDQt
MjcgIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90dHNjaGVzQGxpbnV4LmludGVsLmNv
bT4KKworICAgICAgICBbRUZMXVtEUlRdIGV3a192aWV3X3BhaW50X2NvbnRlbnRzIG1heSB0cmln
Z2VyIGFzc2VydGlvbiBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD04NTA1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIEZpeGluZyBhc3NlcnRpb24gZmFpbHVyZSB0cmlnZ2VyZWQgaW4gbWVkaWEv
bWVkaWEtZnJhZ21lbnQgY2FzZXMuCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAg
ICAgICAoZXdrX3ZpZXdfcGFpbnRfY29udGVudHMpOgorCiAyMDEyLTA0LTI3ICBDaHJpc3RvcGhl
IER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gRFJU
IHNob3VsZCBzdXBwb3J0IExheW91dFRlc3RDb250cm9sbGVyJ3MgZHVtcFJlc291cmNlTG9hZENh
bGxiYWNrcygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3Bw
IGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA2ZDdlZWQzLi44Y2Fk
MmM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBi
L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTI3MzYsNiArMjczNiw4IEBA
IEVpbmFfQm9vbCBld2tfdmlld19wYWludF9jb250ZW50cyhFd2tfVmlld19Qcml2YXRlX0RhdGEq
IHByaXYsIGNhaXJvX3QqIGNyLCBjb25zCiAgICAgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0IGdy
YXBoaWNzQ29udGV4dChjcik7CiAgICAgV2ViQ29yZTo6SW50UmVjdCByZWN0KCphcmVhKTsKIAor
ICAgIGlmICh2aWV3LT5uZWVkc0xheW91dCgpKQorICAgICAgICB2aWV3LT5mb3JjZUxheW91dCgp
OwogICAgIGNhaXJvX3NhdmUoY3IpOwogICAgIGdyYXBoaWNzQ29udGV4dC5zYXZlKCk7CiAgICAg
Z3JhcGhpY3NDb250ZXh0LmNsaXAocmVjdCk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141154</attachid>
            <date>2012-05-10 05:35:49 -0700</date>
            <delta_ts>2012-05-10 07:27:38 -0700</delta_ts>
            <desc>Updated, rebased patch.</desc>
            <filename>bug-85058-20120510153657.patch</filename>
            <type>text/plain</type>
            <size>3351</size>
            <attacher name="Dominik Röttsches (drott)">d-r</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm
bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMTQ1NzdmMGU4
YWFiMTk4NDZiNGUwZjcxY2MxZmI0YTEzNDFkMDZkOC4uYWM5MjIyM2ZlODY4YWI1NGJjZDAwMGM3
ZjNhYmVhMGVmNzdmNmUxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEy
LTA1LTEwICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+
CisKKyAgICAgICAgW0VGTF1bRFJUXSBld2tfdmlld19wYWludF9jb250ZW50cyBtYXkgdHJpZ2dl
ciBhc3NlcnRpb24gZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9ODUwNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBGaXhpbmcgYXNzZXJ0aW9uIGZhaWx1cmUgdHJpZ2dlcmVkIGluIG1lZGlhL21l
ZGlhLWZyYWdtZW50IGNhc2VzLgorICAgICAgICBUaGUgYXNzZXJ0aW9uIGlzIGhpdCBiZWNhdXNl
IG9mIGEgcmFjZSBiZXR3ZWVuIHNjaGVkdWxlUmVsYXlvdXQoKSBhbmQKKyAgICAgICAgdGhlIEVX
SydzIGlkbGUgdGlsaW5nIHBhaW50aW5nLiBUaGlzIGlzIGV4cG9zZWQgYnkgdGVzdCBjYXNlcwor
ICAgICAgICB0aGF0IHJhcGlkbHkgaW5zZXJ0IGNoaWxkIG5vZGVzIHRvIHRoZSBkb2N1bWVudCB3
aGljaCBsZWFkIHRvCisgICAgICAgIHNjaGVkdWxlUmVsYXlvdXQoKSBjYWxscy4KKworICAgICAg
ICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld19wYWludF9jb250ZW50cyk6
CisKIDIwMTItMDUtMTAgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBp
bnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bRFJUXSBDbGVhciBhZGRlZCB1c2VyIHN0eWxlIHNo
ZWV0cyBiZWZvcmUgYSBuZXcgdGVzdGNhc2UgZXhlY3V0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf
dmlldy5jcHAKaW5kZXggN2EwZWUxZWQ2YmFlYmMxZjI2NWQ2NDY0MjI2NTI2YzM5ODYwMTY4Ny4u
MTNiYjk0OWY3ZmRkNGRiMWJiZWJjMGI4ZTJiOGUzNjVmYjc0OGJmMCAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l
d2svZXdrX3ZpZXcuY3BwCkBAIC0yODA2LDYgKzI4MDYsOCBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdf
cGFpbnRfY29udGVudHMoRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKiBwcml2LCBjYWlyb190KiBjciwg
Y29ucwogICAgIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCBncmFwaGljc0NvbnRleHQoY3IpOwog
ICAgIFdlYkNvcmU6OkludFJlY3QgcmVjdCgqYXJlYSk7CiAKKyAgICBpZiAodmlldy0+bmVlZHNM
YXlvdXQoKSkKKyAgICAgICAgdmlldy0+Zm9yY2VMYXlvdXQoKTsKICAgICBjYWlyb19zYXZlKGNy
KTsKICAgICBncmFwaGljc0NvbnRleHQuc2F2ZSgpOwogICAgIGdyYXBoaWNzQ29udGV4dC5jbGlw
KHJlY3QpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv
Q2hhbmdlTG9nCmluZGV4IDI0NTM1ZWUzZmVmYTA5YzJjODI4MmQxZjlmZWQ2MWMzN2FmMGFjMzMu
LjU0MThiYTcxNGY3MGJmY2QzODcwOTAxNzRlNjI3M2EzOWVjM2M3MmUgMTAwNjQ0Ci0tLSBhL0xh
eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNCBAQAorMjAxMi0wNS0xMCAgRG9taW5payBSw7Z0dHNjaGVzICA8ZG9taW5pay5yb3R0c2No
ZXNAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW0RSVF0gZXdrX3ZpZXdfcGFpbnRfY29udGVu
dHMgbWF5IHRyaWdnZXIgYXNzZXJ0aW9uIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MDU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lwcGluZyBtZWRpYS1mcmFnbWVudHMgdGhhdCBw
YXNzIGFmdGVyIHRoZSBhc3NlcnRpb24gZmFpbHVyZSB3YXMgZml4ZWQuCisKKyAgICAgICAgKiBw
bGF0Zm9ybS9lZmwvU2tpcHBlZDoKKwogMjAxMi0wNS0xMCAgQWxleGFuZGVyIFNoYWxhbW92ICA8
YWxleGFuZGVyLnNoYWxhbW92QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtEUlRdIEV2ZW50
U2VuZGVyIC0gc2V0IGRlbGF5ZWQgZXZlbnQgaW5mb3JtYXRpb24gaWYgaXQgd2FzIG5vdCBzZXQg
YmVmb3JlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xh
eW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCmluZGV4IGUxZWZiZjk1ZDY2N2JiMmMzOWY3
Mzg0M2VlODZiYjc0MjM2NGJjNWQuLjhkOTU5M2ZiNmY5ZDc4MDM5Y2QyNzY5ZjUxZTA5NmIxMTUw
MjUxNmEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisrKyBi
L0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC0xMDM4LDE2ICsxMDM4LDYgQEAg
bWVkaWEvbWVkaWEtZnVsbHNjcmVlbi1ub3QtaW4tZG9jdW1lbnQuaHRtbAogbWVkaWEvbWVkaWEt
Y29udHJvbGxlci1wbGF5YmFjay5odG1sCiBtZWRpYS9tZWRpYS1lbGVtZW50LXBsYXktYWZ0ZXIt
ZW9zLmh0bWwKIG1lZGlhL21lZGlhLWV4dGVuc2lvbi13aXRoLWZyYWdtZW50Lmh0bWwKLW1lZGlh
L21lZGlhLWZyYWdtZW50cy9UQzAwMDEtVEMwMDA5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50
cy9UQzAwMTAtVEMwMDE5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwMjAtVEMwMDI5
Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwMzAtVEMwMDM5Lmh0bWwKLW1lZGlhL21l
ZGlhLWZyYWdtZW50cy9UQzAwNDAtVEMwMDQ5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9U
QzAwNTAtVEMwMDU5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwNjAtVEMwMDY5Lmh0
bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwNzAtVEMwMDc5Lmh0bWwKLW1lZGlhL21lZGlh
LWZyYWdtZW50cy9UQzAwODAtVEMwMDg5Lmh0bWwKLW1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAw
OTAtVEMwMDk5Lmh0bWwKIG1lZGlhL21lZGlhLWluaXRpYWxUaW1lLmh0bWwKIG1lZGlhL21lZGlh
LWxvYWQtZXZlbnQuaHRtbAogbWVkaWEvbWVkaWEtc3RhcnRUaW1lLmh0bWwK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141165</attachid>
            <date>2012-05-10 07:27:49 -0700</date>
            <delta_ts>2012-05-10 07:31:10 -0700</delta_ts>
            <desc>Updated, review comment addressed.</desc>
            <filename>bug-85058-20120510172857.patch</filename>
            <type>text/plain</type>
            <size>3770</size>
            <attacher name="Dominik Röttsches (drott)">d-r</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm
bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMTQ1NzdmMGU4
YWFiMTk4NDZiNGUwZjcxY2MxZmI0YTEzNDFkMDZkOC4uMDI2MGZiNWZlOTUzNzZiMjQ4OTllY2Uw
MWExMWI1ODZjMmUwZTI4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEy
LTA1LTEwICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+
CisKKyAgICAgICAgW0VGTF1bRFJUXSBld2tfdmlld19wYWludF9jb250ZW50cyBtYXkgdHJpZ2dl
ciBhc3NlcnRpb24gZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9ODUwNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBGaXhpbmcgYXNzZXJ0aW9uIGZhaWx1cmUgdHJpZ2dlcmVkIGluIG1lZGlhL21l
ZGlhLWZyYWdtZW50IGNhc2VzLgorICAgICAgICBUaGUgYXNzZXJ0aW9uIGlzIGhpdCBiZWNhdXNl
IG9mIGEgcmFjZSBiZXR3ZWVuIHNjaGVkdWxlUmVsYXlvdXQoKSBhbmQKKyAgICAgICAgdGhlIEVX
SydzIGlkbGUgdGlsaW5nIHBhaW50aW5nLiBUaGlzIGlzIGV4cG9zZWQgYnkgdGVzdCBjYXNlcwor
ICAgICAgICB0aGF0IHJhcGlkbHkgaW5zZXJ0IGNoaWxkIG5vZGVzIHRvIHRoZSBkb2N1bWVudCB3
aGljaCBsZWFkIHRvCisgICAgICAgIHNjaGVkdWxlUmVsYXlvdXQoKSBjYWxscy4gVXNpbmcgbGVz
cyB2aW9sZW50IHJlbGF5b3V0IGNhbGwuCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgor
ICAgICAgICAoZXdrX3ZpZXdfcGFpbnRfY29udGVudHMpOgorCiAyMDEyLTA1LTEwICBNaWtoYWls
IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgogCiAgICAgICAgIFtF
RkxdW0RSVF0gQ2xlYXIgYWRkZWQgdXNlciBzdHlsZSBzaGVldHMgYmVmb3JlIGEgbmV3IHRlc3Rj
YXNlIGV4ZWN1dGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmll
dy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDdhMGVlMWVk
NmJhZWJjMWYyNjVkNjQ2NDIyNjUyNmMzOTg2MDE2ODcuLjZmMjJjMDJiMWQ5Y2E5YTExNDFmM2Jm
ZGYzOTRlMjQ4YTM2NWUyMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf
dmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtMjc3
OSw3ICsyNzc5LDcgQEAgRWluYV9Cb29sIGV3a192aWV3X3BhaW50KEV3a19WaWV3X1ByaXZhdGVf
RGF0YSogcHJpdiwgY2Fpcm9fdCogY3IsIGNvbnN0IEVpbmFfUmUKICAgICBFSU5BX1NBRkVUWV9P
Tl9OVUxMX1JFVFVSTl9WQUwodmlldywgZmFsc2UpOwogCiAgICAgaWYgKHZpZXctPm5lZWRzTGF5
b3V0KCkpCi0gICAgICAgIHZpZXctPmZvcmNlTGF5b3V0KCk7CisgICAgICAgIHZpZXctPnVwZGF0
ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUoKTsKICAgICBXZWJDb3JlOjpHcmFwaGlj
c0NvbnRleHQgZ3JhcGhpY3NDb250ZXh0KGNyKTsKICAgICBXZWJDb3JlOjpJbnRSZWN0IHJlY3Qo
KmFyZWEpOwogCkBAIC0yODA2LDYgKzI4MDYsOCBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfcGFpbnRf
Y29udGVudHMoRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKiBwcml2LCBjYWlyb190KiBjciwgY29ucwog
ICAgIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCBncmFwaGljc0NvbnRleHQoY3IpOwogICAgIFdl
YkNvcmU6OkludFJlY3QgcmVjdCgqYXJlYSk7CiAKKyAgICBpZiAodmlldy0+bmVlZHNMYXlvdXQo
KSkKKyAgICAgICAgdmlldy0+dXBkYXRlTGF5b3V0QW5kU3R5bGVJZk5lZWRlZFJlY3Vyc2l2ZSgp
OwogICAgIGNhaXJvX3NhdmUoY3IpOwogICAgIGdyYXBoaWNzQ29udGV4dC5zYXZlKCk7CiAgICAg
Z3JhcGhpY3NDb250ZXh0LmNsaXAocmVjdCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjQ1MzVlZTNmZWZhMDljMmM4Mjgy
ZDFmOWZlZDYxYzM3YWYwYWMzMy4uNTQxOGJhNzE0ZjcwYmZjZDM4NzA5MDE3NGU2MjczYTM5ZWMz
YzcyZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTEwICBEb21pbmlrIFLDtnR0c2No
ZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bRFJUXSBl
d2tfdmlld19wYWludF9jb250ZW50cyBtYXkgdHJpZ2dlciBhc3NlcnRpb24gZmFpbHVyZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUwNTgKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnNraXBwaW5nIG1l
ZGlhLWZyYWdtZW50cyB0aGF0IHBhc3MgYWZ0ZXIgdGhlIGFzc2VydGlvbiBmYWlsdXJlIHdhcyBm
aXhlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Ta2lwcGVkOgorCiAyMDEyLTA1LTEwICBB
bGV4YW5kZXIgU2hhbGFtb3YgIDxhbGV4YW5kZXIuc2hhbGFtb3ZAaW50ZWwuY29tPgogCiAgICAg
ICAgIFtFRkxdW0RSVF0gRXZlbnRTZW5kZXIgLSBzZXQgZGVsYXllZCBldmVudCBpbmZvcm1hdGlv
biBpZiBpdCB3YXMgbm90IHNldCBiZWZvcmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm
b3JtL2VmbC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKaW5kZXgg
ZTFlZmJmOTVkNjY3YmIyYzM5ZjczODQzZWU4NmJiNzQyMzY0YmM1ZC4uOGQ5NTkzZmI2ZjlkNzgw
MzljZDI3NjlmNTFlMDk2YjExNTAyNTE2YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv
cm0vZWZsL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKQEAg
LTEwMzgsMTYgKzEwMzgsNiBAQCBtZWRpYS9tZWRpYS1mdWxsc2NyZWVuLW5vdC1pbi1kb2N1bWVu
dC5odG1sCiBtZWRpYS9tZWRpYS1jb250cm9sbGVyLXBsYXliYWNrLmh0bWwKIG1lZGlhL21lZGlh
LWVsZW1lbnQtcGxheS1hZnRlci1lb3MuaHRtbAogbWVkaWEvbWVkaWEtZXh0ZW5zaW9uLXdpdGgt
ZnJhZ21lbnQuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDAwMS1UQzAwMDkuaHRtbAot
bWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDAxMC1UQzAwMTkuaHRtbAotbWVkaWEvbWVkaWEtZnJh
Z21lbnRzL1RDMDAyMC1UQzAwMjkuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDAzMC1U
QzAwMzkuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDA0MC1UQzAwNDkuaHRtbAotbWVk
aWEvbWVkaWEtZnJhZ21lbnRzL1RDMDA1MC1UQzAwNTkuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21l
bnRzL1RDMDA2MC1UQzAwNjkuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDA3MC1UQzAw
NzkuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDA4MC1UQzAwODkuaHRtbAotbWVkaWEv
bWVkaWEtZnJhZ21lbnRzL1RDMDA5MC1UQzAwOTkuaHRtbAogbWVkaWEvbWVkaWEtaW5pdGlhbFRp
bWUuaHRtbAogbWVkaWEvbWVkaWEtbG9hZC1ldmVudC5odG1sCiBtZWRpYS9tZWRpYS1zdGFydFRp
bWUuaHRtbAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141170</attachid>
            <date>2012-05-10 07:49:46 -0700</date>
            <delta_ts>2012-05-10 08:11:40 -0700</delta_ts>
            <desc>Updated again.</desc>
            <filename>bug-85058-20120510175054.patch</filename>
            <type>text/plain</type>
            <size>3674</size>
            <attacher name="Dominik Röttsches (drott)">d-r</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm
bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMTQ1NzdmMGU4
YWFiMTk4NDZiNGUwZjcxY2MxZmI0YTEzNDFkMDZkOC4uYWM5MjIyM2ZlODY4YWI1NGJjZDAwMGM3
ZjNhYmVhMGVmNzdmNmUxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEy
LTA1LTEwICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+
CisKKyAgICAgICAgW0VGTF1bRFJUXSBld2tfdmlld19wYWludF9jb250ZW50cyBtYXkgdHJpZ2dl
ciBhc3NlcnRpb24gZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9ODUwNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBGaXhpbmcgYXNzZXJ0aW9uIGZhaWx1cmUgdHJpZ2dlcmVkIGluIG1lZGlhL21l
ZGlhLWZyYWdtZW50IGNhc2VzLgorICAgICAgICBUaGUgYXNzZXJ0aW9uIGlzIGhpdCBiZWNhdXNl
IG9mIGEgcmFjZSBiZXR3ZWVuIHNjaGVkdWxlUmVsYXlvdXQoKSBhbmQKKyAgICAgICAgdGhlIEVX
SydzIGlkbGUgdGlsaW5nIHBhaW50aW5nLiBUaGlzIGlzIGV4cG9zZWQgYnkgdGVzdCBjYXNlcwor
ICAgICAgICB0aGF0IHJhcGlkbHkgaW5zZXJ0IGNoaWxkIG5vZGVzIHRvIHRoZSBkb2N1bWVudCB3
aGljaCBsZWFkIHRvCisgICAgICAgIHNjaGVkdWxlUmVsYXlvdXQoKSBjYWxscy4KKworICAgICAg
ICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld19wYWludF9jb250ZW50cyk6
CisKIDIwMTItMDUtMTAgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBp
bnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bRFJUXSBDbGVhciBhZGRlZCB1c2VyIHN0eWxlIHNo
ZWV0cyBiZWZvcmUgYSBuZXcgdGVzdGNhc2UgZXhlY3V0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf
dmlldy5jcHAKaW5kZXggN2EwZWUxZWQ2YmFlYmMxZjI2NWQ2NDY0MjI2NTI2YzM5ODYwMTY4Ny4u
Y2NhMTNkYjE1ZGZlNTU2ZTU1N2FjZjMyNzkyZDFhNmY2ODdmOTg2MSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l
d2svZXdrX3ZpZXcuY3BwCkBAIC0yNzc5LDcgKzI3NzksNyBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdf
cGFpbnQoRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKiBwcml2LCBjYWlyb190KiBjciwgY29uc3QgRWlu
YV9SZQogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTCh2aWV3LCBmYWxzZSk7CiAK
ICAgICBpZiAodmlldy0+bmVlZHNMYXlvdXQoKSkKLSAgICAgICAgdmlldy0+Zm9yY2VMYXlvdXQo
KTsKKyAgICAgICAgdmlldy0+bGF5b3V0KCk7CiAgICAgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0
IGdyYXBoaWNzQ29udGV4dChjcik7CiAgICAgV2ViQ29yZTo6SW50UmVjdCByZWN0KCphcmVhKTsK
IApAQCAtMjgwNiw2ICsyODA2LDggQEAgRWluYV9Cb29sIGV3a192aWV3X3BhaW50X2NvbnRlbnRz
KEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdiwgY2Fpcm9fdCogY3IsIGNvbnMKICAgICBXZWJD
b3JlOjpHcmFwaGljc0NvbnRleHQgZ3JhcGhpY3NDb250ZXh0KGNyKTsKICAgICBXZWJDb3JlOjpJ
bnRSZWN0IHJlY3QoKmFyZWEpOwogCisgICAgaWYgKHZpZXctPm5lZWRzTGF5b3V0KCkpCisgICAg
ICAgIHZpZXctPmxheW91dCgpOwogICAgIGNhaXJvX3NhdmUoY3IpOwogICAgIGdyYXBoaWNzQ29u
dGV4dC5zYXZlKCk7CiAgICAgZ3JhcGhpY3NDb250ZXh0LmNsaXAocmVjdCk7CmRpZmYgLS1naXQg
YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjQ1
MzVlZTNmZWZhMDljMmM4MjgyZDFmOWZlZDYxYzM3YWYwYWMzMy4uNTQxOGJhNzE0ZjcwYmZjZDM4
NzA5MDE3NGU2MjczYTM5ZWMzYzcyZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n
CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTEw
ICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAg
ICAgICAgW0VGTF1bRFJUXSBld2tfdmlld19wYWludF9jb250ZW50cyBtYXkgdHJpZ2dlciBhc3Nl
cnRpb24gZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9ODUwNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBVbnNraXBwaW5nIG1lZGlhLWZyYWdtZW50cyB0aGF0IHBhc3MgYWZ0ZXIgdGhlIGFzc2Vy
dGlvbiBmYWlsdXJlIHdhcyBmaXhlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Ta2lwcGVk
OgorCiAyMDEyLTA1LTEwICBBbGV4YW5kZXIgU2hhbGFtb3YgIDxhbGV4YW5kZXIuc2hhbGFtb3ZA
aW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW0RSVF0gRXZlbnRTZW5kZXIgLSBzZXQgZGVsYXll
ZCBldmVudCBpbmZvcm1hdGlvbiBpZiBpdCB3YXMgbm90IHNldCBiZWZvcmUKZGlmZiAtLWdpdCBh
L0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v
ZWZsL1NraXBwZWQKaW5kZXggZTFlZmJmOTVkNjY3YmIyYzM5ZjczODQzZWU4NmJiNzQyMzY0YmM1
ZC4uOGQ5NTkzZmI2ZjlkNzgwMzljZDI3NjlmNTFlMDk2YjExNTAyNTE2YSAxMDA2NDQKLS0tIGEv
TGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv
cm0vZWZsL1NraXBwZWQKQEAgLTEwMzgsMTYgKzEwMzgsNiBAQCBtZWRpYS9tZWRpYS1mdWxsc2Ny
ZWVuLW5vdC1pbi1kb2N1bWVudC5odG1sCiBtZWRpYS9tZWRpYS1jb250cm9sbGVyLXBsYXliYWNr
Lmh0bWwKIG1lZGlhL21lZGlhLWVsZW1lbnQtcGxheS1hZnRlci1lb3MuaHRtbAogbWVkaWEvbWVk
aWEtZXh0ZW5zaW9uLXdpdGgtZnJhZ21lbnQuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RD
MDAwMS1UQzAwMDkuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDAxMC1UQzAwMTkuaHRt
bAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDAyMC1UQzAwMjkuaHRtbAotbWVkaWEvbWVkaWEt
ZnJhZ21lbnRzL1RDMDAzMC1UQzAwMzkuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDA0
MC1UQzAwNDkuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDA1MC1UQzAwNTkuaHRtbAot
bWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDA2MC1UQzAwNjkuaHRtbAotbWVkaWEvbWVkaWEtZnJh
Z21lbnRzL1RDMDA3MC1UQzAwNzkuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDA4MC1U
QzAwODkuaHRtbAotbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDA5MC1UQzAwOTkuaHRtbAogbWVk
aWEvbWVkaWEtaW5pdGlhbFRpbWUuaHRtbAogbWVkaWEvbWVkaWEtbG9hZC1ldmVudC5odG1sCiBt
ZWRpYS9tZWRpYS1zdGFydFRpbWUuaHRtbAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>141174</attachid>
            <date>2012-05-10 08:11:51 -0700</date>
            <delta_ts>2012-05-10 09:53:18 -0700</delta_ts>
            <desc>Updated patch</desc>
            <filename>bug-85058-20120510181259.patch</filename>
            <type>text/plain</type>
            <size>3991</size>
            <attacher name="Dominik Röttsches (drott)">d-r</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm
bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMTQ1NzdmMGU4
YWFiMTk4NDZiNGUwZjcxY2MxZmI0YTEzNDFkMDZkOC4uMDljZjllNjhjZWI2YmJlOTkwNDhkNzE5
YWUzOTc2YWRhOTVmODMwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEy
LTA1LTEwICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+
CisKKyAgICAgICAgW0VGTF1bRFJUXSBld2tfdmlld19wYWludF9jb250ZW50cyBtYXkgdHJpZ2dl
ciBhc3NlcnRpb24gZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9ODUwNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBGaXhpbmcgYXNzZXJ0aW9uIGZhaWx1cmUgdHJpZ2dlcmVkIGluIG1lZGlhL21l
ZGlhLWZyYWdtZW50IGNhc2VzLgorICAgICAgICBUaGUgYXNzZXJ0aW9uIGlzIGhpdCBiZWNhdXNl
IG9mIGEgcmFjZSBiZXR3ZWVuIHNjaGVkdWxlUmVsYXlvdXQoKSBhbmQKKyAgICAgICAgdGhlIEVX
SydzIGlkbGUgdGlsaW5nIHBhaW50aW5nLiBUaGlzIGlzIGV4cG9zZWQgYnkgdGVzdCBjYXNlcwor
ICAgICAgICB0aGF0IHJhcGlkbHkgaW5zZXJ0IGNoaWxkIG5vZGVzIHRvIHRoZSBkb2N1bWVudCB3
aGljaCBsZWFkIHRvCisgICAgICAgIHNjaGVkdWxlUmVsYXlvdXQoKSBjYWxscy4gVXNpbmcgdGhl
IGdlbmVyYWwgcHVycG9zZSBkZWZlbnNpdmUKKyAgICAgICAgbGF5b3V0IGZ1bmN0aW9uLCBub3Qg
Y2F1c2luZyBhbnkgZXh0cmEgcmVsYXlvdXQgd29yayBpZiB0aGVyZSdzCisgICAgICAgIG5vdGhp
bmcgdG8gYmUgZG9uZSwgYnV0IHN0aWxsIGF2b2lkaW5nIHRoZSBhc3NlcnRpb24gZmFpbHVyZSBp
ZgorICAgICAgICBsYXlvdXQgaXMgbmVlZGVkLgorCisgICAgICAgICogZXdrL2V3a192aWV3LmNw
cDoKKyAgICAgICAgKGV3a192aWV3X3BhaW50KToKKyAgICAgICAgKGV3a192aWV3X3BhaW50X2Nv
bnRlbnRzKToKKwogMjAxMi0wNS0xMCAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pk
bnlha292QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtEUlRdIENsZWFyIGFkZGVkIHVzZXIg
c3R5bGUgc2hlZXRzIGJlZm9yZSBhIG5ldyB0ZXN0Y2FzZSBleGVjdXRpb24uCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwv
ZXdrL2V3a192aWV3LmNwcAppbmRleCA3YTBlZTFlZDZiYWViYzFmMjY1ZDY0NjQyMjY1MjZjMzk4
NjAxNjg3Li44ZWM4NjdkMjFlMjU2ZThlMTFiN2YwZDAzODljMDFmMDJhNTI0NmY1IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJL
aXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTI3NzgsOCArMjc3OCw3IEBAIEVpbmFfQm9vbCBl
d2tfdmlld19wYWludChFd2tfVmlld19Qcml2YXRlX0RhdGEqIHByaXYsIGNhaXJvX3QqIGNyLCBj
b25zdCBFaW5hX1JlCiAgICAgV2ViQ29yZTo6RnJhbWVWaWV3KiB2aWV3ID0gcHJpdi0+bWFpbkZy
YW1lLT52aWV3KCk7CiAgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKHZpZXcsIGZh
bHNlKTsKIAotICAgIGlmICh2aWV3LT5uZWVkc0xheW91dCgpKQotICAgICAgICB2aWV3LT5mb3Jj
ZUxheW91dCgpOworICAgIHZpZXctPnVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNp
dmUoKTsKICAgICBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQgZ3JhcGhpY3NDb250ZXh0KGNyKTsK
ICAgICBXZWJDb3JlOjpJbnRSZWN0IHJlY3QoKmFyZWEpOwogCkBAIC0yODA2LDYgKzI4MDUsNyBA
QCBFaW5hX0Jvb2wgZXdrX3ZpZXdfcGFpbnRfY29udGVudHMoRXdrX1ZpZXdfUHJpdmF0ZV9EYXRh
KiBwcml2LCBjYWlyb190KiBjciwgY29ucwogICAgIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCBn
cmFwaGljc0NvbnRleHQoY3IpOwogICAgIFdlYkNvcmU6OkludFJlY3QgcmVjdCgqYXJlYSk7CiAK
KyAgICB2aWV3LT51cGRhdGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVkUmVjdXJzaXZlKCk7CiAgICAg
Y2Fpcm9fc2F2ZShjcik7CiAgICAgZ3JhcGhpY3NDb250ZXh0LnNhdmUoKTsKICAgICBncmFwaGlj
c0NvbnRleHQuY2xpcChyZWN0KTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi
L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyNDUzNWVlM2ZlZmEwOWMyYzgyODJkMWY5ZmVk
NjFjMzdhZjBhYzMzLi41NDE4YmE3MTRmNzBiZmNkMzg3MDkwMTc0ZTYyNzNhMzllYzNjNzJlIDEw
MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDUtMTAgIERvbWluaWsgUsO2dHRzY2hlcyAgPGRv
bWluaWsucm90dHNjaGVzQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtEUlRdIGV3a192aWV3
X3BhaW50X2NvbnRlbnRzIG1heSB0cmlnZ2VyIGFzc2VydGlvbiBmYWlsdXJlCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTA1OAorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcHBpbmcgbWVkaWEtZnJh
Z21lbnRzIHRoYXQgcGFzcyBhZnRlciB0aGUgYXNzZXJ0aW9uIGZhaWx1cmUgd2FzIGZpeGVkLgor
CisgICAgICAgICogcGxhdGZvcm0vZWZsL1NraXBwZWQ6CisKIDIwMTItMDUtMTAgIEFsZXhhbmRl
ciBTaGFsYW1vdiAgPGFsZXhhbmRlci5zaGFsYW1vdkBpbnRlbC5jb20+CiAKICAgICAgICAgW0VG
TF1bRFJUXSBFdmVudFNlbmRlciAtIHNldCBkZWxheWVkIGV2ZW50IGluZm9ybWF0aW9uIGlmIGl0
IHdhcyBub3Qgc2V0IGJlZm9yZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZs
L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZAppbmRleCBlMWVmYmY5
NWQ2NjdiYjJjMzlmNzM4NDNlZTg2YmI3NDIzNjRiYzVkLi44ZDk1OTNmYjZmOWQ3ODAzOWNkMjc2
OWY1MWUwOTZiMTE1MDI1MTZhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwv
U2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZApAQCAtMTAzOCwx
NiArMTAzOCw2IEBAIG1lZGlhL21lZGlhLWZ1bGxzY3JlZW4tbm90LWluLWRvY3VtZW50Lmh0bWwK
IG1lZGlhL21lZGlhLWNvbnRyb2xsZXItcGxheWJhY2suaHRtbAogbWVkaWEvbWVkaWEtZWxlbWVu
dC1wbGF5LWFmdGVyLWVvcy5odG1sCiBtZWRpYS9tZWRpYS1leHRlbnNpb24td2l0aC1mcmFnbWVu
dC5odG1sCi1tZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDAxLVRDMDAwOS5odG1sCi1tZWRpYS9t
ZWRpYS1mcmFnbWVudHMvVEMwMDEwLVRDMDAxOS5odG1sCi1tZWRpYS9tZWRpYS1mcmFnbWVudHMv
VEMwMDIwLVRDMDAyOS5odG1sCi1tZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDMwLVRDMDAzOS5o
dG1sCi1tZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDQwLVRDMDA0OS5odG1sCi1tZWRpYS9tZWRp
YS1mcmFnbWVudHMvVEMwMDUwLVRDMDA1OS5odG1sCi1tZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMw
MDYwLVRDMDA2OS5odG1sCi1tZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDcwLVRDMDA3OS5odG1s
Ci1tZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDgwLVRDMDA4OS5odG1sCi1tZWRpYS9tZWRpYS1m
cmFnbWVudHMvVEMwMDkwLVRDMDA5OS5odG1sCiBtZWRpYS9tZWRpYS1pbml0aWFsVGltZS5odG1s
CiBtZWRpYS9tZWRpYS1sb2FkLWV2ZW50Lmh0bWwKIG1lZGlhL21lZGlhLXN0YXJ0VGltZS5odG1s
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>