85046 2012-04-27 03:19:26 -0700 [EFL] Add OwnPtr specialization for Eina_Hash. 2012-05-10 07:04:25 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 74921 0 mpakulavelrutka webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 611355 0 mpakulavelrutka 2012-04-27 03:19:26 -0700 OwnPtr does not have as support for Eina_Hash, this patch adds implementation so it can be used by https://bugs.webkit.org/show_bug.cgi?id=74921. 611359 1 139164 mpakulavelrutka 2012-04-27 03:22:06 -0700 Created attachment 139164 proposed patch 612306 2 139164 rakuco 2012-04-28 12:09:47 -0700 Comment on attachment 139164 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=139164&action=review > Source/WTF/wtf/OwnPtrCommon.h:47 > +typedef struct _Eina_Hash Eina_Hash; Please keep this list (as well as the others) sorted. 617472 3 140496 mpakulavelrutka 2012-05-07 02:21:22 -0700 Created attachment 140496 fixed order Fixed alphabetical order in OwnPtrCommon.h and moved new method above other Eina_* method as order is not kept there. 619643 4 rakuco 2012-05-09 10:51:45 -0700 LGTM. 620242 5 140496 gyuyoung.kim 2012-05-09 21:58:20 -0700 Comment on attachment 140496 fixed order Looks good. Thanks. 620553 6 140496 rakuco 2012-05-10 07:04:15 -0700 Comment on attachment 140496 fixed order Clearing flags on attachment: 140496 Committed r116640: <http://trac.webkit.org/changeset/116640> 620554 7 rakuco 2012-05-10 07:04:25 -0700 All reviewed patches have been landed. Closing bug. 139164 2012-04-27 03:22:06 -0700 2012-05-07 02:21:22 -0700 proposed patch ownptr.diff text/plain 1697 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMDBhN2VhNS4uYWM1YWMyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNC0yNyAg TWljaGHFgiBQYWt1xYJhIHZlbCBSdXRrYSAgPG0ucGFrdWxhQHNhbXN1bmcuY29tPgorCisgICAg ICAgIFtFRkxdIEFkZCBPd25QdHIgc3BlY2lhbGl6YXRpb24gZm9yIEVpbmFfSGFzaC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MDQ2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGFuIG92ZXJyaWRl IGZvciBFaW5hX0hhc2ggZm9yIEVGTCBwb3J0LgorCisgICAgICAgICogd3RmL093blB0ckNvbW1v bi5oOgorICAgICAgICAoV1RGKToKKyAgICAgICAgKiB3dGYvZWZsL093blB0ckVmbC5jcHA6Cisg ICAgICAgIChXVEY6OmRlbGV0ZU93bmVkUHRyKToKKyAgICAgICAgKFdURik6CisKIDIwMTItMDQt MjUgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFk ZCBhIHZlcnNpb24gb2YgU3RyaW5nSW1wbDo6ZmluZCgpIHdpdGhvdXQgb2Zmc2V0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9Pd25QdHJDb21tb24uaCBiL1NvdXJjZS9XVEYvd3RmL093blB0 ckNvbW1vbi5oCmluZGV4IGNlYTVhN2YuLjBlODEyY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL093blB0ckNvbW1vbi5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL093blB0ckNvbW1vbi5oCkBA IC00NCw2ICs0NCw3IEBAIHR5cGVkZWYgc3RydWN0IF9FY29yZV9QaXBlIEVjb3JlX1BpcGU7CiB0 eXBlZGVmIHN0cnVjdCBfRWNvcmVfVGltZXIgRWNvcmVfVGltZXI7CiB0eXBlZGVmIHN0cnVjdCBf RWluYV9Nb2R1bGUgRWluYV9Nb2R1bGU7CiB0eXBlZGVmIHN0cnVjdCBfRXZhc19PYmplY3QgRXZh c19PYmplY3Q7Cit0eXBlZGVmIHN0cnVjdCBfRWluYV9IYXNoIEVpbmFfSGFzaDsKICNlbmRpZgog CiBuYW1lc3BhY2UgV1RGIHsKQEAgLTcxLDYgKzcyLDcgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAg dm9pZCBkZWxldGVPd25lZFB0cihFY29yZV9UaW1lciopOwogICAgIHZvaWQgZGVsZXRlT3duZWRQ dHIoRWluYV9Nb2R1bGUqKTsKICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEV2YXNfT2JqZWN0Kik7 CisgICAgdm9pZCBkZWxldGVPd25lZFB0cihFaW5hX0hhc2gqKTsKICNlbmRpZgogCiB9IC8vIG5h bWVzcGFjZSBXVEYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL2VmbC9Pd25QdHJFZmwuY3Bw IGIvU291cmNlL1dURi93dGYvZWZsL093blB0ckVmbC5jcHAKaW5kZXggMzY3MTU1My4uNzBjMDcw OCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvZWZsL093blB0ckVmbC5jcHAKKysrIGIvU291 cmNlL1dURi93dGYvZWZsL093blB0ckVmbC5jcHAKQEAgLTYzLDQgKzYzLDEwIEBAIHZvaWQgZGVs ZXRlT3duZWRQdHIoRWNvcmVfVGltZXIqIHB0cikKICAgICAgICAgZWNvcmVfdGltZXJfZGVsKHB0 cik7CiB9CiAKK3ZvaWQgZGVsZXRlT3duZWRQdHIoRWluYV9IYXNoKiBwdHIpCit7CisgICAgaWYg KHB0cikKKyAgICAgICAgZWluYV9oYXNoX2ZyZWUocHRyKTsKK30KKwogfQo= 140496 2012-05-07 02:21:22 -0700 2012-05-10 07:04:15 -0700 fixed order ownptr_sort_fix.diff text/plain 1851 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMjQyNGU4ZC4uMWNmNGIzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNS0wNyAg TWljaGHFgiBQYWt1xYJhIHZlbCBSdXRrYSAgPG0ucGFrdWxhQHNhbXN1bmcuY29tPgorCisgICAg ICAgIFtFRkxdIEFkZCBPd25QdHIgc3BlY2lhbGl6YXRpb24gZm9yIEVpbmFfSGFzaC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MDQ2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGFuIG92ZXJyaWRl IGZvciBFaW5hX0hhc2ggZm9yIEVGTCBwb3J0LgorCisgICAgICAgICogd3RmL093blB0ckNvbW1v bi5oOgorICAgICAgICAoV1RGKToKKyAgICAgICAgKiB3dGYvZWZsL093blB0ckVmbC5jcHA6Cisg ICAgICAgIChXVEY6OmRlbGV0ZU93bmVkUHRyKToKKyAgICAgICAgKFdURik6CisKIDIwMTItMDUt MDQgIEplZmYgUm9nZXJzICA8anJvZ2Vyc0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5 XSBJbXBsZW1lbnQgbnVtYmVyT2ZQcm9jZXNzb3JDb3JlcygpIGZvciBRTlgKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL093blB0ckNvbW1vbi5oIGIvU291cmNlL1dURi93dGYvT3duUHRyQ29t bW9uLmgKaW5kZXggY2VhNWE3Zi4uODY2NzBlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv T3duUHRyQ29tbW9uLmgKKysrIGIvU291cmNlL1dURi93dGYvT3duUHRyQ29tbW9uLmgKQEAgLTQy LDYgKzQyLDcgQEAgdHlwZWRlZiBzdHJ1Y3QgSFJHTl9fKiBIUkdOOwogdHlwZWRlZiBzdHJ1Y3Qg X0Vjb3JlX0V2YXMgRWNvcmVfRXZhczsKIHR5cGVkZWYgc3RydWN0IF9FY29yZV9QaXBlIEVjb3Jl X1BpcGU7CiB0eXBlZGVmIHN0cnVjdCBfRWNvcmVfVGltZXIgRWNvcmVfVGltZXI7Cit0eXBlZGVm IHN0cnVjdCBfRWluYV9IYXNoIEVpbmFfSGFzaDsKIHR5cGVkZWYgc3RydWN0IF9FaW5hX01vZHVs ZSBFaW5hX01vZHVsZTsKIHR5cGVkZWYgc3RydWN0IF9FdmFzX09iamVjdCBFdmFzX09iamVjdDsK ICNlbmRpZgpAQCAtNjksNiArNzAsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICB2b2lkIGRlbGV0 ZU93bmVkUHRyKEVjb3JlX0V2YXMqKTsKICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEVjb3JlX1Bp cGUqKTsKICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEVjb3JlX1RpbWVyKik7CisgICAgdm9pZCBk ZWxldGVPd25lZFB0cihFaW5hX0hhc2gqKTsKICAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEVpbmFf TW9kdWxlKik7CiAgICAgdm9pZCBkZWxldGVPd25lZFB0cihFdmFzX09iamVjdCopOwogI2VuZGlm CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9lZmwvT3duUHRyRWZsLmNwcCBiL1NvdXJjZS9X VEYvd3RmL2VmbC9Pd25QdHJFZmwuY3BwCmluZGV4IDM2NzE1NTMuLjY1MDFhOTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvd3RmL2VmbC9Pd25QdHJFZmwuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3Rm L2VmbC9Pd25QdHJFZmwuY3BwCkBAIC01MSw2ICs1MSwxMiBAQCB2b2lkIGRlbGV0ZU93bmVkUHRy KEVjb3JlX1BpcGUqIHB0cikKICAgICAgICAgZWNvcmVfcGlwZV9kZWwocHRyKTsKIH0KIAordm9p ZCBkZWxldGVPd25lZFB0cihFaW5hX0hhc2gqIHB0cikKK3sKKyAgICBpZiAocHRyKQorICAgICAg ICBlaW5hX2hhc2hfZnJlZShwdHIpOworfQorCiB2b2lkIGRlbGV0ZU93bmVkUHRyKEVpbmFfTW9k dWxlKiBwdHIpCiB7CiAgICAgaWYgKHB0cikK