85027 2012-04-26 19:52:38 -0700 Generalize the single character optimization of numberProtoFuncToString 2012-04-27 12:14:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin benjamin ggaren oldest_to_newest 611198 0 benjamin 2012-04-26 19:52:38 -0700 Generalize the single character optimization of numberProtoFuncToString 611204 1 139125 benjamin 2012-04-26 20:01:59 -0700 Created attachment 139125 Patch 611240 2 139125 ggaren 2012-04-26 21:56:32 -0700 Comment on attachment 139125 Patch r=me 611770 3 139125 benjamin 2012-04-27 12:14:41 -0700 Comment on attachment 139125 Patch Clearing flags on attachment: 139125 Committed r115465: <http://trac.webkit.org/changeset/115465> 611771 4 benjamin 2012-04-27 12:14:44 -0700 All reviewed patches have been landed. Closing bug. 139125 2012-04-26 20:01:59 -0700 2012-04-27 12:14:41 -0700 Patch bug-85027-20120426200157.patch text/plain 3167 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 ZjZhZWIyYWYzYjI3YmU3ODA0ODc0Nzc1NWVkNDVkNTdmY2MxNDgwLi5jYmUyMmQ5MTIyZjI1ZmNk YmVjMmI1NGY0NWMwYmQyZTBlN2E2M2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxMi0wNC0yNiAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgR2VuZXJhbGl6ZSB0aGUgc2luZ2xlIGNoYXJhY3RlciBvcHRpbWl6 YXRpb24gb2YgbnVtYmVyUHJvdG9GdW5jVG9TdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZ1bmN0aW9uIG51bWJlclByb3RvRnVuY1RvU3Ry aW5nKCkgaGFzIGFuIG9wdGltaXphdGlvbiB0byB1c2UgU21hbGxTdHJpbmdzOjpzaW5nbGVDaGFy YWN0ZXJTdHJpbmcoKQorICAgICAgICB3aGVuIHRoZSByYWRpeCBpcyAzNi4KKworICAgICAgICBU aGlzIHBhdGNoIGdlbmVyYWxpemUgdGhlIG9wdGltaXphdGlvbiBmb3IgYW55IHJhZGl4LiBBbnkg cG9zaXRpdmUgbnVtYmVyIHNtYWxsZXIgdGhhbiBpdHMgcmFkaXgKKyAgICAgICAgY2FuIGJlIHJl cHJlc2VudGVkIGJ5IGEgc2luZ2xlIGNoYXJhY3RlciBvZiByYWRpeERpZ2l0cy4KKworICAgICAg ICBUaGlzIG1ha2VzIG51bWJlclByb3RvRnVuY1RvU3RyaW5nKCkgYWJvdXQgdHdpY2UgYXMgZmFz dCBmb3IgdGhpcyBjYXNlIG9mIHNpbmdsZSBkaWdpdCBjb252ZXJzaW9uLgorCisgICAgICAgICog cnVudGltZS9OdW1iZXJQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjpudW1iZXJQcm90b0Z1 bmNUb1N0cmluZyk6CisKIDIwMTItMDQtMjYgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNv bT4KIAogICAgICAgICBBbGxvY2F0aW5nIFdlYWtJbXBsIHNob3VsZCBub3QgdHJpZ2dlciBHQywg YXMgdGhhdCBtYWtlcyB0aGUgd29ybGQgdmVyeSB0cmlja3N5LgpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTnVtYmVyUHJvdG90eXBlLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL051bWJlclByb3RvdHlwZS5jcHAKaW5kZXggOGY4YzNjMDBmOTU4 ZjUwMTM2OWM5MjY2ODI0ODc0MGJkMzg5NGZhMy4uZmIyNzg4MzU4OWQ4MmI4NjY5ZDc4MWU2MzRk ZGExMzdjOTk0ZTQ5MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv TnVtYmVyUHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9O dW1iZXJQcm90b3R5cGUuY3BwCkBAIC00NDYsMjYgKzQ0NiwyNSBAQCBFbmNvZGVkSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIG51bWJlclByb3RvRnVuY1RvU3RyaW5nKEV4ZWNTdGF0ZSogZXhlYykKICAg ICBlbHNlCiAgICAgICAgIHJhZGl4ID0gc3RhdGljX2Nhc3Q8aW50PihyYWRpeFZhbHVlLnRvSW50 ZWdlcihleGVjKSk7IC8vIG5hbiAtPiAwCiAKLSAgICBpZiAocmFkaXggPT0gMTApCi0gICAgICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIoeCkudG9TdHJpbmcoZXhlYykpOworICAg IGlmIChyYWRpeCA8IDIgfHwgcmFkaXggPiAzNikKKyAgICAgICAgcmV0dXJuIHRocm93Vk1FcnJv cihleGVjLCBjcmVhdGVSYW5nZUVycm9yKGV4ZWMsICJ0b1N0cmluZygpIHJhZGl4IGFyZ3VtZW50 IG11c3QgYmUgYmV0d2VlbiAyIGFuZCAzNiIpKTsKIAogICAgIC8vIEZhc3QgcGF0aCBmb3IgbnVt YmVyIHRvIGNoYXJhY3RlciBjb252ZXJzaW9uLgotICAgIGlmIChyYWRpeCA9PSAzNikgewotICAg ICAgICB1bnNpZ25lZCBjID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHgpOwotICAgICAgICBpZiAo YyA9PSB4ICYmIGMgPCAzNikgewotICAgICAgICAgICAgSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRh ID0gJmV4ZWMtPmdsb2JhbERhdGEoKTsKLSAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNv ZGUoZ2xvYmFsRGF0YS0+c21hbGxTdHJpbmdzLnNpbmdsZUNoYXJhY3RlclN0cmluZyhnbG9iYWxE YXRhLCByYWRpeERpZ2l0c1tjXSkpOwotICAgICAgICB9CisgICAgdW5zaWduZWQgYyA9IHN0YXRp Y19jYXN0PHVuc2lnbmVkPih4KTsKKyAgICB1bnNpZ25lZCB1bnNpZ25lZFJhZGl4ID0gc3RhdGlj X2Nhc3Q8dW5zaWduZWQ+KHJhZGl4KTsKKyAgICBpZiAoYyA9PSB4ICYmIGMgPCB1bnNpZ25lZFJh ZGl4KSB7CisgICAgICAgIEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSA9ICZleGVjLT5nbG9iYWxE YXRhKCk7CisgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoZ2xvYmFsRGF0YS0+c21hbGxT dHJpbmdzLnNpbmdsZUNoYXJhY3RlclN0cmluZyhnbG9iYWxEYXRhLCByYWRpeERpZ2l0c1tjXSkp OwogICAgIH0KIAotICAgIGlmIChyYWRpeCA8IDIgfHwgcmFkaXggPiAzNikKLSAgICAgICAgcmV0 dXJuIHRocm93Vk1FcnJvcihleGVjLCBjcmVhdGVSYW5nZUVycm9yKGV4ZWMsICJ0b1N0cmluZygp IHJhZGl4IGFyZ3VtZW50IG11c3QgYmUgYmV0d2VlbiAyIGFuZCAzNiIpKTsKKyAgICBpZiAocmFk aXggPT0gMTApCisgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIoeCkudG9T dHJpbmcoZXhlYykpOwogCiAgICAgaWYgKCFpc2Zpbml0ZSh4KSkKICAgICAgICAgcmV0dXJuIEpT VmFsdWU6OmVuY29kZShqc1N0cmluZyhleGVjLCBVU3RyaW5nOjpudW1iZXIoeCkpKTsKIAogICAg IFJhZGl4QnVmZmVyIHM7Ci0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1N0cmluZyhleGVj LCB0b1N0cmluZ1dpdGhSYWRpeChzLCB4LCByYWRpeCkpKTsKKyAgICByZXR1cm4gSlNWYWx1ZTo6 ZW5jb2RlKGpzU3RyaW5nKGV4ZWMsIHRvU3RyaW5nV2l0aFJhZGl4KHMsIHgsIHVuc2lnbmVkUmFk aXgpKSk7CiB9CiAKIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgbnVtYmVyUHJvdG9GdW5j VG9Mb2NhbGVTdHJpbmcoRXhlY1N0YXRlKiBleGVjKQo=