85022 2012-04-26 17:48:41 -0700 [V8] Pass Isolate around in getDOMXXXMap() 2012-04-27 15:25:19 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 611128 0 haraken 2012-04-26 17:48:41 -0700 The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to getDOMXXXMap(). 611134 1 139111 haraken 2012-04-26 17:55:27 -0700 Created attachment 139111 Patch 611907 2 haraken 2012-04-27 14:37:54 -0700 Committed r115495: <http://trac.webkit.org/changeset/115495> 139111 2012-04-26 17:55:27 -0700 2012-04-27 15:25:19 -0700 Patch bug-85022-20120426175525.patch text/plain 6124 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWNmZDhiZTA2NzYwYTdm NDVjMjZlYWI0Yzk2MjY2ZDBhYjZlNzMwNS4uNTBhYjUzNWYwYWVjNTFkZWU2OGYwMzZhOGI4YzUy NDhlNjU3MDg3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTA0LTI2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byBnZXRET01YWFhNYXAoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODUwMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgb2JqZWN0aXZlIGlzIHRvIHBhc3MgSXNvbGF0ZSBhcm91bmQgaW4g VjggYmluZGluZ3MuCisgICAgICAgIFRoaXMgcGF0Y2ggcGFzc2VzIElzb2xhdGUgdG8gZ2V0RE9N WFhYTWFwKCkuCisKKyAgICAgICAgQWxzbyB0aGlzIHBhdGNoIHJlbW92ZXMgRE9NTWFwOjpnZXRE T01EYXRhU3RvcmUoKSBhbmQKKyAgICAgICAgRE9NRGF0YTo6Z2V0RGVmYWx1dFN0b3JlKCksIHNp bmNlIHRoZSBpbmRpcmVjdGlvbiBieSB0aGUKKyAgICAgICAgbWV0aG9kcyBpcyByZWR1bmRhbnQu IFRoaXMgaXMgbm90IGZvciBwZXJmb3JtYW5jZQorICAgICAgICBvcHRpbWl6YXRpb24gYnV0IGp1 c3QgZm9yIHJlZmFjdG9yaW5nLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9ET01EYXRhLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkRPTURhdGE6OmdldEN1cnJlbnRTdG9yZSk6CisgICAgICAgICogYmluZGluZ3Mvdjgv RE9NRGF0YS5oOgorICAgICAgICAoRE9NRGF0YSk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhE T01NYXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0RE9NTm9kZU1hcCk6CisgICAgICAgIChX ZWJDb3JlOjpnZXRBY3RpdmVET01Ob2RlTWFwKToKKyAgICAgICAgKFdlYkNvcmU6OmdldERPTU9i amVjdE1hcCk6CisgICAgICAgIChXZWJDb3JlOjpnZXRBY3RpdmVET01PYmplY3RNYXApOgorICAg ICAgICAoV2ViQ29yZTo6cmVtb3ZlQWxsRE9NT2JqZWN0cyk6CisgICAgICAgICogYmluZGluZ3Mv djgvVjhET01NYXAuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEyLTA0LTI2ICBTaGF3biBT aW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlLWltcGxlbWVudCBi YWNrRmFjZVZpc2liaWxpdHkgdG8gYXZvaWQgZGVhbGluZyB3aXRoIHBlcnNwZWN0aXZlIHcgPCAw IHByb2JsZW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGEu Y3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YS5jcHAKaW5kZXggYWI1YzIx MjNkN2ZmZWQ5Njk0YTMyODA5OTY4M2M3Zjk4ZGQyZmFjZS4uYzNmYWY5ODlmYjg2ZTc1Y2ZkYmJi YTAyYWEwZWViZmZlY2IzY2RlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvRE9NRGF0YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YS5j cHAKQEAgLTM3LDIxICszNywxNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXN0YXRpYyBT dGF0aWNET01EYXRhU3RvcmUmIGdldERlZmF1bHRTdG9yZSgpIAorRE9NRGF0YVN0b3JlJiBET01E YXRhOjpnZXRDdXJyZW50U3RvcmUodjg6Oklzb2xhdGUqIGlzb2xhdGUpCiB7CiAgICAgREVGSU5F X1NUQVRJQ19MT0NBTChTdGF0aWNET01EYXRhU3RvcmUsIGRlZmF1bHRTdG9yZSwgKCkpOwotICAg IHJldHVybiBkZWZhdWx0U3RvcmU7Ci19Ci0KLURPTURhdGFTdG9yZSYgRE9NRGF0YTo6Z2V0Q3Vy cmVudFN0b3JlKCkKLXsKICAgICBWOEJpbmRpbmdQZXJJc29sYXRlRGF0YSogZGF0YSA9IFY4Qmlu ZGluZ1Blcklzb2xhdGVEYXRhOjpjdXJyZW50KCk7CiAgICAgaWYgKFVOTElLRUxZKGRhdGEtPmRv bURhdGFTdG9yZSgpICE9IDApKQogICAgICAgICByZXR1cm4gKmRhdGEtPmRvbURhdGFTdG9yZSgp OwogICAgIFY4SXNvbGF0ZWRDb250ZXh0KiBjb250ZXh0ID0gVjhJc29sYXRlZENvbnRleHQ6Omdl dEVudGVyZWQoKTsKICAgICBpZiAoVU5MSUtFTFkoY29udGV4dCAhPSAwKSkKICAgICAgICAgcmV0 dXJuICpjb250ZXh0LT53b3JsZCgpLT5kb21EYXRhU3RvcmUoKTsKLSAgICByZXR1cm4gZ2V0RGVm YXVsdFN0b3JlKCk7CisgICAgcmV0dXJuIGRlZmF1bHRTdG9yZTsKIH0KIAogdm9pZCBET01EYXRh OjpkZXJlZk9iamVjdChXcmFwcGVyVHlwZUluZm8qIHR5cGUsIHZvaWQqIGRvbU9iamVjdCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGEuaCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGEuaAppbmRleCA3MWU3ZTU4YWNkZmI5MTExZDZlNTEw N2EwZjIzN2JhNzNjNGNlMDExLi43ZGY5ZGZkYmE5ZTI4YWUxZWQ0ZjU0MzgwNTQ2MDQ2ZTU2MDk2 ZGRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01EYXRhLmgKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YS5oCkBAIC01Myw3ICs1Myw3IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgc3RhdGljIHZvaWQgcmVtb3ZlT2JqZWN0c0Zy b21XcmFwcGVyTWFwKERPTURhdGFTdG9yZSogc3RvcmUsIEFic3RyYWN0V2Vha1JlZmVyZW5jZU1h cDxULCB2ODo6T2JqZWN0PiYgZG9tTWFwKTsKIAogCi0gICAgICAgIHN0YXRpYyBET01EYXRhU3Rv cmUmIGdldEN1cnJlbnRTdG9yZSgpOworICAgICAgICBzdGF0aWMgRE9NRGF0YVN0b3JlJiBnZXRD dXJyZW50U3RvcmUodjg6Oklzb2xhdGUqID0gMCk7CiAgICAgcHJpdmF0ZToKICAgICAgICAgRE9N RGF0YSgpOwogICAgICAgICBzdGF0aWMgdm9pZCBkZXJlZk9iamVjdChXcmFwcGVyVHlwZUluZm8q IHR5cGUsIHZvaWQqIGRvbU9iamVjdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOERPTU1hcC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTU1h cC5jcHAKaW5kZXggY2U4MDQyNTVlZWM1OTBjNmQ0MzhkNGJkNjFiY2EwNWRiMzM3N2Q2OC4uZjA5 YTRhODk1NDJlNTgxMzgyYzU4Yzk3NzdhMzc1YzM0Y2Y0NTEwYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01NYXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4RE9NTWFwLmNwcApAQCAtNTAsMzggKzUwLDMzIEBAIERPTURhdGFTdG9yZUhh bmRsZTo6fkRPTURhdGFTdG9yZUhhbmRsZSgpCiAgICAgVjhCaW5kaW5nUGVySXNvbGF0ZURhdGE6 OmN1cnJlbnQoKS0+dW5yZWdpc3RlckRPTURhdGFTdG9yZShtX3N0b3JlLmdldCgpKTsKIH0KIAot c3RhdGljIGlubGluZSBET01EYXRhU3RvcmUmIGdldERPTURhdGFTdG9yZSgpCi17Ci0gICAgcmV0 dXJuIERPTURhdGE6OmdldEN1cnJlbnRTdG9yZSgpOwotfQotCiB2b2lkIGVuYWJsZUZhc3RlckRP TVN0b3JlQWNjZXNzKCkKIHsKIH0KIAotRE9NTm9kZU1hcHBpbmcmIGdldERPTU5vZGVNYXAoKQor RE9NTm9kZU1hcHBpbmcmIGdldERPTU5vZGVNYXAodjg6Oklzb2xhdGUqIGlzb2xhdGUpCiB7Ci0g ICAgcmV0dXJuIGdldERPTURhdGFTdG9yZSgpLmRvbU5vZGVNYXAoKTsKKyAgICByZXR1cm4gRE9N RGF0YTo6Z2V0Q3VycmVudFN0b3JlKGlzb2xhdGUpLmRvbU5vZGVNYXAoKTsKIH0KIAotRE9NTm9k ZU1hcHBpbmcmIGdldEFjdGl2ZURPTU5vZGVNYXAoKQorRE9NTm9kZU1hcHBpbmcmIGdldEFjdGl2 ZURPTU5vZGVNYXAodjg6Oklzb2xhdGUqIGlzb2xhdGUpCiB7Ci0gICAgcmV0dXJuIGdldERPTURh dGFTdG9yZSgpLmFjdGl2ZURvbU5vZGVNYXAoKTsKKyAgICByZXR1cm4gRE9NRGF0YTo6Z2V0Q3Vy cmVudFN0b3JlKGlzb2xhdGUpLmFjdGl2ZURvbU5vZGVNYXAoKTsKIH0KIAotRE9NV3JhcHBlck1h cDx2b2lkPiYgZ2V0RE9NT2JqZWN0TWFwKCkKK0RPTVdyYXBwZXJNYXA8dm9pZD4mIGdldERPTU9i amVjdE1hcCh2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKLSAgICByZXR1cm4gZ2V0RE9NRGF0YVN0 b3JlKCkuZG9tT2JqZWN0TWFwKCk7CisgICAgcmV0dXJuIERPTURhdGE6OmdldEN1cnJlbnRTdG9y ZShpc29sYXRlKS5kb21PYmplY3RNYXAoKTsKIH0KIAotRE9NV3JhcHBlck1hcDx2b2lkPiYgZ2V0 QWN0aXZlRE9NT2JqZWN0TWFwKCkKK0RPTVdyYXBwZXJNYXA8dm9pZD4mIGdldEFjdGl2ZURPTU9i amVjdE1hcCh2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKLSAgICByZXR1cm4gZ2V0RE9NRGF0YVN0 b3JlKCkuYWN0aXZlRG9tT2JqZWN0TWFwKCk7CisgICAgcmV0dXJuIERPTURhdGE6OmdldEN1cnJl bnRTdG9yZShpc29sYXRlKS5hY3RpdmVEb21PYmplY3RNYXAoKTsKIH0KIAogdm9pZCByZW1vdmVB bGxET01PYmplY3RzKCkKIHsKLSAgICBET01EYXRhU3RvcmUmIHN0b3JlID0gZ2V0RE9NRGF0YVN0 b3JlKCk7CisgICAgRE9NRGF0YVN0b3JlJiBzdG9yZSA9IERPTURhdGE6OmdldEN1cnJlbnRTdG9y ZSgpOwogCiAgICAgdjg6OkhhbmRsZVNjb3BlIHNjb3BlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTU1hcC5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhET01NYXAuaAppbmRleCA3ZWMxMTA1MmM3MjkxOWEyNWM2NDcyYzAxMGRkNGZiYWNlN2E0 MGRlLi5iYzUxNTQwYTJkOTAyYzllMjRlNTNhZGFhNjM4YzdmZmMwMTJiZjkxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTU1hcC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4RE9NTWFwLmgKQEAgLTE1MSwxNyArMTUxLDE3IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKICAgICB9OwogCiAgICAgLy8gQSBtYXAgZnJvbSBET00gbm9kZSB0byBpdHMg SlMgd3JhcHBlci4KLSAgICBET01Ob2RlTWFwcGluZyYgZ2V0RE9NTm9kZU1hcCgpOwotICAgIERP TU5vZGVNYXBwaW5nJiBnZXRBY3RpdmVET01Ob2RlTWFwKCk7CisgICAgRE9NTm9kZU1hcHBpbmcm IGdldERPTU5vZGVNYXAodjg6Oklzb2xhdGUqID0gMCk7CisgICAgRE9NTm9kZU1hcHBpbmcmIGdl dEFjdGl2ZURPTU5vZGVNYXAodjg6Oklzb2xhdGUqID0gMCk7CiAgICAgdm9pZCB2aXNpdERPTU5v ZGVzKERPTVdyYXBwZXJNYXA8Tm9kZT46OlZpc2l0b3IqKTsKICAgICB2b2lkIHZpc2l0QWN0aXZl RE9NTm9kZXMoRE9NV3JhcHBlck1hcDxOb2RlPjo6VmlzaXRvciopOwogCiAgICAgLy8gQSBtYXAg ZnJvbSBhIERPTSBvYmplY3QgKG5vbi1ub2RlKSB0byBpdHMgSlMgd3JhcHBlci4gVGhpcyBtYXAg ZG9lcyBub3QgY29udGFpbiB0aGUgRE9NIG9iamVjdHMgd2hpY2ggY2FuIGhhdmUgcGVuZGluZyBh Y3Rpdml0eSAoYWN0aXZlIGRvbSBvYmplY3RzKS4KLSAgICBET01XcmFwcGVyTWFwPHZvaWQ+JiBn ZXRET01PYmplY3RNYXAoKTsKKyAgICBET01XcmFwcGVyTWFwPHZvaWQ+JiBnZXRET01PYmplY3RN YXAodjg6Oklzb2xhdGUqID0gMCk7CiAgICAgdm9pZCB2aXNpdERPTU9iamVjdHMoRE9NV3JhcHBl ck1hcDx2b2lkPjo6VmlzaXRvciopOwogCiAgICAgLy8gQSBtYXAgZnJvbSBhIERPTSBvYmplY3Qg dG8gaXRzIEpTIHdyYXBwZXIgZm9yIERPTSBvYmplY3RzIHdoaWNoIGNhbiBoYXZlIHBlbmRpbmcg YWN0aXZpdHkuCi0gICAgRE9NV3JhcHBlck1hcDx2b2lkPiYgZ2V0QWN0aXZlRE9NT2JqZWN0TWFw KCk7CisgICAgRE9NV3JhcHBlck1hcDx2b2lkPiYgZ2V0QWN0aXZlRE9NT2JqZWN0TWFwKHY4OjpJ c29sYXRlKiA9IDApOwogICAgIHZvaWQgdmlzaXRBY3RpdmVET01PYmplY3RzKERPTVdyYXBwZXJN YXA8dm9pZD46OlZpc2l0b3IqKTsKIAogICAgIC8vIFRoaXMgc2hvdWxkIGJlIGNhbGxlZCB0byBy ZW1vdmUgYWxsIERPTSBvYmplY3RzIGFzc29jaWF0ZWQgd2l0aCB0aGUgY3VycmVudCB0aHJlYWQg d2hlbiBpdCBpcyB0ZWFyaW5nIGRvd24uCg==