85020 2012-04-26 17:44:13 -0700 Allocating WeakImpl should not trigger GC, as that makes the world very tricksy. 2012-04-26 17:50:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 611122 0 oliver 2012-04-26 17:44:13 -0700 Allocating WeakImpl should not trigger GC, as that makes the world very tricksy. 611124 1 139107 oliver 2012-04-26 17:46:28 -0700 Created attachment 139107 Patch 611130 2 oliver 2012-04-26 17:50:54 -0700 Committed r115391: <http://trac.webkit.org/changeset/115391> 139107 2012-04-26 17:46:28 -0700 2012-04-26 17:48:06 -0700 Patch bug-85020-20120426174627.patch text/plain 2339 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NmQxZWViYWQ2ZmM3NGNjNGQ3OTM4ZjFjMTA3NDczMWM0NWUyOTQzLi5hMDM4N2M2YmI3Y2JmZDE1 YzBlYjM5YTU2NTMyMGQ0MWQzNGIzMGM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMiBAQAogMjAxMi0wNC0yNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgog CisgICAgICAgIEFsbG9jYXRpbmcgV2Vha0ltcGwgc2hvdWxkIG5vdCB0cmlnZ2VyIEdDLCBhcyB0 aGF0IG1ha2VzIHRoZSB3b3JsZCB2ZXJ5IHRyaWNrc3kuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTAyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdyBpbiB0aGUgZXZlbnQgdGhhdCB3ZSBhcmUgdW5h YmxlIHRvIGZpbmQgYW4gYWxsb2NhdG9yIGZvciBhIG5ldyBoYW5kbGUsIGp1c3QKKyAgICAgICAg YWRkIGEgbmV3IGFsbG9jYXRvciByYXRoZXIgdGhhbiB0cnlpbmcgdG8gcmVjb3ZlciAiZGVhZCIg aGFuZGxlcyB0aHJvdWdoIGEgR0MuCisKKyAgICAgICAgRmluZCBhbGxvY2F0b3IgaXMgbm93IG11 Y2ggc2ltcGxlciwgYW5kIGFkZEFsbG9jYXRvciBkaXJlY3RseSByZXBvcnRzIHRoZQorICAgICAg ICBpbmNyZWFzZWQgbWVtb3J5IHVzYWdlIHRvIHRoZSBoZWFwIHdpdGhvdXQgY2F1c2luZyBhbnkg R0MgdG8gaGFwcGVuIGltbWVkaWF0ZWx5LgorCisgICAgICAgICogaGVhcC9XZWFrU2V0LmNwcDoK KyAgICAgICAgKEpTQzo6V2Vha1NldDo6ZmluZEFsbG9jYXRvcik6CisgICAgICAgIChKU0M6Oldl YWtTZXQ6OmFkZEFsbG9jYXRvcik6CisKKzIwMTItMDQtMjYgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKwogICAgICAgICBSZW1vdmUgUmVnaXN0ZXJGaWxlOjplbmQoKS9tX2VuZAog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUwMTEKIApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvV2Vha1NldC5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9XZWFrU2V0LmNwcAppbmRleCBiYTQ2ZWY3NmIwNmRhMzk3 ZThkODNmZmEwN2IwYTQ2ZjAwMDkzODE0Li5hMjdlMGMyMjhmZjllZDkwODllMjE2Mzc1MmQwMTg0 ZjI3NWJhYjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9XZWFrU2V0 LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9XZWFrU2V0LmNwcApAQCAtOTUs MTYgKzk1LDYgQEAgV2Vha0Jsb2NrOjpGcmVlQ2VsbCogV2Vha1NldDo6ZmluZEFsbG9jYXRvcigp CiAgICAgaWYgKFdlYWtCbG9jazo6RnJlZUNlbGwqIGFsbG9jYXRvciA9IHRyeUZpbmRBbGxvY2F0 b3IoKSkKICAgICAgICAgcmV0dXJuIGFsbG9jYXRvcjsKIAotICAgIC8vIEZJWE1FOiBUaGlzIHJl cG9ydGluZyBvZiB0aGUgYW1vdW50IGFsbG9jYXRlZCBpc24ndCBxdWl0ZSBhY2N1cmF0ZSBhbmQg Ci0gICAgLy8gcHJvYmFibHkgc2hvdWxkIGJlIHJld29ya2VkIGV2ZW50dWFsbHkuCi0gICAgbV9o ZWFwLT5kaWRBbGxvY2F0ZShXZWFrQmxvY2s6OmJsb2NrU2l6ZSk7Ci0gICAgaWYgKG1faGVhcC0+ c2hvdWxkQ29sbGVjdCgpKSB7Ci0gICAgICAgIG1faGVhcC0+Y29sbGVjdChIZWFwOjpEb05vdFN3 ZWVwKTsKLQotICAgICAgICBpZiAoV2Vha0Jsb2NrOjpGcmVlQ2VsbCogYWxsb2NhdG9yID0gdHJ5 RmluZEFsbG9jYXRvcigpKQotICAgICAgICAgICAgcmV0dXJuIGFsbG9jYXRvcjsKLSAgICB9Ci0K ICAgICByZXR1cm4gYWRkQWxsb2NhdG9yKCk7CiB9CiAKQEAgLTEyNiw2ICsxMTYsNyBAQCBXZWFr QmxvY2s6OkZyZWVDZWxsKiBXZWFrU2V0Ojp0cnlGaW5kQWxsb2NhdG9yKCkKIFdlYWtCbG9jazo6 RnJlZUNlbGwqIFdlYWtTZXQ6OmFkZEFsbG9jYXRvcigpCiB7CiAgICAgV2Vha0Jsb2NrKiBibG9j ayA9IFdlYWtCbG9jazo6Y3JlYXRlKCk7CisgICAgbV9oZWFwLT5kaWRBbGxvY2F0ZShXZWFrQmxv Y2s6OmJsb2NrU2l6ZSk7CiAgICAgbV9ibG9ja3MuYXBwZW5kKGJsb2NrKTsKICAgICBXZWFrQmxv Y2s6OlN3ZWVwUmVzdWx0IHN3ZWVwUmVzdWx0ID0gYmxvY2stPnRha2VTd2VlcFJlc3VsdCgpOwog ICAgIEFTU0VSVCghc3dlZXBSZXN1bHQuaXNOdWxsKCkgJiYgc3dlZXBSZXN1bHQuZnJlZUxpc3Qp Owo=