84998 2012-04-26 13:34:03 -0700 Cleanup WebMediaPlayer enum values that didn't match Chromium style guidelines 2012-04-26 18:06:10 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 acolwell acolwell abarth dglazkov eric.carlson feature-media-reviews fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 610907 0 acolwell 2012-04-26 13:34:03 -0700 This is finish the WebMediaPlayer enum style cleanup that was started in http://webk.it/84046 . The Chromium code now uses the new enum value names so the old ones can be removed now. 610913 1 139059 acolwell 2012-04-26 13:36:47 -0700 Created attachment 139059 Patch 610924 2 webkit.review.bot 2012-04-26 13:41:04 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 611141 3 139059 webkit.review.bot 2012-04-26 18:06:04 -0700 Comment on attachment 139059 Patch Clearing flags on attachment: 139059 Committed r115393: <http://trac.webkit.org/changeset/115393> 611142 4 webkit.review.bot 2012-04-26 18:06:10 -0700 All reviewed patches have been landed. Closing bug. 139059 2012-04-26 13:36:47 -0700 2012-04-26 18:06:04 -0700 Patch bug-84998-20120426133646.patch text/plain 4656 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhNzg0ZTM3YTZjZGU5YTIyNzU2YWRmNGExNzExMjJhZDljMTIwMDAuLjU0OTFiZDdkNmMzMTdi OWE4NTVhMTAxMTVkYWJmNmI3NTM5YzRiM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDQtMjYgIEFhcm9uIENvbHdlbGwgIDxhY29sd2VsbEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgQ2xlYW51cCBXZWJNZWRpYVBsYXllciBlbnVtIHZhbHVlcyB0 aGF0IGRpZG4ndCBtYXRjaCBDaHJvbWl1bSBzdHlsZSBndWlkZWxpbmVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDk5OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVy Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYk1lZGlhUGxheWVyOjpnZW5lcmF0ZUtleVJlcXVlc3Qp OgorICAgICAgICAoV2ViS2l0OjpXZWJNZWRpYVBsYXllcjo6YWRkS2V5KToKKyAgICAgICAgKFdl YktpdDo6V2ViTWVkaWFQbGF5ZXI6OmNhbmNlbEtleVJlcXVlc3QpOgorCiAyMDEyLTA0LTI2ICBK b3NodWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBJ bmRleGVkREI6IFVzZSBXZWJJREJLZXlQYXRoIHR5cGUgZm9yIGtleSBwYXRocyBpbiBXZWJLaXQg QVBJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBs YXllci5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXIuaApp bmRleCBmMzk0NjlmMWUxNzBkMjMyYWRkYWRlZjk3ZWIxMDE4MzM0MGRhOGQ4Li5jM2E0OGM3YTVk NTMxZjk0ZTVmMjkyYzE4NTljYmU3MDlmNjJkYWFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyLmgKQEAgLTU3LDEzICs1Nyw2IEBAIHB1YmxpYzoK ICAgICAgICAgTmV0d29ya1N0YXRlRm9ybWF0RXJyb3IsCiAgICAgICAgIE5ldHdvcmtTdGF0ZU5l dHdvcmtFcnJvciwKICAgICAgICAgTmV0d29ya1N0YXRlRGVjb2RlRXJyb3IsCi0gICAgICAgIEVt cHR5ID0gTmV0d29ya1N0YXRlRW1wdHksCi0gICAgICAgIElkbGUgPSBOZXR3b3JrU3RhdGVJZGxl LAotICAgICAgICBMb2FkaW5nID0gTmV0d29ya1N0YXRlTG9hZGluZywKLSAgICAgICAgTG9hZGVk ID0gTmV0d29ya1N0YXRlTG9hZGVkLAotICAgICAgICBGb3JtYXRFcnJvciA9IE5ldHdvcmtTdGF0 ZUZvcm1hdEVycm9yLAotICAgICAgICBOZXR3b3JrRXJyb3IgPSBOZXR3b3JrU3RhdGVOZXR3b3Jr RXJyb3IsCi0gICAgICAgIERlY29kZUVycm9yID0gTmV0d29ya1N0YXRlRGVjb2RlRXJyb3IsCiAg ICAgfTsKIAogICAgIGVudW0gUmVhZHlTdGF0ZSB7CkBAIC03MiwxMSArNjUsNiBAQCBwdWJsaWM6 CiAgICAgICAgIFJlYWR5U3RhdGVIYXZlQ3VycmVudERhdGEsCiAgICAgICAgIFJlYWR5U3RhdGVI YXZlRnV0dXJlRGF0YSwKICAgICAgICAgUmVhZHlTdGF0ZUhhdmVFbm91Z2hEYXRhLAotICAgICAg ICBIYXZlTm90aGluZyA9IFJlYWR5U3RhdGVIYXZlTm90aGluZywKLSAgICAgICAgSGF2ZU1ldGFk YXRhID0gUmVhZHlTdGF0ZUhhdmVNZXRhZGF0YSwKLSAgICAgICAgSGF2ZUN1cnJlbnREYXRhID0g UmVhZHlTdGF0ZUhhdmVDdXJyZW50RGF0YSwKLSAgICAgICAgSGF2ZUZ1dHVyZURhdGEgPSBSZWFk eVN0YXRlSGF2ZUZ1dHVyZURhdGEsCi0gICAgICAgIEhhdmVFbm91Z2hEYXRhID0gUmVhZHlTdGF0 ZUhhdmVFbm91Z2hEYXRhLAogICAgIH07CiAKICAgICBlbnVtIE1vdmllTG9hZFR5cGUgewpAQCAt ODQsMTkgKzcyLDEyIEBAIHB1YmxpYzoKICAgICAgICAgTW92aWVMb2FkVHlwZURvd25sb2FkLAog ICAgICAgICBNb3ZpZUxvYWRUeXBlU3RvcmVkU3RyZWFtLAogICAgICAgICBNb3ZpZUxvYWRUeXBl TGl2ZVN0cmVhbSwKLSAgICAgICAgVW5rbm93biA9IE1vdmllTG9hZFR5cGVVbmtub3duLAotICAg ICAgICBEb3dubG9hZCA9IE1vdmllTG9hZFR5cGVEb3dubG9hZCwKLSAgICAgICAgU3RvcmVkU3Ry ZWFtID0gTW92aWVMb2FkVHlwZVN0b3JlZFN0cmVhbSwKLSAgICAgICAgTGl2ZVN0cmVhbSA9IE1v dmllTG9hZFR5cGVMaXZlU3RyZWFtLAogICAgIH07CiAKICAgICBlbnVtIFByZWxvYWQgewogICAg ICAgICBQcmVsb2FkTm9uZSwKICAgICAgICAgUHJlbG9hZE1ldGFEYXRhLAogICAgICAgICBQcmVs b2FkQXV0bywKLSAgICAgICAgTm9uZSA9IFByZWxvYWROb25lLAotICAgICAgICBNZXRhRGF0YSA9 IFByZWxvYWRNZXRhRGF0YSwKLSAgICAgICAgQXV0byA9IFByZWxvYWRBdXRvLAogICAgIH07CiAK ICAgICBlbnVtIEFkZElkU3RhdHVzIHsKQEAgLTEwOSw5ICs5MCw2IEBAIHB1YmxpYzoKICAgICAg ICAgRW5kT2ZTdHJlYW1TdGF0dXNOb0Vycm9yLAogICAgICAgICBFbmRPZlN0cmVhbVN0YXR1c05l dHdvcmtFcnJvciwKICAgICAgICAgRW5kT2ZTdHJlYW1TdGF0dXNEZWNvZGVFcnJvciwKLSAgICAg ICAgRW9zTm9FcnJvciA9IEVuZE9mU3RyZWFtU3RhdHVzTm9FcnJvciwKLSAgICAgICAgRW9zTmV0 d29ya0Vycm9yID0gRW5kT2ZTdHJlYW1TdGF0dXNOZXR3b3JrRXJyb3IsCi0gICAgICAgIEVvc0Rl Y29kZUVycm9yID0gRW5kT2ZTdHJlYW1TdGF0dXNEZWNvZGVFcnJvciwKICAgICB9OwogCiAgICAg Ly8gUmVwcmVzZW50cyBzeW5jaHJvbm91cyBleGNlcHRpb25zIHRoYXQgY2FuIGJlIHRocm93biBm cm9tIHRoZSBFbmNyeXB0ZWQKQEAgLTEyMCw5ICs5OCw2IEBAIHB1YmxpYzoKICAgICAgICAgTWVk aWFLZXlFeGNlcHRpb25Ob0Vycm9yLAogICAgICAgICBNZWRpYUtleUV4Y2VwdGlvbkludmFsaWRQ bGF5ZXJTdGF0ZSwKICAgICAgICAgTWVkaWFLZXlFeGNlcHRpb25LZXlTeXN0ZW1Ob3RTdXBwb3J0 ZWQsCi0gICAgICAgIE5vRXJyb3IgPSBNZWRpYUtleUV4Y2VwdGlvbk5vRXJyb3IsCi0gICAgICAg IEludmFsaWRQbGF5ZXJTdGF0ZSA9IE1lZGlhS2V5RXhjZXB0aW9uSW52YWxpZFBsYXllclN0YXRl LAotICAgICAgICBLZXlTeXN0ZW1Ob3RTdXBwb3J0ZWQgPSBNZWRpYUtleUV4Y2VwdGlvbktleVN5 c3RlbU5vdFN1cHBvcnRlZCwKICAgICB9OwogCiAgICAgdmlydHVhbCB+V2ViTWVkaWFQbGF5ZXIo KSB7fQpAQCAtMjA1LDkgKzE4MCw5IEBAIHB1YmxpYzoKIAogICAgIC8vIFJldHVybnMgd2hldGhl ciBrZXlTeXN0ZW0gaXMgc3VwcG9ydGVkLiBJZiB0cnVlLCB0aGUgcmVzdWx0IHdpbGwgYmUKICAg ICAvLyByZXBvcnRlZCBieSBhbiBldmVudC4KLSAgICB2aXJ0dWFsIE1lZGlhS2V5RXhjZXB0aW9u IGdlbmVyYXRlS2V5UmVxdWVzdChjb25zdCBXZWJTdHJpbmcmIGtleVN5c3RlbSwgY29uc3QgdW5z aWduZWQgY2hhciogaW5pdERhdGEsIHVuc2lnbmVkIGluaXREYXRhTGVuZ3RoKSB7IHJldHVybiBL ZXlTeXN0ZW1Ob3RTdXBwb3J0ZWQ7IH0KLSAgICB2aXJ0dWFsIE1lZGlhS2V5RXhjZXB0aW9uIGFk ZEtleShjb25zdCBXZWJTdHJpbmcmIGtleVN5c3RlbSwgY29uc3QgdW5zaWduZWQgY2hhcioga2V5 LCB1bnNpZ25lZCBrZXlMZW5ndGgsIGNvbnN0IHVuc2lnbmVkIGNoYXIqIGluaXREYXRhLCB1bnNp Z25lZCBpbml0RGF0YUxlbmd0aCwgY29uc3QgV2ViU3RyaW5nJiBzZXNzaW9uSWQpIHsgcmV0dXJu IEtleVN5c3RlbU5vdFN1cHBvcnRlZDsgfQotICAgIHZpcnR1YWwgTWVkaWFLZXlFeGNlcHRpb24g Y2FuY2VsS2V5UmVxdWVzdChjb25zdCBXZWJTdHJpbmcmIGtleVN5c3RlbSwgY29uc3QgV2ViU3Ry aW5nJiBzZXNzaW9uSWQpIHsgcmV0dXJuIEtleVN5c3RlbU5vdFN1cHBvcnRlZDsgfQorICAgIHZp cnR1YWwgTWVkaWFLZXlFeGNlcHRpb24gZ2VuZXJhdGVLZXlSZXF1ZXN0KGNvbnN0IFdlYlN0cmlu ZyYga2V5U3lzdGVtLCBjb25zdCB1bnNpZ25lZCBjaGFyKiBpbml0RGF0YSwgdW5zaWduZWQgaW5p dERhdGFMZW5ndGgpIHsgcmV0dXJuIE1lZGlhS2V5RXhjZXB0aW9uS2V5U3lzdGVtTm90U3VwcG9y dGVkOyB9CisgICAgdmlydHVhbCBNZWRpYUtleUV4Y2VwdGlvbiBhZGRLZXkoY29uc3QgV2ViU3Ry aW5nJiBrZXlTeXN0ZW0sIGNvbnN0IHVuc2lnbmVkIGNoYXIqIGtleSwgdW5zaWduZWQga2V5TGVu Z3RoLCBjb25zdCB1bnNpZ25lZCBjaGFyKiBpbml0RGF0YSwgdW5zaWduZWQgaW5pdERhdGFMZW5n dGgsIGNvbnN0IFdlYlN0cmluZyYgc2Vzc2lvbklkKSB7IHJldHVybiBNZWRpYUtleUV4Y2VwdGlv bktleVN5c3RlbU5vdFN1cHBvcnRlZDsgfQorICAgIHZpcnR1YWwgTWVkaWFLZXlFeGNlcHRpb24g Y2FuY2VsS2V5UmVxdWVzdChjb25zdCBXZWJTdHJpbmcmIGtleVN5c3RlbSwgY29uc3QgV2ViU3Ry aW5nJiBzZXNzaW9uSWQpIHsgcmV0dXJuIE1lZGlhS2V5RXhjZXB0aW9uS2V5U3lzdGVtTm90U3Vw cG9ydGVkOyB9CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK