84997 2012-04-26 13:32:57 -0700 Delete dead code in Arena.h/cpp 2012-04-26 17:48:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan adamk eric hyatt webkit.review.bot oldest_to_newest 610903 0 ojan 2012-04-26 13:32:57 -0700 Delete dead code in Arena.h/cpp 610909 1 139057 ojan 2012-04-26 13:35:23 -0700 Created attachment 139057 Patch 610918 2 webkit.review.bot 2012-04-26 13:38:26 -0700 Attachment 139057 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/Arena.h:77: _a is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/Arena.h:78: _nb is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/Arena.h:79: _p is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/Arena.h:80: _q is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/Arena.h:83: Else clause should never be on same line as else (use 2 lines) [whitespace/newline] [4] Source/WebCore/platform/Arena.cpp:67: j_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/Arena.cpp:105: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/Arena.cpp:119: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/Arena.cpp:119: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/platform/Arena.cpp:160: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/Arena.cpp:180: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 11 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 610930 3 139057 eric 2012-04-26 13:47:25 -0700 Comment on attachment 139057 Patch OK. You should use the cq to make sure nothing breaks. 611125 4 139057 webkit.review.bot 2012-04-26 17:47:57 -0700 Comment on attachment 139057 Patch Clearing flags on attachment: 139057 Committed r115389: <http://trac.webkit.org/changeset/115389> 611126 5 webkit.review.bot 2012-04-26 17:48:20 -0700 All reviewed patches have been landed. Closing bug. 139057 2012-04-26 13:35:23 -0700 2012-04-26 17:47:56 -0700 Patch bug-84997-20120426133522.patch text/plain 14023 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQ3ZjZkMjNjZWE5MmVh ZmRjMGIzNTIyN2NmMjY5YzU5NTFmMGVlNi4uMWVmNDIwYTE3NGY2YWEyMmNmMDQ0MTY0NzhhZDBl YjdhODJkYzMzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA0LTI2ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGVsZXRlIGRlYWQgY29kZSBp biBBcmVuYS5oL2NwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODQ5OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBbHNvIGNsZWFuZWQgdXAgc29tZSBzdHlsZSBpc3N1ZXMuIFJlbmFtZWQgc29tZSBzaW5n bGUtbGV0dGVyIHZhcmlhYmxlIG5hbWVzLgorICAgICAgICBBdm9pZGVkIGFueXRoaW5nIG90aGVy IHRoYW4gdG90YWxseSB0cml2aWFsIHN0eWxlIGNoYW5nZXMgdG8gYmUgMTAwJSBzdXJlCisgICAg ICAgIHRoYXQgdGhlcmUgaXMgbm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gVGhlcmUncyBubyBub24tc3R5bGUgY29kZSBjaGFuZ2VzIGV4Y2VwdCBpbmxpbmlu ZyBDTEVBUl9VTlVTRUQKKyAgICAgICAgYW5kIENMRUFSX0FSRU5BLgorCisgICAgICAgICogcGxh dGZvcm0vQXJlbmEuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpD ZWlsaW5nTG9nMik6CisgICAgICAgIChXZWJDb3JlOjpJbml0QXJlbmFQb29sKToKKyAgICAgICAg KFdlYkNvcmU6OkFyZW5hQWxsb2NhdGUpOgorICAgICAgICAoV2ViQ29yZTo6RnJlZUFyZW5hTGlz dCk6CisgICAgICAgIChXZWJDb3JlOjpGaW5pc2hBcmVuYVBvb2wpOgorICAgICAgICAqIHBsYXRm b3JtL0FyZW5hLmg6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0wNC0yNSAgS2VubmV0aCBS dXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgRGVsZXRlIENhbnZhc1BpeGVsQXJy YXksIEJ5dGVBcnJheSwgSlNCeXRlQXJyYXkgYW5kIEpTQyBjb2RlIG9uY2UgdW5yZWZlcmVuY2Vk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9BcmVuYS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9BcmVuYS5jcHAKaW5kZXggMzM5ODBlZGZlYjJkNWY0ODIwMDQ0Nzlj Njk3MmI0OGQ0NmY1Y2ExMC4uZjMwNWYxNjkxNGU3ZmJiNDU1NmE5MDdlYjE5ZTM5Y2EwOGFiZmM5 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQXJlbmEuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL0FyZW5hLmNwcApAQCAtNTYsMzcgKzU2LDMzIEBAIHVzaW5n IG5hbWVzcGFjZSBzdGQ7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotLy8jZGVmaW5lIERFQlVH X0FSRU5BX01BTExPQwogI2lmZGVmIERFQlVHX0FSRU5BX01BTExPQwogc3RhdGljIGludCBpID0g MDsKICNlbmRpZgogCi0jZGVmaW5lIEZSRUVMSVNUX01BWCAzMAotc3RhdGljIEFyZW5hICphcmVu YV9mcmVlbGlzdDsKLXN0YXRpYyBpbnQgZnJlZWxpc3RfY291bnQgPSAwOwotCi0jZGVmaW5lIEFS RU5BX0RFRkFVTFRfQUxJR04gIHNpemVvZihkb3VibGUpCi0jZGVmaW5lIEJJVChuKSAgICAgICAg ICAgICAgICAgICAgICAgICAgKCh1bnNpZ25lZCBpbnQpMSA8PCAobikpCi0jZGVmaW5lIEJJVE1B U0sobikgICAgICAgICAgICAgICAgICAgICAgKEJJVChuKSAtIDEpCi0jZGVmaW5lIENFSUxJTkdf TE9HMihfbG9nMixfbikgICBcCi0gICAgICB1bnNpZ25lZCBpbnQgal8gPSAodW5zaWduZWQgaW50 KShfbik7ICAgXAotICAgICAgKF9sb2cyKSA9IDA7ICAgICAgICAgICAgICAgICAgICBcCi0gICAg ICBpZiAoKGpfKSAmICgoal8pLTEpKSAgICAgICAgICAgIFwKLSAgICAgIChfbG9nMikgKz0gMTsg ICAgICAgICAgICAgICBcCi0gICAgICBpZiAoKGpfKSA+PiAxNikgICAgICAgICAgICAgICAgIFwK LSAgICAgIChfbG9nMikgKz0gMTYsIChqXykgPj49IDE2OyBcCi0gICAgICBpZiAoKGpfKSA+PiA4 KSAgICAgICAgICAgICAgICAgIFwKLSAgICAgIChfbG9nMikgKz0gOCwgKGpfKSA+Pj0gODsgICBc Ci0gICAgICBpZiAoKGpfKSA+PiA0KSAgICAgICAgICAgICAgICAgIFwKLSAgICAgIChfbG9nMikg Kz0gNCwgKGpfKSA+Pj0gNDsgICBcCi0gICAgICBpZiAoKGpfKSA+PiAyKSAgICAgICAgICAgICAg ICAgIFwKLSAgICAgIChfbG9nMikgKz0gMiwgKGpfKSA+Pj0gMjsgICBcCi0gICAgICBpZiAoKGpf KSA+PiAxKSAgICAgICAgICAgICAgICAgIFwKLSAgICAgIChfbG9nMikgKz0gMTsKKyNkZWZpbmUg QVJFTkFfREVGQVVMVF9BTElHTiBzaXplb2YoZG91YmxlKQorI2RlZmluZSBCSVQobikgKCh1bnNp Z25lZCBpbnQpMSA8PCAobikpCisjZGVmaW5lIEJJVE1BU0sobikgKEJJVChuKSAtIDEpCisjZGVm aW5lIENFSUxJTkdfTE9HMihfbG9nMiwgX24pICAgXAorICAgIHVuc2lnbmVkIGludCBqXyA9ICh1 bnNpZ25lZCBpbnQpKF9uKTsgICBcCisgICAgKF9sb2cyKSA9IDA7ICAgICAgICAgICAgICAgICAg ICBcCisgICAgaWYgKChqXykgJiAoKGpfKS0xKSkgICAgICAgICAgICBcCisgICAgICAgIChfbG9n MikgKz0gMTsgICAgICAgICAgICAgICBcCisgICAgaWYgKChqXykgPj4gMTYpICAgICAgICAgICAg ICAgICBcCisgICAgICAgIChfbG9nMikgKz0gMTYsIChqXykgPj49IDE2OyBcCisgICAgaWYgKChq XykgPj4gOCkgICAgICAgICAgICAgICAgICBcCisgICAgICAgIChfbG9nMikgKz0gOCwgKGpfKSA+ Pj0gODsgICBcCisgICAgaWYgKChqXykgPj4gNCkgICAgICAgICAgICAgICAgICBcCisgICAgICAg IChfbG9nMikgKz0gNCwgKGpfKSA+Pj0gNDsgICBcCisgICAgaWYgKChqXykgPj4gMikgICAgICAg ICAgICAgICAgICBcCisgICAgICAgIChfbG9nMikgKz0gMiwgKGpfKSA+Pj0gMjsgICBcCisgICAg aWYgKChqXykgPj4gMSkgICAgICAgICAgICAgICAgICBcCisgICAgICAgIChfbG9nMikgKz0gMTsK KyNkZWZpbmUgRlJFRV9QQVRURVJOIDB4REEKIAogc3RhdGljIGludCBDZWlsaW5nTG9nMih1bnNp Z25lZCBpbnQgaSkgewogICAgIGludCBsb2cyOwotICAgIENFSUxJTkdfTE9HMihsb2cyLGkpOwor ICAgIENFSUxJTkdfTE9HMihsb2cyLCBpKTsKICAgICByZXR1cm4gbG9nMjsKIH0KIApAQCAtOTYs MTYzICs5Miw5OCBAQCB2b2lkIEluaXRBcmVuYVBvb2woQXJlbmFQb29sKiBwb29sLCBjb25zdCBj aGFyKiwgdW5zaWduZWQgc2l6ZSwgdW5zaWduZWQgYWxpZ24pCiAgICAgICAgICBhbGlnbiA9IEFS RU5BX0RFRkFVTFRfQUxJR047CiAgICAgIHBvb2wtPm1hc2sgPSBCSVRNQVNLKENlaWxpbmdMb2cy KGFsaWduKSk7CiAgICAgIHBvb2wtPmZpcnN0Lm5leHQgPSBOVUxMOwotICAgICBwb29sLT5maXJz dC5iYXNlID0gcG9vbC0+Zmlyc3QuYXZhaWwgPSBwb29sLT5maXJzdC5saW1pdCA9Ci0gICAgICAg ICAodXdvcmQpQVJFTkFfQUxJR04oJnBvb2wtPmZpcnN0ICsgMSk7CisgICAgIHBvb2wtPmZpcnN0 LmJhc2UgPSBwb29sLT5maXJzdC5hdmFpbCA9IHBvb2wtPmZpcnN0LmxpbWl0ID0gKHV3b3JkKUFS RU5BX0FMSUdOKCZwb29sLT5maXJzdCArIDEpOwogICAgICBwb29sLT5jdXJyZW50ID0gJnBvb2wt PmZpcnN0OwogICAgICBwb29sLT5hcmVuYXNpemUgPSBzaXplOyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAKIH0KIAotCi0vKgotICoqIEFyZW5hQWxsb2NhdGUoKSAtLSBhbGxvY2F0 ZSBzcGFjZSBmcm9tIGFuIGFyZW5hIHBvb2wKLSAqKiAKLSAqKiBEZXNjcmlwdGlvbjogQXJlbmFB bGxvY2F0ZSgpIGFsbG9jYXRlcyBzcGFjZSBmcm9tIGFuIGFyZW5hCi0gKiogcG9vbC4gCi0gKioK LSAqKiBGaXJzdCB0cnkgdG8gc2F0aXNmeSB0aGUgcmVxdWVzdCBmcm9tIGFyZW5hcyBzdGFydGlu ZyBhdAotICoqIHBvb2wtPmN1cnJlbnQuCi0gKioKLSAqKiBJZiB0aGVyZSBpcyBub3QgZW5vdWdo IHNwYWNlIGluIHRoZSBhcmVuYSBwb29sLT5jdXJyZW50LCB0cnkKLSAqKiB0byBjbGFpbSBhbiBh cmVuYSwgb24gYSBmaXJzdCBmaXQgYmFzaXMsIGZyb20gdGhlIGdsb2JhbAotICoqIGZyZWVsaXN0 IChhcmVuYV9mcmVlbGlzdCkuCi0gKiogCi0gKiogSWYgbm8gYXJlbmEgaW4gYXJlbmFfZnJlZWxp c3QgaXMgc3VpdGFibGUsIHRoZW4gdHJ5IHRvCi0gKiogYWxsb2NhdGUgYSBuZXcgYXJlbmEgZnJv bSB0aGUgaGVhcC4KLSAqKgotICoqIFJldHVybnM6IHBvaW50ZXIgdG8gYWxsb2NhdGVkIHNwYWNl IG9yIE5VTEwKLSAqKiAKLSAqLwotdm9pZCogQXJlbmFBbGxvY2F0ZShBcmVuYVBvb2wgKnBvb2ws IHVuc2lnbmVkIGludCBuYikKK3ZvaWQqIEFyZW5hQWxsb2NhdGUoQXJlbmFQb29sKiBwb29sLCB1 bnNpZ25lZCBpbnQgbnVtQnl0ZXMpCiB7Ci0gICAgQXJlbmEgKmE7ICAgCi0gICAgY2hhciAqcnA7 ICAgICAvKiByZXR1cm5lZCBwb2ludGVyICovCisgICAgQXJlbmEqIGFyZW5hOworICAgIGNoYXIq IHJldHVyblBvaW50ZXI7CiAKLSAgICBBU1NFUlQoKG5iICYgcG9vbC0+bWFzaykgPT0gMCk7Cisg ICAgQVNTRVJUKChudW1CeXRlcyAmIHBvb2wtPm1hc2spID09IDApOwogICAgIAotICAgIG5iID0g KHV3b3JkKUFSRU5BX0FMSUdOKG5iKTsgLyogZm9yY2UgYWxpZ25tZW50ICovCisgICAgbnVtQnl0 ZXMgPSAodXdvcmQpQVJFTkFfQUxJR04obnVtQnl0ZXMpOwogCi0gICAgLyogYXR0ZW1wdCB0byBh bGxvY2F0ZSBmcm9tIGFyZW5hcyBhdCBwb29sLT5jdXJyZW50ICovCisgICAgLy8gYXR0ZW1wdCB0 byBhbGxvY2F0ZSBmcm9tIGFyZW5hcyBhdCBwb29sLT5jdXJyZW50CiAgICAgewotICAgICAgICBh ID0gcG9vbC0+Y3VycmVudDsKKyAgICAgICAgYXJlbmEgPSBwb29sLT5jdXJyZW50OwogICAgICAg ICBkbyB7Ci0gICAgICAgICAgICBpZiAoIGEtPmF2YWlsICtuYiA8PSBhLT5saW1pdCApICB7Ci0g ICAgICAgICAgICAgICAgcG9vbC0+Y3VycmVudCA9IGE7Ci0gICAgICAgICAgICAgICAgcnAgPSAo Y2hhciAqKWEtPmF2YWlsOwotICAgICAgICAgICAgICAgIGEtPmF2YWlsICs9IG5iOwotICAgICAg ICAgICAgICAgIHJldHVybiBycDsKLSAgICAgICAgICAgIH0KLSAgICAgICAgfSB3aGlsZSggTlVM TCAhPSAoYSA9IGEtPm5leHQpICk7Ci0gICAgfQotCi0gICAgLyogYXR0ZW1wdCB0byBhbGxvY2F0 ZSBmcm9tIGFyZW5hX2ZyZWVsaXN0ICovCi0gICAgewotICAgICAgICBBcmVuYSAqcCA9IE5VTEw7 IC8qIHByZXZpb3VzIHBvaW50ZXIsIGZvciB1bmxpbmtpbmcgZnJvbSBmcmVlbGlzdCAqLwotCi0g ICAgICAgIGZvciAoIGEgPSBhcmVuYV9mcmVlbGlzdDsgYSAhPSBOVUxMIDsgcCA9IGEsIGEgPSBh LT5uZXh0ICkgewotICAgICAgICAgICAgaWYgKCBhLT5iYXNlICtuYiA8PSBhLT5saW1pdCApICB7 Ci0gICAgICAgICAgICAgICAgaWYgKCBwID09IE5VTEwgKQotICAgICAgICAgICAgICAgICAgICBh cmVuYV9mcmVlbGlzdCA9IGEtPm5leHQ7Ci0gICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAg ICAgICAgICAgICBwLT5uZXh0ID0gYS0+bmV4dDsKLSAgICAgICAgICAgICAgICBhLT5hdmFpbCA9 IGEtPmJhc2U7Ci0gICAgICAgICAgICAgICAgcnAgPSAoY2hhciAqKWEtPmF2YWlsOwotICAgICAg ICAgICAgICAgIGEtPmF2YWlsICs9IG5iOwotICAgICAgICAgICAgICAgIC8qIHRoZSBuZXdseSBh bGxvY2F0ZWQgYXJlbmEgaXMgbGlua2VkIGFmdGVyIHBvb2wtPmN1cnJlbnQgCi0gICAgICAgICAg ICAgICAgICogIGFuZCBiZWNvbWVzIHBvb2wtPmN1cnJlbnQgKi8KLSAgICAgICAgICAgICAgICBh LT5uZXh0ID0gcG9vbC0+Y3VycmVudC0+bmV4dDsKLSAgICAgICAgICAgICAgICBwb29sLT5jdXJy ZW50LT5uZXh0ID0gYTsKLSAgICAgICAgICAgICAgICBwb29sLT5jdXJyZW50ID0gYTsKLSAgICAg ICAgICAgICAgICBpZiAoIDAgPT0gcG9vbC0+Zmlyc3QubmV4dCApCi0gICAgICAgICAgICAgICAg ICAgIHBvb2wtPmZpcnN0Lm5leHQgPSBhOwotICAgICAgICAgICAgICAgIGZyZWVsaXN0X2NvdW50 LS07Ci0gICAgICAgICAgICAgICAgcmV0dXJuKHJwKTsKKyAgICAgICAgICAgIGlmIChhcmVuYS0+ YXZhaWwgKyBudW1CeXRlcyA8PSBhcmVuYS0+bGltaXQpICB7CisgICAgICAgICAgICAgICAgcG9v bC0+Y3VycmVudCA9IGFyZW5hOworICAgICAgICAgICAgICAgIHJldHVyblBvaW50ZXIgPSAoY2hh ciAqKWFyZW5hLT5hdmFpbDsKKyAgICAgICAgICAgICAgICBhcmVuYS0+YXZhaWwgKz0gbnVtQnl0 ZXM7CisgICAgICAgICAgICAgICAgcmV0dXJuIHJldHVyblBvaW50ZXI7CiAgICAgICAgICAgICB9 Ci0gICAgICAgIH0KKyAgICAgICAgfSB3aGlsZSAoTlVMTCAhPSAoYXJlbmEgPSBhcmVuYS0+bmV4 dCkpOwogICAgIH0KIAotICAgIC8qIGF0dGVtcHQgdG8gYWxsb2NhdGUgZnJvbSB0aGUgaGVhcCAq LyAKKyAgICAvLyBhdHRlbXB0IHRvIGFsbG9jYXRlIGZyb20gdGhlIGhlYXAKICAgICB7ICAKLSAg ICAgICAgdW5zaWduZWQgaW50IHN6ID0gbWF4KHBvb2wtPmFyZW5hc2l6ZSwgbmIpOwotICAgICAg ICBzeiArPSBzaXplb2YgKmEgKyBwb29sLT5tYXNrOyAgLyogaGVhZGVyIGFuZCBhbGlnbm1lbnQg c2xvcCAqLworICAgICAgICB1bnNpZ25lZCBpbnQgc2l6ZSA9IG1heChwb29sLT5hcmVuYXNpemUs IG51bUJ5dGVzKTsKKyAgICAgICAgc2l6ZSArPSBzaXplb2YgKmFyZW5hICsgcG9vbC0+bWFzazsg IC8qIGhlYWRlciBhbmQgYWxpZ25tZW50IHNsb3AgKi8KICNpZmRlZiBERUJVR19BUkVOQV9NQUxM T0MKICAgICAgICAgaSsrOwogICAgICAgICBwcmludGYoIk1hbGxvYzogJWRcbiIsIGkpOwogI2Vu ZGlmCi0gICAgICAgIGEgPSAoQXJlbmEqKWZhc3RNYWxsb2Moc3opOworICAgICAgICBhcmVuYSA9 IChBcmVuYSopZmFzdE1hbGxvYyhzaXplKTsKICAgICAgICAgLy8gZmFzdE1hbGxvYyB3aWxsIGFi b3J0KCkgaWYgaXQgZmFpbHMsIHNvIHdlIGFyZSBndWFyYW50ZWVkIHRoYXQgYSBpcyBub3QgMC4K LSAgICAgICAgYS0+bGltaXQgPSAodXdvcmQpYSArIHN6OwotICAgICAgICBhLT5iYXNlID0gYS0+ YXZhaWwgPSAodXdvcmQpQVJFTkFfQUxJR04oYSArIDEpOwotICAgICAgICBycCA9IChjaGFyICop YS0+YXZhaWw7Ci0gICAgICAgIGEtPmF2YWlsICs9IG5iOwotICAgICAgICAvKiB0aGUgbmV3bHkg YWxsb2NhdGVkIGFyZW5hIGlzIGxpbmtlZCBhZnRlciBwb29sLT5jdXJyZW50IAotICAgICAgICAq ICBhbmQgYmVjb21lcyBwb29sLT5jdXJyZW50ICovCi0gICAgICAgIGEtPm5leHQgPSBwb29sLT5j dXJyZW50LT5uZXh0OwotICAgICAgICBwb29sLT5jdXJyZW50LT5uZXh0ID0gYTsKLSAgICAgICAg cG9vbC0+Y3VycmVudCA9IGE7Ci0gICAgICAgIGlmICggIXBvb2wtPmZpcnN0Lm5leHQgKQotICAg ICAgICAgICAgcG9vbC0+Zmlyc3QubmV4dCA9IGE7Ci0gICAgICAgIHJldHVybihycCk7CisgICAg ICAgIGFyZW5hLT5saW1pdCA9ICh1d29yZClhcmVuYSArIHNpemU7CisgICAgICAgIGFyZW5hLT5i YXNlID0gYXJlbmEtPmF2YWlsID0gKHV3b3JkKUFSRU5BX0FMSUdOKGFyZW5hICsgMSk7CisgICAg ICAgIHJldHVyblBvaW50ZXIgPSAoY2hhciAqKWFyZW5hLT5hdmFpbDsKKyAgICAgICAgYXJlbmEt PmF2YWlsICs9IG51bUJ5dGVzOworICAgICAgICAvLyB0aGUgbmV3bHkgYWxsb2NhdGVkIGFyZW5h IGlzIGxpbmtlZCBhZnRlciBwb29sLT5jdXJyZW50IGFuZCBiZWNvbWVzIHBvb2wtPmN1cnJlbnQu CisgICAgICAgIGFyZW5hLT5uZXh0ID0gcG9vbC0+Y3VycmVudC0+bmV4dDsKKyAgICAgICAgcG9v bC0+Y3VycmVudC0+bmV4dCA9IGFyZW5hOworICAgICAgICBwb29sLT5jdXJyZW50ID0gYXJlbmE7 CisgICAgICAgIGlmICghcG9vbC0+Zmlyc3QubmV4dCkKKyAgICAgICAgICAgIHBvb2wtPmZpcnN0 Lm5leHQgPSBhcmVuYTsKKyAgICAgICAgcmV0dXJuKHJldHVyblBvaW50ZXIpOwogICAgIH0KLX0g LyogLS0tIGVuZCBBcmVuYUFsbG9jYXRlKCkgLS0tICovCit9CiAKLS8qCi0gKiBGcmVlIHRhaWwg YXJlbmFzIGxpbmtlZCBhZnRlciBoZWFkLCB3aGljaCBtYXkgbm90IGJlIHRoZSB0cnVlIGxpc3Qg aGVhZC4KLSAqIFJlc2V0IHBvb2wtPmN1cnJlbnQgdG8gcG9pbnQgdG8gaGVhZCBpbiBjYXNlIGl0 IHBvaW50ZWQgYXQgYSB0YWlsIGFyZW5hLgotICovCi1zdGF0aWMgdm9pZCBGcmVlQXJlbmFMaXN0 KEFyZW5hUG9vbCAqcG9vbCwgQXJlbmEgKmhlYWQsIGJvb2wgcmVhbGx5RnJlZSkKKy8vIEZyZWUg dGFpbCBhcmVuYXMgbGlua2VkIGFmdGVyIGhlYWQsIHdoaWNoIG1heSBub3QgYmUgdGhlIHRydWUg bGlzdCBoZWFkLgorLy8gUmVzZXQgcG9vbC0+Y3VycmVudCB0byBwb2ludCB0byBoZWFkIGluIGNh c2UgaXQgcG9pbnRlZCBhdCBhIHRhaWwgYXJlbmEuCitzdGF0aWMgdm9pZCBGcmVlQXJlbmFMaXN0 KEFyZW5hUG9vbCogcG9vbCwgQXJlbmEqIGhlYWQpCiB7Ci0gICAgQXJlbmEgKiphcCwgKmE7Ci0K LSAgICBhcCA9ICZoZWFkLT5uZXh0OwotICAgIGEgPSAqYXA7Ci0gICAgaWYgKCFhKQorICAgIEFy ZW5hKiogYXJlbmFQb2ludGVyID0gJmhlYWQtPm5leHQ7CisgICAgQXJlbmEqIGFyZW5hID0gKmFy ZW5hUG9pbnRlcjsKKyAgICBpZiAoIWFyZW5hKQogICAgICAgICByZXR1cm47CiAKICNpZmRlZiBE RUJVRwogICAgIGRvIHsKLSAgICAgICAgQVNTRVJUKGEtPmJhc2UgPD0gYS0+YXZhaWwgJiYgYS0+ YXZhaWwgPD0gYS0+bGltaXQpOwotICAgICAgICBhLT5hdmFpbCA9IGEtPmJhc2U7Ci0gICAgICAg IENMRUFSX1VOVVNFRChhKTsKLSAgICB9IHdoaWxlICgoYSA9IGEtPm5leHQpICE9IDApOwotICAg IGEgPSAqYXA7CisgICAgICAgIEFTU0VSVChhcmVuYS0+YmFzZSA8PSBhcmVuYS0+YXZhaWwgJiYg YXJlbmEtPmF2YWlsIDw9IGFyZW5hLT5saW1pdCk7CisgICAgICAgIGFyZW5hLT5hdmFpbCA9IGFy ZW5hLT5iYXNlOworICAgICAgICBtZW1zZXQoKHZvaWQqKShhcmVuYSktPmF2YWlsLCBGUkVFX1BB VFRFUk4sIChhcmVuYSktPmxpbWl0IC0gKGFyZW5hKS0+YXZhaWwpCisgICAgfSB3aGlsZSAoKGFy ZW5hID0gYXJlbmEtPm5leHQpICE9IDApOworICAgIGFyZW5hID0gKmFyZW5hUG9pbnRlcjsKKyNl bmRpZgorCisgICAgZG8geworICAgICAgICAqYXJlbmFQb2ludGVyID0gYXJlbmEtPm5leHQ7CisK KyNpZmRlZiBERUJVRyAgICAgICAgCisgICAgICAgIG1lbXNldCgodm9pZCopKGFyZW5hKSwgRlJF RV9QQVRURVJOLCAoYXJlbmEpLT5saW1pdCAtICh1d29yZCkoYXJlbmEpKTsKICNlbmRpZgogCi0g ICAgaWYgKGZyZWVsaXN0X2NvdW50ID49IEZSRUVMSVNUX01BWCkKLSAgICAgICAgcmVhbGx5RnJl ZSA9IHRydWU7Ci0gICAgICAgIAotICAgIGlmIChyZWFsbHlGcmVlKSB7Ci0gICAgICAgIGRvIHsK LSAgICAgICAgICAgICphcCA9IGEtPm5leHQ7Ci0gICAgICAgICAgICBDTEVBUl9BUkVOQShhKTsK ICNpZmRlZiBERUJVR19BUkVOQV9NQUxMT0MKLSAgICAgICAgICAgIGlmIChhKSB7Ci0gICAgICAg ICAgICAgICAgaS0tOwotICAgICAgICAgICAgICAgIHByaW50ZigiRnJlZTogJWRcbiIsIGkpOwot ICAgICAgICAgICAgfQorICAgICAgICBpZiAoYXJlbmEpIHsKKyAgICAgICAgICAgIGktLTsKKyAg ICAgICAgICAgIHByaW50ZigiRnJlZTogJWRcbiIsIGkpOworICAgICAgICB9CiAjZW5kaWYKLSAg ICAgICAgICAgIGZhc3RGcmVlKGEpOyBhID0gMDsKLSAgICAgICAgfSB3aGlsZSAoKGEgPSAqYXAp ICE9IDApOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIC8qIEluc2VydCB0aGUgd2hvbGUgYXJlbmEg Y2hhaW4gYXQgdGhlIGZyb250IG9mIHRoZSBmcmVlbGlzdC4gKi8KLSAgICAgICAgZG8gewotICAg ICAgICAgICAgYXAgPSAmKCphcCktPm5leHQ7Ci0gICAgICAgICAgICBmcmVlbGlzdF9jb3VudCsr OwotICAgICAgICB9IHdoaWxlICgqYXApOwotICAgICAgICAqYXAgPSBhcmVuYV9mcmVlbGlzdDsK LSAgICAgICAgYXJlbmFfZnJlZWxpc3QgPSBhOwotICAgICAgICBoZWFkLT5uZXh0ID0gMDsKLSAg ICB9Ci0gICAgcG9vbC0+Y3VycmVudCA9IGhlYWQ7Ci19CiAKLXZvaWQgRnJlZUFyZW5hUG9vbChB cmVuYVBvb2wgKnBvb2wpCi17Ci0gICAgRnJlZUFyZW5hTGlzdChwb29sLCAmcG9vbC0+Zmlyc3Qs IGZhbHNlKTsKKyAgICAgICAgZmFzdEZyZWUoYXJlbmEpOworICAgICAgICBhcmVuYSA9IDA7Cisg ICAgfSB3aGlsZSAoKGFyZW5hID0gKmFyZW5hUG9pbnRlcikgIT0gMCk7CisgICAgcG9vbC0+Y3Vy cmVudCA9IGhlYWQ7CiB9CiAKLXZvaWQgRmluaXNoQXJlbmFQb29sKEFyZW5hUG9vbCAqcG9vbCkK K3ZvaWQgRmluaXNoQXJlbmFQb29sKEFyZW5hUG9vbCogcG9vbCkKIHsKLSAgICBGcmVlQXJlbmFM aXN0KHBvb2wsICZwb29sLT5maXJzdCwgdHJ1ZSk7CisgICAgRnJlZUFyZW5hTGlzdChwb29sLCAm cG9vbC0+Zmlyc3QpOwogfQogCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9BcmVuYS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQXJlbmEuaAppbmRleCAwNmUwOWYy YTVlOWQ5YjliZWY0ZTY2MmUwYWMzMDRmM2Y5NjE1OTFlLi45NmMzMWU1MDJkZDQzMmM0OGJhYzQ0 MWYzN2M3ZDJiNjUzMjc1ZDY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9B cmVuYS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0FyZW5hLmgKQEAgLTQxLDggKzQx LDYgQEAKICNpZm5kZWYgQXJlbmFfaAogI2RlZmluZSBBcmVuYV9oCiAKLSNpbmNsdWRlIDx3dGYv RmFzdE1hbGxvYy5oPgotCiAvLyBGSVhNRTogV2UnZCBhbHdheXMgbGlrZSB0byB1c2UgQWxsb2NB bGlnbm1lbnRJbnRlZ2VyIGZvciBBcmVuYSBhbGlnbm1lbnQKIC8vIGJ1dCB0aGVyZSBpcyBjb25j ZXJuIG92ZXIgdGhlIG1lbW9yeSBncm93dGggdGhpcyBtYXkgY2F1c2UuCiAjaWZkZWYgV1RGX1VT RV9BUkVOQV9BTExPQ19BTElHTk1FTlRfSU5URUdFUgpAQCAtNjksNzAgKzY3LDIyIEBAIHN0cnVj dCBBcmVuYVBvb2wgewogICAgIHV3b3JkIG1hc2s7ICAgICAgICAgLy8gTWFzayAocG93ZXItb2Yt MiAtIDEpCiB9OwogCi12b2lkIEluaXRBcmVuYVBvb2woQXJlbmFQb29sICpwb29sLCBjb25zdCBj aGFyICpuYW1lLCAKLSAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgc2l6ZSwgdW5zaWdu ZWQgaW50IGFsaWduKTsKLXZvaWQgRmluaXNoQXJlbmFQb29sKEFyZW5hUG9vbCAqcG9vbCk7Ci12 b2lkIEZyZWVBcmVuYVBvb2woQXJlbmFQb29sICpwb29sKTsKLXZvaWQqIEFyZW5hQWxsb2NhdGUo QXJlbmFQb29sICpwb29sLCB1bnNpZ25lZCBpbnQgbmIpOwordm9pZCBJbml0QXJlbmFQb29sKEFy ZW5hUG9vbCosIGNvbnN0IGNoYXIqIG5hbWUsIHVuc2lnbmVkIGludCBzaXplLCB1bnNpZ25lZCBp bnQgYWxpZ24pOwordm9pZCBGaW5pc2hBcmVuYVBvb2woQXJlbmFQb29sKik7Cit2b2lkKiBBcmVu YUFsbG9jYXRlKEFyZW5hUG9vbCosIHVuc2lnbmVkIGludCBuYik7CiAKICNkZWZpbmUgQVJFTkFf QUxJR04obikgKCgodXdvcmQpKG4pICsgQVJFTkFfQUxJR05fTUFTSykgJiB+QVJFTkFfQUxJR05f TUFTSykKLSNkZWZpbmUgSU5JVF9BUkVOQV9QT09MKHBvb2wsIG5hbWUsIHNpemUpIFwKLSAgICAg ICAgSW5pdEFyZW5hUG9vbChwb29sLCBuYW1lLCBzaXplLCBBUkVOQV9BTElHTl9NQVNLICsgMSkK LQorI2RlZmluZSBJTklUX0FSRU5BX1BPT0wocG9vbCwgbmFtZSwgc2l6ZSkgSW5pdEFyZW5hUG9v bChwb29sLCBuYW1lLCBzaXplLCBBUkVOQV9BTElHTl9NQVNLICsgMSkKICNkZWZpbmUgQVJFTkFf QUxMT0NBVEUocCwgcG9vbCwgbmIpIFwKLSAgICAgICAgQXJlbmEgKl9hID0gKHBvb2wpLT5jdXJy ZW50OyBcCi0gICAgICAgIHVuc2lnbmVkIGludCBfbmIgPSBBUkVOQV9BTElHTihuYik7IFwKLSAg ICAgICAgdXdvcmQgX3AgPSBfYS0+YXZhaWw7IFwKLSAgICAgICAgdXdvcmQgX3EgPSBfcCArIF9u YjsgXAotICAgICAgICBpZiAoX3EgPiBfYS0+bGltaXQpIFwKLSAgICAgICAgICAgIF9wID0gKHV3 b3JkKUFyZW5hQWxsb2NhdGUocG9vbCwgX25iKTsgXAotICAgICAgICBlbHNlIFwKLSAgICAgICAg ICAgIF9hLT5hdmFpbCA9IF9xOyBcCi0gICAgICAgIHAgPSAodm9pZCAqKV9wOwotCi0jZGVmaW5l IEFSRU5BX0dST1cocCwgcG9vbCwgc2l6ZSwgaW5jcikgXAotICAgICAgICBBcmVuYSAqX2EgPSAo cG9vbCktPmN1cnJlbnQ7IFwKLSAgICAgICAgdW5zaWduZWQgaW50IF9pbmNyID0gQVJFTkFfQUxJ R04oaW5jcik7IFwKLSAgICAgICAgdXdvcmQgX3AgPSBfYS0+YXZhaWw7IFwKLSAgICAgICAgdXdv cmQgX3EgPSBfcCArIF9pbmNyOyBcCi0gICAgICAgIGlmIChfcCA9PSAodXdvcmQpKHApICsgQVJF TkFfQUxJR04oc2l6ZSkgJiYgXAotICAgICAgICAgICAgX3EgPD0gX2EtPmxpbWl0KSB7IFwKLSAg ICAgICAgICAgIF9hLT5hdmFpbCA9IF9xOyBcCi0gICAgICAgIH0gZWxzZSB7IFwKLSAgICAgICAg ICAgIHAgPSBBcmVuYUdyb3cocG9vbCwgcCwgc2l6ZSwgaW5jcik7IFwKLSAgICAgICAgfQotCi0j ZGVmaW5lIEFSRU5BX01BUksocG9vbCkgKCh2b2lkICopIChwb29sKS0+Y3VycmVudC0+YXZhaWwp Ci0jZGVmaW5lIFVQVFJESUZGKHAscSkgKCh1d29yZCkocCkgLSAodXdvcmQpKHEpKSAgICAgCi0K LSNpZmRlZiBERUJVRwotI2RlZmluZSBGUkVFX1BBVFRFUk4gMHhEQQotI2RlZmluZSBDTEVBUl9V TlVTRUQoYSkgQVNTRVJUKChhKS0+YXZhaWwgPD0gKGEpLT5saW1pdCk7IFwKLSAgICAgICAgICAg ICAgICAgICAgICAgIG1lbXNldCgodm9pZCopKGEpLT5hdmFpbCwgRlJFRV9QQVRURVJOLCBcCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGEpLT5saW1pdCAtIChhKS0+YXZhaWwpCi0jZGVm aW5lIENMRUFSX0FSRU5BKGEpICBtZW1zZXQoKHZvaWQqKShhKSwgRlJFRV9QQVRURVJOLCBcCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGEpLT5saW1pdCAtICh1d29yZCkoYSkpCi0jZWxz ZQotI2RlZmluZSBDTEVBUl9VTlVTRUQoYSkKLSNkZWZpbmUgQ0xFQVJfQVJFTkEoYSkKLSNlbmRp ZgotCi0jZGVmaW5lIEFSRU5BX1JFTEVBU0UocG9vbCwgbWFyaykgXAotICAgICAgICAgY2hhciAq X20gPSAoY2hhciAqKShtYXJrKTsgXAotICAgICAgICAgQXJlbmEgKl9hID0gKHBvb2wpLT5jdXJy ZW50OyBcCi0gICAgICAgICBpZiAoVVBUUkRJRkYoX20sIF9hLT5iYXNlKSA8PSBVUFRSRElGRihf YS0+YXZhaWwsIF9hLT5iYXNlKSkgeyBcCi0gICAgICAgICAgICAgX2EtPmF2YWlsID0gKHV3b3Jk KUFSRU5BX0FMSUdOKF9tKTsgXAotICAgICAgICAgICAgIENMRUFSX1VOVVNFRChfYSk7IFwKLSAg ICAgICAgIH0gZWxzZSB7IFwKLSAgICAgICAgICAgICBBcmVuYVJlbGVhc2UocG9vbCwgX20pOyBc Ci0gICAgICAgICB9Ci0KLSNkZWZpbmUgQVJFTkFfREVTVFJPWShwb29sLCBhLCBwbmV4dCkgXAot ICAgICAgICAgaWYgKChwb29sKS0+Y3VycmVudCA9PSAoYSkpIChwb29sKS0+Y3VycmVudCA9ICYo cG9vbCktPmZpcnN0OyBcCi0gICAgICAgICAqKHBuZXh0KSA9IChhKS0+bmV4dDsgXAotICAgICAg ICAgQ0xFQVJfQVJFTkEoYSk7IFwKLSAgICAgICAgIGZhc3RGcmVlKGEpOyBcCi0gICAgICAgICAo YSkgPSAwOworICAgIEFyZW5hKiBfYSA9IChwb29sKS0+Y3VycmVudDsgXAorICAgIHVuc2lnbmVk IGludCBfbmIgPSBBUkVOQV9BTElHTihuYik7IFwKKyAgICB1d29yZCBfcCA9IF9hLT5hdmFpbDsg XAorICAgIHV3b3JkIF9xID0gX3AgKyBfbmI7IFwKKyAgICBpZiAoX3EgPiBfYS0+bGltaXQpIFwK KyAgICAgICAgX3AgPSAodXdvcmQpQXJlbmFBbGxvY2F0ZShwb29sLCBfbmIpOyBcCisgICAgZWxz ZSBcCisgICAgICAgIF9hLT5hdmFpbCA9IF9xOyBcCisgICAgcCA9ICh2b2lkKilfcDsKIAogfQog Cg==