84991 2012-04-26 12:35:09 -0700 Add a test for crash in DOMSelection::deleteFromDocument 2012-04-26 17:20:02 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 44153 1 rniwa rniwa adele ap darin enrica oldest_to_newest 610830 0 rniwa 2012-04-26 12:35:09 -0700 We need a test for the bug 44153. 610868 1 139050 rniwa 2012-04-26 13:03:52 -0700 Created attachment 139050 Adds a regression test 610883 2 139050 ap 2012-04-26 13:16:31 -0700 Comment on attachment 139050 Adds a regression test View in context: https://bugs.webkit.org/attachment.cgi?id=139050&action=review > LayoutTests/editing/selection/deleteFromDocument-after-document-open-crash.html:25 > + layoutTestController.notifyDone(); This test doesn't appear to need waitUntilDone/notifyDone - all the work is done from unload. 610884 3 139050 rniwa 2012-04-26 13:18:00 -0700 Comment on attachment 139050 Adds a regression test View in context: https://bugs.webkit.org/attachment.cgi?id=139050&action=review >> LayoutTests/editing/selection/deleteFromDocument-after-document-open-crash.html:25 >> + layoutTestController.notifyDone(); > > This test doesn't appear to need waitUntilDone/notifyDone - all the work is done from unload. document.open() sometimes ends DRT so without this, the test will be flaky. 610900 4 ap 2012-04-26 13:32:10 -0700 > document.open() sometimes ends DRT so without this, the test will be flaky. How can this possibly be non-deterministic? Is there an uninitialized variable somewhere? Looks like you're covering up a real bug. 610916 5 rniwa 2012-04-26 13:37:49 -0700 (In reply to comment #4) > > document.open() sometimes ends DRT so without this, the test will be flaky. > > How can this possibly be non-deterministic? Is there an uninitialized variable somewhere? > > Looks like you're covering up a real bug. Maybe. The last time I checked, this was expected behavior per spec and non-determinism was due to some race conditions. But then I'm not too familiar with this area. 610958 6 rniwa 2012-04-26 14:06:38 -0700 Hm... it appears that this problem no longer reproduces at least on this test. I'm gonna just remove waitUntilDone/notifyDone for now. 610961 7 rniwa 2012-04-26 14:09:26 -0700 Committed r115360: <http://trac.webkit.org/changeset/115360> 611070 8 ap 2012-04-26 16:30:47 -0700 > it appears that this problem no longer reproduces at least on this test Perhaps it's more complicated when the script runs during load, as opposed to unload handler. 611083 9 rniwa 2012-04-26 16:48:25 -0700 (In reply to comment #8) > > it appears that this problem no longer reproduces at least on this test > > Perhaps it's more complicated when the script runs during load, as opposed to unload handler. Hm... that's possible. I guess Chromium WebKit gardeners will notice if this test becomes flaky :) 611113 10 ap 2012-04-26 17:20:02 -0700 > unload onload, thank you autocorrection :) 139050 2012-04-26 13:03:52 -0700 2012-04-26 13:18:00 -0700 Adds a regression test bug-84991-20120426130351.patch text/plain 2315 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDExNTM0MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTI2ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhIHRlc3QgZm9yIGNyYXNoIGluIERPTVNl bGVjdGlvbjo6ZGVsZXRlRnJvbURvY3VtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NDk5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBhIHRlc3QgZm9yIHRoZSBidWcgNDQxNTMgKGZpeGVkIGlu IHI2NTU4NykuCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9kZWxldGVGcm9tRG9jdW1l bnQtYWZ0ZXItZG9jdW1lbnQtb3Blbi1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGVkaXRpbmcvc2VsZWN0aW9uL2RlbGV0ZUZyb21Eb2N1bWVudC1hZnRlci1kb2N1bWVudC1v cGVuLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA0LTI1IEtlbiBCdWNoYW5hbiAgPGtlbnJi QGNocm9taXVtLm9yZz4KIAogICAgICAgICBDcmFzaCBmcm9tIHJlbW92YWwgb2YgbGluZSBicmVh ayBvYmplY3QgYWZ0ZXIgbGF5b3V0CkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlv bi9kZWxldGVGcm9tRG9jdW1lbnQtYWZ0ZXItZG9jdW1lbnQtb3Blbi1jcmFzaC1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vZGVsZXRlRnJv bURvY3VtZW50LWFmdGVyLWRvY3VtZW50LW9wZW4tY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vZGVsZXRlRnJvbURvY3VtZW50 LWFmdGVyLWRvY3VtZW50LW9wZW4tY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDMgQEAKK1RoaXMgY2FsbGluZyBkZWxldGVGcm9tRG9jdW1lbnQgYWZ0ZXIgZG9jdW1l bnQub3Blbi4gV2ViS2l0IHNob3VsZCBub3QgY3Jhc2guCitQQVNTCisKSW5kZXg6IExheW91dFRl c3RzL2VkaXRpbmcvc2VsZWN0aW9uL2RlbGV0ZUZyb21Eb2N1bWVudC1hZnRlci1kb2N1bWVudC1v cGVuLWNyYXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rp b24vZGVsZXRlRnJvbURvY3VtZW50LWFmdGVyLWRvY3VtZW50LW9wZW4tY3Jhc2guaHRtbAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2RlbGV0ZUZyb21Eb2N1 bWVudC1hZnRlci1kb2N1bWVudC1vcGVuLWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMzEgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgorCitpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgp OworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK30KKworZnVuY3Rpb24g cnVuKCkgeworICAgIHNlbGVjdGlvbiA9IHdpbmRvdy5nZXRTZWxlY3Rpb24oKTsKKyAgICByYW5n ZSA9IGRvY3VtZW50LmNyZWF0ZVJhbmdlKCk7CisgICAgc2VsZWN0aW9uLmFkZFJhbmdlKHJhbmdl KTsKKworICAgIGRvY3VtZW50LmRlc2lnbk1vZGUgPSAib24iOworICAgIGRvY3VtZW50LmV4ZWND b21tYW5kKCJJbnNlcnRUZXh0IiwgZmFsc2UsICd4Jyk7CisgICAgZG9jdW1lbnQub3BlbigpOwor ICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJVbmRvIik7CisKKyAgICBzZWxlY3Rpb24uZGVsZXRl RnJvbURvY3VtZW50KCk7CisKKyAgICBkb2N1bWVudC53cml0ZSgnVGhpcyBjYWxsaW5nIGRlbGV0 ZUZyb21Eb2N1bWVudCBhZnRlciBkb2N1bWVudC5vcGVuLiBXZWJLaXQgc2hvdWxkIG5vdCBjcmFz aC48YnI+Jyk7CisgICAgZG9jdW1lbnQud3JpdGUoJ1BBU1M8YnI+Jyk7CisKKyAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5 IG9ubG9hZD0icnVuKCkiPgorPC9ib2R5PgorPC9odG1sPgo=