84961 2012-04-26 07:54:07 -0700 [GTK] and [Win] TestWebKitAPI/WebKit2/TestSpacebarScrolling fails 2017-03-11 10:54:43 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux NEW Gtk P2 Normal --- 1 cgarcia roger_fong bugs-noreply eric jhoneycutt pnormand roger_fong thorton oldest_to_newest 610613 0 cgarcia 2012-04-26 07:54:07 -0700 We need to look at it in detail, I don't know why it fails 610616 1 cgarcia 2012-04-26 07:58:03 -0700 [ FATAL ] ../Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:1059:: pthread_mutex_destroy(&mutex_)failed with error 16 [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WebKit2 [ RUN ] WebKit2.SpacebarScrolling ../Tools/TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:92: Failure JS expression: isDocumentScrolled() Actual: false Expected: true Tests failed: Programs/TestWebKitAPI/WebKit2/TestSpacebarScrolling 731011 2 roger_fong 2012-09-28 14:58:03 -0700 This also breaks on the Apple Windows port. I got it to work by adding the second call to EXPECT_JS_TRUE(webView.page(), "textFieldContainsSpace()") to after the call to isDocumentScrolled. At least on Windows if you don't re-enter the javascript context first after simulating the space bar key press the document won't actually scroll. I thought it could have been a timing thing at first so I put a nice long loop into the SpaceBarScrolling.cpp could right before the failing EXPECT_JS_TRUE to see if it the page just didn't have time to scroll before the check. It still failed. So there's probably something goofy going on with the Windows TestWebKitAPI support, but for now, just switching the two lines will make the test pass. Maybe it will work on gtk as well... 731021 3 roger_fong 2012-09-28 15:15:17 -0700 Same behaviour can be observed earlier in the test right after the first space press is simulated. webView.simulateSpacebarKeyPress(); EXPECT_JS_FALSE(webView.page(), "isDocumentScrolled()"); EXPECT_JS_TRUE(webView.page(), "textFieldContainsSpace()"); If you switch the second two lines to: webView.simulateSpacebarKeyPress(); EXPECT_JS_TRUE(webView.page(), "textFieldContainsSpace()"); EXPECT_JS_FALSE(webView.page(), "isDocumentScrolled()"); the test will fail on the first EXPECT_JS_TRUE because the spacebarkeypress has not yet actually happened. The patch I'll land is a work around for this test but I'll file a new bug for the larger problem at hand. 731023 4 166322 roger_fong 2012-09-28 15:17:46 -0700 Created attachment 166322 patch 731836 5 166322 thorton 2012-10-01 11:37:14 -0700 Comment on attachment 166322 patch View in context: https://bugs.webkit.org/attachment.cgi?id=166322&action=review > Tools/TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:92 > + EXPECT_JS_TRUE(webView.page(), "textFieldContainsSpace()"); I think it would be interesting to know why this needs to happen before isDocumentScrolled() returns the correct value. You should see if a 0-delay timeout also fixes this, and then it would be interesting to know what's different between Win/Mac wrt. isDocumentScrolled and spinning the runloop. 731995 6 roger_fong 2012-10-01 14:33:52 -0700 Disregard the patch. It defeats the purpose of the test. Making a new test that just disables the failing line on Win using an #if 732001 7 roger_fong 2012-10-01 14:39:58 -0700 Bug to track the larger problem at hand: https://bugs.webkit.org/show_bug.cgi?id=97946 732024 8 166552 roger_fong 2012-10-01 14:55:38 -0700 Created attachment 166552 patch 732149 9 roger_fong 2012-10-01 17:17:35 -0700 Hmm can I get an r+/- from someone? 733066 10 166552 andersca 2012-10-02 14:16:38 -0700 Comment on attachment 166552 patch View in context: https://bugs.webkit.org/attachment.cgi?id=166552&action=review > Tools/TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:92 > +#if !PLATFORM(WIN) You should put a comment here with the link to the relevant bugzilla bug here. 733152 11 roger_fong 2012-10-02 15:41:19 -0700 Comment added, committed here: http://trac.webkit.org/changeset/130221 Leaving bug open in case GTK wants to do the same... 800028 12 eric 2013-01-04 00:52:47 -0800 Attachment 166552 was posted by a committer and has review+, assigning to Roger Fong for commit. 166322 2012-09-28 15:17:46 -0700 2012-10-01 14:55:38 -0700 patch 84961_patch.txt text/plain 1328 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyOTk1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTA5LTI4ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgRml4IFNwYWNlYmFyU2Nyb2xsaW5nIHRlc3Qgb24gV2luIChhbmQgaG9wZWZ1 bGx5IEdUSykgcG9ydC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg0OTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTG9va3MgbGlrZSB0aGUgdGVzdCBuZWVkcyB0byByZS1lbnRlciB0aGUgamF2YXNjcmlw dCBjb250ZXh0IGJlZm9yZSB0aGUgc2Nyb2xsaW5nIGFjdHVhbGx5IGhhcHBlbnMuCisgICAgICAg IAorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9TcGFjZWJhclNjcm9sbGlu Zy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxMi0wOS0yOCAgRGly ayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICB3ZWJraXQtcGF0Y2gg cmViYXNlbGluZS1leHBlY3RhdGlvbnMgaXMgYnJva2VuCkluZGV4OiBUb29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdDIvU3BhY2ViYXJTY3JvbGxpbmcuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9TcGFjZWJhclNjcm9sbGluZy5jcHAJKHJl dmlzaW9uIDEyODk4NykKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9TcGFj ZWJhclNjcm9sbGluZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg5LDYgKzg5LDcgQEAgVEVTVChX ZWJLaXQyLCBTcGFjZWJhclNjcm9sbGluZykKICAgICBkaWROb3RIYW5kbGVLZXlEb3duRXZlbnQg PSBmYWxzZTsKICAgICB3ZWJWaWV3LnNpbXVsYXRlU3BhY2ViYXJLZXlQcmVzcygpOwogCisgICAg RVhQRUNUX0pTX1RSVUUod2ViVmlldy5wYWdlKCksICJ0ZXh0RmllbGRDb250YWluc1NwYWNlKCki KTsKICAgICBFWFBFQ1RfSlNfVFJVRSh3ZWJWaWV3LnBhZ2UoKSwgImlzRG9jdW1lbnRTY3JvbGxl ZCgpIik7CiAgICAgRVhQRUNUX0pTX1RSVUUod2ViVmlldy5wYWdlKCksICJ0ZXh0RmllbGRDb250 YWluc1NwYWNlKCkiKTsKIAo= 166552 2012-10-01 14:55:38 -0700 2012-10-02 14:16:38 -0700 patch 84961_patch.txt text/plain 1375 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzMDA3OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTEwLTAxICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgSWdub3JlIGZhaWxpbmcgbGluZSBvZiBTcGFjZWJhclNjcm9sbGluZyBBUEkg dGVzdCBvbiBXaW5kb3dzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODQ5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUZXN0IGlzIGZhaWxpbmcgYmVjYXVzZSBvZiBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTc5NDYuCisgICAgICAgIElnbm9yaW5nIHRoZSBsaW5lIHRoYXQg ZmFpbHMgb24gV2luZG93cyBmb3Igbm93IHVudGlsIHRoZSBsYXJnZXIgcHJvYmxlbSBhdCBoYW5k IGlzIGZpeGVkLgorICAgICAgICAKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dDIvU3BhY2ViYXJTY3JvbGxpbmcuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6 CisKIDIwMTItMTAtMDEgIEVtaWwgQSBFa2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHVwZ3JhZGUgZWFlIHRvIHJldmlld2VyLiAKSW5kZXg6IFRvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9TcGFjZWJhclNjcm9sbGluZy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL1NwYWNlYmFyU2Nyb2xsaW5n LmNwcAkocmV2aXNpb24gMTI4OTg3KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQyL1NwYWNlYmFyU2Nyb2xsaW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODksNyArODksOSBA QCBURVNUKFdlYktpdDIsIFNwYWNlYmFyU2Nyb2xsaW5nKQogICAgIGRpZE5vdEhhbmRsZUtleURv d25FdmVudCA9IGZhbHNlOwogICAgIHdlYlZpZXcuc2ltdWxhdGVTcGFjZWJhcktleVByZXNzKCk7 CiAKKyNpZiAhUExBVEZPUk0oV0lOKQogICAgIEVYUEVDVF9KU19UUlVFKHdlYlZpZXcucGFnZSgp LCAiaXNEb2N1bWVudFNjcm9sbGVkKCkiKTsKKyNlbmRpZgogICAgIEVYUEVDVF9KU19UUlVFKHdl YlZpZXcucGFnZSgpLCAidGV4dEZpZWxkQ29udGFpbnNTcGFjZSgpIik7CiAKICNpZiBQTEFURk9S TShNQUMpCg==