84956 2012-04-26 07:37:44 -0700 Add copy constructor to CSSSelector 2012-04-26 08:56:54 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77745 1 koivisto webkit-unassigned kling macpherson menard webkit.review.bot oldest_to_newest 610596 0 koivisto 2012-04-26 07:37:44 -0700 Top copy CSSSelectorList correctly CSSSelector needs a copy constructor. 610598 1 139001 koivisto 2012-04-26 07:43:43 -0700 Created attachment 139001 patch 610600 2 webkit.review.bot 2012-04-26 07:46:21 -0700 Attachment 139001 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSSelector.h:40: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/css/CSSSelector.h:246: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 610605 3 139001 menard 2012-04-26 07:50:12 -0700 Comment on attachment 139001 patch View in context: https://bugs.webkit.org/attachment.cgi?id=139001&action=review > Source/WebCore/ChangeLog:8 > + To copy CSSSelectorLists correctly CSSSelector needs a copy constructor. Maybe you should explain the why, the real objective in this first patch. 610618 4 139001 webkit-ews 2012-04-26 07:59:30 -0700 Comment on attachment 139001 patch Attachment 139001 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12530950 610621 5 139001 buildbot 2012-04-26 08:04:22 -0700 Comment on attachment 139001 patch Attachment 139001 did not pass win-ews (win): Output: http://queues.webkit.org/results/12543094 610622 6 139003 koivisto 2012-04-26 08:04:53 -0700 Created attachment 139003 fix build 610661 7 koivisto 2012-04-26 08:56:54 -0700 http://trac.webkit.org/changeset/115319 139001 2012-04-26 07:43:43 -0700 2012-04-26 08:04:53 -0700 patch selector-copy.patch text/plain 7076 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTMxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDEyLTA0LTI2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgY29weSBjb25zdHJ1Y3Rv ciB0byBDU1NTZWxlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODQ5NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUbyBjb3B5IENTU1NlbGVjdG9yTGlzdHMgY29ycmVjdGx5IENTU1NlbGVjdG9yIG5l ZWRzIGEgY29weSBjb25zdHJ1Y3Rvci4KKyAgICAgICAgCisgICAgICAgIFRoZSBjb2RlIGlzIG5v dCB5ZXQgdXNlZC4KKworICAgICAgICAqIGNzcy9DU1NTZWxlY3Rvci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDU1NTZWxlY3Rvcjo6Y3JlYXRlUmFyZURhdGEpOgorICAgICAgICAqIGNzcy9DU1NT ZWxlY3Rvci5oOgorICAgICAgICAoQ1NTU2VsZWN0b3IpOgorICAgICAgICAoV2ViQ29yZTo6Q1NT U2VsZWN0b3I6OlJhcmVEYXRhOjpjcmVhdGUpOgorICAgICAgICAoUmFyZURhdGEpOgorICAgICAg ICAKKyAgICAgICAgICAgIFJlZmNvdW50IFJhcmVEYXRhIHRvIG1ha2UgY29weWluZyBlYXNpZXIu IFRoaXMgaGFzIG5vIHNpZ25pZmljYW50IG1lbW9yeSBpbXBhY3QsIHJhcmUgZGF0YSBpcyByYXJl LgorCisgICAgICAgIChXZWJDb3JlOjpDU1NTZWxlY3Rvcjo6Q1NTU2VsZWN0b3IpOgorICAgICAg ICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NTZWxlY3Rvcjo6fkNTU1NlbGVjdG9y KToKKyAgICAgICAgKiBjc3MvQ1NTU2VsZWN0b3JMaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNTU1NlbGVjdG9yTGlzdDo6Q1NTU2VsZWN0b3JMaXN0KToKKyAgICAgICAgCisgICAgICAgICAg ICBVc2UgY29weSBjb25zdHJ1Y3RvciBpbnN0ZWFkIG9mIG1lbWNweSAod2hpY2ggZG9lc24ndCB3 b3JrKS4KKwogMjAxMi0wNC0yNiAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2Vu QG5va2lhLmNvbT4KIAogICAgICAgICBNb3ZlIFdlYktpdDEgc3BlY2lmaWMgY29udmVyc2lvbiBv ZiB0b3VjaC1ldmVudHMgdG8gV2ViS2l0MS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT ZWxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9y LmNwcAkocmV2aXNpb24gMTE1Mjk4KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9y LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDMsNyArNDMsNyBAQCB2b2lkIENTU1NlbGVjdG9yOjpj cmVhdGVSYXJlRGF0YSgpCiAgICAgaWYgKG1faGFzUmFyZURhdGEpCiAgICAgICAgIHJldHVybjsK ICAgICAvLyBNb3ZlIHRoZSB2YWx1ZSB0byB0aGUgcmFyZSBkYXRhIHN0dWN0dXJlLgotICAgIG1f ZGF0YS5tX3JhcmVEYXRhID0gbmV3IFJhcmVEYXRhKGFkb3B0UmVmKG1fZGF0YS5tX3ZhbHVlKSk7 CisgICAgbV9kYXRhLm1fcmFyZURhdGEgPSBSYXJlRGF0YTo6Y3JlYXRlKGFkb3B0UmVmKG1fZGF0 YS5tX3ZhbHVlKSkubGVha1JlZigpOwogICAgIG1faGFzUmFyZURhdGEgPSB0cnVlOwogfQogCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuaAkocmV2aXNpb24gMTE1Mjk4KQorKysgU291cmNl L1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTMzLDQxICszMywx MyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAvLyB0aGlzIGNsYXNzIHJlcHJlc2VudHMg YSBzZWxlY3RvciBmb3IgYSBTdHlsZVJ1bGUKICAgICBjbGFzcyBDU1NTZWxlY3RvciB7Ci0gICAg ICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKENTU1NlbGVjdG9yKTsgV1RGX01BS0VfRkFTVF9BTExP Q0FURUQ7CisgICAgICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogICAgIHB1YmxpYzoKLSAg ICAgICAgQ1NTU2VsZWN0b3IoKQotICAgICAgICAgICAgOiBtX3JlbGF0aW9uKERlc2NlbmRhbnQp Ci0gICAgICAgICAgICAsIG1fbWF0Y2goTm9uZSkKLSAgICAgICAgICAgICwgbV9wc2V1ZG9UeXBl KFBzZXVkb05vdFBhcnNlZCkKLSAgICAgICAgICAgICwgbV9wYXJzZWROdGgoZmFsc2UpCi0gICAg ICAgICAgICAsIG1faXNMYXN0SW5TZWxlY3Rvckxpc3QoZmFsc2UpCi0gICAgICAgICAgICAsIG1f aXNMYXN0SW5UYWdIaXN0b3J5KHRydWUpCi0gICAgICAgICAgICAsIG1faGFzUmFyZURhdGEoZmFs c2UpCi0gICAgICAgICAgICAsIG1faXNGb3JQYWdlKGZhbHNlKQotICAgICAgICAgICAgLCBtX3Rh ZyhhbnlRTmFtZSgpKQotICAgICAgICB7Ci0gICAgICAgIH0KLQotICAgICAgICBDU1NTZWxlY3Rv cihjb25zdCBRdWFsaWZpZWROYW1lJiBxTmFtZSkKLSAgICAgICAgICAgIDogbV9yZWxhdGlvbihE ZXNjZW5kYW50KQotICAgICAgICAgICAgLCBtX21hdGNoKE5vbmUpCi0gICAgICAgICAgICAsIG1f cHNldWRvVHlwZShQc2V1ZG9Ob3RQYXJzZWQpCi0gICAgICAgICAgICAsIG1fcGFyc2VkTnRoKGZh bHNlKQotICAgICAgICAgICAgLCBtX2lzTGFzdEluU2VsZWN0b3JMaXN0KGZhbHNlKQotICAgICAg ICAgICAgLCBtX2lzTGFzdEluVGFnSGlzdG9yeSh0cnVlKQotICAgICAgICAgICAgLCBtX2hhc1Jh cmVEYXRhKGZhbHNlKQotICAgICAgICAgICAgLCBtX2lzRm9yUGFnZShmYWxzZSkKLSAgICAgICAg ICAgICwgbV90YWcocU5hbWUpCi0gICAgICAgIHsKLSAgICAgICAgfQorICAgICAgICBDU1NTZWxl Y3RvcigpOworICAgICAgICBDU1NTZWxlY3Rvcihjb25zdCBRdWFsaWZpZWROYW1lJiBxTmFtZSk7 CisgICAgICAgIENTU1NlbGVjdG9yKGNvbnN0IENTU1NlbGVjdG9yJiBvKTsKIAotICAgICAgICB+ Q1NTU2VsZWN0b3IoKQotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAobV9oYXNSYXJlRGF0YSkK LSAgICAgICAgICAgICAgICBkZWxldGUgbV9kYXRhLm1fcmFyZURhdGE7Ci0gICAgICAgICAgICBl bHNlIGlmIChtX2RhdGEubV92YWx1ZSkKLSAgICAgICAgICAgICAgICBtX2RhdGEubV92YWx1ZS0+ ZGVyZWYoKTsKLSAgICAgICAgfQorICAgICAgICB+Q1NTU2VsZWN0b3IoKTsKIAogICAgICAgICAv KioKICAgICAgICAgICogUmUtY3JlYXRlIHNlbGVjdG9yIHRleHQgZnJvbSBzZWxlY3RvcidzIGRh dGEKQEAgLTI3MCwxMCArMjQyLDExIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdW5z aWduZWQgc3BlY2lmaWNpdHlGb3JQYWdlKCkgY29uc3Q7CiAgICAgICAgIHZvaWQgZXh0cmFjdFBz ZXVkb1R5cGUoKSBjb25zdDsKIAotICAgICAgICBzdHJ1Y3QgUmFyZURhdGEgewotICAgICAgICAg ICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoUmFyZURhdGEpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRF RDsKLSAgICAgICAgcHVibGljOgotICAgICAgICAgICAgUmFyZURhdGEoUGFzc1JlZlB0cjxBdG9t aWNTdHJpbmdJbXBsPiB2YWx1ZSk7CisgICAgICAgIC8vIEhpZGUuCisgICAgICAgIENTU1NlbGVj dG9yJiBvcGVyYXRvcj0oY29uc3QgQ1NTU2VsZWN0b3ImIG8pOworCisgICAgICAgIHN0cnVjdCBS YXJlRGF0YSA6IHB1YmxpYyBSZWZDb3VudGVkPFJhcmVEYXRhPiB7CisgICAgICAgICAgICBzdGF0 aWMgUGFzc1JlZlB0cjxSYXJlRGF0YT4gY3JlYXRlKFBhc3NSZWZQdHI8QXRvbWljU3RyaW5nSW1w bD4gdmFsdWUpIHsgcmV0dXJuIGFkb3B0UmVmKG5ldyBSYXJlRGF0YSh2YWx1ZSkpOyB9CiAgICAg ICAgICAgICB+UmFyZURhdGEoKTsKIAogICAgICAgICAgICAgYm9vbCBwYXJzZU50aCgpOwpAQCAt Mjg1LDYgKzI1OCw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgIFF1YWxpZmll ZE5hbWUgbV9hdHRyaWJ1dGU7IC8vIHVzZWQgZm9yIGF0dHJpYnV0ZSBzZWxlY3RvcgogICAgICAg ICAgICAgQXRvbWljU3RyaW5nIG1fYXJndW1lbnQ7IC8vIFVzZWQgZm9yIDpjb250YWlucywgOmxh bmcgYW5kIDpudGgtKgogICAgICAgICAgICAgT3duUHRyPENTU1NlbGVjdG9yTGlzdD4gbV9zZWxl Y3Rvckxpc3Q7IC8vIFVzZWQgZm9yIDotd2Via2l0LWFueSBhbmQgOm5vdAorICAgICAgICAKKyAg ICAgICAgcHJpdmF0ZToKKyAgICAgICAgICAgIFJhcmVEYXRhKFBhc3NSZWZQdHI8QXRvbWljU3Ry aW5nSW1wbD4gdmFsdWUpOwogICAgICAgICB9OwogICAgICAgICB2b2lkIGNyZWF0ZVJhcmVEYXRh KCk7CiAKQEAgLTM2OSw2ICszNDUsNjAgQEAgaW5saW5lIHZvaWQgbW92ZShQYXNzT3duUHRyPENT U1NlbGVjdG9yPgogICAgIGZhc3REZWxldGVTa2lwcGluZ0Rlc3RydWN0b3IoZnJvbS5sZWFrUHRy KCkpOwogfQogCitpbmxpbmUgQ1NTU2VsZWN0b3I6OkNTU1NlbGVjdG9yKCkKKyAgICA6IG1fcmVs YXRpb24oRGVzY2VuZGFudCkKKyAgICAsIG1fbWF0Y2goTm9uZSkKKyAgICAsIG1fcHNldWRvVHlw ZShQc2V1ZG9Ob3RQYXJzZWQpCisgICAgLCBtX3BhcnNlZE50aChmYWxzZSkKKyAgICAsIG1faXNM YXN0SW5TZWxlY3Rvckxpc3QoZmFsc2UpCisgICAgLCBtX2lzTGFzdEluVGFnSGlzdG9yeSh0cnVl KQorICAgICwgbV9oYXNSYXJlRGF0YShmYWxzZSkKKyAgICAsIG1faXNGb3JQYWdlKGZhbHNlKQor ICAgICwgbV90YWcoYW55UU5hbWUoKSkKK3sKK30KKworaW5saW5lIENTU1NlbGVjdG9yOjpDU1NT ZWxlY3Rvcihjb25zdCBRdWFsaWZpZWROYW1lJiBxTmFtZSkKKyAgICA6IG1fcmVsYXRpb24oRGVz Y2VuZGFudCkKKyAgICAsIG1fbWF0Y2goTm9uZSkKKyAgICAsIG1fcHNldWRvVHlwZShQc2V1ZG9O b3RQYXJzZWQpCisgICAgLCBtX3BhcnNlZE50aChmYWxzZSkKKyAgICAsIG1faXNMYXN0SW5TZWxl Y3Rvckxpc3QoZmFsc2UpCisgICAgLCBtX2lzTGFzdEluVGFnSGlzdG9yeSh0cnVlKQorICAgICwg bV9oYXNSYXJlRGF0YShmYWxzZSkKKyAgICAsIG1faXNGb3JQYWdlKGZhbHNlKQorICAgICwgbV90 YWcocU5hbWUpCit7Cit9CisKK2lubGluZSBDU1NTZWxlY3Rvcjo6Q1NTU2VsZWN0b3IoY29uc3Qg Q1NTU2VsZWN0b3ImIG8pCisgICAgOiBtX3JlbGF0aW9uKG8ubV9yZWxhdGlvbikKKyAgICAsIG1f bWF0Y2goby5tX21hdGNoKQorICAgICwgbV9wc2V1ZG9UeXBlKG8ubV9wc2V1ZG9UeXBlKQorICAg ICwgbV9wYXJzZWROdGgoby5tX3BhcnNlZE50aCkKKyAgICAsIG1faXNMYXN0SW5TZWxlY3Rvckxp c3Qoby5tX2lzTGFzdEluU2VsZWN0b3JMaXN0KQorICAgICwgbV9pc0xhc3RJblRhZ0hpc3Rvcnko by5tX2lzTGFzdEluVGFnSGlzdG9yeSkKKyAgICAsIG1faGFzUmFyZURhdGEoby5tX2hhc1JhcmVE YXRhKQorICAgICwgbV9pc0ZvclBhZ2Uoby5tX2lzRm9yUGFnZSkKKyAgICAsIG1fdGFnKG8ubV90 YWcpCit7CisgICAgaWYgKG8ubV9oYXNSYXJlRGF0YSkgeworICAgICAgICBtX2RhdGEubV9yYXJl RGF0YSA9IG8ubV9kYXRhLm1fcmFyZURhdGE7CisgICAgICAgIG1fZGF0YS5tX3JhcmVEYXRhLT5y ZWYoKTsKKyAgICB9IGVsc2UgaWYgKG8ubV9kYXRhLm1fdmFsdWUpIHsKKyAgICAgICAgbV9kYXRh Lm1fdmFsdWUgPSBvLm1fZGF0YS5tX3ZhbHVlOworICAgICAgICBtX2RhdGEubV92YWx1ZS0+cmVm KCk7CisgICAgfQorfQorCitDU1NTZWxlY3Rvcjo6fkNTU1NlbGVjdG9yKCkKK3sKKyAgICBpZiAo bV9oYXNSYXJlRGF0YSkKKyAgICAgICAgbV9kYXRhLm1fcmFyZURhdGEtPmRlcmVmKCk7CisgICAg ZWxzZSBpZiAobV9kYXRhLm1fdmFsdWUpCisgICAgICAgIG1fZGF0YS5tX3ZhbHVlLT5kZXJlZigp OworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBDU1NTZWxlY3Rvcl9o CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3JMaXN0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3JMaXN0LmNwcAkocmV2aXNpb24gMTE1 Mjk4KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yTGlzdC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQzLDggKzQzLDE0IEBAIENTU1NlbGVjdG9yTGlzdDo6Q1NTU2VsZWN0b3JMaXN0 KGNvbnN0IEMKICAgICB3aGlsZSAoIWN1cnJlbnQtPmlzTGFzdEluU2VsZWN0b3JMaXN0KCkpCiAg ICAgICAgICsrY3VycmVudDsKICAgICB1bnNpZ25lZCBsZW5ndGggPSAoY3VycmVudCAtIG8ubV9z ZWxlY3RvckFycmF5KSArIDE7CisgICAgaWYgKGxlbmd0aCA9PSAxKSB7CisgICAgICAgIC8vIERl c3RydWN0b3IgZXhwZWN0cyBhIHNpbmdsZSBzZWxlY3RvciB0byBiZSBhbGxvY2F0ZWQgYnkgbmV3 LCBtdWx0aXBsZSB3aXRoIGZhc3RNYWxsb2MuCisgICAgICAgIG1fc2VsZWN0b3JBcnJheSA9IG5l dyBDU1NTZWxlY3RvcihvLm1fc2VsZWN0b3JBcnJheVswXSk7CisgICAgICAgIHJldHVybjsKKyAg ICB9CiAgICAgbV9zZWxlY3RvckFycmF5ID0gcmVpbnRlcnByZXRfY2FzdDxDU1NTZWxlY3Rvcio+ KGZhc3RNYWxsb2Moc2l6ZW9mKENTU1NlbGVjdG9yKSAqIGxlbmd0aCkpOwotICAgIG1lbWNweSht X3NlbGVjdG9yQXJyYXksIG8ubV9zZWxlY3RvckFycmF5LCBzaXplb2YoQ1NTU2VsZWN0b3IpICog bGVuZ3RoKTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kpCisgICAg ICAgIG5ldyAoJm1fc2VsZWN0b3JBcnJheVtpXSkgQ1NTU2VsZWN0b3Ioby5tX3NlbGVjdG9yQXJy YXlbaV0pOwogfQogCiB2b2lkIENTU1NlbGVjdG9yTGlzdDo6YWRvcHQoQ1NTU2VsZWN0b3JMaXN0 JiBsaXN0KQo= 139003 2012-04-26 08:04:53 -0700 2012-04-26 08:34:17 -0700 fix build selector-copy-3.patch text/plain 7126 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTMxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDEyLTA0LTI2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgY29weSBjb25zdHJ1Y3Rv ciB0byBDU1NTZWxlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODQ5NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUbyBjb3B5IENTU1NlbGVjdG9yTGlzdHMgY29ycmVjdGx5IENTU1NlbGVjdG9yIG5l ZWRzIGEgY29weSBjb25zdHJ1Y3Rvci4KKyAgICAgICAgCisgICAgICAgIFRoaXMgd2lsbCBiZSBu ZWVkZWQgdG8gaW1wbGVtZW50IHN0eWxlc2hlZXQgY2FjaGluZy4gVGhlIGNvZGUgaXMgbm90IHVz ZWQgeWV0LgorCisgICAgICAgICogY3NzL0NTU1NlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1NlbGVjdG9yOjpjcmVhdGVSYXJlRGF0YSk6CisgICAgICAgICogY3NzL0NTU1NlbGVj dG9yLmg6CisgICAgICAgIChDU1NTZWxlY3Rvcik6CisgICAgICAgIChXZWJDb3JlOjpDU1NTZWxl Y3Rvcjo6UmFyZURhdGE6OmNyZWF0ZSk6CisgICAgICAgIChSYXJlRGF0YSk6CisgICAgICAgIAor ICAgICAgICAgICAgUmVmY291bnQgUmFyZURhdGEgdG8gbWFrZSBjb3B5aW5nIGVhc2llci4gVGhp cyBoYXMgbm8gc2lnbmlmaWNhbnQgbWVtb3J5IGltcGFjdCwgcmFyZSBkYXRhIGlzIHJhcmUuCisK KyAgICAgICAgKFdlYkNvcmU6OkNTU1NlbGVjdG9yOjpDU1NTZWxlY3Rvcik6CisgICAgICAgIChX ZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1NlbGVjdG9yOjp+Q1NTU2VsZWN0b3IpOgor ICAgICAgICAqIGNzcy9DU1NTZWxlY3Rvckxpc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NT U2VsZWN0b3JMaXN0OjpDU1NTZWxlY3Rvckxpc3QpOgorICAgICAgICAKKyAgICAgICAgICAgIFVz ZSBjb3B5IGNvbnN0cnVjdG9yIGluc3RlYWQgb2YgbWVtY3B5ICh3aGljaCBkb2Vzbid0IHdvcmsp LgorCiAyMDEyLTA0LTI2ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9r aWEuY29tPgogCiAgICAgICAgIE1vdmUgV2ViS2l0MSBzcGVjaWZpYyBjb252ZXJzaW9uIG9mIHRv dWNoLWV2ZW50cyB0byBXZWJLaXQxLgpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVj dG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuY3Bw CShyZXZpc2lvbiAxMTUyOTgpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00Myw3ICs0Myw3IEBAIHZvaWQgQ1NTU2VsZWN0b3I6OmNyZWF0 ZVJhcmVEYXRhKCkKICAgICBpZiAobV9oYXNSYXJlRGF0YSkKICAgICAgICAgcmV0dXJuOwogICAg IC8vIE1vdmUgdGhlIHZhbHVlIHRvIHRoZSByYXJlIGRhdGEgc3R1Y3R1cmUuCi0gICAgbV9kYXRh Lm1fcmFyZURhdGEgPSBuZXcgUmFyZURhdGEoYWRvcHRSZWYobV9kYXRhLm1fdmFsdWUpKTsKKyAg ICBtX2RhdGEubV9yYXJlRGF0YSA9IFJhcmVEYXRhOjpjcmVhdGUoYWRvcHRSZWYobV9kYXRhLm1f dmFsdWUpKS5sZWFrUmVmKCk7CiAgICAgbV9oYXNSYXJlRGF0YSA9IHRydWU7CiB9CiAKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5oCShyZXZpc2lvbiAxMTUyOTgpCisrKyBTb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTU2VsZWN0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMzMsNDEgKzMzLDEzIEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgIC8vIHRoaXMgY2xhc3MgcmVwcmVzZW50cyBhIHNl bGVjdG9yIGZvciBhIFN0eWxlUnVsZQogICAgIGNsYXNzIENTU1NlbGVjdG9yIHsKLSAgICAgICAg V1RGX01BS0VfTk9OQ09QWUFCTEUoQ1NTU2VsZWN0b3IpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRF RDsKKyAgICAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiAgICAgcHVibGljOgotICAgICAg ICBDU1NTZWxlY3RvcigpCi0gICAgICAgICAgICA6IG1fcmVsYXRpb24oRGVzY2VuZGFudCkKLSAg ICAgICAgICAgICwgbV9tYXRjaChOb25lKQotICAgICAgICAgICAgLCBtX3BzZXVkb1R5cGUoUHNl dWRvTm90UGFyc2VkKQotICAgICAgICAgICAgLCBtX3BhcnNlZE50aChmYWxzZSkKLSAgICAgICAg ICAgICwgbV9pc0xhc3RJblNlbGVjdG9yTGlzdChmYWxzZSkKLSAgICAgICAgICAgICwgbV9pc0xh c3RJblRhZ0hpc3RvcnkodHJ1ZSkKLSAgICAgICAgICAgICwgbV9oYXNSYXJlRGF0YShmYWxzZSkK LSAgICAgICAgICAgICwgbV9pc0ZvclBhZ2UoZmFsc2UpCi0gICAgICAgICAgICAsIG1fdGFnKGFu eVFOYW1lKCkpCi0gICAgICAgIHsKLSAgICAgICAgfQotCi0gICAgICAgIENTU1NlbGVjdG9yKGNv bnN0IFF1YWxpZmllZE5hbWUmIHFOYW1lKQotICAgICAgICAgICAgOiBtX3JlbGF0aW9uKERlc2Nl bmRhbnQpCi0gICAgICAgICAgICAsIG1fbWF0Y2goTm9uZSkKLSAgICAgICAgICAgICwgbV9wc2V1 ZG9UeXBlKFBzZXVkb05vdFBhcnNlZCkKLSAgICAgICAgICAgICwgbV9wYXJzZWROdGgoZmFsc2Up Ci0gICAgICAgICAgICAsIG1faXNMYXN0SW5TZWxlY3Rvckxpc3QoZmFsc2UpCi0gICAgICAgICAg ICAsIG1faXNMYXN0SW5UYWdIaXN0b3J5KHRydWUpCi0gICAgICAgICAgICAsIG1faGFzUmFyZURh dGEoZmFsc2UpCi0gICAgICAgICAgICAsIG1faXNGb3JQYWdlKGZhbHNlKQotICAgICAgICAgICAg LCBtX3RhZyhxTmFtZSkKLSAgICAgICAgewotICAgICAgICB9CisgICAgICAgIENTU1NlbGVjdG9y KCk7CisgICAgICAgIENTU1NlbGVjdG9yKGNvbnN0IFF1YWxpZmllZE5hbWUmKTsKKyAgICAgICAg Q1NTU2VsZWN0b3IoY29uc3QgQ1NTU2VsZWN0b3ImKTsKIAotICAgICAgICB+Q1NTU2VsZWN0b3Io KQotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAobV9oYXNSYXJlRGF0YSkKLSAgICAgICAgICAg ICAgICBkZWxldGUgbV9kYXRhLm1fcmFyZURhdGE7Ci0gICAgICAgICAgICBlbHNlIGlmIChtX2Rh dGEubV92YWx1ZSkKLSAgICAgICAgICAgICAgICBtX2RhdGEubV92YWx1ZS0+ZGVyZWYoKTsKLSAg ICAgICAgfQorICAgICAgICB+Q1NTU2VsZWN0b3IoKTsKIAogICAgICAgICAvKioKICAgICAgICAg ICogUmUtY3JlYXRlIHNlbGVjdG9yIHRleHQgZnJvbSBzZWxlY3RvcidzIGRhdGEKQEAgLTI3MCwx MCArMjQyLDExIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdW5zaWduZWQgc3BlY2lm aWNpdHlGb3JQYWdlKCkgY29uc3Q7CiAgICAgICAgIHZvaWQgZXh0cmFjdFBzZXVkb1R5cGUoKSBj b25zdDsKIAotICAgICAgICBzdHJ1Y3QgUmFyZURhdGEgewotICAgICAgICAgICAgV1RGX01BS0Vf Tk9OQ09QWUFCTEUoUmFyZURhdGEpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKLSAgICAgICAg cHVibGljOgotICAgICAgICAgICAgUmFyZURhdGEoUGFzc1JlZlB0cjxBdG9taWNTdHJpbmdJbXBs PiB2YWx1ZSk7CisgICAgICAgIC8vIEhpZGUuCisgICAgICAgIENTU1NlbGVjdG9yJiBvcGVyYXRv cj0oY29uc3QgQ1NTU2VsZWN0b3ImKTsKKworICAgICAgICBzdHJ1Y3QgUmFyZURhdGEgOiBwdWJs aWMgUmVmQ291bnRlZDxSYXJlRGF0YT4geworICAgICAgICAgICAgc3RhdGljIFBhc3NSZWZQdHI8 UmFyZURhdGE+IGNyZWF0ZShQYXNzUmVmUHRyPEF0b21pY1N0cmluZ0ltcGw+IHZhbHVlKSB7IHJl dHVybiBhZG9wdFJlZihuZXcgUmFyZURhdGEodmFsdWUpKTsgfQogICAgICAgICAgICAgflJhcmVE YXRhKCk7CiAKICAgICAgICAgICAgIGJvb2wgcGFyc2VOdGgoKTsKQEAgLTI4NSw2ICsyNTgsOSBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgICAgICBRdWFsaWZpZWROYW1lIG1fYXR0cmli dXRlOyAvLyB1c2VkIGZvciBhdHRyaWJ1dGUgc2VsZWN0b3IKICAgICAgICAgICAgIEF0b21pY1N0 cmluZyBtX2FyZ3VtZW50OyAvLyBVc2VkIGZvciA6Y29udGFpbnMsIDpsYW5nIGFuZCA6bnRoLSoK ICAgICAgICAgICAgIE93blB0cjxDU1NTZWxlY3Rvckxpc3Q+IG1fc2VsZWN0b3JMaXN0OyAvLyBV c2VkIGZvciA6LXdlYmtpdC1hbnkgYW5kIDpub3QKKyAgICAgICAgCisgICAgICAgIHByaXZhdGU6 CisgICAgICAgICAgICBSYXJlRGF0YShQYXNzUmVmUHRyPEF0b21pY1N0cmluZ0ltcGw+IHZhbHVl KTsKICAgICAgICAgfTsKICAgICAgICAgdm9pZCBjcmVhdGVSYXJlRGF0YSgpOwogCkBAIC0zNjks NiArMzQ1LDYwIEBAIGlubGluZSB2b2lkIG1vdmUoUGFzc093blB0cjxDU1NTZWxlY3Rvcj4KICAg ICBmYXN0RGVsZXRlU2tpcHBpbmdEZXN0cnVjdG9yKGZyb20ubGVha1B0cigpKTsKIH0KIAoraW5s aW5lIENTU1NlbGVjdG9yOjpDU1NTZWxlY3RvcigpCisgICAgOiBtX3JlbGF0aW9uKERlc2NlbmRh bnQpCisgICAgLCBtX21hdGNoKE5vbmUpCisgICAgLCBtX3BzZXVkb1R5cGUoUHNldWRvTm90UGFy c2VkKQorICAgICwgbV9wYXJzZWROdGgoZmFsc2UpCisgICAgLCBtX2lzTGFzdEluU2VsZWN0b3JM aXN0KGZhbHNlKQorICAgICwgbV9pc0xhc3RJblRhZ0hpc3RvcnkodHJ1ZSkKKyAgICAsIG1faGFz UmFyZURhdGEoZmFsc2UpCisgICAgLCBtX2lzRm9yUGFnZShmYWxzZSkKKyAgICAsIG1fdGFnKGFu eVFOYW1lKCkpCit7Cit9CisKK2lubGluZSBDU1NTZWxlY3Rvcjo6Q1NTU2VsZWN0b3IoY29uc3Qg UXVhbGlmaWVkTmFtZSYgcU5hbWUpCisgICAgOiBtX3JlbGF0aW9uKERlc2NlbmRhbnQpCisgICAg LCBtX21hdGNoKE5vbmUpCisgICAgLCBtX3BzZXVkb1R5cGUoUHNldWRvTm90UGFyc2VkKQorICAg ICwgbV9wYXJzZWROdGgoZmFsc2UpCisgICAgLCBtX2lzTGFzdEluU2VsZWN0b3JMaXN0KGZhbHNl KQorICAgICwgbV9pc0xhc3RJblRhZ0hpc3RvcnkodHJ1ZSkKKyAgICAsIG1faGFzUmFyZURhdGEo ZmFsc2UpCisgICAgLCBtX2lzRm9yUGFnZShmYWxzZSkKKyAgICAsIG1fdGFnKHFOYW1lKQorewor fQorCitpbmxpbmUgQ1NTU2VsZWN0b3I6OkNTU1NlbGVjdG9yKGNvbnN0IENTU1NlbGVjdG9yJiBv KQorICAgIDogbV9yZWxhdGlvbihvLm1fcmVsYXRpb24pCisgICAgLCBtX21hdGNoKG8ubV9tYXRj aCkKKyAgICAsIG1fcHNldWRvVHlwZShvLm1fcHNldWRvVHlwZSkKKyAgICAsIG1fcGFyc2VkTnRo KG8ubV9wYXJzZWROdGgpCisgICAgLCBtX2lzTGFzdEluU2VsZWN0b3JMaXN0KG8ubV9pc0xhc3RJ blNlbGVjdG9yTGlzdCkKKyAgICAsIG1faXNMYXN0SW5UYWdIaXN0b3J5KG8ubV9pc0xhc3RJblRh Z0hpc3RvcnkpCisgICAgLCBtX2hhc1JhcmVEYXRhKG8ubV9oYXNSYXJlRGF0YSkKKyAgICAsIG1f aXNGb3JQYWdlKG8ubV9pc0ZvclBhZ2UpCisgICAgLCBtX3RhZyhvLm1fdGFnKQoreworICAgIGlm IChvLm1faGFzUmFyZURhdGEpIHsKKyAgICAgICAgbV9kYXRhLm1fcmFyZURhdGEgPSBvLm1fZGF0 YS5tX3JhcmVEYXRhOworICAgICAgICBtX2RhdGEubV9yYXJlRGF0YS0+cmVmKCk7CisgICAgfSBl bHNlIGlmIChvLm1fZGF0YS5tX3ZhbHVlKSB7CisgICAgICAgIG1fZGF0YS5tX3ZhbHVlID0gby5t X2RhdGEubV92YWx1ZTsKKyAgICAgICAgbV9kYXRhLm1fdmFsdWUtPnJlZigpOworICAgIH0KK30K KworaW5saW5lIENTU1NlbGVjdG9yOjp+Q1NTU2VsZWN0b3IoKQoreworICAgIGlmIChtX2hhc1Jh cmVEYXRhKQorICAgICAgICBtX2RhdGEubV9yYXJlRGF0YS0+ZGVyZWYoKTsKKyAgICBlbHNlIGlm IChtX2RhdGEubV92YWx1ZSkKKyAgICAgICAgbV9kYXRhLm1fdmFsdWUtPmRlcmVmKCk7Cit9CisK IH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIENTU1NlbGVjdG9yX2gKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvckxpc3QuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvckxpc3QuY3BwCShyZXZpc2lvbiAxMTUyOTgpCisr KyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3JMaXN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDMsOCArNDMsMTQgQEAgQ1NTU2VsZWN0b3JMaXN0OjpDU1NTZWxlY3Rvckxpc3QoY29uc3Qg QwogICAgIHdoaWxlICghY3VycmVudC0+aXNMYXN0SW5TZWxlY3Rvckxpc3QoKSkKICAgICAgICAg KytjdXJyZW50OwogICAgIHVuc2lnbmVkIGxlbmd0aCA9IChjdXJyZW50IC0gby5tX3NlbGVjdG9y QXJyYXkpICsgMTsKKyAgICBpZiAobGVuZ3RoID09IDEpIHsKKyAgICAgICAgLy8gRGVzdHJ1Y3Rv ciBleHBlY3RzIGEgc2luZ2xlIHNlbGVjdG9yIHRvIGJlIGFsbG9jYXRlZCBieSBuZXcsIG11bHRp cGxlIHdpdGggZmFzdE1hbGxvYy4KKyAgICAgICAgbV9zZWxlY3RvckFycmF5ID0gbmV3IENTU1Nl bGVjdG9yKG8ubV9zZWxlY3RvckFycmF5WzBdKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KICAg ICBtX3NlbGVjdG9yQXJyYXkgPSByZWludGVycHJldF9jYXN0PENTU1NlbGVjdG9yKj4oZmFzdE1h bGxvYyhzaXplb2YoQ1NTU2VsZWN0b3IpICogbGVuZ3RoKSk7Ci0gICAgbWVtY3B5KG1fc2VsZWN0 b3JBcnJheSwgby5tX3NlbGVjdG9yQXJyYXksIHNpemVvZihDU1NTZWxlY3RvcikgKiBsZW5ndGgp OworICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkKKyAgICAgICAgbmV3 ICgmbV9zZWxlY3RvckFycmF5W2ldKSBDU1NTZWxlY3RvcihvLm1fc2VsZWN0b3JBcnJheVtpXSk7 CiB9CiAKIHZvaWQgQ1NTU2VsZWN0b3JMaXN0OjphZG9wdChDU1NTZWxlY3Rvckxpc3QmIGxpc3Qp Cg==