84950 2012-04-26 06:34:17 -0700 [GTK] Massive media tests failures since r115288 2012-06-26 14:25:19 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand mhahnenberg ggaren mhahnenberg spena webkit.review.bot yong.li.webkit oldest_to_newest 610537 0 pnormand 2012-04-26 06:34:17 -0700 Lots of tests now timing out. It seems the GStreamer media player does something wrong which has bad consequences on the memory management of the media elements. This works fine: run-webkit-tests --run-singly --gtk media But when the DRT instance is reused acrossed tests (default behavior) it triggers unexpected flakiness of the media suite. 610619 1 mhahnenberg 2012-04-26 08:02:31 -0700 I believe this has to do with the fact that we only have a properly implemented GCActivityCallback on platforms which have CoreFoundation, meaning we are now not doing any collection for those platforms without CoreFoundation when we call GCController::garbageCollectSoon(). This is obviously bad. I'd imagine that this issue manifests itself in the media tests because of the fact that they're dealing with very large things that need to be collected pretty quickly when they die to prevent memory bloat. 610811 2 139040 mhahnenberg 2012-04-26 12:20:48 -0700 Created attachment 139040 Patch 610850 3 pnormand 2012-04-26 12:52:45 -0700 I've just tested the patch locally and it fixes the media suite flakyness. Thanks Mark! 611046 4 139040 webkit.review.bot 2012-04-26 15:52:53 -0700 Comment on attachment 139040 Patch Clearing flags on attachment: 139040 Committed r115383: <http://trac.webkit.org/changeset/115383> 611047 5 webkit.review.bot 2012-04-26 15:52:57 -0700 All reviewed patches have been landed. Closing bug. 657991 6 yong.li.webkit 2012-06-26 14:22:25 -0700 How about moving Timer/SharedTimer into WTF as is done for String? 657995 7 mhahnenberg 2012-06-26 14:25:19 -0700 (In reply to comment #6) > How about moving Timer/SharedTimer into WTF as is done for String? Yes, that is what I'd like to do when I get around to it. If you'd like to do that, you're more than welcome! :-) 139040 2012-04-26 12:20:48 -0700 2012-04-26 15:52:52 -0700 Patch bug-84950-20120426122047.patch text/plain 3668 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDVkMzY1ZmZlMGRkYjM4 NDE2NjIxY2QzNWE2ZWFlOWYwZTBkMDQ2My4uN2JhMTc1ZGU4ZjUzNDc2Y2YzZDQzMzg1N2U3Y2Uw OTNjZDczMTY5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA0LTI2ICBNYXJr IEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW0dUS10gTWFz c2l2ZSBtZWRpYSB0ZXN0cyBmYWlsdXJlcyBzaW5jZSByMTE1Mjg4CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDk1MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICBT aW5jZSB0aGUgImNyb3NzLXBsYXRmb3JtIiBXZWJDb3JlIHRpbWVyIGlzIGF0IHRvbyBoaWdoIG9m IGEgbGV2ZWwgaW4gdGVybXMgb2YgdGhlIGxheWVycyAKKyAgICAgICAgb2YgV2ViS2l0IGZvciBK U0MgdG8gdXNlLCB3ZSBhcmUgbm90IGN1cnJlbnRseSBhYmxlIHRvIHVzZSBpdCBpbiBKU0MsIHRo dXMgb25seSB0aG9zZSAKKyAgICAgICAgcGxhdGZvcm1zIHRoYXQgc3VwcG9ydCBDb3JlRm91bmRh dGlvbiBjYW4gY3VycmVudGx5IHRha2UgYWR2YW50YWdlIG9mIHRoZSBuZXcgYW5kIGltcHJvdmVk IAorICAgICAgICBHQyBhY3Rpdml0eSB0aW1lci4gV2UndmUgcmVzdG9yZWQgdGhlIG9sZCBjb2Rl IHBhdGhzIGZvciB0aG9zZSBwbGF0Zm9ybXMgdGhhdCBkb24ndCBoYXZlIAorICAgICAgICBDRiBz byB0aGF0IHRoZXkgd2lsbCBhdCBsZWFzdCBoYXZlIHRoZSBzYW1lIGJlaGF2aW9yIGFzIGJlZm9y ZSB3aGVuIGNhbGxpbmcgZ2FyYmFnZUNvbGxlY3RTb29uLgorCisgICAgICAgICogYmluZGluZ3Mv anMvR0NDb250cm9sbGVyLmNwcDogQWRkZWQgYmFjayB0aGUgb2xkIFdlYkNvcmUgdGltZXIgYWxv bmcgd2l0aCBzb21lIAorICAgICAgICBpZi1kZWZzIHRoYXQgZG8gYXdheSB3aXRoIHRoZSBXZWJD b3JlIHRpbWVyIG9uIHBsYXRmb3JtcyB0aGF0IHN1cHBvcnQgQ29yZUZvdW5kYXRpb24uCisgICAg ICAgIChXZWJDb3JlOjpHQ0NvbnRyb2xsZXI6OkdDQ29udHJvbGxlcik6CisgICAgICAgIChXZWJD b3JlOjpHQ0NvbnRyb2xsZXI6OmdhcmJhZ2VDb2xsZWN0U29vbik6CisgICAgICAgIChXZWJDb3Jl KToKKyAgICAgICAgKFdlYkNvcmU6OkdDQ29udHJvbGxlcjo6Z2NUaW1lckZpcmVkKToKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuaDogRGl0dG8uCisgICAgICAgIChHQ0NvbnRy b2xsZXIpOgorCiAyMDEyLTA0LTI2ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW1wbGVtZW50IHRoZSAiRGlzYWJsZSBK YXZhU2NyaXB0IiBvcHRpb24gaW4gdGhlIHNldHRpbmdzIGRpYWxvZwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHAKaW5kZXggM2UwYTg4YzUyNzVkOTVmNzI2OGUx ZGQ5MzVjOTA2NGVjNzZkMmM0Yy4uYTEzN2MzYTAzNWI3ODAwZjNkZDMwNjQ1ZDA0MjAxMTM2YzUy OWYyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvR0NDb250cm9sbGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwCkBA IC00OSwxNSArNDksMzUgQEAgR0NDb250cm9sbGVyJiBnY0NvbnRyb2xsZXIoKQogfQogCiBHQ0Nv bnRyb2xsZXI6OkdDQ29udHJvbGxlcigpCisjaWYgIVVTRShDRikKKyAgICA6IG1fR0NUaW1lcih0 aGlzLCAmR0NDb250cm9sbGVyOjpnY1RpbWVyRmlyZWQpCisjZW5kaWYKIHsKIH0KIAogdm9pZCBH Q0NvbnRyb2xsZXI6OmdhcmJhZ2VDb2xsZWN0U29vbigpCiB7CisgICAgLy8gV2Ugb25seSB1c2Ug cmVwb3J0QWJhbmRvbmVkT2JqZWN0R3JhcGggb24gc3lzdGVtcyB3aXRoIENvcmVGb3VuZGF0aW9u IAorICAgIC8vIHNpbmNlIGl0IHVzZXMgYSBydW5sb29wLWJhc2VkIHRpbWVyIHRoYXQgaXMgY3Vy cmVudGx5IG9ubHkgYXZhaWxhYmxlIG9uIAorICAgIC8vIHN5c3RlbXMgd2l0aCBDb3JlRm91bmRh dGlvbi4gSWYgYW5kIHdoZW4gdGhlIG5vdGlvbiBvZiBhIHJ1biBsb29wIGlzIHB1c2hlZCAKKyAg ICAvLyBkb3duIGludG8gV1RGIHNvIHRoYXQgbW9yZSBwbGF0Zm9ybXMgY2FuIHRha2UgYWR2YW50 YWdlIG9mIGl0LCB3ZSB3aWxsIGJlIAorICAgIC8vIGFibGUgdG8gdXNlIHJlcG9ydEFiYW5kb25l ZE9iamVjdEdyYXBoIG9uIG1vcmUgcGxhdGZvcm1zLgorI2lmIFVTRShDRikKICAgICBKU0xvY2sg bG9jayhTaWxlbmNlQXNzZXJ0aW9uc09ubHkpOwogICAgIEpTRE9NV2luZG93Ojpjb21tb25KU0ds b2JhbERhdGEoKS0+aGVhcC5yZXBvcnRBYmFuZG9uZWRPYmplY3RHcmFwaCgpOworI2Vsc2UKKyAg ICBpZiAoIW1fR0NUaW1lci5pc0FjdGl2ZSgpKQorICAgICAgICBtX0dDVGltZXIuc3RhcnRPbmVT aG90KDApOworI2VuZGlmCiB9CiAKKyNpZiAhVVNFKENGKQordm9pZCBHQ0NvbnRyb2xsZXI6Omdj VGltZXJGaXJlZChUaW1lcjxHQ0NvbnRyb2xsZXI+KikKK3sKKyAgICBjb2xsZWN0KDApOworfQor I2VuZGlmCisKIHZvaWQgR0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVjdE5vdygpCiB7CiAgICAg SlNMb2NrIGxvY2soU2lsZW5jZUFzc2VydGlvbnNPbmx5KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvR0NDb250cm9sbGVyLmgKaW5kZXggYzU2Y2I4ODE3YzRlOTY2NDQxMmViODhmZjM0NDZj YmQ0YWQ1MDdmZC4uYTM2NzM3ODgwNWZjYTQxYmEzNjc2YjE3ZTgxMGFmMmUxOTBjYTk2MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmgKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmgKQEAgLTI2LDggKzI2LDEy IEBACiAjaWZuZGVmIEdDQ29udHJvbGxlcl9oCiAjZGVmaW5lIEdDQ29udHJvbGxlcl9oCiAKKyNp ZiBVU0UoQ0YpCiAjaW5jbHVkZSA8d3RmL0Zhc3RBbGxvY0Jhc2UuaD4KICNpbmNsdWRlIDx3dGYv Tm9uY29weWFibGUuaD4KKyNlbHNlCisjaW5jbHVkZSAiVGltZXIuaCIKKyNlbmRpZgogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKQEAgLTQ1LDYgKzQ5LDExIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAogICAgIHByaXZhdGU6CiAgICAgICAgIEdDQ29udHJvbGxlcigpOyAvLyBVc2UgZ2NDb250cm9s bGVyKCkgaW5zdGVhZAorCisjaWYgIVVTRShDRikKKyAgICAgICAgdm9pZCBnY1RpbWVyRmlyZWQo VGltZXI8R0NDb250cm9sbGVyPiopOworICAgICAgICBUaW1lcjxHQ0NvbnRyb2xsZXI+IG1fR0NU aW1lcjsKKyNlbmRpZgogICAgIH07CiAKICAgICAvLyBGdW5jdGlvbiB0byBvYnRhaW4gdGhlIGds b2JhbCBHQyBjb250cm9sbGVyLgo=