84948 2012-04-26 06:22:25 -0700 [Qt][WK2] Tap highlight should have a delay not to interfere with panning 2012-04-26 07:14:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All Linux RESOLVED FIXED Qt P3 Normal --- 1 abecsi abecsi hausmann jturcotte kenneth menard webkit.review.bot zoltan oldest_to_newest 610532 0 abecsi 2012-04-26 06:22:25 -0700 Start the tap highlight animation after a slight delay so that pan gestures do not result in flashing highlight rects which slow down flicking, especially for continuous pan gestures. 610539 1 138987 abecsi 2012-04-26 06:41:53 -0700 Created attachment 138987 proposed patch 610547 2 138990 abecsi 2012-04-26 06:47:49 -0700 Created attachment 138990 proposed patch 610561 3 138990 kenneth 2012-04-26 06:56:06 -0700 Comment on attachment 138990 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=138990&action=review > Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp:102 > +void QtTapGestureRecognizer::tapHighlightTimeout() We are in the TAP gesture recognizer,,,.. maybe highlightTimeout is sufficient > Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.h:39 > +const int tapHighlightThreshold = 80; highlightPostponeTime would make more sense > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:499 > + // Early return since this was a touch end event. touch-end event 610580 4 abecsi 2012-04-26 07:14:00 -0700 Landed in http://trac.webkit.org/changeset/115311. 610581 5 138990 abecsi 2012-04-26 07:14:19 -0700 Comment on attachment 138990 proposed patch Clearing flags. 138987 2012-04-26 06:41:53 -0700 2012-04-26 06:47:49 -0700 proposed patch 0001-tap-highlight-fix.patch text/plain 6929 abecsi RnJvbSAyMmUxYzVjYjMxMTg5NGIyOWZhMTQyNDFjZDdjMWQzNzAyYjhhN2Y0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyYXMgQmVjc2kgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+ CkRhdGU6IFRodSwgMjYgQXByIDIwMTIgMTU6NDA6MjkgKzAyMDAKU3ViamVjdDogW1BBVENIXSB0 YXAgaGlnaGxpZ2h0IGZpeAoKLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgMjIgKysrKysrKysrKysrKysrKysrKysKIC4uLi9VSVByb2Nl c3MvcXQvUXRUYXBHZXN0dXJlUmVjb2duaXplci5jcHAgICAgICAgIHwgICAyMSArKysrKysrKysr KysrKystLS0KIC4uLi9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFRhcEdlc3R1cmVSZWNvZ25pemVy LmggIHwgICAgNSArKystCiAuLi4vV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRI YW5kbGVyLmNwcCB8ICAgMTcgKysrKysrKysrKy0tLS0tCiA0IGZpbGVzIGNoYW5nZWQsIDU0IGlu c2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA4YTkxY2Q5Li5jYzkx MGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTItMDQtMjYgIEFuZHJhcyBCZWNz aSAgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XVtXSzJdIFRhcCBoaWdo bGlnaHQgc2hvdWxkIGhhdmUgYSBkZWxheSBub3QgdG8gaW50ZXJmZXJlIHdpdGggcGFubmluZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ5NDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdGFydCB0aGUg dGFwIGhpZ2hsaWdodCBhbmltYXRpb24gYWZ0ZXIgYSBzbGlnaHQgZGVsYXkgc28gdGhhdCBwYW4K KyAgICAgICAgZ2VzdHVyZXMgZG8gbm90IHJlc3VsdCBpbiBmbGFzaGluZyBoaWdobGlnaHQgcmVj dHMgd2hpY2ggc2xvdyBkb3duCisgICAgICAgIGZsaWNraW5nLCBlc3BlY2lhbGx5IGR1cmluZyBj b250aW51b3VzIHBhbiBnZXN0dXJlcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFRhcEdl c3R1cmVSZWNvZ25pemVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UXRUYXBHZXN0dXJlUmVjb2du aXplcjo6dXBkYXRlKToKKyAgICAgICAgKFdlYktpdDo6UXRUYXBHZXN0dXJlUmVjb2duaXplcjo6 dGFwSGlnaGxpZ2h0VGltZW91dCk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoV2ViS2l0 OjpRdFRhcEdlc3R1cmVSZWNvZ25pemVyOjpyZXNldCk6CisgICAgICAgIChXZWJLaXQ6OlF0VGFw R2VzdHVyZVJlY29nbml6ZXI6OnRpbWVyRXZlbnQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9R dFRhcEdlc3R1cmVSZWNvZ25pemVyLmg6CisgICAgICAgIChRdFRhcEdlc3R1cmVSZWNvZ25pemVy KToKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRIYW5kbGVyLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6UXRXZWJQYWdlRXZlbnRIYW5kbGVyOjpkb25lV2l0aFRvdWNoRXZlbnQp OgorCiAyMDEyLTA0LTI1ICBMYXJzIEtudWRzZW4gIDxsYXJzLmtudWRzZW5Abm9raWEuY29tPgog CiAgICAgICAgIE1ha2UgaXQgcG9zc2libGUgdG8gdXNlIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5n IGZvciBwYWdlIG92ZXJsYXkgZmFkaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvUXRUYXBHZXN0dXJlUmVjb2duaXplci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvUXRUYXBHZXN0dXJlUmVjb2duaXplci5jcHAKaW5kZXggZTY0NDMxZC4uOTMzMWM5 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0VGFwR2VzdHVyZVJl Y29nbml6ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFRhcEdlc3R1 cmVSZWNvZ25pemVyLmNwcApAQCAtNTgsNyArNTgsNyBAQCBib29sIFF0VGFwR2VzdHVyZVJlY29n bml6ZXI6OnVwZGF0ZShRRXZlbnQ6OlR5cGUgZXZlbnRUeXBlLCBjb25zdCBRVG91Y2hFdmVudDo6 VAogICAgICAgICBlbHNlIHsKICAgICAgICAgICAgIG1fY2FuZGlkYXRlID0gU2luZ2xlVGFwQ2Fu ZGlkYXRlOwogICAgICAgICAgICAgLy8gVGhlIGJlbG93IGluIGZhY3RzIHJlc2V0cyBhbnkgcHJl dmlvdXMgc2luZ2xlIHRhcCBldmVudC4KLSAgICAgICAgICAgIG1fZXZlbnRIYW5kbGVyLT5oYW5k bGVQb3RlbnRpYWxTaW5nbGVUYXBFdmVudCh0b3VjaFBvaW50KTsKKyAgICAgICAgICAgIG1fdGFw SGlnaGxpZ2h0VGltZXIuc3RhcnQodGFwSGlnaGxpZ2h0VGhyZXNob2xkLCB0aGlzKTsKICAgICAg ICAgICAgIG1fbGFzdFRvdWNoUG9pbnQgPSB0b3VjaFBvaW50OwogICAgICAgICAgICAgbV9kb3Vi bGVUYXBUaW1lci5zdGFydChtYXhEb3VibGVUYXBJbnRlcnZhbCwgdGhpcyk7CiAgICAgICAgIH0K QEAgLTk5LDYgKzk5LDE2IEBAIHZvaWQgUXRUYXBHZXN0dXJlUmVjb2duaXplcjo6Y2FuY2VsKCkK ICAgICByZXNldCgpOwogfQogCit2b2lkIFF0VGFwR2VzdHVyZVJlY29nbml6ZXI6OnRhcEhpZ2hs aWdodFRpbWVvdXQoKQoreworICAgIG1fdGFwSGlnaGxpZ2h0VGltZXIuc3RvcCgpOworICAgIGlm IChtX2NhbmRpZGF0ZSA9PSBJbnZhbGlkIHx8IG1fY2FuZGlkYXRlID09IERvdWJsZVRhcENhbmRp ZGF0ZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgQVNTRVJUKG1fbGFzdFRvdWNoUG9pbnQuaWQo KSAhPSAtMSk7CisgICAgbV9ldmVudEhhbmRsZXItPmhhbmRsZVBvdGVudGlhbFNpbmdsZVRhcEV2 ZW50KG1fbGFzdFRvdWNoUG9pbnQpOworfQorCiB2b2lkIFF0VGFwR2VzdHVyZVJlY29nbml6ZXI6 OnNpbmdsZVRhcFRpbWVvdXQoKQogewogICAgIC8vIEZpbmdlciBpcyBzdGlsbCBwcmVzc2VkLCBp Z25vcmUuCkBAIC0xMzAsOSArMTQwLDEwIEBAIHZvaWQgUXRUYXBHZXN0dXJlUmVjb2duaXplcjo6 cmVzZXQoKQogICAgICAgICBtX2V2ZW50SGFuZGxlci0+aGFuZGxlUG90ZW50aWFsU2luZ2xlVGFw RXZlbnQoUVRvdWNoRXZlbnQ6OlRvdWNoUG9pbnQoKSk7CiAKICAgICBtX2NhbmRpZGF0ZSA9IElu dmFsaWQ7Ci0gICAgbV90YXBBbmRIb2xkVGltZXIuc3RvcCgpOwotICAgIG1fZG91YmxlVGFwVGlt ZXIuc3RvcCgpOwogICAgIG1fbGFzdFRvdWNoUG9pbnQuc2V0SWQoLTEpOworICAgIG1fdGFwSGln aGxpZ2h0VGltZXIuc3RvcCgpOworICAgIG1fZG91YmxlVGFwVGltZXIuc3RvcCgpOworICAgIG1f dGFwQW5kSG9sZFRpbWVyLnN0b3AoKTsKIAogICAgIFF0R2VzdHVyZVJlY29nbml6ZXI6OnJlc2V0 KCk7CiB9CkBAIC0xNDAsNyArMTUxLDkgQEAgdm9pZCBRdFRhcEdlc3R1cmVSZWNvZ25pemVyOjpy ZXNldCgpCiB2b2lkIFF0VGFwR2VzdHVyZVJlY29nbml6ZXI6OnRpbWVyRXZlbnQoUVRpbWVyRXZl bnQqIGV2KQogewogICAgIGludCB0aW1lcklkID0gZXYtPnRpbWVySWQoKTsKLSAgICBpZiAodGlt ZXJJZCA9PSBtX2RvdWJsZVRhcFRpbWVyLnRpbWVySWQoKSkKKyAgICBpZiAodGltZXJJZCA9PSBt X3RhcEhpZ2hsaWdodFRpbWVyLnRpbWVySWQoKSkKKyAgICAgICAgdGFwSGlnaGxpZ2h0VGltZW91 dCgpOworICAgIGVsc2UgaWYgKHRpbWVySWQgPT0gbV9kb3VibGVUYXBUaW1lci50aW1lcklkKCkp CiAgICAgICAgIHNpbmdsZVRhcFRpbWVvdXQoKTsKICAgICBlbHNlIGlmICh0aW1lcklkID09IG1f dGFwQW5kSG9sZFRpbWVyLnRpbWVySWQoKSkKICAgICAgICAgdGFwQW5kSG9sZFRpbWVvdXQoKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFRhcEdlc3R1cmVSZWNv Z25pemVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRUYXBHZXN0dXJlUmVjb2du aXplci5oCmluZGV4IGRlMWY2NDEuLmIzYjQ3YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9xdC9RdFRhcEdlc3R1cmVSZWNvZ25pemVyLmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL3F0L1F0VGFwR2VzdHVyZVJlY29nbml6ZXIuaApAQCAtMzIsMTAgKzMyLDEx IEBACiAjaW5jbHVkZSA8UXRDb3JlL1FPYmplY3Q+CiAKIC8vIEZJWE1FOiBUaGVzZSBjb25zdGFu dHMgc2hvdWxkIHBvc3NpYmx5IGRlcGVuZCBvbiBEUEkuCi1jb25zdCBpbnQgbWF4UGFuRGlzdGFu Y2UgPSA1OworY29uc3QgaW50IG1heFBhbkRpc3RhbmNlID0gMTA7CiBjb25zdCBpbnQgbWF4RG91 YmxlVGFwRGlzdGFuY2UgPSAxMjA7CiBjb25zdCBpbnQgdGFwQW5kSG9sZFRpbWUgPSA4MDA7CiBj b25zdCBpbnQgbWF4RG91YmxlVGFwSW50ZXJ2YWwgPSA0MDA7Citjb25zdCBpbnQgdGFwSGlnaGxp Z2h0VGhyZXNob2xkID0gODA7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCkBAIC00OSw2ICs1MCw3 IEBAIHB1YmxpYzoKIAogcHJvdGVjdGVkOgogICAgIHZvaWQgdGltZXJFdmVudChRVGltZXJFdmVu dCopOworICAgIHZvaWQgdGFwSGlnaGxpZ2h0VGltZW91dCgpOwogICAgIHZvaWQgc2luZ2xlVGFw VGltZW91dCgpOwogICAgIHZvaWQgdGFwQW5kSG9sZFRpbWVvdXQoKTsKIApAQCAtNTYsNiArNTgs NyBAQCBwcml2YXRlOgogICAgIHZvaWQgcmVzZXQoKTsKICAgICBib29sIHdpdGhpbkRpc3RhbmNl KGNvbnN0IFFUb3VjaEV2ZW50OjpUb3VjaFBvaW50JiwgaW50IGRpc3RhbmNlKTsKIAorICAgIFFC YXNpY1RpbWVyIG1fdGFwSGlnaGxpZ2h0VGltZXI7CiAgICAgUUJhc2ljVGltZXIgbV9kb3VibGVU YXBUaW1lcjsKICAgICBRQmFzaWNUaW1lciBtX3RhcEFuZEhvbGRUaW1lcjsKICAgICBRVG91Y2hF dmVudDo6VG91Y2hQb2ludCBtX2xhc3RUb3VjaFBvaW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRIYW5kbGVyLmNwcAppbmRleCBkYzMxMzgy Li4yNzVlNWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQ YWdlRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRX ZWJQYWdlRXZlbnRIYW5kbGVyLmNwcApAQCAtNDg4LDExICs0ODgsMTYgQEAgdm9pZCBRdFdlYlBh Z2VFdmVudEhhbmRsZXI6OmRvbmVXaXRoVG91Y2hFdmVudChjb25zdCBOYXRpdmVXZWJUb3VjaEV2 ZW50JiBldmVudCwKICAgICBjb25zdCBpbnQgYWN0aXZlVG91Y2hQb2ludENvdW50ID0gYWN0aXZl VG91Y2hQb2ludHMuc2l6ZSgpOwogCiAgICAgaWYgKCFhY3RpdmVUb3VjaFBvaW50Q291bnQpIHsK LSAgICAgICAgaWYgKHRvdWNoUG9pbnRDb3VudCA9PSAxKQotICAgICAgICAgICAvLyBObyBhY3Rp dmUgdG91Y2ggcG9pbnRzLCBvbmUgZmluZ2VyIHJlbGVhc2VkLgotICAgICAgICAgICBtX3Bhbkdl c3R1cmVSZWNvZ25pemVyLmZpbmlzaCh0b3VjaFBvaW50cy5maXJzdCgpLCBldmVudFRpbWVzdGFt cE1pbGxpcyk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgbV9waW5jaEdlc3R1cmVSZWNvZ25p emVyLmZpbmlzaCgpOworICAgICAgICBpZiAodG91Y2hQb2ludENvdW50ID09IDEpIHsKKyAgICAg ICAgICAgIC8vIE5vIGFjdGl2ZSB0b3VjaCBwb2ludHMsIG9uZSBmaW5nZXIgcmVsZWFzZWQuCisg ICAgICAgICAgICBpZiAoIW1fcGFuR2VzdHVyZVJlY29nbml6ZXIuaXNSZWNvZ25pemVkKCkpCisg ICAgICAgICAgICAgICAgbV90YXBHZXN0dXJlUmVjb2duaXplci51cGRhdGUoZXYtPnR5cGUoKSwg dG91Y2hQb2ludHMuZmlyc3QoKSk7CisgICAgICAgICAgICBtX3Bhbkdlc3R1cmVSZWNvZ25pemVy LmZpbmlzaCh0b3VjaFBvaW50cy5maXJzdCgpLCBldmVudFRpbWVzdGFtcE1pbGxpcyk7CisgICAg ICAgIH0gZWxzZQorICAgICAgICAgICAgbV9waW5jaEdlc3R1cmVSZWNvZ25pemVyLmZpbmlzaCgp OworCisgICAgICAgIC8vIEVhcmx5IHJldHVybiBzaW5jZSB0aGlzIHdhcyBhIHRvdWNoIGVuZCBl dmVudC4KKyAgICAgICAgcmV0dXJuOwogICAgIH0gZWxzZSBpZiAoYWN0aXZlVG91Y2hQb2ludENv dW50ID09IDEpIHsKICAgICAgICAgLy8gSWYgdGhlIHBpbmNoIGdlc3R1cmUgcmVjb2duaXplciB3 YXMgcHJldmlvdXNseSBpbiBhY3RpdmUgc3RhdGUgdGhlIGNvbnRlbnQgbWlnaHQKICAgICAgICAg Ly8gYmUgb3V0IG9mIHZhbGlkIHpvb20gYm91bmRhcmllcywgdGh1cyB3ZSBuZWVkIHRvIGZpbmlz aCB0aGUgcGluY2ggZ2VzdHVyZSBoZXJlLgpAQCAtNTA0LDcgKzUwOSw3IEBAIHZvaWQgUXRXZWJQ YWdlRXZlbnRIYW5kbGVyOjpkb25lV2l0aFRvdWNoRXZlbnQoY29uc3QgTmF0aXZlV2ViVG91Y2hF dmVudCYgZXZlbnQsCiAgICAgICAgIG1fcGluY2hHZXN0dXJlUmVjb2duaXplci51cGRhdGUoYWN0 aXZlVG91Y2hQb2ludHMuZmlyc3QoKSwgYWN0aXZlVG91Y2hQb2ludHMubGFzdCgpKTsKICAgICB9 CiAKLSAgICBpZiAobV9wYW5HZXN0dXJlUmVjb2duaXplci5pc1JlY29nbml6ZWQoKSB8fCBtX3Bp bmNoR2VzdHVyZVJlY29nbml6ZXIuaXNSZWNvZ25pemVkKCkpCisgICAgaWYgKG1fcGFuR2VzdHVy ZVJlY29nbml6ZXIuaXNSZWNvZ25pemVkKCkgfHwgbV9waW5jaEdlc3R1cmVSZWNvZ25pemVyLmlz UmVjb2duaXplZCgpIHx8IG1fd2ViVmlldy0+aXNNb3ZpbmcoKSkKICAgICAgICAgbV90YXBHZXN0 dXJlUmVjb2duaXplci5jYW5jZWwoKTsKICAgICBlbHNlIGlmICh0b3VjaFBvaW50Q291bnQgPT0g MSkKICAgICAgICAgbV90YXBHZXN0dXJlUmVjb2duaXplci51cGRhdGUoZXYtPnR5cGUoKSwgdG91 Y2hQb2ludHMuZmlyc3QoKSk7Ci0tIAoxLjcuNS40Cgo= 138990 2012-04-26 06:47:49 -0700 2012-04-26 07:14:18 -0700 proposed patch 0001-tap-highlight-fix.patch text/plain 6869 abecsi RnJvbSBjNzgyZDA2NzA0NmNmNDAyMzdmZTFkMTk3ZjQyMDk5NjJmNzE4YzZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyYXMgQmVjc2kgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+ CkRhdGU6IFRodSwgMjYgQXByIDIwMTIgMTU6NDA6MjkgKzAyMDAKU3ViamVjdDogW1BBVENIXSB0 YXAgaGlnaGxpZ2h0IGZpeAoKLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgMjIgKysrKysrKysrKysrKysrKysrKysKIC4uLi9VSVByb2Nl c3MvcXQvUXRUYXBHZXN0dXJlUmVjb2duaXplci5jcHAgICAgICAgIHwgICAyMCArKysrKysrKysr KysrKy0tLQogLi4uL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0VGFwR2VzdHVyZVJlY29nbml6ZXIu aCAgfCAgICA1ICsrKy0KIC4uLi9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhh bmRsZXIuY3BwIHwgICAxNyArKysrKysrKysrLS0tLS0KIDQgZmlsZXMgY2hhbmdlZCwgNTMgaW5z ZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDhhOTFjZDkuLmNjOTEw YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMi0wNC0yNiAgQW5kcmFzIEJlY3Np ICA8YW5kcmFzLmJlY3NpQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdW1dLMl0gVGFwIGhpZ2hs aWdodCBzaG91bGQgaGF2ZSBhIGRlbGF5IG5vdCB0byBpbnRlcmZlcmUgd2l0aCBwYW5uaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDk0OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0YXJ0IHRoZSB0 YXAgaGlnaGxpZ2h0IGFuaW1hdGlvbiBhZnRlciBhIHNsaWdodCBkZWxheSBzbyB0aGF0IHBhbgor ICAgICAgICBnZXN0dXJlcyBkbyBub3QgcmVzdWx0IGluIGZsYXNoaW5nIGhpZ2hsaWdodCByZWN0 cyB3aGljaCBzbG93IGRvd24KKyAgICAgICAgZmxpY2tpbmcsIGVzcGVjaWFsbHkgZHVyaW5nIGNv bnRpbnVvdXMgcGFuIGdlc3R1cmVzLgorCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0VGFwR2Vz dHVyZVJlY29nbml6ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpRdFRhcEdlc3R1cmVSZWNvZ25p emVyOjp1cGRhdGUpOgorICAgICAgICAoV2ViS2l0OjpRdFRhcEdlc3R1cmVSZWNvZ25pemVyOjp0 YXBIaWdobGlnaHRUaW1lb3V0KToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXQ6 OlF0VGFwR2VzdHVyZVJlY29nbml6ZXI6OnJlc2V0KToKKyAgICAgICAgKFdlYktpdDo6UXRUYXBH ZXN0dXJlUmVjb2duaXplcjo6dGltZXJFdmVudCk6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0 VGFwR2VzdHVyZVJlY29nbml6ZXIuaDoKKyAgICAgICAgKFF0VGFwR2VzdHVyZVJlY29nbml6ZXIp OgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwOgorICAg ICAgICAoV2ViS2l0OjpRdFdlYlBhZ2VFdmVudEhhbmRsZXI6OmRvbmVXaXRoVG91Y2hFdmVudCk6 CisKIDIwMTItMDQtMjUgIExhcnMgS251ZHNlbiAgPGxhcnMua251ZHNlbkBub2tpYS5jb20+CiAK ICAgICAgICAgTWFrZSBpdCBwb3NzaWJsZSB0byB1c2UgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcg Zm9yIHBhZ2Ugb3ZlcmxheSBmYWRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9xdC9RdFRhcEdlc3R1cmVSZWNvZ25pemVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9xdC9RdFRhcEdlc3R1cmVSZWNvZ25pemVyLmNwcAppbmRleCBlNjQ0MzFkLi4zNTU2ZmJk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRUYXBHZXN0dXJlUmVj b2duaXplci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0VGFwR2VzdHVy ZVJlY29nbml6ZXIuY3BwCkBAIC01OCw3ICs1OCw3IEBAIGJvb2wgUXRUYXBHZXN0dXJlUmVjb2du aXplcjo6dXBkYXRlKFFFdmVudDo6VHlwZSBldmVudFR5cGUsIGNvbnN0IFFUb3VjaEV2ZW50OjpU CiAgICAgICAgIGVsc2UgewogICAgICAgICAgICAgbV9jYW5kaWRhdGUgPSBTaW5nbGVUYXBDYW5k aWRhdGU7CiAgICAgICAgICAgICAvLyBUaGUgYmVsb3cgaW4gZmFjdHMgcmVzZXRzIGFueSBwcmV2 aW91cyBzaW5nbGUgdGFwIGV2ZW50LgotICAgICAgICAgICAgbV9ldmVudEhhbmRsZXItPmhhbmRs ZVBvdGVudGlhbFNpbmdsZVRhcEV2ZW50KHRvdWNoUG9pbnQpOworICAgICAgICAgICAgbV90YXBI aWdobGlnaHRUaW1lci5zdGFydCh0YXBIaWdobGlnaHRUaHJlc2hvbGQsIHRoaXMpOwogICAgICAg ICAgICAgbV9sYXN0VG91Y2hQb2ludCA9IHRvdWNoUG9pbnQ7CiAgICAgICAgICAgICBtX2RvdWJs ZVRhcFRpbWVyLnN0YXJ0KG1heERvdWJsZVRhcEludGVydmFsLCB0aGlzKTsKICAgICAgICAgfQpA QCAtOTksNiArOTksMTUgQEAgdm9pZCBRdFRhcEdlc3R1cmVSZWNvZ25pemVyOjpjYW5jZWwoKQog ICAgIHJlc2V0KCk7CiB9CiAKK3ZvaWQgUXRUYXBHZXN0dXJlUmVjb2duaXplcjo6dGFwSGlnaGxp Z2h0VGltZW91dCgpCit7CisgICAgaWYgKG1fY2FuZGlkYXRlICE9IFNpbmdsZVRhcENhbmRpZGF0 ZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgQVNTRVJUKG1fbGFzdFRvdWNoUG9pbnQuaWQoKSAh PSAtMSk7CisgICAgbV9ldmVudEhhbmRsZXItPmhhbmRsZVBvdGVudGlhbFNpbmdsZVRhcEV2ZW50 KG1fbGFzdFRvdWNoUG9pbnQpOworfQorCiB2b2lkIFF0VGFwR2VzdHVyZVJlY29nbml6ZXI6OnNp bmdsZVRhcFRpbWVvdXQoKQogewogICAgIC8vIEZpbmdlciBpcyBzdGlsbCBwcmVzc2VkLCBpZ25v cmUuCkBAIC0xMzAsOSArMTM5LDEwIEBAIHZvaWQgUXRUYXBHZXN0dXJlUmVjb2duaXplcjo6cmVz ZXQoKQogICAgICAgICBtX2V2ZW50SGFuZGxlci0+aGFuZGxlUG90ZW50aWFsU2luZ2xlVGFwRXZl bnQoUVRvdWNoRXZlbnQ6OlRvdWNoUG9pbnQoKSk7CiAKICAgICBtX2NhbmRpZGF0ZSA9IEludmFs aWQ7Ci0gICAgbV90YXBBbmRIb2xkVGltZXIuc3RvcCgpOwotICAgIG1fZG91YmxlVGFwVGltZXIu c3RvcCgpOwogICAgIG1fbGFzdFRvdWNoUG9pbnQuc2V0SWQoLTEpOworICAgIG1fdGFwSGlnaGxp Z2h0VGltZXIuc3RvcCgpOworICAgIG1fZG91YmxlVGFwVGltZXIuc3RvcCgpOworICAgIG1fdGFw QW5kSG9sZFRpbWVyLnN0b3AoKTsKIAogICAgIFF0R2VzdHVyZVJlY29nbml6ZXI6OnJlc2V0KCk7 CiB9CkBAIC0xNDAsNyArMTUwLDkgQEAgdm9pZCBRdFRhcEdlc3R1cmVSZWNvZ25pemVyOjpyZXNl dCgpCiB2b2lkIFF0VGFwR2VzdHVyZVJlY29nbml6ZXI6OnRpbWVyRXZlbnQoUVRpbWVyRXZlbnQq IGV2KQogewogICAgIGludCB0aW1lcklkID0gZXYtPnRpbWVySWQoKTsKLSAgICBpZiAodGltZXJJ ZCA9PSBtX2RvdWJsZVRhcFRpbWVyLnRpbWVySWQoKSkKKyAgICBpZiAodGltZXJJZCA9PSBtX3Rh cEhpZ2hsaWdodFRpbWVyLnRpbWVySWQoKSkKKyAgICAgICAgdGFwSGlnaGxpZ2h0VGltZW91dCgp OworICAgIGVsc2UgaWYgKHRpbWVySWQgPT0gbV9kb3VibGVUYXBUaW1lci50aW1lcklkKCkpCiAg ICAgICAgIHNpbmdsZVRhcFRpbWVvdXQoKTsKICAgICBlbHNlIGlmICh0aW1lcklkID09IG1fdGFw QW5kSG9sZFRpbWVyLnRpbWVySWQoKSkKICAgICAgICAgdGFwQW5kSG9sZFRpbWVvdXQoKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFRhcEdlc3R1cmVSZWNvZ25p emVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRUYXBHZXN0dXJlUmVjb2duaXpl ci5oCmluZGV4IGRlMWY2NDEuLmIzYjQ3YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9xdC9RdFRhcEdlc3R1cmVSZWNvZ25pemVyLmgKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL3F0L1F0VGFwR2VzdHVyZVJlY29nbml6ZXIuaApAQCAtMzIsMTAgKzMyLDExIEBA CiAjaW5jbHVkZSA8UXRDb3JlL1FPYmplY3Q+CiAKIC8vIEZJWE1FOiBUaGVzZSBjb25zdGFudHMg c2hvdWxkIHBvc3NpYmx5IGRlcGVuZCBvbiBEUEkuCi1jb25zdCBpbnQgbWF4UGFuRGlzdGFuY2Ug PSA1OworY29uc3QgaW50IG1heFBhbkRpc3RhbmNlID0gMTA7CiBjb25zdCBpbnQgbWF4RG91Ymxl VGFwRGlzdGFuY2UgPSAxMjA7CiBjb25zdCBpbnQgdGFwQW5kSG9sZFRpbWUgPSA4MDA7CiBjb25z dCBpbnQgbWF4RG91YmxlVGFwSW50ZXJ2YWwgPSA0MDA7Citjb25zdCBpbnQgdGFwSGlnaGxpZ2h0 VGhyZXNob2xkID0gODA7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCkBAIC00OSw2ICs1MCw3IEBA IHB1YmxpYzoKIAogcHJvdGVjdGVkOgogICAgIHZvaWQgdGltZXJFdmVudChRVGltZXJFdmVudCop OworICAgIHZvaWQgdGFwSGlnaGxpZ2h0VGltZW91dCgpOwogICAgIHZvaWQgc2luZ2xlVGFwVGlt ZW91dCgpOwogICAgIHZvaWQgdGFwQW5kSG9sZFRpbWVvdXQoKTsKIApAQCAtNTYsNiArNTgsNyBA QCBwcml2YXRlOgogICAgIHZvaWQgcmVzZXQoKTsKICAgICBib29sIHdpdGhpbkRpc3RhbmNlKGNv bnN0IFFUb3VjaEV2ZW50OjpUb3VjaFBvaW50JiwgaW50IGRpc3RhbmNlKTsKIAorICAgIFFCYXNp Y1RpbWVyIG1fdGFwSGlnaGxpZ2h0VGltZXI7CiAgICAgUUJhc2ljVGltZXIgbV9kb3VibGVUYXBU aW1lcjsKICAgICBRQmFzaWNUaW1lciBtX3RhcEFuZEhvbGRUaW1lcjsKICAgICBRVG91Y2hFdmVu dDo6VG91Y2hQb2ludCBtX2xhc3RUb3VjaFBvaW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRIYW5kbGVyLmNwcAppbmRleCBkYzMxMzgyLi4y NzVlNWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdl RXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQ YWdlRXZlbnRIYW5kbGVyLmNwcApAQCAtNDg4LDExICs0ODgsMTYgQEAgdm9pZCBRdFdlYlBhZ2VF dmVudEhhbmRsZXI6OmRvbmVXaXRoVG91Y2hFdmVudChjb25zdCBOYXRpdmVXZWJUb3VjaEV2ZW50 JiBldmVudCwKICAgICBjb25zdCBpbnQgYWN0aXZlVG91Y2hQb2ludENvdW50ID0gYWN0aXZlVG91 Y2hQb2ludHMuc2l6ZSgpOwogCiAgICAgaWYgKCFhY3RpdmVUb3VjaFBvaW50Q291bnQpIHsKLSAg ICAgICAgaWYgKHRvdWNoUG9pbnRDb3VudCA9PSAxKQotICAgICAgICAgICAvLyBObyBhY3RpdmUg dG91Y2ggcG9pbnRzLCBvbmUgZmluZ2VyIHJlbGVhc2VkLgotICAgICAgICAgICBtX3Bhbkdlc3R1 cmVSZWNvZ25pemVyLmZpbmlzaCh0b3VjaFBvaW50cy5maXJzdCgpLCBldmVudFRpbWVzdGFtcE1p bGxpcyk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgbV9waW5jaEdlc3R1cmVSZWNvZ25pemVy LmZpbmlzaCgpOworICAgICAgICBpZiAodG91Y2hQb2ludENvdW50ID09IDEpIHsKKyAgICAgICAg ICAgIC8vIE5vIGFjdGl2ZSB0b3VjaCBwb2ludHMsIG9uZSBmaW5nZXIgcmVsZWFzZWQuCisgICAg ICAgICAgICBpZiAoIW1fcGFuR2VzdHVyZVJlY29nbml6ZXIuaXNSZWNvZ25pemVkKCkpCisgICAg ICAgICAgICAgICAgbV90YXBHZXN0dXJlUmVjb2duaXplci51cGRhdGUoZXYtPnR5cGUoKSwgdG91 Y2hQb2ludHMuZmlyc3QoKSk7CisgICAgICAgICAgICBtX3Bhbkdlc3R1cmVSZWNvZ25pemVyLmZp bmlzaCh0b3VjaFBvaW50cy5maXJzdCgpLCBldmVudFRpbWVzdGFtcE1pbGxpcyk7CisgICAgICAg IH0gZWxzZQorICAgICAgICAgICAgbV9waW5jaEdlc3R1cmVSZWNvZ25pemVyLmZpbmlzaCgpOwor CisgICAgICAgIC8vIEVhcmx5IHJldHVybiBzaW5jZSB0aGlzIHdhcyBhIHRvdWNoIGVuZCBldmVu dC4KKyAgICAgICAgcmV0dXJuOwogICAgIH0gZWxzZSBpZiAoYWN0aXZlVG91Y2hQb2ludENvdW50 ID09IDEpIHsKICAgICAgICAgLy8gSWYgdGhlIHBpbmNoIGdlc3R1cmUgcmVjb2duaXplciB3YXMg cHJldmlvdXNseSBpbiBhY3RpdmUgc3RhdGUgdGhlIGNvbnRlbnQgbWlnaHQKICAgICAgICAgLy8g YmUgb3V0IG9mIHZhbGlkIHpvb20gYm91bmRhcmllcywgdGh1cyB3ZSBuZWVkIHRvIGZpbmlzaCB0 aGUgcGluY2ggZ2VzdHVyZSBoZXJlLgpAQCAtNTA0LDcgKzUwOSw3IEBAIHZvaWQgUXRXZWJQYWdl RXZlbnRIYW5kbGVyOjpkb25lV2l0aFRvdWNoRXZlbnQoY29uc3QgTmF0aXZlV2ViVG91Y2hFdmVu dCYgZXZlbnQsCiAgICAgICAgIG1fcGluY2hHZXN0dXJlUmVjb2duaXplci51cGRhdGUoYWN0aXZl VG91Y2hQb2ludHMuZmlyc3QoKSwgYWN0aXZlVG91Y2hQb2ludHMubGFzdCgpKTsKICAgICB9CiAK LSAgICBpZiAobV9wYW5HZXN0dXJlUmVjb2duaXplci5pc1JlY29nbml6ZWQoKSB8fCBtX3BpbmNo R2VzdHVyZVJlY29nbml6ZXIuaXNSZWNvZ25pemVkKCkpCisgICAgaWYgKG1fcGFuR2VzdHVyZVJl Y29nbml6ZXIuaXNSZWNvZ25pemVkKCkgfHwgbV9waW5jaEdlc3R1cmVSZWNvZ25pemVyLmlzUmVj b2duaXplZCgpIHx8IG1fd2ViVmlldy0+aXNNb3ZpbmcoKSkKICAgICAgICAgbV90YXBHZXN0dXJl UmVjb2duaXplci5jYW5jZWwoKTsKICAgICBlbHNlIGlmICh0b3VjaFBvaW50Q291bnQgPT0gMSkK ICAgICAgICAgbV90YXBHZXN0dXJlUmVjb2duaXplci51cGRhdGUoZXYtPnR5cGUoKSwgdG91Y2hQ b2ludHMuZmlyc3QoKSk7Ci0tIAoxLjcuNS40Cgo=