84942 2012-04-26 04:02:33 -0700 MediaStream API: Change LocalMediaStream::stop to be synchronous 2012-04-30 10:43:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56459 1 tommyw tommyw adam.bergkvist eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 610488 0 tommyw 2012-04-26 04:02:33 -0700 Since I changed LocalMediaStream to be a ActiveDOMObject recently the stop behaviour needs to change since it is no longer a good idea to start a timer when called. 610491 1 138970 tommyw 2012-04-26 04:06:09 -0700 Created attachment 138970 Patch 612515 2 138970 jamesr 2012-04-30 01:21:22 -0700 Comment on attachment 138970 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138970&action=review > Source/WebCore/Modules/mediastream/LocalMediaStream.cpp:2 > + * Copyright (C) 2012 Google Inc. All rights reserved. we don't do this in WebKit, just leave the date alone > Source/WebCore/Modules/mediastream/LocalMediaStream.h:2 > + * Copyright (C) 2012 Google Inc. All rights reserved. same here 612517 3 139426 tommyw 2012-04-30 01:39:50 -0700 Created attachment 139426 Patch 612518 4 138970 tommyw 2012-04-30 01:41:16 -0700 Comment on attachment 138970 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138970&action=review >> Source/WebCore/Modules/mediastream/LocalMediaStream.cpp:2 >> + * Copyright (C) 2012 Google Inc. All rights reserved. > > we don't do this in WebKit, just leave the date alone Done. >> Source/WebCore/Modules/mediastream/LocalMediaStream.h:2 >> + * Copyright (C) 2012 Google Inc. All rights reserved. > > same here Done. 612610 5 adam.bergkvist 2012-04-30 07:18:20 -0700 This patch changes specified (and testable) API behavior. The "ended" event will be dispatched synchronously when LocalMediaStream.stop() is called from JavaScript. I don't think calling MediaStreamCenter::didStopLocalMediaStream() from ActiveDOMObject::stop() is the right approach. I've posted a bug to discuss this. See http://webkit.org/b/85191 612734 6 139426 webkit.review.bot 2012-04-30 10:43:55 -0700 Comment on attachment 139426 Patch Clearing flags on attachment: 139426 Committed r115649: <http://trac.webkit.org/changeset/115649> 612735 7 webkit.review.bot 2012-04-30 10:43:59 -0700 All reviewed patches have been landed. Closing bug. 138970 2012-04-26 04:06:09 -0700 2012-04-30 01:41:16 -0700 Patch bug-84942-20120426130607.patch text/plain 3507 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1Mjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI3NzRlNDZjYTUzZWJi MDJiMTcyM2U1M2JmOWVmMzFiYzNhZGQxNi4uOThkN2UzN2Y0MWQ1NjU3MjZmOGU2YjQwZGJmMGU3 ZjFlMmVhZmVmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTI2ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogQ2hhbmdlIExvY2FsTWVkaWFTdHJlYW06OnN0b3AgdG8gYmUgc3luY2hyb25vdXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0OTQyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgSSBjaGFu Z2VkIExvY2FsTWVkaWFTdHJlYW0gdG8gYmUgYSBBY3RpdmVET01PYmplY3QgcmVjZW50bHkgdGhl IHN0b3AoKQorICAgICAgICBiZWhhdmlvdXIgbmVlZHMgdG8gY2hhbmdlIHNpbmNlIGl0IGlzIG5v IGxvbmdlciBhIGdvb2QgaWRlYSB0byBzdGFydCBhIHRpbWVyIHdoZW4gY2FsbGVkLgorCisgICAg ICAgIE5vdCBwb3NzaWJsZSB0byB3cml0ZSBhIHRlc3QgZm9yIHRoaXMuCisKKyAgICAgICAgKiBN b2R1bGVzL21lZGlhc3RyZWFtL0xvY2FsTWVkaWFTdHJlYW0uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TG9jYWxNZWRpYVN0cmVhbTo6TG9jYWxNZWRpYVN0cmVhbSk6CisgICAgICAgIChXZWJDb3Jl OjpMb2NhbE1lZGlhU3RyZWFtOjpzdG9wKToKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFt L0xvY2FsTWVkaWFTdHJlYW0uaDoKKyAgICAgICAgKExvY2FsTWVkaWFTdHJlYW0pOgorCiAyMDEy LTA0LTI2ICBNaWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIENy YXNoIHdoZW4gY29sbGVjdGluZyBzdmcgc3ltYm9sIGVsZW1lbnQgaW4gbmFtZWQgZmxvdy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0 cmVhbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0xvY2FsTWVkaWFT dHJlYW0uY3BwCmluZGV4IDkyZmE2OTg1YjFiODRhMzNmZmUyZjY5YWU1ZjdmOWJkOWI4MjdmYzEu LjY0ZjdlZDVmNGMxMWRjMjE5YjM5MTM3MTkzYTliMDM3N2JlMTY3ZGMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Mb2NhbE1lZGlhU3RyZWFtLmNw cApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTEgR29vZ2xlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMiBHb29nbGUgSW5jLiBB bGwgcmlnaHRzIHJlc2VydmVkLgogICogQ29weXJpZ2h0IChDKSAyMDExIEVyaWNzc29uIEFCLiBB bGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dApAQCAtNDIsNyArNDIsNiBAQCBQ YXNzUmVmUHRyPExvY2FsTWVkaWFTdHJlYW0+IExvY2FsTWVkaWFTdHJlYW06OmNyZWF0ZShTY3Jp cHRFeGVjdXRpb25Db250ZXh0KiBjbwogCiBMb2NhbE1lZGlhU3RyZWFtOjpMb2NhbE1lZGlhU3Ry ZWFtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIGNvbnN0IE1lZGlhU3RyZWFtU291 cmNlVmVjdG9yJiBhdWRpb1NvdXJjZXMsIGNvbnN0IE1lZGlhU3RyZWFtU291cmNlVmVjdG9yJiB2 aWRlb1NvdXJjZXMpCiAgICAgOiBNZWRpYVN0cmVhbShjb250ZXh0LCBNZWRpYVN0cmVhbURlc2Ny aXB0b3I6OmNyZWF0ZShjcmVhdGVDYW5vbmljYWxVVUlEU3RyaW5nKCksIGF1ZGlvU291cmNlcywg dmlkZW9Tb3VyY2VzKSkKLSAgICAsIG1fc3RvcFRpbWVyKHRoaXMsICZMb2NhbE1lZGlhU3RyZWFt OjpzdG9wVGltZXJGaXJlZCkKIHsKIH0KIApAQCAtNTMsMTQgKzUyLDYgQEAgdm9pZCBMb2NhbE1l ZGlhU3RyZWFtOjpzdG9wRnVuY3Rpb24oKQogCiB2b2lkIExvY2FsTWVkaWFTdHJlYW06OnN0b3Ao KQogewotICAgIGlmICghbV9zdG9wVGltZXIuaXNBY3RpdmUoKSkKLSAgICAgICAgbV9zdG9wVGlt ZXIuc3RhcnRPbmVTaG90KDApOwotfQotCi12b2lkIExvY2FsTWVkaWFTdHJlYW06OnN0b3BUaW1l ckZpcmVkKFRpbWVyPExvY2FsTWVkaWFTdHJlYW0+KiB0aW1lcikKLXsKLSAgICBBU1NFUlRfVU5V U0VEKHRpbWVyLCB0aW1lciA9PSAmbV9zdG9wVGltZXIpOwotCiAgICAgaWYgKHJlYWR5U3RhdGUo KSA9PSBFTkRFRCkKICAgICAgICAgcmV0dXJuOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0xvY2FsTWVkaWFTdHJlYW0uaCBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5oCmluZGV4IDc2MTgwNWVjYTAy ODJjNjNjNjljMzAwYjFiN2EyMzBiZjJmYWE1ZWQuLjQ3OWMyMmJlYjI5MmM5ZWY3ZmU3MzIxZTFh MWYyMTU1OWU3NTUxODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5oCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHly aWdodCAoQykgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJp Z2h0IChDKSAyMDEyIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiBDb3B5cmln aHQgKEMpIDIwMTEgRXJpY3Nzb24gQUIuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVk aXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3 aXRob3V0CkBAIC0yOSw3ICsyOSw2IEBACiAjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKIAogI2lu Y2x1ZGUgIk1lZGlhU3RyZWFtLmgiCi0jaW5jbHVkZSAiVGltZXIuaCIKIAogbmFtZXNwYWNlIFdl YkNvcmUgewogCkBAIC00OCwxMCArNDcsNiBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgTG9j YWxNZWRpYVN0cmVhbShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgY29uc3QgTWVkaWFTdHJlYW1T b3VyY2VWZWN0b3ImIGF1ZGlvU291cmNlcywgY29uc3QgTWVkaWFTdHJlYW1Tb3VyY2VWZWN0b3Im IHZpZGVvU291cmNlcyk7Ci0KLSAgICB2b2lkIHN0b3BUaW1lckZpcmVkKFRpbWVyPExvY2FsTWVk aWFTdHJlYW0+Kik7Ci0KLSAgICBUaW1lcjxMb2NhbE1lZGlhU3RyZWFtPiBtX3N0b3BUaW1lcjsK IH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 139426 2012-04-30 01:39:50 -0700 2012-04-30 10:43:54 -0700 Patch bug-84942-20120430103948.patch text/plain 2979 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1Mjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI3NzRlNDZjYTUzZWJi MDJiMTcyM2U1M2JmOWVmMzFiYzNhZGQxNi4uOThkN2UzN2Y0MWQ1NjU3MjZmOGU2YjQwZGJmMGU3 ZjFlMmVhZmVmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTI2ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogQ2hhbmdlIExvY2FsTWVkaWFTdHJlYW06OnN0b3AgdG8gYmUgc3luY2hyb25vdXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0OTQyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgSSBjaGFu Z2VkIExvY2FsTWVkaWFTdHJlYW0gdG8gYmUgYSBBY3RpdmVET01PYmplY3QgcmVjZW50bHkgdGhl IHN0b3AoKQorICAgICAgICBiZWhhdmlvdXIgbmVlZHMgdG8gY2hhbmdlIHNpbmNlIGl0IGlzIG5v IGxvbmdlciBhIGdvb2QgaWRlYSB0byBzdGFydCBhIHRpbWVyIHdoZW4gY2FsbGVkLgorCisgICAg ICAgIE5vdCBwb3NzaWJsZSB0byB3cml0ZSBhIHRlc3QgZm9yIHRoaXMuCisKKyAgICAgICAgKiBN b2R1bGVzL21lZGlhc3RyZWFtL0xvY2FsTWVkaWFTdHJlYW0uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TG9jYWxNZWRpYVN0cmVhbTo6TG9jYWxNZWRpYVN0cmVhbSk6CisgICAgICAgIChXZWJDb3Jl OjpMb2NhbE1lZGlhU3RyZWFtOjpzdG9wKToKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFt L0xvY2FsTWVkaWFTdHJlYW0uaDoKKyAgICAgICAgKExvY2FsTWVkaWFTdHJlYW0pOgorCiAyMDEy LTA0LTI2ICBNaWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIENy YXNoIHdoZW4gY29sbGVjdGluZyBzdmcgc3ltYm9sIGVsZW1lbnQgaW4gbmFtZWQgZmxvdy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0 cmVhbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0xvY2FsTWVkaWFT dHJlYW0uY3BwCmluZGV4IDkyZmE2OTg1YjFiODRhMzNmZmUyZjY5YWU1ZjdmOWJkOWI4MjdmYzEu Ljc2MjY1MTkxYzI0ZWI4N2FlMjdiNjdmODQ3ZmNjODg1ZDJkY2U2NmYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Mb2NhbE1lZGlhU3RyZWFtLmNw cApAQCAtNDIsNyArNDIsNiBAQCBQYXNzUmVmUHRyPExvY2FsTWVkaWFTdHJlYW0+IExvY2FsTWVk aWFTdHJlYW06OmNyZWF0ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjbwogCiBMb2NhbE1lZGlh U3RyZWFtOjpMb2NhbE1lZGlhU3RyZWFtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQs IGNvbnN0IE1lZGlhU3RyZWFtU291cmNlVmVjdG9yJiBhdWRpb1NvdXJjZXMsIGNvbnN0IE1lZGlh U3RyZWFtU291cmNlVmVjdG9yJiB2aWRlb1NvdXJjZXMpCiAgICAgOiBNZWRpYVN0cmVhbShjb250 ZXh0LCBNZWRpYVN0cmVhbURlc2NyaXB0b3I6OmNyZWF0ZShjcmVhdGVDYW5vbmljYWxVVUlEU3Ry aW5nKCksIGF1ZGlvU291cmNlcywgdmlkZW9Tb3VyY2VzKSkKLSAgICAsIG1fc3RvcFRpbWVyKHRo aXMsICZMb2NhbE1lZGlhU3RyZWFtOjpzdG9wVGltZXJGaXJlZCkKIHsKIH0KIApAQCAtNTMsMTQg KzUyLDYgQEAgdm9pZCBMb2NhbE1lZGlhU3RyZWFtOjpzdG9wRnVuY3Rpb24oKQogCiB2b2lkIExv Y2FsTWVkaWFTdHJlYW06OnN0b3AoKQogewotICAgIGlmICghbV9zdG9wVGltZXIuaXNBY3RpdmUo KSkKLSAgICAgICAgbV9zdG9wVGltZXIuc3RhcnRPbmVTaG90KDApOwotfQotCi12b2lkIExvY2Fs TWVkaWFTdHJlYW06OnN0b3BUaW1lckZpcmVkKFRpbWVyPExvY2FsTWVkaWFTdHJlYW0+KiB0aW1l cikKLXsKLSAgICBBU1NFUlRfVU5VU0VEKHRpbWVyLCB0aW1lciA9PSAmbV9zdG9wVGltZXIpOwot CiAgICAgaWYgKHJlYWR5U3RhdGUoKSA9PSBFTkRFRCkKICAgICAgICAgcmV0dXJuOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0xvY2FsTWVkaWFTdHJl YW0uaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVh bS5oCmluZGV4IDc2MTgwNWVjYTAyODJjNjNjNjljMzAwYjFiN2EyMzBiZjJmYWE1ZWQuLjc3NzAz MjA0ZDVkNmJlOGQ3YjA5ZjJhNWRiMTUyODg2Y2VkOGFmZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5oCkBAIC0yOSw3 ICsyOSw2IEBACiAjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKIAogI2luY2x1ZGUgIk1lZGlhU3Ry ZWFtLmgiCi0jaW5jbHVkZSAiVGltZXIuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC00 OCwxMCArNDcsNiBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgTG9jYWxNZWRpYVN0cmVhbShT Y3JpcHRFeGVjdXRpb25Db250ZXh0KiwgY29uc3QgTWVkaWFTdHJlYW1Tb3VyY2VWZWN0b3ImIGF1 ZGlvU291cmNlcywgY29uc3QgTWVkaWFTdHJlYW1Tb3VyY2VWZWN0b3ImIHZpZGVvU291cmNlcyk7 Ci0KLSAgICB2b2lkIHN0b3BUaW1lckZpcmVkKFRpbWVyPExvY2FsTWVkaWFTdHJlYW0+Kik7Ci0K LSAgICBUaW1lcjxMb2NhbE1lZGlhU3RyZWFtPiBtX3N0b3BUaW1lcjsKIH07CiAKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUK