84937 2012-04-26 02:52:28 -0700 FormatBlock crashes when body element is removed prior to the command execution 2012-04-27 11:52:33 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 rniwa rniwa adele darin enrica webkit.review.bot oldest_to_newest 610455 0 rniwa 2012-04-26 02:52:28 -0700 Reduction: <!DOCTYPE html> <body> </body> <script type="text/javascript"> document.designMode = 'on'; document.execCommand("SelectAll"); document.documentElement.removeChild(document.body); document.execCommand("FormatBlock", false, "div"); </script> http://code.google.com/p/chromium/issues/detail?id=123441 610456 1 138961 rniwa 2012-04-26 03:01:50 -0700 Created attachment 138961 Fixes the crash 611751 2 138961 webkit.review.bot 2012-04-27 11:52:29 -0700 Comment on attachment 138961 Fixes the crash Clearing flags on attachment: 138961 Committed r115461: <http://trac.webkit.org/changeset/115461> 611752 3 webkit.review.bot 2012-04-27 11:52:33 -0700 All reviewed patches have been landed. Closing bug. 138961 2012-04-26 03:01:50 -0700 2012-04-27 11:52:29 -0700 Fixes the crash fix84937 text/plain 4672 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQXBwbHlCbG9ja0VsZW1lbnRDb21tYW5kLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5QmxvY2tFbGVtZW50 Q29tbWFuZC5jcHAJKHJldmlzaW9uIDExNTIyNikKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcv QXBwbHlCbG9ja0VsZW1lbnRDb21tYW5kLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTYsMTQgKzU2 LDE0IEBACiAKIHZvaWQgQXBwbHlCbG9ja0VsZW1lbnRDb21tYW5kOjpkb0FwcGx5KCkKIHsKLSAg ICBpZiAoIWVuZGluZ1NlbGVjdGlvbigpLmlzTm9uT3JwaGFuZWRDYXJldE9yUmFuZ2UoKSkKLSAg ICAgICAgcmV0dXJuOwotCiAgICAgaWYgKCFlbmRpbmdTZWxlY3Rpb24oKS5yb290RWRpdGFibGVF bGVtZW50KCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIFZpc2libGVQb3NpdGlvbiB2aXNpYmxl RW5kID0gZW5kaW5nU2VsZWN0aW9uKCkudmlzaWJsZUVuZCgpOwogICAgIFZpc2libGVQb3NpdGlv biB2aXNpYmxlU3RhcnQgPSBlbmRpbmdTZWxlY3Rpb24oKS52aXNpYmxlU3RhcnQoKTsKKyAgICBp ZiAodmlzaWJsZVN0YXJ0LmlzTnVsbCgpIHx8IHZpc2libGVTdGFydC5pc09ycGhhbigpIHx8IHZp c2libGVFbmQuaXNOdWxsKCkgfHwgdmlzaWJsZUVuZC5pc09ycGhhbigpKQorICAgICAgICByZXR1 cm47CisKICAgICAvLyBXaGVuIGEgc2VsZWN0aW9uIGVuZHMgYXQgdGhlIHN0YXJ0IG9mIGEgcGFy YWdyYXBoLCB3ZSByYXJlbHkgcGFpbnQgCiAgICAgLy8gdGhlIHNlbGVjdGlvbiBnYXAgYmVmb3Jl IHRoYXQgcGFyYWdyYXBoLCBiZWNhdXNlIHRoZXJlIG9mdGVuIGlzIG5vIGdhcC4gIAogICAgIC8v IEluIGEgY2FzZSBsaWtlIHRoaXMsIGl0J3Mgbm90IG9idmlvdXMgdG8gdGhlIHVzZXIgdGhhdCB0 aGUgc2VsZWN0aW9uIApJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE1Mjk4KQorKysgU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTIt MDQtMjYgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRm9ybWF0 QmxvY2sgY3Jhc2hlcyB3aGVuIGJvZHkgZWxlbWVudCBpcyByZW1vdmVkIHByaW9yIHRvIHRoZSBj b21tYW5kIGV4ZWN1dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODQ5MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgY3Jhc2ggd2FzIGJlY2F1c2UgYmVjYXVzZSBET00gaGFkIGJlZW4gbW9kaWZp ZWQgc2luY2UgdGhlIGxhc3QgdGltZSBzZWxlY3Rpb24gaGFkIGJlZW4gInZhbGlkYXRlZCIsCisg ICAgICAgIGFuZCB0aGVyZWZvcmUgZnJhbWUgc2VsZWN0aW9uJ3MgZW5kcG9pbnRzIGFyZSBubyBs b25nZXIgdmlzaWJsZSB3aGVuIHdlIGluc3RhbnRpYXRlZCB2aXNpYmxlU3RhcnQKKyAgICAgICAg YW5kIHZpc2libGVFbmQgZnJvbSBtX2VuZGluZ1NlbGVjdGlvbiBvZiB0aGUgZWRpdCBjb21tYW5k LgorCisgICAgICAgIEZpeGVkIHRoZSBidWcgYnkgY2hlY2tpbmcgdGhlIG51bGxpdHkgYW5kIG9y cGhhbmVkbmVzcyBvZiB2aXNpYmxlIHN0YXJ0IGFuZCB2aXNpYmxlIGVuZCBkaXJlY3RseS4KKyAg ICAgICAgSSBzdXNwZWN0IHdlIGhhdmUgc2ltaWxhciBidWdzIGluIG90aGVyIGNvbW1hbmRzLiBU aGUgZnVuZGFtZW50YWwgcHJvYmxlbSBpcyB0aGF0IHRoZSBjb3B5IGNvbnN0cnVjdG9yCisgICAg ICAgIG9mIFZpc2libGVTZWxlY3Rpb24gbmV2ZXIgdmFsaWRhdGVzIHNvIHdoZW4gYSBWaXNpYmxl U2VsZWN0aW9uIGlzIHBhc3NlZCBmcm9tIG9uZSBjbGFzcyB0byBhbm90aGVyCisgICAgICAgIChl LmcuIEZyYW1lU2VsZWN0aW9uIHRvIEVkaXRDb21tYW5kKSwgd2UgbWF5IG5vdCBhZGp1c3QgZW5k IHBvaW50cyBhcyBuZWVkZWQuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9leGVjQ29tbWFuZC9m b3JtYXQtYmxvY2std2l0aG91dC1ib2R5LWNyYXNoLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcv QXBwbHlCbG9ja0VsZW1lbnRDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGx5Qmxv Y2tFbGVtZW50Q29tbWFuZDo6ZG9BcHBseSk6CisKIDIwMTItMDQtMjYgIE1paG5lYSBPdmlkZW5p ZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggd2hlbiBjb2xsZWN0aW5nIHN2 ZyBzeW1ib2wgZWxlbWVudCBpbiBuYW1lZCBmbG93LgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGlu Zy9leGVjQ29tbWFuZC9mb3JtYXQtYmxvY2std2l0aG91dC1ib2R5LWNyYXNoLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2Zvcm1hdC1i bG9jay13aXRob3V0LWJvZHktY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9mb3JtYXQtYmxvY2std2l0aG91dC1ib2R5LWNy YXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2IEBACitUaGlzIHRlc3Rz IGV4ZWN1dGluZyBGb3JtYXRCbG9jayBjb21tYW5kIHdpdGhvdXQgYm9keSBlbGVtZW50LgorVGhl IHBhc3NlcyBpZiBXZWJLaXQgZG9lcyBub3QgY3Jhc2guCisKK1BBU1MKKworCkluZGV4OiBMYXlv dXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2Zvcm1hdC1ibG9jay13aXRob3V0LWJvZHktY3Jh c2guaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2Zv cm1hdC1ibG9jay13aXRob3V0LWJvZHktY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvZm9ybWF0LWJsb2NrLXdpdGhvdXQtYm9keS1jcmFz aC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxi b2R5PgorPC9ib2R5PgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCitpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKKworZG9jdW1lbnQuZGVzaWduTW9kZSA9ICdvbic7Citkb2N1bWVudC5leGVjQ29t bWFuZCgiU2VsZWN0QWxsIik7Citkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQucmVtb3ZlQ2hpbGQo ZG9jdW1lbnQuYm9keSk7Citkb2N1bWVudC5leGVjQ29tbWFuZCgiRm9ybWF0QmxvY2siLCBmYWxz ZSwgImRpdiIpOworCitkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgnYm9keScpKTsKK2RvY3VtZW50LmJvZHkuaW5uZXJUZXh0ID0gJ1Ro aXMgdGVzdHMgZXhlY3V0aW5nIEZvcm1hdEJsb2NrIGNvbW1hbmQgd2l0aG91dCBib2R5IGVsZW1l bnQuXG4nCisgKyAnVGhlIHBhc3NlcyBpZiBXZWJLaXQgZG9lcyBub3QgY3Jhc2guXG5cbicKKyAr ICdQQVNTXG5cbic7CisKKzwvc2NyaXB0PgpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTE1Mjk4KQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTItMDQtMjYgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRm9y bWF0QmxvY2sgY3Jhc2hlcyB3aGVuIGJvZHkgZWxlbWVudCBpcyByZW1vdmVkIHByaW9yIHRvIHRo ZSBjb21tYW5kIGV4ZWN1dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODQ5MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgYSByZWdyZXNzaW9uIHRlc3QgZm9yIGV4ZWN1dGluZyBGb3JtYXRDb21t YW5kIGltbWVkaWF0ZWx5IGFmdGVyIHJlbW92aW5nCisgICAgICAgIHRoZSBib2R5IGVsZW1lbnQg dGhlcmVieSB0dXJuaW5nIHRoZSBzZWxlY3Rpb24gZW5kIHBvaW50cyB0byBub24tY2FuZGlkYXRl cy4KKworICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvZm9ybWF0LWJsb2NrLXdpdGhvdXQt Ym9keS1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0Nv bW1hbmQvZm9ybWF0LWJsb2NrLXdpdGhvdXQtYm9keS1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAx Mi0wNC0yNiAgTWlobmVhIE92aWRlbmllICA8bWlobmVhQGFkb2JlLmNvbT4KIAogICAgICAgICBD cmFzaCB3aGVuIGNvbGxlY3Rpbmcgc3ZnIHN5bWJvbCBlbGVtZW50IGluIG5hbWVkIGZsb3cuCg==