84916 2012-04-25 17:45:26 -0700 Placeholder view is immediately removed from hosting window upon entering full screen. 2012-05-03 14:07:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85388 1 jer.noble jer.noble oldest_to_newest 610221 0 jer.noble 2012-04-25 17:45:26 -0700 Placeholder view is immediately removed from hosting window upon entering full screen. 610225 1 138908 jer.noble 2012-04-25 17:48:46 -0700 Created attachment 138908 Patch 610234 2 138908 darin 2012-04-25 17:54:32 -0700 Comment on attachment 138908 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138908&action=review > Source/WebKit/mac/WebView/WebFullScreenController.mm:457 > + [[view superview] addSubview:otherView positioned:NSWindowAbove relativeTo:otherView];r114567 Oops. 610238 3 138908 buildbot 2012-04-25 17:56:06 -0700 Comment on attachment 138908 Patch Attachment 138908 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12522620 610240 4 138908 darin 2012-04-25 17:56:35 -0700 Comment on attachment 138908 Patch r=me but please don't check in the typo since its ill break the build! What about test coverage? 610316 5 jer.noble 2012-04-25 19:46:37 -0700 (In reply to comment #4) > (From update of attachment 138908 [details]) > r=me but please don't check in the typo since its ill break the build! Whoops. I fixed that in the WebKit2 side of the patch; I'll fix it here too. > What about test coverage? This issue was found by manual testing, and this fix will require manual testing too. 610685 6 jer.noble 2012-04-26 09:51:45 -0700 Committed r115324: <http://trac.webkit.org/changeset/115324> 138908 2012-04-25 17:48:46 -0700 2012-04-25 17:56:35 -0700 Patch bug-84916-20120425174845.patch text/plain 3468 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggMmExMGQxZTRm NjIyNTRiNDUxMGI4YWE1NGI5NzlkZTZlMGU0ZmRmOC4uODAzZDI0Y2FjNjNmY2UxYTNhNzgwMDVl YTk2MDU3ZjJhN2ZhMGMwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTA0LTI1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFBsYWNl aG9sZGVyIHZpZXcgaXMgaW1tZWRpYXRlbHkgcmVtb3ZlZCBmcm9tIGhvc3Rpbmcgd2luZG93IHVw b24gZW50ZXJpbmcgZnVsbCBzY3JlZW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04NDkxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENvcnJlY3QgYSBtaXN0YWtlIGFkZGVkIGluIHIxMTQ1NjcuICBXaGVu IHN3YXBwaW5nIHZpZXcgZm9yIG90aGVyVmlldywgYWRkIG90aGVyVmlldyBhbmQgCisgICAgICAg IHJlbW92ZSB2aWV3IChyYXRoZXIgdGhhbiBhZGRpbmcgb3RoZXJWaWV3IGFuZCByZW1vdmluZyBv dGhlclZpZXcpLgorCisgICAgICAgICogV2ViVmlldy9XZWJGdWxsU2NyZWVuQ29udHJvbGxlci5t bToKKyAgICAgICAgKC1bV2ViRnVsbFNjcmVlbkNvbnRyb2xsZXIgX3N3YXBWaWV3OndpdGg6XSk6 CisKIDIwMTItMDQtMjMgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAg IEluY3JlbWVudGFsIHJlbmRlcmluZyBzaG91bGQgYmUgdW5zdXBwcmVzc2VkIGFmdGVyIHRoZSBs b2FkIGV2ZW50IG9yIGEgY29uZmlndXJhYmxlIHRpbWVvdXQsIHdoaWNoZXZlciBvY2N1cnMgZmly c3QuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKaW5kZXggMjExNGRlMmU1MWNhZWY4OGUwN2M0YTRkZmQ2YTk5MzUzYTIwMzU0 ZC4uNzA2NDAxZGQ5OTBmNDE0ODk4YjQwMzU1YzJhYjYxYTU4YjUxZWY5NSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTI1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUu Y29tPgorCisgICAgICAgIFBsYWNlaG9sZGVyIHZpZXcgaXMgaW1tZWRpYXRlbHkgcmVtb3ZlZCBm cm9tIGhvc3Rpbmcgd2luZG93IHVwb24gZW50ZXJpbmcgZnVsbCBzY3JlZW4uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDkxNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3QgYSBtaXN0YWtlIGFk ZGVkIGluIHIxMTQ1NjcuICBXaGVuIHN3YXBwaW5nIHZpZXcgZm9yIG90aGVyVmlldywgYWRkIG90 aGVyVmlldyBhbmQgCisgICAgICAgIHJlbW92ZSB2aWV3IChyYXRoZXIgdGhhbiBhZGRpbmcgb3Ro ZXJWaWV3IGFuZCByZW1vdmluZyBvdGhlclZpZXcpLgorCisgICAgICAgICogVUlQcm9jZXNzL21h Yy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS0Z1bGxTY3Jl ZW5XaW5kb3dDb250cm9sbGVyIF9zd2FwVmlldzp3aXRoOl0pOgorCiAyMDEyLTA0LTI0ICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KIAogICAg ICAgICBbUXRdIFVucmV2aWV3ZWQgYnVpbGQgZml4IGFmdGVyIHIxMTUwODMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnVsbFNjcmVlbkNvbnRyb2xsZXIubW0gYi9T b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZ1bGxTY3JlZW5Db250cm9sbGVyLm1tCmluZGV4 IDYyYWY0MTRhY2E5NTlkYTY4YWFmY2QyYWEzYTcyNDFmMmY3YmNkODMuLmRlMGZiMmYwZWY4MmZh YTI0MTYxNjc0Y2I3ZjQ4YmNlZWRkYTYxODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViRnVsbFNjcmVlbkNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9t YWMvV2ViVmlldy9XZWJGdWxsU2NyZWVuQ29udHJvbGxlci5tbQpAQCAtNDU0LDggKzQ1NCw4IEBA IHN0YXRpYyBJbnRSZWN0IHNjcmVlblJlY3RPZkNvbnRlbnRzKEVsZW1lbnQqIGVsZW1lbnQpCiAg ICAgW290aGVyVmlldyBzZXRGcmFtZTpbdmlldyBmcmFtZV1dOyAgICAgICAgCiAgICAgW290aGVy VmlldyBzZXRBdXRvcmVzaXppbmdNYXNrOlt2aWV3IGF1dG9yZXNpemluZ01hc2tdXTsKICAgICBb b3RoZXJWaWV3IHJlbW92ZUZyb21TdXBlcnZpZXddOwotICAgIFtbdmlldyBzdXBlcnZpZXddIGFk ZFN1YnZpZXc6b3RoZXJWaWV3IHBvc2l0aW9uZWQ6TlNXaW5kb3dBYm92ZSByZWxhdGl2ZVRvOm90 aGVyVmlld107Ci0gICAgW290aGVyVmlldyByZW1vdmVGcm9tU3VwZXJ2aWV3XTsKKyAgICBbW3Zp ZXcgc3VwZXJ2aWV3XSBhZGRTdWJ2aWV3Om90aGVyVmlldyBwb3NpdGlvbmVkOk5TV2luZG93QWJv dmUgcmVsYXRpdmVUbzpvdGhlclZpZXddO3IxMTQ1NjcKKyAgICBbdmlldyByZW1vdmVGcm9tU3Vw ZXJ2aWV3XTsKICAgICBbQ0FUcmFuc2FjdGlvbiBjb21taXRdOwogfQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIu bW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRy b2xsZXIubW0KaW5kZXggMTcyYzcxYjhlNDQyZDJmYzNjNzA2M2JmNDAyN2ViMTAzMDM0MWMyOC4u YTkzOWFiY2EyZmMzNzY1NmI2ZWRkZmIzMTE1YjIyMDg2NjA4ZjcxMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29u dHJvbGxlci5tbQpAQCAtNDUyLDcgKzQ1Miw3IEBAIHN0YXRpYyBjb25zdCBOU1RpbWVJbnRlcnZh bCBEZWZhdWx0V2F0Y2hkb2dUaW1lckludGVydmFsID0gMTsKICAgICBbb3RoZXJWaWV3IHNldEF1 dG9yZXNpemluZ01hc2s6W3ZpZXcgYXV0b3Jlc2l6aW5nTWFza11dOwogICAgIFtvdGhlclZpZXcg cmVtb3ZlRnJvbVN1cGVydmlld107CiAgICAgW1t2aWV3IHN1cGVydmlld10gYWRkU3Vidmlldzpv dGhlclZpZXcgcG9zaXRpb25lZDpOU1dpbmRvd0Fib3ZlIHJlbGF0aXZlVG86b3RoZXJWaWV3XTsK LSAgICBbb3RoZXJWaWV3IHJlbW92ZUZyb21TdXBlcnZpZXddOworICAgIFt2aWV3IHJlbW92ZUZy b21TdXBlcnZpZXddOwogICAgIFtDQVRyYW5zYWN0aW9uIGNvbW1pdF07CiB9CiAK