84915 2012-04-25 17:44:50 -0700 Move convertJSMethodNameToObjc() to be a utility function of ObjcClass 2012-04-25 18:05:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 84668 1 benjamin benjamin oldest_to_newest 610220 0 benjamin 2012-04-25 17:44:50 -0700 Move convertJSMethodNameToObjc() to be a utility function of ObjcClass 610231 1 138911 benjamin 2012-04-25 17:53:23 -0700 Created attachment 138911 Patch 610232 2 benjamin 2012-04-25 17:54:11 -0700 Just the trivial change, move the function around without any other modification. 610237 3 138911 darin 2012-04-25 17:55:51 -0700 Comment on attachment 138911 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138911&action=review > Source/WebCore/WebCore.order:-6356 > -__ZN3JSC8Bindings25convertJSMethodNameToObjcEPKcPcm No need to update order files; those are generated mechanically and don’t need to be edited. 610251 4 benjamin 2012-04-25 18:05:36 -0700 Committed r115269: <http://trac.webkit.org/changeset/115269> 138911 2012-04-25 17:53:23 -0700 2012-04-25 17:55:51 -0700 Patch bug-84915-20120425175322.patch text/plain 6888 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODYzMzgwYjZiMTUzZTI4 MmFkNzVmZmM3YzNjNGUwNzMzYWYxYjI5MS4uNWNlZTY1Y2MxMjQ2OGZjNzcyNzQ0M2JiMjBiOGJi MmI0MzYwYjI1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTI1ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIE1vdmUgY29udmVy dEpTTWV0aG9kTmFtZVRvT2JqYygpIHRvIGJlIGEgdXRpbGl0eSBmdW5jdGlvbiBvZiBPYmpjQ2xh c3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0OTE1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZ1 bmN0aW9uIGNvbnZlcnRKU01ldGhvZE5hbWVUb09iamMoKSBpcyBvbmx5IHVzZWZ1bCBmb3IgT2Jq Y0NsYXNzOjptZXRob2RzTmFtZWQoKS4KKworICAgICAgICBUaGlzIHBhdGNoIG1vdmVzIHRoZSBm dW5jdGlvbiBmcm9tIG9iamNfdXRpbGl0eS5tbSB0byBiZSBhIHN0YXRpYyBmdW5jdGlvbiBpbiBv YmpjX2NsYXNzLm1tLgorICAgICAgICBJdCBhaW1zIGF0IHNpbXBsaWZ5aW5nIHRoZSBjb2RlIGZv ciBmdXR1cmUgY2hhbmdlcyBvZiBPYmpjQ2xhc3MuCisKKyAgICAgICAgKiBXZWJDb3JlLm9yZGVy OgorICAgICAgICAqIGJyaWRnZS9vYmpjL29iamNfY2xhc3MubW06CisgICAgICAgIChCaW5kaW5n cyk6CisgICAgICAgIChKU0M6OkJpbmRpbmdzOjpjb252ZXJ0SlNNZXRob2ROYW1lVG9PYmpjKToK KyAgICAgICAgKiBicmlkZ2Uvb2JqYy9vYmpjX3V0aWxpdHkuaDoKKyAgICAgICAgKiBicmlkZ2Uv b2JqYy9vYmpjX3V0aWxpdHkubW06CisgICAgICAgIChCaW5kaW5ncyk6CisKIDIwMTItMDQtMjUg IEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBh IHZlcnNpb24gb2YgU3RyaW5nSW1wbDo6ZmluZCgpIHdpdGhvdXQgb2Zmc2V0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLm9yZGVyIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5v cmRlcgppbmRleCBmYjA1YzcwNzg4NzliNmU4ZDllZGUxNmJlN2Y0Y2U5NmY0NDYzYjZmLi4yM2Rm ZjZmNzM3ODFmNmExZjA0MDZiYjk5YzIyNjE3ZWYyYzI5NDA4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLm9yZGVyCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUub3JkZXIK QEAgLTYzNTMsNyArNjM1Myw2IEBAIF9fWk4zSlNDOEJpbmRpbmdzOU9iamNDbGFzc0MyRVAxMG9i amNfY2xhc3MKIF9fWk5LM0pTQzhCaW5kaW5nczlPYmpjQ2xhc3MxMGZpZWxkTmFtZWRFUktOU18x MElkZW50aWZpZXJFUE5TMF84SW5zdGFuY2VFCiBfX1pOM1dURjEwUmVmQ291bnRlZElOU18xM0NT dHJpbmdCdWZmZXJFRTVkZXJlZkV2CiBfX1pOSzNKU0M4QmluZGluZ3M5T2JqY0NsYXNzMTJtZXRo b2RzTmFtZWRFUktOU18xMElkZW50aWZpZXJFUE5TMF84SW5zdGFuY2VFCi1fX1pOM0pTQzhCaW5k aW5nczI1Y29udmVydEpTTWV0aG9kTmFtZVRvT2JqY0VQS2NQY20KIF9fWk4zSlNDOEJpbmRpbmdz MTBPYmpjTWV0aG9kQzFFUDEwb2JqY19jbGFzc1AxM29iamNfc2VsZWN0b3IKIF9fWk4zV1RGNlZl Y3RvcklQTjNKU0M4QmluZGluZ3M2TWV0aG9kRUxtMEVFMTRleHBhbmRDYXBhY2l0eUVtCiBfX1pO M0pTQzhCaW5kaW5nczhJbnN0YW5jZTNlbmRFdgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YnJpZGdlL29iamMvb2JqY19jbGFzcy5tbSBiL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9vYmpjL29i amNfY2xhc3MubW0KaW5kZXggMTFjZjA0YTc4ZjhiM2RkNmRiZGRjODBhODNlMjQ5MmU2MWExMzhi OS4uMTMwM2IzYWViYzQwMWU2ZTU2NjgxODZjOTRmZTE3ZmI1MTdiOTI3NyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYnJpZGdlL29iamMvb2JqY19jbGFzcy5tbQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9icmlkZ2Uvb2JqYy9vYmpjX2NsYXNzLm1tCkBAIC02Niw2ICs2Niw1NiBAQCBPYmpjQ2xh c3MqIE9iamNDbGFzczo6Y2xhc3NGb3JJc0EoQ2xhc3NTdHJ1Y3RQdHIgaXNhKQogICAgIHJldHVy biBhQ2xhc3M7CiB9CiAKKy8qCisgICAgQnkgZGVmYXVsdCwgYSBKYXZhU2NyaXB0IG1ldGhvZCBu YW1lIGlzIHByb2R1Y2VkIGJ5IGNvbmNhdGVuYXRpbmcgdGhlCisgICAgY29tcG9uZW50cyBvZiBh biBPYmplY3RpdmVDIG1ldGhvZCBuYW1lLCByZXBsYWNpbmcgJzonIHdpdGggJ18nLCBhbmQKKyAg ICBlc2NhcGluZyAnXycgYW5kICckJyB3aXRoIGEgbGVhZGluZyAnJCcsIHN1Y2ggdGhhdCAnXycg YmVjb21lcyAiJF8iIGFuZAorICAgICckJyBiZWNvbWVzICIkJCIuIEZvciBleGFtcGxlOgorCisg ICAgT2JqZWN0aXZlQyBuYW1lICAgICAgICAgRGVmYXVsdCBKYXZhU2NyaXB0IG5hbWUKKyAgICAg ICAgbW92ZVRvOjogICAgICAgICAgICAgICAgbW92ZVRvX18KKyAgICAgICAgbW92ZVRvXyAgICAg ICAgICAgICAgICAgbW92ZVRvJF8KKyAgICAgICAgbW92ZVRvJF8gICAgICAgICAgICAgICAgbW92 ZVRvJCQkXworCisgICAgVGhpcyBmdW5jdGlvbiBwZXJmb3JtcyB0aGUgaW52ZXJzZSBvZiB0aGF0 IG9wZXJhdGlvbi4KKworICAgIEByZXN1bHQgRmlsbHMgJ2J1ZmZlcicgd2l0aCB0aGUgT2JqZWN0 aXZlQyBtZXRob2QgbmFtZSB0aGF0IGNvcnJlc3BvbmRzIHRvICdKU05hbWUnLgorICAgICAgICAg ICAgUmV0dXJucyB0cnVlIGZvciBzdWNjZXNzLCBmYWxzZSBmb3IgZmFpbHVyZS4gKEZhaWx1cmUg b2NjdXJzIHdoZW4gJ2J1ZmZlcicKKyAgICAgICAgICAgIGlzIG5vdCBiaWcgZW5vdWdoIHRvIGhv bGQgdGhlIHJlc3VsdC4pCisqLworc3RhdGljIGJvb2wgY29udmVydEpTTWV0aG9kTmFtZVRvT2Jq Yyhjb25zdCBjaGFyICpKU05hbWUsIGNoYXIgKmJ1ZmZlciwgc2l6ZV90IGJ1ZmZlclNpemUpCit7 CisgICAgQVNTRVJUKEpTTmFtZSAmJiBidWZmZXIpOworCisgICAgY29uc3QgY2hhciAqc3AgPSBK U05hbWU7IC8vIHNvdXJjZSBwb2ludGVyCisgICAgY2hhciAqZHAgPSBidWZmZXI7IC8vIGRlc3Rp bmF0aW9uIHBvaW50ZXIKKworICAgIGNoYXIgKmVuZCA9IGJ1ZmZlciArIGJ1ZmZlclNpemU7Cisg ICAgd2hpbGUgKGRwIDwgZW5kKSB7CisgICAgICAgIGlmICgqc3AgPT0gJyQnKSB7CisgICAgICAg ICAgICArK3NwOworICAgICAgICAgICAgKmRwID0gKnNwOworICAgICAgICB9IGVsc2UgaWYgKCpz cCA9PSAnXycpCisgICAgICAgICAgICAqZHAgPSAnOic7CisgICAgICAgIGVsc2UKKyAgICAgICAg ICAgICpkcCA9ICpzcDsKKworICAgICAgICAvLyBJZiBhIGZ1dHVyZSBjb2RlciBwdXRzIGZ1bm55 ICsrIG9wZXJhdG9ycyBhYm92ZSwgd2UgbWlnaHQgd3JpdGUgb2ZmIHRoZSBlbmQKKyAgICAgICAg Ly8gb2YgdGhlIGJ1ZmZlciBpbiB0aGUgbWlkZGxlIG9mIHRoaXMgbG9vcC4gTGV0J3MgbWFrZSBz dXJlIHRvIGNoZWNrIGZvciB0aGF0LgorICAgICAgICBBU1NFUlQoZHAgPCBlbmQpOworCisgICAg ICAgIGlmICgqc3AgPT0gMCkgeyAvLyBXZSBmaW5pc2hlZCBjb252ZXJ0aW5nIEpTTmFtZQorICAg ICAgICAgICAgQVNTRVJUKHN0cmxlbihKU05hbWUpIDwgYnVmZmVyU2l6ZSk7CisgICAgICAgICAg ICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQorCisgICAgICAgICsrc3A7CisgICAgICAgICsrZHA7 CisgICAgfQorCisgICAgcmV0dXJuIGZhbHNlOyAvLyBXZSByYW4gb3V0IG9mIGJ1ZmZlciBiZWZv cmUgY29udmVydGluZyBKU05hbWUKK30KKwogTWV0aG9kTGlzdCBPYmpjQ2xhc3M6Om1ldGhvZHNO YW1lZChjb25zdCBJZGVudGlmaWVyJiBpZGVudGlmaWVyLCBJbnN0YW5jZSopIGNvbnN0CiB7CiAg ICAgTWV0aG9kTGlzdCBtZXRob2RMaXN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJp ZGdlL29iamMvb2JqY191dGlsaXR5LmggYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvb2JqYy9vYmpj X3V0aWxpdHkuaAppbmRleCA1MzNjMTFlNmM4YzczYzkwZGY4ZmI2MzExOGI1YWE5ZGE2YTM0ZTYx Li4xOWU2ZTdhNDk3ZWQ0YmYzZWM1NzU1N2ZhMmFlODIxZWUwMGY2Mjk2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9icmlkZ2Uvb2JqYy9vYmpjX3V0aWxpdHkuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9icmlkZ2Uvb2JqYy9vYmpjX3V0aWxpdHkuaApAQCAtNzQsOCArNzQsNiBAQCBKU1ZhbHVl IGNvbnZlcnROU1N0cmluZ1RvU3RyaW5nKEV4ZWNTdGF0ZSogZXhlYywgTlNTdHJpbmcgKm5zc3Ry aW5nKTsKIEpTVmFsdWUgY29udmVydE9iamNWYWx1ZVRvVmFsdWUoRXhlY1N0YXRlKiwgdm9pZCog YnVmZmVyLCBPYmpjVmFsdWVUeXBlLCBSb290T2JqZWN0Kik7CiBPYmpjVmFsdWVUeXBlIG9iamNW YWx1ZVR5cGVGb3JUeXBlKGNvbnN0IGNoYXIgKnR5cGUpOwogCi1ib29sIGNvbnZlcnRKU01ldGhv ZE5hbWVUb09iamMoY29uc3QgY2hhciAqSlNOYW1lLCBjaGFyICpidWZmZXIsIHNpemVfdCBidWZm ZXJTaXplKTsKLQogSlNPYmplY3QgKnRocm93RXJyb3IoRXhlY1N0YXRlICosIE5TU3RyaW5nICpt ZXNzYWdlKTsKIAogfSAvLyBuYW1lc3BhY2UgQmluZGluZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JyaWRnZS9vYmpjL29iamNfdXRpbGl0eS5tbSBiL1NvdXJjZS9XZWJDb3JlL2JyaWRn ZS9vYmpjL29iamNfdXRpbGl0eS5tbQppbmRleCAwNGFjZjczNjlhMTRmOWRmY2I2YjEyYmU2ZThl OGQyMzlkZDA3NmE5Li5iOTI5YWMwZDQyYzgwMTczMWNlMThkNjIxN2RiODM3ZjZmYjUzZWQ3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvb2JqYy9vYmpjX3V0aWxpdHkubW0KKysr IGIvU291cmNlL1dlYkNvcmUvYnJpZGdlL29iamMvb2JqY191dGlsaXR5Lm1tCkBAIC02Niw1NiAr NjYsNiBAQCBuYW1lc3BhY2UgSlNDIHsKIG5hbWVzcGFjZSBCaW5kaW5ncyB7CiAKIC8qCi0gICAg QnkgZGVmYXVsdCwgYSBKYXZhU2NyaXB0IG1ldGhvZCBuYW1lIGlzIHByb2R1Y2VkIGJ5IGNvbmNh dGVuYXRpbmcgdGhlIAotICAgIGNvbXBvbmVudHMgb2YgYW4gT2JqZWN0aXZlQyBtZXRob2QgbmFt ZSwgcmVwbGFjaW5nICc6JyB3aXRoICdfJywgYW5kIAotICAgIGVzY2FwaW5nICdfJyBhbmQgJyQn IHdpdGggYSBsZWFkaW5nICckJywgc3VjaCB0aGF0ICdfJyBiZWNvbWVzICIkXyIgYW5kIAotICAg ICckJyBiZWNvbWVzICIkJCIuIEZvciBleGFtcGxlOgotCi0gICAgT2JqZWN0aXZlQyBuYW1lICAg ICAgICAgRGVmYXVsdCBKYXZhU2NyaXB0IG5hbWUKLSAgICAgICAgbW92ZVRvOjogICAgICAgICAg ICAgICAgbW92ZVRvX18KLSAgICAgICAgbW92ZVRvXyAgICAgICAgICAgICAgICAgbW92ZVRvJF8K LSAgICAgICAgbW92ZVRvJF8gICAgICAgICAgICAgICAgbW92ZVRvJCQkXwotCi0gICAgVGhpcyBm dW5jdGlvbiBwZXJmb3JtcyB0aGUgaW52ZXJzZSBvZiB0aGF0IG9wZXJhdGlvbi4KLSAKLSAgICBA cmVzdWx0IEZpbGxzICdidWZmZXInIHdpdGggdGhlIE9iamVjdGl2ZUMgbWV0aG9kIG5hbWUgdGhh dCBjb3JyZXNwb25kcyB0byAnSlNOYW1lJy4gCi0gICAgICAgICAgICBSZXR1cm5zIHRydWUgZm9y IHN1Y2Nlc3MsIGZhbHNlIGZvciBmYWlsdXJlLiAoRmFpbHVyZSBvY2N1cnMgd2hlbiAnYnVmZmVy JyAKLSAgICAgICAgICAgIGlzIG5vdCBiaWcgZW5vdWdoIHRvIGhvbGQgdGhlIHJlc3VsdC4pCi0q LwotYm9vbCBjb252ZXJ0SlNNZXRob2ROYW1lVG9PYmpjKGNvbnN0IGNoYXIgKkpTTmFtZSwgY2hh ciAqYnVmZmVyLCBzaXplX3QgYnVmZmVyU2l6ZSkKLXsKLSAgICBBU1NFUlQoSlNOYW1lICYmIGJ1 ZmZlcik7Ci0gICAgCi0gICAgY29uc3QgY2hhciAqc3AgPSBKU05hbWU7IC8vIHNvdXJjZSBwb2lu dGVyCi0gICAgY2hhciAqZHAgPSBidWZmZXI7IC8vIGRlc3RpbmF0aW9uIHBvaW50ZXIKLSAgICAg ICAgCi0gICAgY2hhciAqZW5kID0gYnVmZmVyICsgYnVmZmVyU2l6ZTsKLSAgICB3aGlsZSAoZHAg PCBlbmQpIHsKLSAgICAgICAgaWYgKCpzcCA9PSAnJCcpIHsKLSAgICAgICAgICAgICsrc3A7Ci0g ICAgICAgICAgICAqZHAgPSAqc3A7Ci0gICAgICAgIH0gZWxzZSBpZiAoKnNwID09ICdfJykKLSAg ICAgICAgICAgICpkcCA9ICc6JzsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgKmRwID0gKnNw OwotCi0gICAgICAgIC8vIElmIGEgZnV0dXJlIGNvZGVyIHB1dHMgZnVubnkgKysgb3BlcmF0b3Jz IGFib3ZlLCB3ZSBtaWdodCB3cml0ZSBvZmYgdGhlIGVuZCAKLSAgICAgICAgLy8gb2YgdGhlIGJ1 ZmZlciBpbiB0aGUgbWlkZGxlIG9mIHRoaXMgbG9vcC4gTGV0J3MgbWFrZSBzdXJlIHRvIGNoZWNr IGZvciB0aGF0LgotICAgICAgICBBU1NFUlQoZHAgPCBlbmQpOwotICAgICAgICAKLSAgICAgICAg aWYgKCpzcCA9PSAwKSB7IC8vIFdlIGZpbmlzaGVkIGNvbnZlcnRpbmcgSlNOYW1lCi0gICAgICAg ICAgICBBU1NFUlQoc3RybGVuKEpTTmFtZSkgPCBidWZmZXJTaXplKTsKLSAgICAgICAgICAgIHJl dHVybiB0cnVlOwotICAgICAgICB9Ci0gICAgICAgIAotICAgICAgICArK3NwOyAKLSAgICAgICAg KytkcDsKLSAgICB9Ci0KLSAgICByZXR1cm4gZmFsc2U7IC8vIFdlIHJhbiBvdXQgb2YgYnVmZmVy IGJlZm9yZSBjb252ZXJ0aW5nIEpTTmFtZQotfQotCi0vKgogCiAgICAgSmF2YVNjcmlwdCB0byAg IE9iakMKICAgICBOdW1iZXIgICAgICAgICAgY29lcmNlZCB0byBjaGFyLCBzaG9ydCwgaW50LCBs b25nLCBmbG9hdCwgZG91YmxlLCBvciBOU051bWJlciwgYXMgYXBwcm9wcmlhdGUK