84913 2012-04-25 17:33:57 -0700 WebKit 1: Initialize deviceScaleFactor on creation of the WebView 2012-04-25 18:11:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin darin oldest_to_newest 610210 0 bdakin 2012-04-25 17:33:57 -0700 The change should be adopted for WebKit 1 as well: http://trac.webkit.org/changeset/107017 Without this, deviceScaleFactor will not be initialized until viewDidMoveToWindow, which is quite late for a background tab. <rdar://problem/11322716> Patch forthcoming. 610214 1 138907 bdakin 2012-04-25 17:37:19 -0700 Created attachment 138907 Patch 610217 2 138907 darin 2012-04-25 17:43:02 -0700 Comment on attachment 138907 Patch OK 610218 3 darin 2012-04-25 17:43:44 -0700 One difference with WebKit1 is that we have the “host window” concept. The host window should be set quite early for a background tab. I’d think we could change things so that a WebView that gets a host window could set its scale factor appropriately based on the host window. 610244 4 138913 bdakin 2012-04-25 18:00:51 -0700 Created attachment 138913 Patch that uses hostWindow instead 610249 5 138913 darin 2012-04-25 18:05:22 -0700 Comment on attachment 138913 Patch that uses hostWindow instead This looks good. But for applications that don’t use a host window, I think we want the union of your previous patch and this one. I think we need both! 610257 6 bdakin 2012-04-25 18:11:06 -0700 Committed both: http://trac.webkit.org/changeset/115271 138907 2012-04-25 17:37:19 -0700 2012-04-25 18:00:51 -0700 Patch for-review-wk1.txt text/plain 1402 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTI2NSkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTI1 ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ5MTMKKyAgICAgICAgV2ViS2l0IDE6IEluaXRp YWxpemUgZGV2aWNlU2NhbGVGYWN0b3Igb24gY3JlYXRpb24gb2YgdGhlIFdlYlZpZXcKKyAgICAg ICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTEzMjI3MTY+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cDov L3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTA3MDE3IHNob3VsZCBiZSBhZG9wdGVkIGZvciBX SzEgYXMgd2VsbC4KKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAgICgtW1dl YlZpZXcgX2luaXRXaXRoRnJhbWU6ZnJhbWVOYW1lOmdyb3VwTmFtZTp1c2VzRG9jdW1lbnRWaWV3 czpdKToKKwogMjAxMi0wNC0yNCAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJv c3NhLm9yZz4KIAogICAgICAgICBSZXBsYWNlIG9jY3VyZW5jZXMgb2Ygc3R5bGUgc2VsZWN0b3Ig ZnJvbSB2YXJpYWJsZXMgYW5kIG1ldGhvZHMgbmFtZXMgYnkgc3R5bGUgcmVzb2x2ZXIuCkluZGV4 OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCShyZXZpc2lvbiAxMTUyMzIpCisrKyBT b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTg0 Niw2ICs4NDYsNyBAQCAtIChpZClfaW5pdFdpdGhGcmFtZTooTlNSZWN0KWYgZnJhbWVOYW1lCiAg ICAgX3ByaXZhdGUgPSBbW1dlYlZpZXdQcml2YXRlIGFsbG9jXSBpbml0XTsKICAgICBbc2VsZiBf Y29tbW9uSW5pdGlhbGl6YXRpb25XaXRoRnJhbWVOYW1lOmZyYW1lTmFtZSBncm91cE5hbWU6Z3Jv dXBOYW1lXTsKICAgICBbc2VsZiBzZXRNYWludGFpbnNCYWNrRm9yd2FyZExpc3Q6IFlFU107Cisg ICAgX3ByaXZhdGUtPnBhZ2UtPnNldERldmljZVNjYWxlRmFjdG9yKFtzZWxmIF9kZXZpY2VTY2Fs ZUZhY3Rvcl0pOwogICAgIHJldHVybiBzZWxmOwogfQogCg== 138913 2012-04-25 18:00:51 -0700 2012-04-25 18:05:22 -0700 Patch that uses hostWindow instead for-review-wk1-2.txt text/plain 2237 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTI2NikKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTI1 ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ5MTMKKyAgICAgICAgV2ViS2l0IDE6IEluaXRp YWxpemUgZGV2aWNlU2NhbGVGYWN0b3Igb24gY3JlYXRpb24gb2YgdGhlIFdlYlZpZXcKKyAgICAg ICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTEzMjI3MTY+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVmb3Jl IHRoaXMgcGF0Y2gsIHdlIHdlcmVuJ3Qgc2V0dGluZyB0aGUgZGV2aWNlU2NhbGVGYWN0b3IgdW50 aWwgCisgICAgICAgIHZpZXdEaWRNb3ZlVG9XaW5kb3cgd2hpY2ggaXMgcXVpdGUgbGF0ZSBmb3Ig YmFja2dyb3VuZCB0YWJzLiBzZXRIb3N0V2luZG93IHdpbGwgCisgICAgICAgIGhhcHBlbiBlYXJs eSBvbiB0aG91Z2guCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtX ZWJWaWV3IHNldEhvc3RXaW5kb3c6XSk6CisgICAgICAgICgtW1dlYlZpZXcgX2RldmljZVNjYWxl RmFjdG9yXSk6CisKIDIwMTItMDQtMjQgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9w ZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmVwbGFjZSBvY2N1cmVuY2VzIG9mIHN0eWxlIHNlbGVj dG9yIGZyb20gdmFyaWFibGVzIGFuZCBtZXRob2RzIG5hbWVzIGJ5IHN0eWxlIHJlc29sdmVyLgpJ bmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24gMTE1MjMyKQor KysgU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBA IC0zOTY0LDYgKzM5NjQsNyBAQCAtICh2b2lkKXNldEhvc3RXaW5kb3c6KE5TV2luZG93ICopaG9z dFdpCiAgICAgX3ByaXZhdGUtPmhvc3RXaW5kb3cgPSBbaG9zdFdpbmRvdyByZXRhaW5dOwogICAg IGZvciAoRnJhbWUqIGZyYW1lID0gY29yZUZyYW1lOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+dHJl ZSgpLT50cmF2ZXJzZU5leHQoY29yZUZyYW1lKSkKICAgICAgICAgW1tba2l0KGZyYW1lKSBmcmFt ZVZpZXddIGRvY3VtZW50Vmlld10gdmlld0RpZE1vdmVUb0hvc3RXaW5kb3ddOworICAgIF9wcml2 YXRlLT5wYWdlLT5zZXREZXZpY2VTY2FsZUZhY3Rvcihbc2VsZiBfZGV2aWNlU2NhbGVGYWN0b3Jd KTsKIH0KIAogLSAoTlNXaW5kb3cgKilob3N0V2luZG93CkBAIC01NjY0LDEzICs1NjY1LDE4IEBA IC0gKGZsb2F0KV9kZXZpY2VTY2FsZUZhY3RvcgogICAgICAgICByZXR1cm4gX3ByaXZhdGUtPmN1 c3RvbURldmljZVNjYWxlRmFjdG9yOwogCiAgICAgTlNXaW5kb3cgKndpbmRvdyA9IFtzZWxmIHdp bmRvd107CisgICAgTlNXaW5kb3cgKmhvc3RXaW5kb3cgPSBbc2VsZiBob3N0V2luZG93XTsKICNp ZiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9T Tk9XX0xFT1BBUkQpCiAgICAgaWYgKHdpbmRvdykKICAgICAgICAgcmV0dXJuIFt3aW5kb3cgYmFj a2luZ1NjYWxlRmFjdG9yXTsKKyAgICBpZiAoaG9zdFdpbmRvdykKKyAgICAgICAgcmV0dXJuIFto b3N0V2luZG93IGJhY2tpbmdTY2FsZUZhY3Rvcl07CiAgICAgcmV0dXJuIFtbTlNTY3JlZW4gbWFp blNjcmVlbl0gYmFja2luZ1NjYWxlRmFjdG9yXTsKICNlbHNlCiAgICAgaWYgKHdpbmRvdykKICAg ICAgICAgcmV0dXJuIFt3aW5kb3cgdXNlclNwYWNlU2NhbGVGYWN0b3JdOworICAgIGlmIChob3N0 V2luZG93KQorICAgICAgICByZXR1cm4gW2hvc3RXaW5kb3cgdXNlclNwYWNlU2NhbGVGYWN0b3Jd OwogICAgIHJldHVybiBbW05TU2NyZWVuIG1haW5TY3JlZW5dIHVzZXJTcGFjZVNjYWxlRmFjdG9y XTsKICNlbmRpZgogfQo=