84898 2012-04-25 15:46:14 -0700 Biolab disaster crashes on ToT 2012-04-25 16:00:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 610109 0 oliver 2012-04-25 15:46:14 -0700 Biolab disaster crashes on ToT 610113 1 138886 oliver 2012-04-25 15:49:31 -0700 Created attachment 138886 Patch 610114 2 138886 fpizlo 2012-04-25 15:52:36 -0700 Comment on attachment 138886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138886&action=review r=me with the simplification > Source/JavaScriptCore/dfg/DFGVirtualRegisterAllocationPhase.cpp:115 > + InlineCallFrame& inlineCallFrame = codeBlock()->inlineCallFrames()[i]; > + CodeBlock* codeBlock = jsCast<FunctionExecutable*>(inlineCallFrame.executable.get())->baselineCodeBlockFor(inlineCallFrame.isCall ? CodeForCall : CodeForConstruct); baselineCodeBlockForInlineCallFrame(&codeBlock()->inlineCallFrames()[i]) 610117 3 oliver 2012-04-25 15:57:15 -0700 Committed r115252: <http://trac.webkit.org/changeset/115252> 610119 4 oliver 2012-04-25 16:00:17 -0700 Committed r115253: <http://trac.webkit.org/changeset/115253> 138886 2012-04-25 15:49:31 -0700 2012-04-25 15:52:36 -0700 Patch bug-84898-20120425154929.patch text/plain 2643 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl NDBjZGU0NzA4Y2I0ODdjYjgwZThmNzExOTEwZWNhZGVhNGYwYTUyLi43MWE0NWQ0MWQzNGYyNGQ3 OTQ4M2MxYThlMTA2ZGJlMTZmZWRlYTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxMi0wNC0yNSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEJpb2xhYiBkaXNhc3RlciBjcmFzaGVzIG9uIFRvVAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ4OTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIHJlY2VudGx5IGFkZGVkIGFuIGFzc2Vy dGlvbiB0byB0aGUgSW50ZXJwcmV0ZXIgdG8gY2F0Y2ggaW5jb3JyZWN0CisgICAgICAgIHVwZGF0 ZXMgb2YgdG9wQ2FsbEZyYW1lLiAgVGhpcyBjYXVzZWQgYSBidW5jaCBvZiBzaXRlcyAoaW5jbHVk aW5nIGJpb2xhYgorICAgICAgICBkaXNhc3RlcikgdG8gY3Jhc2ggYXMgd2Ugd2VyZSBub3QgY29y cmVjdGx5IGhhbmRsaW5nIGNhbGxlZSByZWdpc3RlcnMKKyAgICAgICAgb2YgaW5saW5lZCBmdW5j dGlvbnMsIGxlYWRpbmcgdG8gYSBtaXNtYXRjaC4KKworICAgICAgICBJIGNvdWxkIG5vdCBhY3R1 YWxseSBtYWtlIHRoaXMgdHJpZ2dlciBkaXJlY3RseSwgYWx0aG91Z2ggaXQgZG9lcyB0cmlnZ2Vy CisgICAgICAgIGFscmVhZHkgb24gc29tZSBvZiB0aGUgR1RLIGFuZCBRVCBib3RzLgorCisgICAg ICAgICogZGZnL0RGR1ZpcnR1YWxSZWdpc3RlckFsbG9jYXRpb25QaGFzZS5jcHA6CisgICAgICAg IChKU0M6OkRGRzo6VmlydHVhbFJlZ2lzdGVyQWxsb2NhdGlvblBoYXNlOjpydW4pOgorCiAyMDEy LTA0LTI1ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBEZWxl dGUgQ2FudmFzUGl4ZWxBcnJheSwgQnl0ZUFycmF5LCBKU0J5dGVBcnJheSBhbmQgSlNDIGNvZGUg b25jZSB1bnJlZmVyZW5jZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHVmlydHVhbFJlZ2lzdGVyQWxsb2NhdGlvblBoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHVmlydHVhbFJlZ2lzdGVyQWxsb2NhdGlvblBoYXNlLmNwcAppbmRleCBjMDVj NmIxOWNmZTQ1NTZjOWY4Y2YwNjU5NWY0MmJhZjUxY2RlZDg5Li4yNzA3ZTMyZWZmODg5ZWRmZmNm ZDNiMWRkNzM3MTQ4YzViM2U4Y2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1ZpcnR1YWxSZWdpc3RlckFsbG9jYXRpb25QaGFzZS5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdWaXJ0dWFsUmVnaXN0ZXJBbGxvY2F0aW9uUGhhc2UuY3BwCkBA IC0xMDksNiArMTA5LDE0IEBAIHB1YmxpYzoKICAgICAgICAgLy8gZm9yIHRoZSBmdW5jdGlvbiAo YW5kIGNoZWNrZWQgZm9yIG9uIGVudHJ5KS4gU2luY2Ugd2UgcGVyZm9ybSBhIG5ldyBhbmQKICAg ICAgICAgLy8gZGlmZmVyZW50IGFsbG9jYXRpb24gb2YgdGVtcG9yYXJpZXMsIG1vcmUgcmVnaXN0 ZXJzIG1heSBub3cgYmUgcmVxdWlyZWQuCiAgICAgICAgIHVuc2lnbmVkIGNhbGxlZVJlZ2lzdGVy cyA9IHNjb3JlQm9hcmQuaGlnaFdhdGVybWFyaygpICsgbV9ncmFwaC5tX3BhcmFtZXRlclNsb3Rz OworICAgICAgICBzaXplX3QgaW5saW5lQ2FsbEZyYW1lQ291bnQgPSBjb2RlQmxvY2soKS0+aW5s aW5lQ2FsbEZyYW1lcygpLnNpemUoKTsKKyAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBp bmxpbmVDYWxsRnJhbWVDb3VudDsgaSsrKSB7CisgICAgICAgICAgICBJbmxpbmVDYWxsRnJhbWUm IGlubGluZUNhbGxGcmFtZSA9IGNvZGVCbG9jaygpLT5pbmxpbmVDYWxsRnJhbWVzKClbaV07Cisg ICAgICAgICAgICBDb2RlQmxvY2sqIGNvZGVCbG9jayA9IGpzQ2FzdDxGdW5jdGlvbkV4ZWN1dGFi bGUqPihpbmxpbmVDYWxsRnJhbWUuZXhlY3V0YWJsZS5nZXQoKSktPmJhc2VsaW5lQ29kZUJsb2Nr Rm9yKGlubGluZUNhbGxGcmFtZS5pc0NhbGwgPyBDb2RlRm9yQ2FsbCA6IENvZGVGb3JDb25zdHJ1 Y3QpOworICAgICAgICAgICAgdW5zaWduZWQgcmVxdWlyZWRDYWxsZWVSZWdpc3RlcnMgPSBpbmxp bmVDYWxsRnJhbWUuc3RhY2tPZmZzZXQgKyBjb2RlQmxvY2stPm1fbnVtQ2FsbGVlUmVnaXN0ZXJz OworICAgICAgICAgICAgaWYgKHJlcXVpcmVkQ2FsbGVlUmVnaXN0ZXJzID4gY2FsbGVlUmVnaXN0 ZXJzKQorICAgICAgICAgICAgICAgIGNhbGxlZVJlZ2lzdGVycyA9IHJlcXVpcmVkQ2FsbGVlUmVn aXN0ZXJzOworICAgICAgICB9CiAgICAgICAgIGlmICgodW5zaWduZWQpY29kZUJsb2NrKCktPm1f bnVtQ2FsbGVlUmVnaXN0ZXJzIDwgY2FsbGVlUmVnaXN0ZXJzKQogICAgICAgICAgICAgY29kZUJs b2NrKCktPm1fbnVtQ2FsbGVlUmVnaXN0ZXJzID0gY2FsbGVlUmVnaXN0ZXJzOwogI2lmIERGR19F TkFCTEUoREVCVUdfVkVSQk9TRSkK