84897 2012-04-25 15:39:23 -0700 WebCore shouldn't call collectAllGarbage directly 2012-04-25 22:07:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg benjamin ggaren webkit.review.bot oldest_to_newest 610103 0 mhahnenberg 2012-04-25 15:39:23 -0700 Currently, GCController calls Heap::collectAllGarbage directly, which leads to an overload of collections as the timer in GCController and the timer in GCActivityCallback compete for collection time and fire independently. As a result, we end up doing almost 600 full collections during an in-browser run of SunSpider, or 20 full collections on a single load of TechCrunch. We can do better by preventing WebCore from calling collectAllGarbage directly and instead going through Heap::reportAbandonedObjectGraph, since that is what WebCore is trying to do--notify the Heap that a lot of garbage may have just been generated when we left a page. 610131 1 138891 mhahnenberg 2012-04-25 16:13:27 -0700 Created attachment 138891 Patch 610146 2 mhahnenberg 2012-04-25 16:29:15 -0700 With this patch, we do 133 GCs in a run of in-browser SunSpider running 20 iterations. We used to do 712 collections using this same testing setup. We also do 10 collections vs. 20 collections when loading TechCrunch. 610149 3 mhahnenberg 2012-04-25 16:30:03 -0700 I should also mention that neither our wall clock time nor our benchmark score for in-browser SunSpider are affected by this patch. 610157 4 138891 buildbot 2012-04-25 16:46:36 -0700 Comment on attachment 138891 Patch Attachment 138891 did not pass win-ews (win): Output: http://queues.webkit.org/results/12520704 610166 5 138899 mhahnenberg 2012-04-25 16:55:23 -0700 Created attachment 138899 Patch 610273 6 138899 ggaren 2012-04-25 18:22:16 -0700 Comment on attachment 138899 Patch r=me 610350 7 138899 webkit.review.bot 2012-04-25 22:07:26 -0700 Comment on attachment 138899 Patch Clearing flags on attachment: 138899 Committed r115288: <http://trac.webkit.org/changeset/115288> 610351 8 webkit.review.bot 2012-04-25 22:07:32 -0700 All reviewed patches have been landed. Closing bug. 138891 2012-04-25 16:13:27 -0700 2012-04-25 16:55:11 -0700 Patch bug-84897-20120425161326.patch text/plain 7270 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE1MjU2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTA0LTI1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgV2ViQ29yZSBzaG91bGRuJ3QgY2FsbCBjb2xsZWN0QWxsR2FyYmFnZSBkaXJlY3Rs eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ4OTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGhlYXAv SGVhcC5oOiBFeHBvcnRlZCBzeW1ib2wgZm9yIHJlcG9ydEFiYW5vbmRlZE9iamVjdEdyYXBoIHNv IFdlYkNvcmUgY2FuIHVzZSBpdC4KKwogMjAxMi0wNC0yNSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJA YXBwbGUuY29tPgogCiAgICAgICAgIEJpb2xhYiBkaXNhc3RlciBjcmFzaGVzIG9uIFRvVApJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAkocmV2aXNpb24gMTE1MjUwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTksNyArMTE5 LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHZvaWQgY29sbGVjdChTd2VlcFRvZ2dsZSk7 CiAKICAgICAgICAgdm9pZCByZXBvcnRFeHRyYU1lbW9yeUNvc3Qoc2l6ZV90IGNvc3QpOwotICAg ICAgICB2b2lkIHJlcG9ydEFiYW5kb25lZE9iamVjdEdyYXBoKCk7CisgICAgICAgIEpTX0VYUE9S VF9QUklWQVRFIHZvaWQgcmVwb3J0QWJhbmRvbmVkT2JqZWN0R3JhcGgoKTsKIAogICAgICAgICBK U19FWFBPUlRfUFJJVkFURSB2b2lkIHByb3RlY3QoSlNWYWx1ZSk7CiAgICAgICAgIEpTX0VYUE9S VF9QUklWQVRFIGJvb2wgdW5wcm90ZWN0KEpTVmFsdWUpOyAvLyBUcnVlIHdoZW4gdGhlIHByb3Rl Y3QgY291bnQgZHJvcHMgdG8gMC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTI1NikKKysr IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM0IEBA CisyMDEyLTA0LTI1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgV2ViQ29yZSBzaG91bGRuJ3QgY2FsbCBjb2xsZWN0QWxsR2FyYmFnZSBkaXJlY3Rs eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ4OTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMuIAorCisgICAgICAgIEN1cnJlbnRseSwgR0NDb250cm9sbGVyIGNhbGxzIEhlYXA6OmNv bGxlY3RBbGxHYXJiYWdlIGRpcmVjdGx5LCB3aGljaCBsZWFkcyAKKyAgICAgICAgdG8gYW4gb3Zl cmxvYWQgb2YgY29sbGVjdGlvbnMgYXMgdGhlIHRpbWVyIGluIEdDQ29udHJvbGxlciBhbmQgdGhl IHRpbWVyIGluIAorICAgICAgICBHQ0FjdGl2aXR5Q2FsbGJhY2sgY29tcGV0ZSBmb3IgY29sbGVj dGlvbiB0aW1lIGFuZCBmaXJlIGluZGVwZW5kZW50bHkuIEFzIGEgCisgICAgICAgIHJlc3VsdCwg d2UgZW5kIHVwIGRvaW5nIGFsbW9zdCA2MDAgZnVsbCBjb2xsZWN0aW9ucyBkdXJpbmcgYW4gaW4t YnJvd3NlciBydW4gCisgICAgICAgIG9mIFN1blNwaWRlciwgb3IgMjAgZnVsbCBjb2xsZWN0aW9u cyBvbiBhIHNpbmdsZSBsb2FkIG9mIFRlY2hDcnVuY2guIAorCisgICAgICAgIFdlIGNhbiBkbyBi ZXR0ZXIgYnkgcHJldmVudGluZyBXZWJDb3JlIGZyb20gY2FsbGluZyBjb2xsZWN0QWxsR2FyYmFn ZSBkaXJlY3RseSAKKyAgICAgICAgYW5kIGluc3RlYWQgZ29pbmcgdGhyb3VnaCBIZWFwOjpyZXBv cnRBYmFuZG9uZWRPYmplY3RHcmFwaCwgc2luY2UgdGhhdCBpcyB3aGF0IAorICAgICAgICBXZWJD b3JlIGlzIHRyeWluZyB0byBkby0tbm90aWZ5IHRoZSBIZWFwIHRoYXQgYSBsb3Qgb2YgZ2FyYmFn ZSBtYXkgaGF2ZSBqdXN0IAorICAgICAgICBiZWVuIGdlbmVyYXRlZCB3aGVuIHdlIGxlZnQgYSBw YWdlLgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisgICAgICAgICogYmluZGluZ3MvanMv R0NDb250cm9sbGVyLmNwcDogUmVtb3ZlZCBhbGwgdGltZXIgc3R1ZmYuCisgICAgICAgIChXZWJD b3JlOjpHQ0NvbnRyb2xsZXI6OkdDQ29udHJvbGxlcik6CisgICAgICAgIChXZWJDb3JlOjpHQ0Nv bnRyb2xsZXI6OmdhcmJhZ2VDb2xsZWN0U29vbik6IENoYW5nZWQgdG8gY2FsbCBIZWFwOjpyZXBv cnRBYmFuZG9uZWRPYmplY3RHcmFwaC4KKyAgICAgICAgKFdlYkNvcmU6OkdDQ29udHJvbGxlcjo6 Z2FyYmFnZUNvbGxlY3ROb3cpOiBDaGFuZ2VkIHRvIHN0aWxsIGRpcmVjdGx5IGNhbGwgY29sbGVj dEFsbEdhcmJhZ2UuCisgICAgICAgIFdlIHdpbGwgZGVwcmVjYXRlIHRoaXMgZnVuY3Rpb24gc29v biBob3BlZnVsbHkuCisgICAgICAgICogYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmg6IFJlbW92 ZWQgdGltZXIgc3R1ZmYuCisgICAgICAgIChHQ0NvbnRyb2xsZXIpOgorICAgICAgICAqIGJpbmRp bmdzL2pzL1NjcmlwdFByb2ZpbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFByb2Zp bGVyOjpjb2xsZWN0R2FyYmFnZSk6IENoYW5nZWQgdG8gY2FsbCBnYXJiYWdlQ29sbGVjdFNvb24u CisKIDIwMTItMDQtMjUgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAg ICAgIFRyeSB0byBmaXggYnVpbGQgd2l0aCBTVFlMRV9TQ09QRUQgZW5hYmxlZC4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L1dlYkNvcmUuZXhwLmluCShyZXZpc2lvbiAxMTUyNTApCisrKyBTb3VyY2UvV2ViQ29yZS9XZWJD b3JlLmV4cC5pbgkod29ya2luZyBjb3B5KQpAQCAtMjUwLDYgKzI1MCw3IEBAIF9fWk43V2ViQ29y ZTEyRXZlbnRIYW5kbGVyOGtleUV2ZW50RVA3TlMKIF9fWk43V2ViQ29yZTEyRXZlbnRIYW5kbGVy OGtleUV2ZW50RVJLTlNfMjFQbGF0Zm9ybUtleWJvYXJkRXZlbnRFCiBfX1pON1dlYkNvcmUxMkV2 ZW50SGFuZGxlcjltb3VzZURvd25FUDdOU0V2ZW50CiBfX1pON1dlYkNvcmUxMkdDQ29udHJvbGxl cjE3Z2FyYmFnZUNvbGxlY3ROb3dFdgorX19aTjdXZWJDb3JlMTJHQ0NvbnRyb2xsZXIxOGdhcmJh Z2VDb2xsZWN0U29vbkV2CiBfX1pON1dlYkNvcmUxMkdDQ29udHJvbGxlcjQzZ2FyYmFnZUNvbGxl Y3RPbkFsdGVybmF0ZVRocmVhZEZvckRlYnVnZ2luZ0ViCiBfX1pON1dlYkNvcmUxMlBvcHVwTWVu dU1hY0MxRVBOU18xNVBvcHVwTWVudUNsaWVudEUKIF9fWk43V2ViQ29yZTEyUHJpbnRDb250ZXh0 MTJwYWdlUHJvcGVydHlFUE5TXzVGcmFtZUVQS2NpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHAJKHJldmlzaW9uIDExNTI1MCkKKysrIFNvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5 LDI2ICs0OSwyMCBAQCBHQ0NvbnRyb2xsZXImIGdjQ29udHJvbGxlcigpCiB9CiAKIEdDQ29udHJv bGxlcjo6R0NDb250cm9sbGVyKCkKLSAgICA6IG1fR0NUaW1lcih0aGlzLCAmR0NDb250cm9sbGVy OjpnY1RpbWVyRmlyZWQpCiB7CiB9CiAKIHZvaWQgR0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVj dFNvb24oKQogewotICAgIGlmICghbV9HQ1RpbWVyLmlzQWN0aXZlKCkpCi0gICAgICAgIG1fR0NU aW1lci5zdGFydE9uZVNob3QoMCk7Ci19Ci0KLXZvaWQgR0NDb250cm9sbGVyOjpnY1RpbWVyRmly ZWQoVGltZXI8R0NDb250cm9sbGVyPiopCi17Ci0gICAgY29sbGVjdCgwKTsKKyAgICBKU0xvY2sg bG9jayhTaWxlbmNlQXNzZXJ0aW9uc09ubHkpOworICAgIEpTRE9NV2luZG93Ojpjb21tb25KU0ds b2JhbERhdGEoKS0+aGVhcC5yZXBvcnRBYmFuZG9uZWRPYmplY3RHcmFwaCgpOwogfQogCiB2b2lk IEdDQ29udHJvbGxlcjo6Z2FyYmFnZUNvbGxlY3ROb3coKQogewogICAgIEpTTG9jayBsb2NrKFNp bGVuY2VBc3NlcnRpb25zT25seSk7CiAgICAgaWYgKCFKU0RPTVdpbmRvdzo6Y29tbW9uSlNHbG9i YWxEYXRhKCktPmhlYXAuaXNCdXN5KCkpCi0gICAgICAgIGNvbGxlY3QoMCk7CisgICAgICAgIEpT RE9NV2luZG93Ojpjb21tb25KU0dsb2JhbERhdGEoKS0+aGVhcC5jb2xsZWN0QWxsR2FyYmFnZSgp OwogfQogCiB2b2lkIEdDQ29udHJvbGxlcjo6Z2FyYmFnZUNvbGxlY3RPbkFsdGVybmF0ZVRocmVh ZEZvckRlYnVnZ2luZyhib29sIHdhaXRVbnRpbERvbmUpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuaAkocmV2aXNpb24gMTE1MjUwKQorKysgU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTI2LDcg KzI2LDggQEAKICNpZm5kZWYgR0NDb250cm9sbGVyX2gKICNkZWZpbmUgR0NDb250cm9sbGVyX2gK IAotI2luY2x1ZGUgIlRpbWVyLmgiCisjaW5jbHVkZSA8d3RmL0Zhc3RBbGxvY0Jhc2UuaD4KKyNp bmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC00 NCw5ICs0NSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgIHByaXZhdGU6CiAgICAgICAg IEdDQ29udHJvbGxlcigpOyAvLyBVc2UgZ2NDb250cm9sbGVyKCkgaW5zdGVhZAotICAgICAgICB2 b2lkIGdjVGltZXJGaXJlZChUaW1lcjxHQ0NvbnRyb2xsZXI+Kik7Ci0gICAgICAgIAotICAgICAg ICBUaW1lcjxHQ0NvbnRyb2xsZXI+IG1fR0NUaW1lcjsKICAgICB9OwogCiAgICAgLy8gRnVuY3Rp b24gdG8gb2J0YWluIHRoZSBnbG9iYWwgR0MgY29udHJvbGxlci4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL1NjcmlwdFByb2ZpbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRQcm9maWxlci5jcHAJKHJldmlzaW9uIDExNTI1MCkK KysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFByb2ZpbGVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDMsNyArNDMsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHZvaWQgU2Ny aXB0UHJvZmlsZXI6OmNvbGxlY3RHYXJiYWdlKCkKIHsKLSAgICBnY0NvbnRyb2xsZXIoKS5nYXJi YWdlQ29sbGVjdE5vdygpOworICAgIGdjQ29udHJvbGxlcigpLmdhcmJhZ2VDb2xsZWN0U29vbigp OwogfQogCiBTY3JpcHRPYmplY3QgU2NyaXB0UHJvZmlsZXI6Om9iamVjdEJ5SGVhcE9iamVjdElk KHVuc2lnbmVkKQpJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMTE1MjU2KQorKysgU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDQt MjUgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KKworICAgICAgICBX ZWJDb3JlIHNob3VsZG4ndCBjYWxsIGNvbGxlY3RBbGxHYXJiYWdlIGRpcmVjdGx5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDg5NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ cm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6ZGlkQ2xvc2UpOiBDaGFu Z2VkIHRvIGNhbGwgZ2FyYmFnZUNvbGxlY3RTb29uLiBUaGlzIGlzIHRoZSAKKyAgICAgICAgZnVu Y3Rpb24gdGhhdCBjYXVzZXMgdXMgdG8gZG8gc28gbXVjaCBjb2xsZWN0aW9uIG9uIHBhZ2UgbmF2 aWdhdGlvbi4KKwogMjAxMi0wNC0yNSAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29t PgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxMTA0OTQpOiBEcmFnZ2luZyBpbWFnZXMgZnJvbSBT YWZhcmkgdG8gRmluZGVyIHJlc3VsdHMgaW4gLndlYmxvYyByYXRoZXIgdGhhbiBpbWFnZSBmaWxl CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHJldmlzaW9u IDExNTI1MCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTY4Niw3ICs2ODYsNyBAQCB2b2lkIFdlYlByb2Nlc3M6OmRpZENsb3Nl KENvcmVJUEM6OkNvbm5lCiAgICAgICAgIHBhZ2VzW2ldLT5jbG9zZSgpOwogICAgIHBhZ2VzLmNs ZWFyKCk7CiAKLSAgICBnY0NvbnRyb2xsZXIoKS5nYXJiYWdlQ29sbGVjdE5vdygpOworICAgIGdj Q29udHJvbGxlcigpLmdhcmJhZ2VDb2xsZWN0U29vbigpOwogICAgIG1lbW9yeUNhY2hlKCktPnNl dERpc2FibGVkKHRydWUpOwogI2VuZGlmICAgIAogCg== 138899 2012-04-25 16:55:23 -0700 2012-04-25 22:07:26 -0700 Patch bug-84897-20120425165522.patch text/plain 8177 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE1MjYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTA0LTI1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgV2ViQ29yZSBzaG91bGRuJ3QgY2FsbCBjb2xsZWN0QWxsR2FyYmFnZSBkaXJlY3Rs eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ4OTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEphdmFT Y3JpcHRDb3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWY6IEV4cG9y dGVkIHN5bWJvbCAKKyAgICAgICAgZm9yIHJlcG9ydEFiYW5vbmRlZE9iamVjdEdyYXBoIHNvIFdl YkNvcmUgY2FuIHVzZSBpdC4KKyAgICAgICAgKiBoZWFwL0hlYXAuaDogRGl0dG8uCisKIDIwMTIt MDQtMjUgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBCaW9sYWIg ZGlzYXN0ZXIgY3Jhc2hlcyBvbiBUb1QKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZh U2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZGVmCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZGVmCShyZXZpc2lvbiAxMTUyNTApCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHRDb3JlLmRlZgkod29ya2luZyBjb3B5KQpAQCAtMjgwLDYgKzI4MCw3IEBAIEVYUE9S VFMKICAgICA/cmVsZWFzZURlY29tbWl0dGVkQE9TQWxsb2NhdG9yQFdURkBAU0FYUEFYSUBaCiAg ICAgP3JlbGVhc2VFeGVjdXRhYmxlTWVtb3J5QEpTR2xvYmFsRGF0YUBKU0NAQFFBRVhYWgogICAg ID9yZW1vdmVCbG9ja0BNYXJrZWRBbGxvY2F0b3JASlNDQEBRQUVYUEFWTWFya2VkQmxvY2tAMkBA WgorICAgID9yZXBvcnRBYmFuZG9uZWRPYmplY3RHcmFwaEBIZWFwQEpTQ0BAUUFFWFhaCiAgICAg P3JlcG9ydEV4dHJhTWVtb3J5Q29zdFNsb3dDYXNlQEhlYXBASlNDQEBBQUVYSUBaCiAgICAgP3Jl c2VydmVBbmRDb21taXRAT1NBbGxvY2F0b3JAV1RGQEBTQVBBWElXNFVzYWdlQDEyQF9OMTFAWgog ICAgID9yZXNlcnZlQ2FwYWNpdHlAU3RyaW5nQnVpbGRlckBXVEZAQFFBRVhJQFoKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgJKHJldmlzaW9uIDExNTI1MCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL0hlYXAuaAkod29ya2luZyBjb3B5KQpAQCAtMTE5LDcgKzExOSw3IEBA IG5hbWVzcGFjZSBKU0MgewogICAgICAgICB2b2lkIGNvbGxlY3QoU3dlZXBUb2dnbGUpOwogCiAg ICAgICAgIHZvaWQgcmVwb3J0RXh0cmFNZW1vcnlDb3N0KHNpemVfdCBjb3N0KTsKLSAgICAgICAg dm9pZCByZXBvcnRBYmFuZG9uZWRPYmplY3RHcmFwaCgpOworICAgICAgICBKU19FWFBPUlRfUFJJ VkFURSB2b2lkIHJlcG9ydEFiYW5kb25lZE9iamVjdEdyYXBoKCk7CiAKICAgICAgICAgSlNfRVhQ T1JUX1BSSVZBVEUgdm9pZCBwcm90ZWN0KEpTVmFsdWUpOwogICAgICAgICBKU19FWFBPUlRfUFJJ VkFURSBib29sIHVucHJvdGVjdChKU1ZhbHVlKTsgLy8gVHJ1ZSB3aGVuIHRoZSBwcm90ZWN0IGNv dW50IGRyb3BzIHRvIDAuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTUyNjApCisrKyBTb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwzNCBAQAorMjAx Mi0wNC0yNSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgorCisgICAg ICAgIFdlYkNvcmUgc2hvdWxkbid0IGNhbGwgY29sbGVjdEFsbEdhcmJhZ2UgZGlyZWN0bHkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0ODk3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LiAKKworICAgICAgICBDdXJyZW50bHksIEdDQ29udHJvbGxlciBjYWxscyBIZWFwOjpjb2xsZWN0 QWxsR2FyYmFnZSBkaXJlY3RseSwgd2hpY2ggbGVhZHMgCisgICAgICAgIHRvIGFuIG92ZXJsb2Fk IG9mIGNvbGxlY3Rpb25zIGFzIHRoZSB0aW1lciBpbiBHQ0NvbnRyb2xsZXIgYW5kIHRoZSB0aW1l ciBpbiAKKyAgICAgICAgR0NBY3Rpdml0eUNhbGxiYWNrIGNvbXBldGUgZm9yIGNvbGxlY3Rpb24g dGltZSBhbmQgZmlyZSBpbmRlcGVuZGVudGx5LiBBcyBhIAorICAgICAgICByZXN1bHQsIHdlIGVu ZCB1cCBkb2luZyBhbG1vc3QgNjAwIGZ1bGwgY29sbGVjdGlvbnMgZHVyaW5nIGFuIGluLWJyb3dz ZXIgcnVuIAorICAgICAgICBvZiBTdW5TcGlkZXIsIG9yIDIwIGZ1bGwgY29sbGVjdGlvbnMgb24g YSBzaW5nbGUgbG9hZCBvZiBUZWNoQ3J1bmNoLiAKKworICAgICAgICBXZSBjYW4gZG8gYmV0dGVy IGJ5IHByZXZlbnRpbmcgV2ViQ29yZSBmcm9tIGNhbGxpbmcgY29sbGVjdEFsbEdhcmJhZ2UgZGly ZWN0bHkgCisgICAgICAgIGFuZCBpbnN0ZWFkIGdvaW5nIHRocm91Z2ggSGVhcDo6cmVwb3J0QWJh bmRvbmVkT2JqZWN0R3JhcGgsIHNpbmNlIHRoYXQgaXMgd2hhdCAKKyAgICAgICAgV2ViQ29yZSBp cyB0cnlpbmcgdG8gZG8tLW5vdGlmeSB0aGUgSGVhcCB0aGF0IGEgbG90IG9mIGdhcmJhZ2UgbWF5 IGhhdmUganVzdCAKKyAgICAgICAgYmVlbiBnZW5lcmF0ZWQgd2hlbiB3ZSBsZWZ0IGEgcGFnZS4K KworICAgICAgICAqIFdlYkNvcmUuZXhwLmluOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0dDQ29u dHJvbGxlci5jcHA6IFJlbW92ZWQgYWxsIHRpbWVyIHN0dWZmLgorICAgICAgICAoV2ViQ29yZTo6 R0NDb250cm9sbGVyOjpHQ0NvbnRyb2xsZXIpOgorICAgICAgICAoV2ViQ29yZTo6R0NDb250cm9s bGVyOjpnYXJiYWdlQ29sbGVjdFNvb24pOiBDaGFuZ2VkIHRvIGNhbGwgSGVhcDo6cmVwb3J0QWJh bmRvbmVkT2JqZWN0R3JhcGguCisgICAgICAgIChXZWJDb3JlOjpHQ0NvbnRyb2xsZXI6OmdhcmJh Z2VDb2xsZWN0Tm93KTogQ2hhbmdlZCB0byBzdGlsbCBkaXJlY3RseSBjYWxsIGNvbGxlY3RBbGxH YXJiYWdlLgorICAgICAgICBXZSB3aWxsIGRlcHJlY2F0ZSB0aGlzIGZ1bmN0aW9uIHNvb24gaG9w ZWZ1bGx5LgorICAgICAgICAqIGJpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5oOiBSZW1vdmVkIHRp bWVyIHN0dWZmLgorICAgICAgICAoR0NDb250cm9sbGVyKToKKyAgICAgICAgKiBiaW5kaW5ncy9q cy9TY3JpcHRQcm9maWxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRQcm9maWxlcjo6 Y29sbGVjdEdhcmJhZ2UpOiBDaGFuZ2VkIHRvIGNhbGwgZ2FyYmFnZUNvbGxlY3RTb29uLgorCiAy MDEyLTA0LTI1ICBEb3VnbGFzIFN0b2Nrd2VsbCAgPGRzdG9ja3dlbGxAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIEluZGV4ZWREQjogY3Vyc29yIGRvZXMgbm90IGNvcnJlY3RseSBpdGVyYXRlIG92 ZXIga2V5cyBhZGRlZCBhbmQgcmVtb3ZlZCBkdXJpbmcgaXRlcmF0aW9uCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmV4cC5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9XZWJD b3JlLmV4cC5pbgkocmV2aXNpb24gMTE1MjUwKQorKysgU291cmNlL1dlYkNvcmUvV2ViQ29yZS5l eHAuaW4JKHdvcmtpbmcgY29weSkKQEAgLTI1MCw2ICsyNTAsNyBAQCBfX1pON1dlYkNvcmUxMkV2 ZW50SGFuZGxlcjhrZXlFdmVudEVQN05TCiBfX1pON1dlYkNvcmUxMkV2ZW50SGFuZGxlcjhrZXlF dmVudEVSS05TXzIxUGxhdGZvcm1LZXlib2FyZEV2ZW50RQogX19aTjdXZWJDb3JlMTJFdmVudEhh bmRsZXI5bW91c2VEb3duRVA3TlNFdmVudAogX19aTjdXZWJDb3JlMTJHQ0NvbnRyb2xsZXIxN2dh cmJhZ2VDb2xsZWN0Tm93RXYKK19fWk43V2ViQ29yZTEyR0NDb250cm9sbGVyMThnYXJiYWdlQ29s bGVjdFNvb25FdgogX19aTjdXZWJDb3JlMTJHQ0NvbnRyb2xsZXI0M2dhcmJhZ2VDb2xsZWN0T25B bHRlcm5hdGVUaHJlYWRGb3JEZWJ1Z2dpbmdFYgogX19aTjdXZWJDb3JlMTJQb3B1cE1lbnVNYWND MUVQTlNfMTVQb3B1cE1lbnVDbGllbnRFCiBfX1pON1dlYkNvcmUxMlByaW50Q29udGV4dDEycGFn ZVByb3BlcnR5RVBOU181RnJhbWVFUEtjaQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvR0NDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9HQ0NvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxMTUyNTApCisrKyBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OSwyNiAr NDksMjAgQEAgR0NDb250cm9sbGVyJiBnY0NvbnRyb2xsZXIoKQogfQogCiBHQ0NvbnRyb2xsZXI6 OkdDQ29udHJvbGxlcigpCi0gICAgOiBtX0dDVGltZXIodGhpcywgJkdDQ29udHJvbGxlcjo6Z2NU aW1lckZpcmVkKQogewogfQogCiB2b2lkIEdDQ29udHJvbGxlcjo6Z2FyYmFnZUNvbGxlY3RTb29u KCkKIHsKLSAgICBpZiAoIW1fR0NUaW1lci5pc0FjdGl2ZSgpKQotICAgICAgICBtX0dDVGltZXIu c3RhcnRPbmVTaG90KDApOwotfQotCi12b2lkIEdDQ29udHJvbGxlcjo6Z2NUaW1lckZpcmVkKFRp bWVyPEdDQ29udHJvbGxlcj4qKQotewotICAgIGNvbGxlY3QoMCk7CisgICAgSlNMb2NrIGxvY2so U2lsZW5jZUFzc2VydGlvbnNPbmx5KTsKKyAgICBKU0RPTVdpbmRvdzo6Y29tbW9uSlNHbG9iYWxE YXRhKCktPmhlYXAucmVwb3J0QWJhbmRvbmVkT2JqZWN0R3JhcGgoKTsKIH0KIAogdm9pZCBHQ0Nv bnRyb2xsZXI6OmdhcmJhZ2VDb2xsZWN0Tm93KCkKIHsKICAgICBKU0xvY2sgbG9jayhTaWxlbmNl QXNzZXJ0aW9uc09ubHkpOwogICAgIGlmICghSlNET01XaW5kb3c6OmNvbW1vbkpTR2xvYmFsRGF0 YSgpLT5oZWFwLmlzQnVzeSgpKQotICAgICAgICBjb2xsZWN0KDApOworICAgICAgICBKU0RPTVdp bmRvdzo6Y29tbW9uSlNHbG9iYWxEYXRhKCktPmhlYXAuY29sbGVjdEFsbEdhcmJhZ2UoKTsKIH0K IAogdm9pZCBHQ0NvbnRyb2xsZXI6OmdhcmJhZ2VDb2xsZWN0T25BbHRlcm5hdGVUaHJlYWRGb3JE ZWJ1Z2dpbmcoYm9vbCB3YWl0VW50aWxEb25lKQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvR0NDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvR0NDb250cm9sbGVyLmgJKHJldmlzaW9uIDExNTI1MCkKKysrIFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw3ICsyNiw4 IEBACiAjaWZuZGVmIEdDQ29udHJvbGxlcl9oCiAjZGVmaW5lIEdDQ29udHJvbGxlcl9oCiAKLSNp bmNsdWRlICJUaW1lci5oIgorI2luY2x1ZGUgPHd0Zi9GYXN0QWxsb2NCYXNlLmg+CisjaW5jbHVk ZSA8d3RmL05vbmNvcHlhYmxlLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtNDQsOSAr NDUsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICBwcml2YXRlOgogICAgICAgICBHQ0Nv bnRyb2xsZXIoKTsgLy8gVXNlIGdjQ29udHJvbGxlcigpIGluc3RlYWQKLSAgICAgICAgdm9pZCBn Y1RpbWVyRmlyZWQoVGltZXI8R0NDb250cm9sbGVyPiopOwotICAgICAgICAKLSAgICAgICAgVGlt ZXI8R0NDb250cm9sbGVyPiBtX0dDVGltZXI7CiAgICAgfTsKIAogICAgIC8vIEZ1bmN0aW9uIHRv IG9idGFpbiB0aGUgZ2xvYmFsIEdDIGNvbnRyb2xsZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9TY3JpcHRQcm9maWxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvU2NyaXB0UHJvZmlsZXIuY3BwCShyZXZpc2lvbiAxMTUyNTApCisrKyBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRQcm9maWxlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQzLDcgKzQzLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB2b2lkIFNjcmlwdFBy b2ZpbGVyOjpjb2xsZWN0R2FyYmFnZSgpCiB7Ci0gICAgZ2NDb250cm9sbGVyKCkuZ2FyYmFnZUNv bGxlY3ROb3coKTsKKyAgICBnY0NvbnRyb2xsZXIoKS5nYXJiYWdlQ29sbGVjdFNvb24oKTsKIH0K IAogU2NyaXB0T2JqZWN0IFNjcmlwdFByb2ZpbGVyOjpvYmplY3RCeUhlYXBPYmplY3RJZCh1bnNp Z25lZCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTI2MCkKKysrIFNvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0LTI1ICBN YXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViQ29y ZSBzaG91bGRuJ3QgY2FsbCBjb2xsZWN0QWxsR2FyYmFnZSBkaXJlY3RseQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ4OTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUHJvY2Vz cy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OmRpZENsb3NlKTogQ2hhbmdlZCB0 byBjYWxsIGdhcmJhZ2VDb2xsZWN0U29vbi4gVGhpcyBpcyB0aGUgCisgICAgICAgIGZ1bmN0aW9u IHRoYXQgY2F1c2VzIHVzIHRvIGRvIHNvIG11Y2ggY29sbGVjdGlvbiBvbiBwYWdlIG5hdmlnYXRp b24uCisKIDIwMTItMDQtMjUgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OIChyMTEwNDk0KTogRHJhZ2dpbmcgaW1hZ2VzIGZyb20gU2FmYXJp IHRvIEZpbmRlciByZXN1bHRzIGluIC53ZWJsb2MgcmF0aGVyIHRoYW4gaW1hZ2UgZmlsZQpJbmRl eDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCShyZXZpc2lvbiAxMTUy NTApCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC02ODYsNyArNjg2LDcgQEAgdm9pZCBXZWJQcm9jZXNzOjpkaWRDbG9zZShDb3Jl SVBDOjpDb25uZQogICAgICAgICBwYWdlc1tpXS0+Y2xvc2UoKTsKICAgICBwYWdlcy5jbGVhcigp OwogCi0gICAgZ2NDb250cm9sbGVyKCkuZ2FyYmFnZUNvbGxlY3ROb3coKTsKKyAgICBnY0NvbnRy b2xsZXIoKS5nYXJiYWdlQ29sbGVjdFNvb24oKTsKICAgICBtZW1vcnlDYWNoZSgpLT5zZXREaXNh YmxlZCh0cnVlKTsKICNlbmRpZiAgICAKIAo=