84896 2012-04-25 15:29:54 -0700 Remove unnecessary timeouts (and closures) from content-element-in-* tests. 2012-04-25 18:16:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov eric.carlson feature-media-reviews ojan shinyak webkit.review.bot oldest_to_newest 610095 0 dglazkov 2012-04-25 15:29:54 -0700 Remove unnecessary timeouts (and closures) from content-element-in-* tests. 610096 1 138884 dglazkov 2012-04-25 15:31:29 -0700 Created attachment 138884 Patch 610100 2 dglazkov 2012-04-25 15:33:52 -0700 Ojan, help me cleanse my sins. 610104 3 138884 ojan 2012-04-25 15:39:54 -0700 Comment on attachment 138884 Patch setTimeout-- 610263 4 138884 webkit.review.bot 2012-04-25 18:15:56 -0700 Comment on attachment 138884 Patch Clearing flags on attachment: 138884 Committed r115273: <http://trac.webkit.org/changeset/115273> 610264 5 webkit.review.bot 2012-04-25 18:16:01 -0700 All reviewed patches have been landed. Closing bug. 138884 2012-04-25 15:31:29 -0700 2012-04-25 18:15:56 -0700 Patch bug-84896-20120425153128.patch text/plain 5691 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MjM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzYxMjhmNGIwNzlmNDVkNjg1MDUy M2QyZGVmZTg0MmJiMDY4YWQ2My4uOTVhZWM2OWZjZjVlODRmYjJhYjQyMzJiYjdmNTliOWE4OWUw ZmEyMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTI1ICBEaW1pdHJpIEdsYXprb3Yg IDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5IHRp bWVvdXRzIChhbmQgY2xvc3VyZXMpIGZyb20gY29udGVudC1lbGVtZW50LWluLSogdGVzdHMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDg5NgorCisg ICAgICAgIFRoZXNlIHRlc3RzIGRvbid0IG5lZWQgYW55IG9mIHRoZW0uIE5vdCBzdXJlIGhvdyB0 aGV5IGdvdCB0aGVyZSBpbiB0aGUgZmlyc3QgcGxhY2UuIE9oIHdhaXQuIEkgcmV2aWV3ZWQgdGhp cyBjb2RlLiAvbWUgaGFuZHMgaGVhZCBpbiBzaGFtZS4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9tL3NoYWRvdy9jb250ZW50LWVsZW1l bnQtaW4tbWVkaWEtZWxlbWVudC5odG1sOiBSZW1vdmVkIHRoZSB0aW1lb3V0IGFuZCBleHRyYSBj bG9zdXJlcy4KKyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvY29udGVudC1lbGVtZW50LWluLW1l dGVyLWVsZW1lbnQuaHRtbDogRGl0dG8uCisgICAgICAgICogZmFzdC9kb20vc2hhZG93L2NvbnRl bnQtZWxlbWVudC1pbi1wcm9ncmVzcy1lbGVtZW50Lmh0bWw6IERpdHRvLgorICAgICAgICAqIGZh c3QvZG9tL3NoYWRvdy9jb250ZW50LWVsZW1lbnQtaW4tc2VsZWN0LWVsZW1lbnQuaHRtbDogRGl0 dG8uCisKIDIwMTItMDQtMjUgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFVzZSB0aGUgc2FtZSByZXN1bHRzIGZvciBmYXN0L2h0bWwvZGV0YWlscy1tYXJrZXIt c3R5bGUuaHRtbCBvbiBhbGwgbWFjIGJvdHMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2RvbS9zaGFkb3cvY29udGVudC1lbGVtZW50LWluLW1lZGlhLWVsZW1lbnQuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9jb250ZW50LWVsZW1lbnQtaW4tbWVkaWEtZWxlbWVudC5o dG1sCmluZGV4IGIwYjEwN2I1MThiNzM3NjQwZDhmOGM4MzYyMzEwZDJjNjY3MTIzMzYuLjNiYTky YjA5YjNhNzU3ZTIzYTQ4MzhjMTM2ZGMyZjgxYjE3MGRkYWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3QvZG9tL3NoYWRvdy9jb250ZW50LWVsZW1lbnQtaW4tbWVkaWEtZWxlbWVudC5odG1s CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9jb250ZW50LWVsZW1lbnQtaW4tbWVk aWEtZWxlbWVudC5odG1sCkBAIC0yOSwxNyArMjksMTIgQEAgdGVzdEZ1bmNzLnB1c2goZnVuY3Rp b24gY29udGVudEVsZW1lbnRJblZpZGVvRWxlbWVudChjYWxsSWZEb25lKSB7CiAKICAgICB2YXIg c3IgPSBuZXcgV2ViS2l0U2hhZG93Um9vdChkaXYpOwogCi0gICAgdmFyIGYgPSAoZnVuY3Rpb24o c3IsIGNhbGxJZkRvbmUpIHsKLSAgICAgICAgcmV0dXJuIGZ1bmN0aW9uKCkgewotICAgICAgICAg ICAgdmFyIHZpZGVvID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndmlkZW8nKTsKLSAgICAgICAg ICAgIHZhciBjb250ZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnY29udGVudCcpOwotICAg ICAgICAgICAgdmlkZW8uYXBwZW5kQ2hpbGQoY29udGVudCk7Ci0gICAgICAgICAgICBzci5hcHBl bmRDaGlsZCh2aWRlbyk7Ci0gICAgICAgICAgICBjYWxsSWZEb25lKCk7Ci0gICAgICAgIH07Ci0g ICAgfSkoc3IsIGNhbGxJZkRvbmUpOwotCi0gICAgc2V0VGltZW91dChmLCAwKTsKKyAgICB2YXIg dmlkZW8gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCd2aWRlbycpOworICAgIHZhciBjb250ZW50 ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnY29udGVudCcpOworICAgIHZpZGVvLmFwcGVuZENo aWxkKGNvbnRlbnQpOworICAgIHNyLmFwcGVuZENoaWxkKHZpZGVvKTsKKyAgICBkb2N1bWVudC5i b2R5Lm9mZnNldFdpZHRoOyAvLyBmb3JjZSBzdHlsZSByZWNhbGMuCisgICAgY2FsbElmRG9uZSgp OwogfSk7CiAKIDwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hh ZG93L2NvbnRlbnQtZWxlbWVudC1pbi1tZXRlci1lbGVtZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2RvbS9zaGFkb3cvY29udGVudC1lbGVtZW50LWluLW1ldGVyLWVsZW1lbnQuaHRtbAppbmRl eCBjZjNlNzAxMjA0MmVjZmEzYWUyNWUyNTJlMTg4MDhmOTNlZmVhOWFhLi4yZjA4YTIwNzU0Yzc2 YzM2MDU5MDQ4NTYxNDU5ZjcxNDhkNjUwNDE5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L2RvbS9zaGFkb3cvY29udGVudC1lbGVtZW50LWluLW1ldGVyLWVsZW1lbnQuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvY29udGVudC1lbGVtZW50LWluLW1ldGVyLWVsZW1l bnQuaHRtbApAQCAtMjksMTcgKzI5LDEyIEBAIHRlc3RGdW5jcy5wdXNoKGZ1bmN0aW9uIGNvbnRl bnRFbGVtZW50SW5NZXRlckVsZW1lbnQoY2FsbElmRG9uZSkgewogCiAgICAgdmFyIHNyID0gbmV3 IFdlYktpdFNoYWRvd1Jvb3QoZGl2KTsKIAotICAgIHZhciBmID0gKGZ1bmN0aW9uKHNyLCBjYWxs SWZEb25lKSB7Ci0gICAgICAgIHJldHVybiBmdW5jdGlvbigpIHsKLSAgICAgICAgICAgIHZhciBt ZXRlciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ21ldGVyJyk7Ci0gICAgICAgICAgICB2YXIg Y29udGVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2NvbnRlbnQnKTsKLSAgICAgICAgICAg IG1ldGVyLmFwcGVuZENoaWxkKGNvbnRlbnQpOwotICAgICAgICAgICAgc3IuYXBwZW5kQ2hpbGQo bWV0ZXIpOwotICAgICAgICAgICAgY2FsbElmRG9uZSgpOwotICAgICAgICB9OwotICAgIH0pKHNy LCBjYWxsSWZEb25lKTsKLQotICAgIHNldFRpbWVvdXQoZiwgMCk7CisgICAgdmFyIG1ldGVyID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnbWV0ZXInKTsKKyAgICB2YXIgY29udGVudCA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoJ2NvbnRlbnQnKTsKKyAgICBtZXRlci5hcHBlbmRDaGlsZChjb250 ZW50KTsKKyAgICBzci5hcHBlbmRDaGlsZChtZXRlcik7CisgICAgZG9jdW1lbnQuYm9keS5vZmZz ZXRXaWR0aDsgLy8gZm9yY2Ugc3R5bGUgcmVjYWxjLgorICAgIGNhbGxJZkRvbmUoKTsKIH0pOwog CiA8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9jb250 ZW50LWVsZW1lbnQtaW4tcHJvZ3Jlc3MtZWxlbWVudC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9k b20vc2hhZG93L2NvbnRlbnQtZWxlbWVudC1pbi1wcm9ncmVzcy1lbGVtZW50Lmh0bWwKaW5kZXgg Yzk4MjJjODEyOWZjNTJiMGVhZTg4YmZhNWRhZTg0OTA3NjU3YzY3NC4uNjk1NzgxMzExODY0ZTBk MjM2MjExNDcwMjBlYzIwYTZkMTI5YzViYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9k b20vc2hhZG93L2NvbnRlbnQtZWxlbWVudC1pbi1wcm9ncmVzcy1lbGVtZW50Lmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2NvbnRlbnQtZWxlbWVudC1pbi1wcm9ncmVzcy1l bGVtZW50Lmh0bWwKQEAgLTI5LDE3ICsyOSwxMiBAQCB0ZXN0RnVuY3MucHVzaChmdW5jdGlvbiBj b250ZW50RWxlbWVudEluUHJvZ3Jlc3NFbGVtZW50KGNhbGxJZkRvbmUpIHsKIAogICAgIHZhciBz ciA9IG5ldyBXZWJLaXRTaGFkb3dSb290KGRpdik7CiAKLSAgICB2YXIgZiA9IChmdW5jdGlvbihz ciwgY2FsbElmRG9uZSkgewotICAgICAgICByZXR1cm4gZnVuY3Rpb24oKSB7Ci0gICAgICAgICAg ICB2YXIgcHJvZ3Jlc3MgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdwcm9ncmVzcycpOwotICAg ICAgICAgICAgdmFyIGNvbnRlbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdjb250ZW50Jyk7 Ci0gICAgICAgICAgICBwcm9ncmVzcy5hcHBlbmRDaGlsZChjb250ZW50KTsKLSAgICAgICAgICAg IHNyLmFwcGVuZENoaWxkKHByb2dyZXNzKTsKLSAgICAgICAgICAgIGNhbGxJZkRvbmUoKTsKLSAg ICAgICAgfTsKLSAgICB9KShzciwgY2FsbElmRG9uZSk7Ci0KLSAgICBzZXRUaW1lb3V0KGYsIDAp OworICAgIHZhciBwcm9ncmVzcyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3Byb2dyZXNzJyk7 CisgICAgdmFyIGNvbnRlbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdjb250ZW50Jyk7Cisg ICAgcHJvZ3Jlc3MuYXBwZW5kQ2hpbGQoY29udGVudCk7CisgICAgc3IuYXBwZW5kQ2hpbGQocHJv Z3Jlc3MpOworICAgIGRvY3VtZW50LmJvZHkub2Zmc2V0V2lkdGg7IC8vIGZvcmNlIHN0eWxlIHJl Y2FsYy4KKyAgICBjYWxsSWZEb25lKCk7CiB9KTsKIAogPC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvY29udGVudC1lbGVtZW50LWluLXNlbGVjdC1lbGVt ZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvY29udGVudC1lbGVtZW50LWlu LXNlbGVjdC1lbGVtZW50Lmh0bWwKaW5kZXggNTgxMzAxZDBmYTkwYmZhYzhlNjc3ZTE2NTlmMmI2 ZmYxZDUzZmQyZi4uMjJmZjg1MmIxZjczYTQ0N2IwZGZjZGFjNGFkMDYyM2E0ZWVhOWQwOCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2NvbnRlbnQtZWxlbWVudC1pbi1z ZWxlY3QtZWxlbWVudC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9jb250 ZW50LWVsZW1lbnQtaW4tc2VsZWN0LWVsZW1lbnQuaHRtbApAQCAtMjksMTcgKzI5LDEyIEBAIHRl c3RGdW5jcy5wdXNoKGZ1bmN0aW9uIGNvbnRlbnRFbGVtZW50SW5TZWxlY3RFbGVtZW50KGNhbGxJ ZkRvbmUpIHsKIAogICAgIHZhciBzciA9IG5ldyBXZWJLaXRTaGFkb3dSb290KGRpdik7CiAKLSAg ICB2YXIgZiA9IChmdW5jdGlvbihzciwgY2FsbElmRG9uZSkgewotICAgICAgICByZXR1cm4gZnVu Y3Rpb24oKSB7Ci0gICAgICAgICAgICB2YXIgc2VsZWN0ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgnc2VsZWN0Jyk7Ci0gICAgICAgICAgICB2YXIgY29udGVudCA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoJ2NvbnRlbnQnKTsKLSAgICAgICAgICAgIHNlbGVjdC5hcHBlbmRDaGlsZChjb250ZW50 KTsKLSAgICAgICAgICAgIHNyLmFwcGVuZENoaWxkKHNlbGVjdCk7Ci0gICAgICAgICAgICBjYWxs SWZEb25lKCk7Ci0gICAgICAgIH07Ci0gICAgfSkoc3IsIGNhbGxJZkRvbmUpOwotCi0gICAgc2V0 VGltZW91dChmLCAwKTsKKyAgICB2YXIgc2VsZWN0ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgn c2VsZWN0Jyk7CisgICAgdmFyIGNvbnRlbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdjb250 ZW50Jyk7CisgICAgc2VsZWN0LmFwcGVuZENoaWxkKGNvbnRlbnQpOworICAgIHNyLmFwcGVuZENo aWxkKHNlbGVjdCk7CisgICAgZG9jdW1lbnQuYm9keS5vZmZzZXRXaWR0aDsgLy8gZm9yY2Ugc3R5 bGUgcmVjYWxjLgorICAgIGNhbGxJZkRvbmUoKTsKIH0pOwogCiA8L3NjcmlwdD4K