84892 2012-04-25 14:47:45 -0700 [BlackBerry] Find-in-page fails to deactivate the old active match when moving backwards 2012-04-27 06:51:48 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 andchen webkit-unassigned mifenton tonikitoo webkit.review.bot oldest_to_newest 610063 0 andchen 2012-04-25 14:47:45 -0700 searchStartingPoint was incorrectly initialized. 610126 1 138888 andchen 2012-04-25 16:05:53 -0700 Created attachment 138888 patch 610176 2 138888 mifenton 2012-04-25 17:06:22 -0700 Comment on attachment 138888 patch View in context: https://bugs.webkit.org/attachment.cgi?id=138888&action=review > Source/WebKit/blackberry/ChangeLog:8 > + Find in page fails to deactivatee the old active match when moving backwards Typo deactivate > Source/WebKit/blackberry/WebKitSupport/InPageSearchManager.cpp:107 > + searchStartingPoint->setEnd(m_activeMatch->endPosition()); This seems unnecessary. It should use static PassRefPtr<Range> create(PassRefPtr<Document>, const Position&, const Position&); to constructor the range rather can create one for the entire page and reset both start and end. Can you explain why the copy of the range is invalid, but using the details is? Is the problem the use of RefPtr? 610202 3 138888 andchen 2012-04-25 17:26:38 -0700 Comment on attachment 138888 patch View in context: https://bugs.webkit.org/attachment.cgi?id=138888&action=review >> Source/WebKit/blackberry/WebKitSupport/InPageSearchManager.cpp:107 >> + searchStartingPoint->setEnd(m_activeMatch->endPosition()); > > This seems unnecessary. It should use static PassRefPtr<Range> create(PassRefPtr<Document>, const Position&, const Position&); to constructor the range rather can create one for the entire page and reset both start and end. > > Can you explain why the copy of the range is invalid, but using the details is? Is the problem the use of RefPtr? I can create it in that way. RefPtr<Range> searchStartingPoint(m_activeMatch) seems like not making a copy of Range, but making a copy of the RefPtr itself. Later, when we call this line(122): searchStartingPoint->setEnd(searchStartingPoint->startPosition()); it actually changes the end position of m_activeMatch, so if we try to deactivate it, the range has been changed so marker was not found. 610505 4 mifenton 2012-04-26 04:47:45 -0700 (In reply to comment #3) > RefPtr<Range> searchStartingPoint(m_activeMatch) seems like not making a copy of Range, but making a copy of the RefPtr itself. > Later, when we call this line(122): searchStartingPoint->setEnd(searchStartingPoint->startPosition()); it actually changes the end position of m_activeMatch, so if we try to deactivate it, the range has been changed so marker was not found. Yes, if you want a copy of the actual object you need to use m_activeMatch.get() Please give that a try. 610649 5 139011 andchen 2012-04-26 08:43:28 -0700 Created attachment 139011 patch 611018 6 139079 andchen 2012-04-26 14:59:32 -0700 Created attachment 139079 patch 611452 7 139079 webkit.review.bot 2012-04-27 06:51:42 -0700 Comment on attachment 139079 patch Clearing flags on attachment: 139079 Committed r115424: <http://trac.webkit.org/changeset/115424> 611453 8 webkit.review.bot 2012-04-27 06:51:48 -0700 All reviewed patches have been landed. Closing bug. 138888 2012-04-25 16:05:53 -0700 2012-04-26 04:48:01 -0700 patch 0001-2012-04-25-Andy-Chen-andchen-rim.com.patch text/plain 2974 andchen RnJvbSAxMjA0N2JmYjdkZTExMjZhODM0ZDZiMzQ2MjM1YWE1MDY1NTczYmFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmR5IENoZW4gPGFuZGNoZW5AcmltLmNvbT4KRGF0ZTogV2Vk LCAyNSBBcHIgMjAxMiAxNzozMTozNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDQtMjUg IEFuZHkgQ2hlbiAgPGFuZGNoZW5AcmltLmNvbT4KCiAgICAgICAgRmluZCBpbiBwYWdlIGZhaWxz IHRvIGRlYWN0aXZhdGVlIHRoZSBvbGQgYWN0aXZlIG1hdGNoIHdoZW4gbW92aW5nIGJhY2t3YXJk cwogICAgICAgIGJlY2F1c2Ugc2VhcmNoU3RhcnRpbmdQb2ludCB3YXMgaW5jb3JyZWN0bHkgaW5p dGlhbGl6ZWQuCiAgICAgICAgQ3JlYXRlIGEgcmVhbCByYW5nZSBvYmplY3QgaW5zdGVhZCBvZiBy ZWZlcmVuY2luZyBvdGhlciByYW5nZSBvYmplY3QuCiAgICAgICAgUFIxNTIwMDkKCiAgICAgICAg SW50ZXJuYWxseSByZXZpZXdlZCBieSBZb25neGluIERhaS4KCiAgICAgICAgKiBXZWJLaXRTdXBw b3J0L0luUGFnZVNlYXJjaE1hbmFnZXIuY3BwOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6 OkluUGFnZVNlYXJjaE1hbmFnZXI6OmZpbmROZXh0U3RyaW5nKToKLS0tCiBTb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysr KysrKysKIC4uLi9XZWJLaXRTdXBwb3J0L0luUGFnZVNlYXJjaE1hbmFnZXIuY3BwICAgICAgICAg IHwgICAgOCArKysrKysrLQogMiBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDM4Yzc5YWYuLjI5 N2Q2MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisy MDEyLTA0LTI1ICBBbmR5IENoZW4gIDxhbmRjaGVuQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNr QmVycnldIEZpbmQtaW4tcGFnZSBmYWlscyB0byBkZWFjdGl2YXRlIHRoZSBvbGQgYWN0aXZlIG1h dGNoIHdoZW4gbW92aW5nIGJhY2t3YXJkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODQ4OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaW5kIGluIHBhZ2UgZmFpbHMgdG8gZGVhY3RpdmF0ZWUgdGhlIG9s ZCBhY3RpdmUgbWF0Y2ggd2hlbiBtb3ZpbmcgYmFja3dhcmRzCisgICAgICAgIGJlY2F1c2Ugc2Vh cmNoU3RhcnRpbmdQb2ludCB3YXMgaW5jb3JyZWN0bHkgaW5pdGlhbGl6ZWQuCisgICAgICAgIENy ZWF0ZSBhIHJlYWwgcmFuZ2Ugb2JqZWN0IGluc3RlYWQgb2YgcmVmZXJlbmNpbmcgb3RoZXIgcmFu Z2Ugb2JqZWN0LgorICAgICAgICBQUiAxNTIwMDkKKworICAgICAgICBJbnRlcm5hbGx5IHJldmll d2VkIGJ5IFlvbmd4aW4gRGFpLgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JblBhZ2VTZWFy Y2hNYW5hZ2VyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5QYWdlU2VhcmNo TWFuYWdlcjo6ZmluZE5leHRTdHJpbmcpOgorCiAyMDEyLTA0LTI1ICBZb25nIExpICA8eW9saUBy aW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBQb3NzaWJsZSBKUyByZS1lbnRyYW5jeSBj YXVzZWQgYnkgVUkgZXZlbnRzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYktpdFN1cHBvcnQvSW5QYWdlU2VhcmNoTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNwcAppbmRleCBjYTRl YzJkLi5kNWI5YTM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNwcApAQCAtMjYsNiArMjYs NyBAQAogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiTm9kZS5oIgogI2luY2x1ZGUgIlBh Z2UuaCIKKyNpbmNsdWRlICJSYW5nZS5oIgogI2luY2x1ZGUgIlRleHRJdGVyYXRvci5oIgogI2lu Y2x1ZGUgIlRpbWVyLmgiCiAjaW5jbHVkZSAiV2ViUGFnZV9wLmgiCkBAIC05OSw3ICsxMDAsMTIg QEAgYm9vbCBJblBhZ2VTZWFyY2hNYW5hZ2VyOjpmaW5kTmV4dFN0cmluZyhjb25zdCBTdHJpbmcm IHRleHQsIEZpbmRPcHRpb25zIGZpbmRPcHQKICAgICBpZiAobV9hY3RpdmVNYXRjaCAmJiAhbV9h Y3RpdmVNYXRjaC0+Ym91bmRhcnlQb2ludHNWYWxpZCgpKQogICAgICAgICBtX2FjdGl2ZU1hdGNo ID0gMDsKIAotICAgIFJlZlB0cjxSYW5nZT4gc2VhcmNoU3RhcnRpbmdQb2ludChtX2FjdGl2ZU1h dGNoKTsKKyAgICBSZWZQdHI8UmFuZ2U+IHNlYXJjaFN0YXJ0aW5nUG9pbnQ7CisgICAgaWYgKG1f YWN0aXZlTWF0Y2gpIHsKKyAgICAgICAgc2VhcmNoU3RhcnRpbmdQb2ludCA9IHJhbmdlT2ZDb250 ZW50cyhtX2FjdGl2ZU1hdGNoLT5vd25lckRvY3VtZW50KCkpOworICAgICAgICBzZWFyY2hTdGFy dGluZ1BvaW50LT5zZXRTdGFydChtX2FjdGl2ZU1hdGNoLT5zdGFydFBvc2l0aW9uKCkpOworICAg ICAgICBzZWFyY2hTdGFydGluZ1BvaW50LT5zZXRFbmQobV9hY3RpdmVNYXRjaC0+ZW5kUG9zaXRp b24oKSk7CisgICAgfQogICAgIGJvb2wgbmV3U2VhcmNoID0gbV9hY3RpdmVTZWFyY2hTdHJpbmcg IT0gdGV4dDsKICAgICBib29sIGZvcndhcmQgPSAhKGZpbmRPcHRpb25zICYgV2ViQ29yZTo6QmFj a3dhcmRzKTsKICAgICBpZiAobmV3U2VhcmNoKSB7IC8vIFN0YXJ0IGEgbmV3IHNlYXJjaC4KLS0g CjEuNy41LjQKCg== 139011 2012-04-26 08:43:28 -0700 2012-04-26 14:59:51 -0700 patch 0001-2012-04-25-Andy-Chen-andchen-rim.com.patch text/plain 2843 andchen RnJvbSA0NzYxNGQ3MDNmOGNmNGI3MjhmZTdjMTlkNWU0OTgwNjVlYjliYzhjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmR5IENoZW4gPGFuZGNoZW5AcmltLmNvbT4KRGF0ZTogV2Vk LCAyNSBBcHIgMjAxMiAxNzozMTozNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDQtMjUg IEFuZHkgQ2hlbiAgPGFuZGNoZW5AcmltLmNvbT4KCiAgICAgICAgRmluZCBpbiBwYWdlIGZhaWxz IHRvIGRlYWN0aXZhdGUgdGhlIG9sZCBhY3RpdmUgbWF0Y2ggd2hlbiBtb3ZpbmcgYmFja3dhcmRz CiAgICAgICAgYmVjYXVzZSBzZWFyY2hTdGFydGluZ1BvaW50IHdhcyBpbmNvcnJlY3RseSBpbml0 aWFsaXplZC4KICAgICAgICBDcmVhdGUgYSByZWFsIHJhbmdlIG9iamVjdCBpbnN0ZWFkIG9mIHJl ZmVyZW5jaW5nIG90aGVyIHJhbmdlIG9iamVjdC4KICAgICAgICBQUjE1MjAwOQoKICAgICAgICBJ bnRlcm5hbGx5IHJldmlld2VkIGJ5IFlvbmd4aW4gRGFpLgoKICAgICAgICAqIFdlYktpdFN1cHBv cnQvSW5QYWdlU2VhcmNoTWFuYWdlci5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 SW5QYWdlU2VhcmNoTWFuYWdlcjo6ZmluZE5leHRTdHJpbmcpOgotLS0KIFNvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxNyArKysrKysrKysrKysr KysrKwogLi4uL1dlYktpdFN1cHBvcnQvSW5QYWdlU2VhcmNoTWFuYWdlci5jcHAgICAgICAgICAg fCAgICAzICsrLQogMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDM4Yzc5YWYuLjdmZGJkNTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0 LTI1ICBBbmR5IENoZW4gIDxhbmRjaGVuQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnld IEZpbmQtaW4tcGFnZSBmYWlscyB0byBkZWFjdGl2YXRlIHRoZSBvbGQgYWN0aXZlIG1hdGNoIHdo ZW4gbW92aW5nIGJhY2t3YXJkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODQ4OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaW5kIGluIHBhZ2UgZmFpbHMgdG8gZGVhY3RpdmF0ZSB0aGUgb2xkIGFjdGl2 ZSBtYXRjaCB3aGVuIG1vdmluZyBiYWNrd2FyZHMKKyAgICAgICAgYmVjYXVzZSBzZWFyY2hTdGFy dGluZ1BvaW50IHdhcyBpbmNvcnJlY3RseSBpbml0aWFsaXplZC4KKyAgICAgICAgQ3JlYXRlIGEg cmVhbCByYW5nZSBvYmplY3QgaW5zdGVhZCBvZiByZWZlcmVuY2luZyBvdGhlciByYW5nZSBvYmpl Y3QuCisgICAgICAgIFBSIDE1MjAwOQorCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkg WW9uZ3hpbiBEYWkuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0luUGFnZVNlYXJjaE1hbmFn ZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJblBhZ2VTZWFyY2hNYW5hZ2Vy OjpmaW5kTmV4dFN0cmluZyk6CisKIDIwMTItMDQtMjUgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+ CiAKICAgICAgICAgW0JsYWNrQmVycnldIFBvc3NpYmxlIEpTIHJlLWVudHJhbmN5IGNhdXNlZCBi eSBVSSBldmVudHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L0luUGFnZVNlYXJjaE1hbmFnZXIuY3BwCmluZGV4IGNhNGVjMmQuLjk5 OGI0ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L0luUGFnZVNlYXJjaE1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L0luUGFnZVNlYXJjaE1hbmFnZXIuY3BwCkBAIC0yNiw2ICsyNiw3IEBACiAj aW5jbHVkZSAiRnJhbWUuaCIKICNpbmNsdWRlICJOb2RlLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgor I2luY2x1ZGUgIlJhbmdlLmgiCiAjaW5jbHVkZSAiVGV4dEl0ZXJhdG9yLmgiCiAjaW5jbHVkZSAi VGltZXIuaCIKICNpbmNsdWRlICJXZWJQYWdlX3AuaCIKQEAgLTk5LDcgKzEwMCw3IEBAIGJvb2wg SW5QYWdlU2VhcmNoTWFuYWdlcjo6ZmluZE5leHRTdHJpbmcoY29uc3QgU3RyaW5nJiB0ZXh0LCBG aW5kT3B0aW9ucyBmaW5kT3B0CiAgICAgaWYgKG1fYWN0aXZlTWF0Y2ggJiYgIW1fYWN0aXZlTWF0 Y2gtPmJvdW5kYXJ5UG9pbnRzVmFsaWQoKSkKICAgICAgICAgbV9hY3RpdmVNYXRjaCA9IDA7CiAK LSAgICBSZWZQdHI8UmFuZ2U+IHNlYXJjaFN0YXJ0aW5nUG9pbnQobV9hY3RpdmVNYXRjaCk7Cisg ICAgUmVmUHRyPFJhbmdlPiBzZWFyY2hTdGFydGluZ1BvaW50ID0gbV9hY3RpdmVNYXRjaCA/IFJh bmdlOjpjcmVhdGUobV9hY3RpdmVNYXRjaC0+b3duZXJEb2N1bWVudCgpLCBtX2FjdGl2ZU1hdGNo LT5zdGFydFBvc2l0aW9uKCksIG1fYWN0aXZlTWF0Y2gtPmVuZFBvc2l0aW9uKCkpIDogMDsKICAg ICBib29sIG5ld1NlYXJjaCA9IG1fYWN0aXZlU2VhcmNoU3RyaW5nICE9IHRleHQ7CiAgICAgYm9v bCBmb3J3YXJkID0gIShmaW5kT3B0aW9ucyAmIFdlYkNvcmU6OkJhY2t3YXJkcyk7CiAgICAgaWYg KG5ld1NlYXJjaCkgeyAvLyBTdGFydCBhIG5ldyBzZWFyY2guCi0tIAoxLjcuNS40Cgo= 139079 2012-04-26 14:59:32 -0700 2012-04-27 06:51:42 -0700 patch 0001-2012-04-25-Andy-Chen-andchen-rim.com.patch text/plain 2793 andchen RnJvbSBkNTIxN2QxYWUzZmJlOTVlMjcyYzcxYzYxYTlkMDJlYmJjMjE4MzFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmR5IENoZW4gPGFuZGNoZW5AcmltLmNvbT4KRGF0ZTogV2Vk LCAyNSBBcHIgMjAxMiAxNzozMTozNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDQtMjUg IEFuZHkgQ2hlbiAgPGFuZGNoZW5AcmltLmNvbT4KCiAgICAgICAgRmluZCBpbiBwYWdlIGZhaWxz IHRvIGRlYWN0aXZhdGUgdGhlIG9sZCBhY3RpdmUgbWF0Y2ggd2hlbiBtb3ZpbmcgYmFja3dhcmRz CiAgICAgICAgYmVjYXVzZSBzZWFyY2hTdGFydGluZ1BvaW50IHdhcyBpbmNvcnJlY3RseSBpbml0 aWFsaXplZC4KICAgICAgICBDcmVhdGUgYSByZWFsIHJhbmdlIG9iamVjdCBpbnN0ZWFkIG9mIHJl ZmVyZW5jaW5nIG90aGVyIHJhbmdlIG9iamVjdC4KICAgICAgICBQUjE1MjAwOQoKICAgICAgICBJ bnRlcm5hbGx5IHJldmlld2VkIGJ5IE1pa2UgRmVudG9uLgoKICAgICAgICAqIFdlYktpdFN1cHBv cnQvSW5QYWdlU2VhcmNoTWFuYWdlci5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 SW5QYWdlU2VhcmNoTWFuYWdlcjo6ZmluZE5leHRTdHJpbmcpOgotLS0KIFNvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxNyArKysrKysrKysrKysr KysrKwogLi4uL1dlYktpdFN1cHBvcnQvSW5QYWdlU2VhcmNoTWFuYWdlci5jcHAgICAgICAgICAg fCAgICA0ICsrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCAzOGM3OWFmLi43ZmRiZDU3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0w NC0yNSAgQW5keSBDaGVuICA8YW5kY2hlbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5 XSBGaW5kLWluLXBhZ2UgZmFpbHMgdG8gZGVhY3RpdmF0ZSB0aGUgb2xkIGFjdGl2ZSBtYXRjaCB3 aGVuIG1vdmluZyBiYWNrd2FyZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg0ODkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRmluZCBpbiBwYWdlIGZhaWxzIHRvIGRlYWN0aXZhdGUgdGhlIG9sZCBhY3Rp dmUgbWF0Y2ggd2hlbiBtb3ZpbmcgYmFja3dhcmRzCisgICAgICAgIGJlY2F1c2Ugc2VhcmNoU3Rh cnRpbmdQb2ludCB3YXMgaW5jb3JyZWN0bHkgaW5pdGlhbGl6ZWQuCisgICAgICAgIENyZWF0ZSBh IHJlYWwgcmFuZ2Ugb2JqZWN0IGluc3RlYWQgb2YgcmVmZXJlbmNpbmcgb3RoZXIgcmFuZ2Ugb2Jq ZWN0LgorICAgICAgICBQUiAxNTIwMDkKKworICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5 IFlvbmd4aW4gRGFpLgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5h Z2VyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5QYWdlU2VhcmNoTWFuYWdl cjo6ZmluZE5leHRTdHJpbmcpOgorCiAyMDEyLTA0LTI1ICBZb25nIExpICA8eW9saUByaW0uY29t PgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBQb3NzaWJsZSBKUyByZS1lbnRyYW5jeSBjYXVzZWQg YnkgVUkgZXZlbnRzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvSW5QYWdlU2VhcmNoTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNwcAppbmRleCBjYTRlYzJkLi5j NDMyMmRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9y dC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv V2ViS2l0U3VwcG9ydC9JblBhZ2VTZWFyY2hNYW5hZ2VyLmNwcApAQCAtMjYsNiArMjYsNyBAQAog I2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiTm9kZS5oIgogI2luY2x1ZGUgIlBhZ2UuaCIK KyNpbmNsdWRlICJSYW5nZS5oIgogI2luY2x1ZGUgIlRleHRJdGVyYXRvci5oIgogI2luY2x1ZGUg IlRpbWVyLmgiCiAjaW5jbHVkZSAiV2ViUGFnZV9wLmgiCkBAIC05OSw3ICsxMDAsOCBAQCBib29s IEluUGFnZVNlYXJjaE1hbmFnZXI6OmZpbmROZXh0U3RyaW5nKGNvbnN0IFN0cmluZyYgdGV4dCwg RmluZE9wdGlvbnMgZmluZE9wdAogICAgIGlmIChtX2FjdGl2ZU1hdGNoICYmICFtX2FjdGl2ZU1h dGNoLT5ib3VuZGFyeVBvaW50c1ZhbGlkKCkpCiAgICAgICAgIG1fYWN0aXZlTWF0Y2ggPSAwOwog Ci0gICAgUmVmUHRyPFJhbmdlPiBzZWFyY2hTdGFydGluZ1BvaW50KG1fYWN0aXZlTWF0Y2gpOwor ICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOworICAgIFJlZlB0cjxSYW5nZT4gc2VhcmNoU3RhcnRp bmdQb2ludCA9IG1fYWN0aXZlTWF0Y2ggPyBtX2FjdGl2ZU1hdGNoLT5jbG9uZVJhbmdlKGVjKSA6 IDA7CiAgICAgYm9vbCBuZXdTZWFyY2ggPSBtX2FjdGl2ZVNlYXJjaFN0cmluZyAhPSB0ZXh0Owog ICAgIGJvb2wgZm9yd2FyZCA9ICEoZmluZE9wdGlvbnMgJiBXZWJDb3JlOjpCYWNrd2FyZHMpOwog ICAgIGlmIChuZXdTZWFyY2gpIHsgLy8gU3RhcnQgYSBuZXcgc2VhcmNoLgotLSAKMS43LjUuNAoK