84877 2012-04-25 11:16:59 -0700 Layout Test fast/css/getPropertyValue-border.html is failing 2012-04-26 14:44:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hclam bulach bulach rniwa webkit.review.bot oldest_to_newest 609928 0 hclam 2012-04-25 11:16:59 -0700 The following layout test is failing on chromium fast/css/getPropertyValue-border.html Probable cause: Test starts failing since this change: http://trac.webkit.org/changeset/115227 chromium.webkit flakiness bots results: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&tests=fast/css/getPropertyValue-border.html 609981 1 rniwa 2012-04-25 12:42:19 -0700 I think this was caused by my last-minute change to use StringBuilder. Will land a build fix soon. 610037 2 rniwa 2012-04-25 14:16:55 -0700 Fixed in http://trac.webkit.org/changeset/115244. 610487 3 bulach 2012-04-26 04:01:39 -0700 this test seems to be happy now: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss%2FgetPropertyValue-border.html should we remove it from test_expections.txt? 610502 4 rniwa 2012-04-26 04:41:21 -0700 Yes. 610528 5 bulach 2012-04-26 06:14:19 -0700 Reopening to attach new patch. 610529 6 138985 bulach 2012-04-26 06:14:22 -0700 Created attachment 138985 Patch 610802 7 138985 rniwa 2012-04-26 12:10:39 -0700 Comment on attachment 138985 Patch You can make these changes without a review. 610974 8 138985 webkit.review.bot 2012-04-26 14:25:32 -0700 Comment on attachment 138985 Patch Rejecting attachment 138985 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 3678. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ryosuke Ni..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12553002 611000 9 138985 rniwa 2012-04-26 14:44:24 -0700 Comment on attachment 138985 Patch Done in http://trac.webkit.org/changeset/115371. 138985 2012-04-26 06:14:22 -0700 2012-04-26 14:44:24 -0700 Patch bug-84877-20120426141421.patch text/plain 1270 bulach ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0MjcxN2MxYzM4NmI2YTM3NzE1MDUyZWQ2MmRhMjNkY2JkYzU3ODU0Li43MmUwNWQ5 ZWZkY2U2ZDM0YTM0MTg4NTkzNDYyZTcxYjg0NDAwZjZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTItMDQtMjYgIE1hcmN1cyBCdWxhY2ggIDxidWxhY2hAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFtjaHJvbWl1bV0gUmVtb3ZlcyBleHBlY3RhdGlvbiBmb3IgZmFzdC9jc3MvZ2V0UHJvcGVy dHlWYWx1ZS1ib3JkZXIuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODQ4NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXhlZCBieSByMTE1MjQ0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1 bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTItMDQtMjYgIENocmlzdG9waGUgRHVtZXog IDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBodHRwL3Rlc3RzL3NlY3Vy aXR5L2Nyb3NzLWZyYW1lLWFjY2Vzcy1wdXQuaHRtbCBpcyBmYWlsaW5nCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggY2Vm Y2E4NDcxOTEwMWM1MjBmYzNkMmM1MzhlZTFkMmU0ODAyZDVlMS4uM2IzMDFiYWYzYTgzOTA3OTM1 NmVmZGJhZTYwY2E3MGU4NDQxNGY0NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtMzY3OCw0ICszNjc4LDMgQEAgQlVH V0s4NDg1NCBMSU5VWCBYODYgOiBzdmcvYmF0aWsvdGV4dC92ZXJ0aWNhbFRleHRPblBhdGguc3Zn ID0gSU1BR0UgUEFTUwogQlVHV0s4MzU2OCA6IHN2Zy9jdXN0b20vcGF0aC16ZXJvLXN0cm9rZXdp ZHRoLnN2ZyA9IElNQUdFCiBCVUdXSzgzNTY4IDogc3ZnL2N1c3RvbS9qcy11cGRhdGUtc3R5bGUu c3ZnID0gSU1BR0UKIAotQlVHV0s4NDg3NyA6IGZhc3QvY3NzL2dldFByb3BlcnR5VmFsdWUtYm9y ZGVyLmh0bWwgPSBURVhUCg==