84875 2012-04-25 10:59:44 -0700 [Qt][WK2] Virtual keyboard is not showing when user clicks inside of <input> tag 2012-11-02 09:46:08 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.7 RESOLVED WORKSFORME P2 Normal --- 0 alex.bravo webkit-unassigned allan.jensen cmarcelo hugo.lima humitos jesus kenneth lauro.neto menard noam rafael.lobo webkit.review.bot zoltan oldest_to_newest 609911 0 alex.bravo 2012-04-25 10:59:44 -0700 This problem happens on both Linux (11.10 x64) and Harmattan/N9. One simple solution is to either add ItemAcceptsInputMethod permanently in here (new line is marked with //AB). From Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp: QtWebPageEventHandler::QtWebPageEventHandler(WKPageRef pageRef, QQuickWebPage* qmlWebPage, QQuickWebView* qmlWebView) : m_webPageProxy(toImpl(pageRef)) , m_interactionEngine(0) , m_panGestureRecognizer(this) , m_pinchGestureRecognizer(this) , m_tapGestureRecognizer(this) , m_webPage(qmlWebPage) , m_webView(qmlWebView) , m_previousClickButton(Qt::NoButton) , m_clickCount(0) , m_postponeTextInputStateChanged(false) { connect(qApp->inputPanel(), SIGNAL(visibleChanged()), this, SLOT(inputPanelVisibleChanged())); m_webView->setFlag(QQuickItem::ItemAcceptsInputMethod, true); //AB } Or alternatively add this flag only if editor content is editable: void QtWebPageEventHandler::updateTextInputState() { if (m_postponeTextInputStateChanged) return; const EditorState& editor = m_webPageProxy->editorState(); if (!m_webView->hasFocus()) return; // Ignore input method requests not due to a tap gesture. if (!editor.isContentEditable) { m_webView->setFlag(QQuickItem::ItemAcceptsInputMethod, false); //AB setInputPanelVisible(false); } } void QtWebPageEventHandler::doneWithGestureEvent(const WebGestureEvent& event, bool wasEventHandled) { if (event.type() != WebEvent::GestureSingleTap) return; m_postponeTextInputStateChanged = false; if (!wasEventHandled || !m_webView->hasFocus()) return; const EditorState& editor = m_webPageProxy->editorState(); bool newVisible = editor.isContentEditable; m_webView->setFlag(QQuickItem::ItemAcceptsInputMethod, newVisible); //AB } Note: Once this issue with ItemAcceptsInputMethod is solved, another bug in focusEditableArea() (called from QtWebPageEventHandler::inputPanelVisibleChanged()) shows up. This bug prevents Virtual keyboard from showing when user clicks inside of <input> tag second time (after Edit area is zoomed in once.) To temporary fix this problem and be able to use ZVirtual keyborad repeatedly, either zoom page manually or comment out two lines marked with //AB as shown below: void QtWebPageEventHandler::inputPanelVisibleChanged() { if (!m_interactionEngine) return; // We only respond to the input panel becoming visible. if (!m_webView->hasFocus() || !qApp->inputPanel()->visible()) return; const EditorState& editor = m_webPageProxy->editorState(); //AB if (editor.isContentEditable) //AB m_interactionEngine->focusEditableArea(QRectF(editor.cursorRect), QRectF(editor.editorRect)); } 609924 1 jesus 2012-04-25 11:14:19 -0700 Alex, thanks for looking into this! Do you plan to submit a patch for review following webkit guidelines? 609932 2 alex.bravo 2012-04-25 11:24:29 -0700 (In reply to comment #1) > Alex, thanks for looking into this! > > Do you plan to submit a patch for review following webkit guidelines? I wanted to get first the feedback on wheach of mentioned two ways of adding ItemAcceptsInputMethod is better before I do a patch. 609962 3 kenneth 2012-04-25 12:19:36 -0700 (In reply to comment #2) > (In reply to comment #1) > > Alex, thanks for looking into this! > > > > Do you plan to submit a patch for review following webkit guidelines? > > I wanted to get first the feedback on wheach of mentioned two ways of adding ItemAcceptsInputMethod is better before I do a patch. Even if it is not for review, it would be so much easier to give comments if it was uploaded as a patch 610197 4 138906 alex.bravo 2012-04-25 17:21:19 -0700 Created attachment 138906 Patch 610201 5 alex.bravo 2012-04-25 17:26:23 -0700 In the proccess of testing this patch I found out that the trunk works without this patch just fine - vkb is show and hidden. Which means that more investigation is needed on my part to find out which of the other of my changes are needed for this patch. 610746 6 lauro.neto 2012-04-26 11:13:56 -0700 How did you test it? I've just tested revision 115325 against the latest pinned Qt5 hash (From early April) and VKB is not shown. I tested using a release build with both Snowshoe[1] and Femto[2] on a PR1.2 N9. [1] http://github.com/snowshoe/snowshoe/ [2] https://gitorious.org/femto/femto 610768 7 alex.bravo 2012-04-26 11:38:25 -0700 (In reply to comment #6) > How did you test it? I'm using MiniBrowser. I tested yesterday with trunk at ebfce6a90080fe64aa07d009354ff4a975267782 on desktop. 610769 8 noam 2012-04-26 11:40:47 -0700 (In reply to comment #7) > (In reply to comment #6) > > How did you test it? > > I'm using MiniBrowser. I tested yesterday with trunk at ebfce6a90080fe64aa07d009354ff4a975267782 on desktop. You mean, on desktop with maliit enabled :) 610775 9 rafael.lobo 2012-04-26 11:44:00 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > How did you test it? > > > > I'm using MiniBrowser. I tested yesterday with trunk at ebfce6a90080fe64aa07d009354ff4a975267782 on desktop. > > You mean, on desktop with maliit enabled :) Did you run MiniBrowser in desktop mode or mobile? 610784 10 alex.bravo 2012-04-26 11:52:30 -0700 > Did you run MiniBrowser in desktop mode or mobile? I'm not using --desktop switch, which I guess makes it run in mobile mode? What's the difference? @No'am Yes, I malliit was installed. Abd Qt compiled with dbus. 612038 11 alex.bravo 2012-04-27 17:12:22 -0700 I verified that vkb is shown and hidden in MiniBrowser using revision 115493. There's still an issue with zooming in when the WebView is not the same size as the whole window, but that's a separate bug. So I'm marking this bug as resolved. 613070 12 138906 noam 2012-04-30 16:50:09 -0700 Comment on attachment 138906 Patch Clearing review flag. 757247 13 172077 humitos 2012-11-02 09:07:27 -0700 Created attachment 172077 Test case for type="text" and type="password" <input> tags Test case 757248 14 172077 humitos 2012-11-02 09:08:13 -0700 Comment on attachment 172077 Test case for type="text" and type="password" <input> tags I'm having a similar issue in Browse[1] (from the OLPC / Sugar Platform). It shows the Maliit virtual keyboard on <input type="text"> tags but it doesn't for <input type="password">. I create a simple script as test case. It shows a webpage that has two <input> tags, one is type="text" which reveals the virtual keyboard and the other one is type="password" that doesn't reveal the VK. It's attached. Any clue where I can take a look? [1] http://git.sugarlabs.org/browse 757276 15 humitos 2012-11-02 09:46:08 -0700 (In reply to comment #14) > Any clue where I can take a look? I found this bug that deals with this specific issue: * https://bugs.webkit.org/show_bug.cgi?id=34285 138906 2012-04-25 17:21:19 -0700 2012-04-30 16:50:09 -0700 Patch bug-84875-20120425172115.patch text/plain 2056 alex.bravo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWFmZGYzNTdjOTM2YWY5 NjM3YzMyZDcxNWVhYTFiMTZkM2JhZTBmOC4uMGRiM2RkZGJiZDVkMzZiYTIwZGU0MjcwNTkwNjFh NDBkNGEyYmU5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTI1ICBBbGV4 IEJyYXZvICA8YWxleC5icmF2b0Bub2tpYS5jb20+CisKKyAgICAgICAgW1F0XVtXSzJdIFZpcnR1 YWwga2V5Ym9hcmQgaXMgbm90IHNob3dpbmcgd2hlbiB1c2VyIGNsaWNrcyBpbnNpZGUgb2YgPGlu cHV0PiB0YWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg0ODc1CisKKyAgICAgICAgU2V0IEl0ZW1BY2NlcHRzSW5wdXRNZXRob2QgZmxhZyBvbiB3ZWJW aWV3IHRvIHRydWUgaWYgY29udGVudCBpcyBlZGl0YWJsZS4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVu dEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpRdFdlYlBhZ2VFdmVudEhhbmRsZXI6OnVw ZGF0ZVRleHRJbnB1dFN0YXRlKToKKyAgICAgICAgKFdlYktpdDo6UXRXZWJQYWdlRXZlbnRIYW5k bGVyOjpkb25lV2l0aEdlc3R1cmVFdmVudCk6CisKIDIwMTItMDQtMjUgIEVucmljYSBDYXN1Y2Np ICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTEwNDk0KTogRHJh Z2dpbmcgaW1hZ2VzIGZyb20gU2FmYXJpIHRvIEZpbmRlciByZXN1bHRzIGluIC53ZWJsb2MgcmF0 aGVyIHRoYW4gaW1hZ2UgZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv cXQvUXRXZWJQYWdlRXZlbnRIYW5kbGVyLmNwcAppbmRleCBkYzMxMzgyMzI1MGU5ZjdhYjc4MWQ5 MDEyMzAwMDIzNzVkODVkMDhhLi4zZTczZTM3NzVhNTcyNjRjMWI2Zjc3Mzk0YTEzYjU3NDk0NmJk MDVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZl bnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdl RXZlbnRIYW5kbGVyLmNwcApAQCAtNDEzLDggKzQxMywxMCBAQCB2b2lkIFF0V2ViUGFnZUV2ZW50 SGFuZGxlcjo6dXBkYXRlVGV4dElucHV0U3RhdGUoKQogICAgICAgICByZXR1cm47CiAKICAgICAv LyBJZ25vcmUgaW5wdXQgbWV0aG9kIHJlcXVlc3RzIG5vdCBkdWUgdG8gYSB0YXAgZ2VzdHVyZS4K LSAgICBpZiAoIWVkaXRvci5pc0NvbnRlbnRFZGl0YWJsZSkKKyAgICBpZiAoIWVkaXRvci5pc0Nv bnRlbnRFZGl0YWJsZSkgeworICAgICAgICBtX3dlYlZpZXctPnNldEZsYWcoUVF1aWNrSXRlbTo6 SXRlbUFjY2VwdHNJbnB1dE1ldGhvZCwgZmFsc2UpOwogICAgICAgICBzZXRJbnB1dFBhbmVsVmlz aWJsZShmYWxzZSk7CisgICAgfQogfQogCiB2b2lkIFF0V2ViUGFnZUV2ZW50SGFuZGxlcjo6ZG9u ZVdpdGhHZXN0dXJlRXZlbnQoY29uc3QgV2ViR2VzdHVyZUV2ZW50JiBldmVudCwgYm9vbCB3YXNF dmVudEhhbmRsZWQpCkBAIC00MzAsNiArNDMyLDcgQEAgdm9pZCBRdFdlYlBhZ2VFdmVudEhhbmRs ZXI6OmRvbmVXaXRoR2VzdHVyZUV2ZW50KGNvbnN0IFdlYkdlc3R1cmVFdmVudCYgZXZlbnQsIGIK ICAgICBjb25zdCBFZGl0b3JTdGF0ZSYgZWRpdG9yID0gbV93ZWJQYWdlUHJveHktPmVkaXRvclN0 YXRlKCk7CiAgICAgYm9vbCBuZXdWaXNpYmxlID0gZWRpdG9yLmlzQ29udGVudEVkaXRhYmxlOwog CisgICAgbV93ZWJWaWV3LT5zZXRGbGFnKFFRdWlja0l0ZW06Okl0ZW1BY2NlcHRzSW5wdXRNZXRo b2QsIG5ld1Zpc2libGUpOwogICAgIHNldElucHV0UGFuZWxWaXNpYmxlKG5ld1Zpc2libGUpOwog fQogCg== 172077 2012-11-02 09:07:27 -0700 2012-11-02 09:08:13 -0700 Test case for type="text" and type="password" <input> tags webkit_webview.py text/x-python 902 humitos ZnJvbSBnaS5yZXBvc2l0b3J5IGltcG9ydCBHdGsKZnJvbSBnaS5yZXBvc2l0b3J5IGltcG9ydCBX ZWJLaXQKCgpIVE1MID0gJycnCjxIVE1MPgo8SEVBRD4KICA8VElUTEU+VGVzdCBQYWdlPC9USVRM RT4KPC9IRUFEPgoKPFRBQkxFIEJPUkRFUj0iMCIgQ0VMTFNQQUNJTkc9IjIiIENFTExQQURESU5H PSIyIj4KICA8VFI+CiAgICA8VEQgQUxJR049IlJJR0hUIj48Rk9OVCBTSVpFPSItMSI+VXNlciBu YW1lOjwvRk9OVD48L1REPgogICAgPFREPjxJTlBVVCBOQU1FPSJsb2dpbm5hbWUiIFNJWkU9IjMw IiBUWVBFPSJ0ZXh0Ij48L1REPgogIDwvVFI+CiAgPFRSPgogICAgPFREIEFMSUdOPSJSSUdIVCI+ PEZPTlQgU0laRT0iLTEiPlBhc3N3b3JkOjwvRk9OVD48L1REPgogICAgPFREPjxJTlBVVCBOQU1F PSJwYXNzd29yZCIgVFlQRT0icGFzc3dvcmQiIFNJWkU9IjMwIj48L1REPgogIDwvVFI+CjwvVEFC TEU+PEJSPgoKPC9IVE1MPgonJycKCgpjbGFzcyBNeVdpbmRvdyhHdGsuV2luZG93KToKCiAgICBk ZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgR3RrLldpbmRvdy5fX2luaXRfXyhzZWxmLCB0aXRs ZT0iV2ViS2l0IE1hbGlpdCBJbnB1dCIpCiAgICAgICAgc2VsZi5zZXRfZGVmYXVsdF9zaXplKDI1 MCwgMjAwKQogICAgICAgIHNlbGYuY29ubmVjdCgiZGVsZXRlLWV2ZW50IiwgR3RrLm1haW5fcXVp dCkKCiAgICAgICAgd2VidmlldyA9IFdlYktpdC5XZWJWaWV3KCkKICAgICAgICB3ZWJ2aWV3Lmxv YWRfc3RyaW5nKEhUTUwsICd0ZXh0L2h0bWwnLCAndXRmOCcsICd0ZXN0JykKCiAgICAgICAgc2Vs Zi5hZGQod2VidmlldykKICAgICAgICBzZWxmLnNob3dfYWxsKCkKCgppZiBfX25hbWVfXyA9PSAn X19tYWluX18nOgogICAgd2luID0gTXlXaW5kb3coKQogICAgR3RrLm1haW4oKQo=