84873 2012-04-25 10:21:53 -0700 Make ScrollView::scrollSize scrollbar-independent 2012-04-27 18:09:49 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85002 1 tonikitoo tonikitoo andersca darin jamesr manyoso simon.fraser oldest_to_newest 609876 0 tonikitoo 2012-04-25 10:21:53 -0700 This method is so far tied to the existence of scrollbars to identify a scrollview as scrollable. for ports that disable scrollbars at FrameView creation it makes it impossible to use any ScrollAnimatorXXX method. 609889 1 138840 tonikitoo 2012-04-25 10:37:06 -0700 Created attachment 138840 (r115345 + r115401, r=andersca) patch v1 610026 2 manyoso 2012-04-25 13:52:33 -0700 Why have the conditional at all? Why not just calculate in your fashion irregardless of whether there are scrollbars or not? 610028 3 tonikitoo 2012-04-25 14:00:30 -0700 (In reply to comment #2) > Why have the conditional at all? Why not just calculate in your fashion irregardless of whether there are scrollbars or not? Fair enough. 610325 4 138927 tonikitoo 2012-04-25 21:09:44 -0700 Created attachment 138927 patch v2 - implementing what Adam questioned 610686 5 manyoso 2012-04-26 09:51:53 -0700 (In reply to comment #4) > Created an attachment (id=138927) [details] > patch v2 - implementing what Adam questioned LGTM, but since I haven't touched this code in a long time (at least not in upstream repo) I think someone else should review too. Thanks Antonio! 610897 6 138840 tonikitoo 2012-04-26 13:31:15 -0700 Comment on attachment 138840 (r115345 + r115401, r=andersca) patch v1 Committed: <http://trac.webkit.org/changeset/115345> 611668 7 darin 2012-04-27 10:50:01 -0700 It seems that http://trac.webkit.org/changeset/115401 went in without any comments here explaining why it’s needed. 611712 8 tonikitoo 2012-04-27 11:20:54 -0700 Ooh my :( I did a bad job at first (pushed the wrong patch) and at second (amended the proper patch as a diff against what was committed originally) without a changelog entry :/ Darin, want me to revert both, and push it properly? 612057 9 darin 2012-04-27 18:09:49 -0700 I’m not sure there is any significant benefit to trying to fix this now; I just would have liked to have a comment here in the bug explaining what happened. 138840 2012-04-25 10:37:06 -0700 2012-04-26 20:08:43 -0700 (r115345 + r115401, r=andersca) patch v1 0001-Make-ScrollView-scrollSize-scrollbars-independent-ht.patch text/plain 2769 tonikitoo RnJvbSBjNDY1ZTUxNmNkODBiNTU3ZmEwYTkwYzY1ZDUyMDRiYmY4YzE3NjQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog V2VkLCAyNSBBcHIgMjAxMiAxMzoyODoyOSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIE1ha2UgU2Ny b2xsVmlldzo6c2Nyb2xsU2l6ZSBzY3JvbGxiYXJzIGluZGVwZW5kZW50CiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ4NzMKClJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgpQYXRjaCBieSBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KCkZvciBwb3J0cyB0 aGF0IGRpc2FibGUgc2Nyb2xsYmFycyBjcmVhdGlvbiBhdCBGcmFtZVZpZXcgY3JlYXRpb24gdGlt ZQpTY3JvbGxWaWV3OjpzY3JvbGxTaXplIHNob3VsZCBzdGlsbCByZXR1cm4gdGhlIHNjcm9sbGFi bGUgYW1tb3VudCBvZgpjb250ZW50IChpZiBhbnkpIGlmIHNjcm9sbGluZyBpcyBub3QgcHJvaGli dGVkLgoKTm8gbmV3IHRlc3QsIGJ1dCBpdCBtYWtlcyBTY3JvbGxBbmltYXRvciB3b3JrIGZvciB0 aGUgQmxhY2tCZXJyeSBwb3J0LgoKKiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKFdlYkNvcmU6 OlNjcm9sbFZpZXc6OnNjcm9sbFNpemUpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9TY3JvbGxWaWV3LmNwcCB8ICAgIDcgKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyMyBp bnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5YmFhZTk1Li5jZGNi YjgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTItMDQtMjUgIEFudG9uaW8gR29t ZXMgIDxhZ29tZXNAcmltLmNvbT4KIAorICAgICAgICBNYWtlIFNjcm9sbFZpZXc6OnNjcm9sbFNp emUgc2Nyb2xsYmFycyBpbmRlcGVuZGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODQ4NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGb3IgcG9ydHMgdGhhdCBkaXNhYmxlIHNjcm9sbGJhcnMgY3JlYXRp b24gYXQgRnJhbWVWaWV3IGNyZWF0aW9uIHRpbWUKKyAgICAgICAgU2Nyb2xsVmlldzo6c2Nyb2xs U2l6ZSBzaG91bGQgc3RpbGwgcmV0dXJuIHRoZSBzY3JvbGxhYmxlIGFtbW91bnQgb2YKKyAgICAg ICAgY29udGVudCAoaWYgYW55KSBpZiBzY3JvbGxpbmcgaXMgbm90IHByb2hpYnRlZC4KKworICAg ICAgICBObyBuZXcgdGVzdCwgYnV0IGl0IG1ha2VzIFNjcm9sbEFuaW1hdG9yIHdvcmsgZm9yIHRo ZSBCbGFja0JlcnJ5IHBvcnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnNjcm9sbFNpemUpOgorCisyMDEyLTA0LTI1 ICBBbnRvbmlvIEdvbWVzICA8YWdvbWVzQHJpbS5jb20+CisKICAgICAgICAgRXh0ZW5kIFNjcm9s bEFuaW1hdG9yIHRvIGFsbG93IG92ZXJzY3JvbGxpbmcgd2hpbGUgdGhlIGFuaW1hdGlvbiBydW5z CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDYyNQog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IDFkY2M2ZTcuLmI5ODJk NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBAIC0zMjksNiArMzI5 LDEzIEBAIEludFBvaW50IFNjcm9sbFZpZXc6OmFkanVzdFNjcm9sbFBvc2l0aW9uV2l0aGluUmFu Z2UoY29uc3QgSW50UG9pbnQmIHNjcm9sbFBvaW50CiAKIGludCBTY3JvbGxWaWV3OjpzY3JvbGxT aXplKFNjcm9sbGJhck9yaWVudGF0aW9uIG9yaWVudGF0aW9uKSBjb25zdAogeworICAgIC8vIElm IG5vIHNjcm9sbGJhcnMgYXJlIHByZXNlbnQsIGl0IGRvZXMgbm90IGluZGljYXRlIGNvbnRlbnQg aXMgbm90IGJlIHNjcm9sbGFibGUuCisgICAgaWYgKCFtX2hvcml6b250YWxTY3JvbGxiYXIgJiYg IW1fdmVydGljYWxTY3JvbGxiYXIgJiYgIXByb2hpYml0c1Njcm9sbGluZygpKSB7CisgICAgICAg IEludFNpemUgc2Nyb2xsU2l6ZSA9IG1fY29udGVudHNTaXplIC0gdmlzaWJsZUNvbnRlbnRSZWN0 KCkuc2l6ZSgpOworICAgICAgICBzY3JvbGxTaXplLmNsYW1wTmVnYXRpdmVUb1plcm8oKTsKKyAg ICAgICAgcmV0dXJuIG9yaWVudGF0aW9uID09IEhvcml6b250YWxTY3JvbGxiYXIgPyBzY3JvbGxT aXplLndpZHRoKCkgOiBzY3JvbGxTaXplLmhlaWdodCgpOworICAgIH0KKwogICAgIFNjcm9sbGJh ciogc2Nyb2xsYmFyID0gKChvcmllbnRhdGlvbiA9PSBIb3Jpem9udGFsU2Nyb2xsYmFyKSA/IG1f aG9yaXpvbnRhbFNjcm9sbGJhciA6IG1fdmVydGljYWxTY3JvbGxiYXIpLmdldCgpOwogICAgIHJl dHVybiBzY3JvbGxiYXIgPyAoc2Nyb2xsYmFyLT50b3RhbFNpemUoKSAtIHNjcm9sbGJhci0+dmlz aWJsZVNpemUoKSkgOiAwOwogfQotLSAKMS43LjUuNAoK 138927 2012-04-25 21:09:44 -0700 2012-04-26 10:14:34 -0700 patch v2 - implementing what Adam questioned 0001-Make-ScrollView-scrollSize-scrollbar-independent.patch text/plain 2744 tonikitoo RnJvbSBiMzhhY2M1MjkxZTg0YjQ4NzU3YWNlNGExM2VkZThkZjljOWI4YzA4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog V2VkLCAyNSBBcHIgMjAxMiAxMzoyODoyOSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIE1ha2UgU2Ny b2xsVmlldzo6c2Nyb2xsU2l6ZSBzY3JvbGxiYXItaW5kZXBlbmRlbnQKIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDg3MwoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuClBhdGNoIGJ5IEFudG9uaW8gR29tZXMgPGFnb21lc0ByaW0uY29tPgoKRm9yIHBvcnRzIHRo YXQgZGlzYWJsZSBzY3JvbGxiYXJzIGF0IEZyYW1lVmlldyBjcmVhdGlvbiB0aW1lLApTY3JvbGxW aWV3OjpzY3JvbGxTaXplIHdvbid0IHdvcmsgYXMgaXMuIFBhdGNoIGNoYW5nZXMgaXQgdG8gd29y awppbmRlcGVuZGVudGx5IGZyb20gc2Nyb2xsYmFycyBwcmVzZW5jZS4KClBhdGNoIGlzIGFsc28g YSBzdGVwIGZvcndhcmQgdG8gbWFrZSBzY3JvbGxiYXJzICd2aWV3JyBvbmx5IG9iamVjdHMuCgpO byBuZXcgdGVzdCwgYnV0IGl0IG1ha2VzIFNjcm9sbEFuaW1hdG9yIHdvcmsgZm9yIHRoZSBCbGFj a0JlcnJ5IHBvcnQuCgoqIHBsYXRmb3JtL1Njcm9sbFZpZXcuY3BwOgooV2ViQ29yZTo6U2Nyb2xs Vmlldzo6c2Nyb2xsU2l6ZSk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgfCAgIDE4ICsrKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v U2Nyb2xsVmlldy5jcHAgfCAgICA1ICsrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGFlNzFmZWEuLmJiZGExMWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsNSArMSwyMyBAQAogMjAxMi0wNC0yNSAgQW50b25pbyBHb21lcyAgPGFn b21lc0ByaW0uY29tPgogCisgICAgICAgIE1ha2UgU2Nyb2xsVmlldzo6c2Nyb2xsU2l6ZSBzY3Jv bGxiYXItaW5kZXBlbmRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg0ODczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRm9yIHBvcnRzIHRoYXQgZGlzYWJsZSBzY3JvbGxiYXJzIGF0IEZyYW1lVmlldyBj cmVhdGlvbiB0aW1lLAorICAgICAgICBTY3JvbGxWaWV3OjpzY3JvbGxTaXplIHdvbid0IHdvcmsg YXMgaXMuIFBhdGNoIGNoYW5nZXMgaXQgdG8gd29yaworICAgICAgICBpbmRlcGVuZGVudGx5IGZy b20gc2Nyb2xsYmFycyBwcmVzZW5jZS4KKworICAgICAgICBQYXRjaCBpcyBhbHNvIGEgc3RlcCBm b3J3YXJkIHRvIG1ha2Ugc2Nyb2xsYmFycyAndmlldycgb25seSBvYmplY3RzLgorCisgICAgICAg IE5vIG5ldyB0ZXN0LCBidXQgaXQgbWFrZXMgU2Nyb2xsQW5pbWF0b3Igd29yayBmb3IgdGhlIEJs YWNrQmVycnkgcG9ydC4KKworICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbFZpZXcuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6c2Nyb2xsU2l6ZSk6CisKKzIwMTItMDQtMjUgIEFu dG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KKwogICAgICAgICBBZGQgU2Nyb2xsQW5pbWF0 b3JCbGFja0JlcnJ5IGFzIGFuIGV4dGVuc2lvbiB0byBTY3JvbGxBbmltYXRvck5vbmUKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NjI1CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKaW5kZXggNTJjZTc4OC4uYjliNzZjMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKQEAgLTM2Miw4ICszNjIsOSBAQCBJ bnRQb2ludCBTY3JvbGxWaWV3OjphZGp1c3RTY3JvbGxQb3NpdGlvbldpdGhpblJhbmdlKGNvbnN0 IEludFBvaW50JiBzY3JvbGxQb2ludAogCiBpbnQgU2Nyb2xsVmlldzo6c2Nyb2xsU2l6ZShTY3Jv bGxiYXJPcmllbnRhdGlvbiBvcmllbnRhdGlvbikgY29uc3QKIHsKLSAgICBTY3JvbGxiYXIqIHNj cm9sbGJhciA9ICgob3JpZW50YXRpb24gPT0gSG9yaXpvbnRhbFNjcm9sbGJhcikgPyBtX2hvcml6 b250YWxTY3JvbGxiYXIgOiBtX3ZlcnRpY2FsU2Nyb2xsYmFyKS5nZXQoKTsKLSAgICByZXR1cm4g c2Nyb2xsYmFyID8gKHNjcm9sbGJhci0+dG90YWxTaXplKCkgLSBzY3JvbGxiYXItPnZpc2libGVT aXplKCkpIDogMDsKKyAgICBJbnRTaXplIHNjcm9sbFNpemUgPSBtX2NvbnRlbnRzU2l6ZSAtIHZp c2libGVDb250ZW50UmVjdCgpLnNpemUoKTsKKyAgICBzY3JvbGxTaXplLmNsYW1wTmVnYXRpdmVU b1plcm8oKTsKKyAgICByZXR1cm4gb3JpZW50YXRpb24gPT0gSG9yaXpvbnRhbFNjcm9sbGJhciA/ IHNjcm9sbFNpemUud2lkdGgoKSA6IHNjcm9sbFNpemUuaGVpZ2h0KCk7CiB9CiAKIHZvaWQgU2Ny b2xsVmlldzo6bm90aWZ5UGFnZVRoYXRDb250ZW50QXJlYVdpbGxQYWludCgpIGNvbnN0Ci0tIAox LjcuNS40Cgo=