84864 2012-04-25 07:50:13 -0700 [Qt] Printing Page-Layouting broken (height unknown) 2012-05-02 08:07:23 -0700 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 milian.wolff webkit-unassigned webkit.review.bot oldest_to_newest 609749 0 milian.wolff 2012-04-25 07:50:13 -0700 Printing with the Qt port is currently broken, because the page height is not passed to the print context. This results in various issues, most prominently all those page-break-* CSS3 attributes are not handled. The reason that this was not catched by the existing unit tests, is that no ref/pixel test exists for this. Instead, the current tests use LTC::pageNumberForElementById which eventually calls PrintContext::pageNumberForElement, bypassing QWebFrame::print alltogether. The fix is trivial, one just needs to replace printContext.begin(pageRect.width()); with printContext.begin(pageRect.width(), pageRect.height()); in QWebFrame::print. I'll supply a patch for that. But I see no way to write a unit test for that (as that code creates PDFs). Anyhow, lets hope you will merge it anyways. 609875 1 138835 milian.wolff 2012-04-25 10:21:10 -0700 Created attachment 138835 Patch 614299 2 138835 webkit.review.bot 2012-05-02 08:07:19 -0700 Comment on attachment 138835 Patch Clearing flags on attachment: 138835 Committed r115832: <http://trac.webkit.org/changeset/115832> 614300 3 webkit.review.bot 2012-05-02 08:07:23 -0700 All reviewed patches have been landed. Closing bug. 138835 2012-04-25 10:21:10 -0700 2012-05-02 08:07:19 -0700 Patch bug-84864-20120425192108.patch text/plain 1421 milian.wolff U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDk4NTUzNDc2NjE5 NGJlNTgzYTZiYzQ4ZjQyZjY2YTU4YWFlNzI2ZDAuLjI1MjViYWFlOGM5OTNjZDE5MjdmMGU3YWYw ODZlMTgzZTNhZWViZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDQt MjUgIE1pbGlhbiBXb2xmZiAgPG1pbGlhbi53b2xmZkBrZGFiLmNvbT4KKworICAgICAgICBbUXRd IFBhc3MgcGFnZS1oZWlnaHQgdG8gUHJpbnRDb250ZXh0OjpiZWdpbiB0byBmaXggcHJpbnQgbGF5 b3V0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NDg2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog QXBpL3F3ZWJmcmFtZS5jcHA6CisgICAgICAgIChRV2ViRnJhbWU6OnByaW50KToKKwogMjAxMi0w NC0yNCAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAg ICAgICBSZXBsYWNlIG9jY3VyZW5jZXMgb2Ygc3R5bGUgc2VsZWN0b3IgZnJvbSB2YXJpYWJsZXMg YW5kIG1ldGhvZHMgbmFtZXMgYnkgc3R5bGUgcmVzb2x2ZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmZy YW1lLmNwcAppbmRleCBkY2YyMzA2MWRjZWUyZTY3NDcyNTg3OWMxNTdhYTNjNjAyNGRiZjkzLi5m MDlhOGE4MGRmYzEzZGY3NjZmNjMwYjY5ZjI0NWMxMDUwYzQ4M2MzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQXBp L3F3ZWJmcmFtZS5jcHAKQEAgLTE1MDksNyArMTUwOSw3IEBAIHZvaWQgUVdlYkZyYW1lOjpwcmlu dChRUHJpbnRlciAqcHJpbnRlcikgY29uc3QKICAgICAgICAgICAgICAgICAgICAgIGludChxcHJp bnRlclJlY3Qud2lkdGgoKSAvIHpvb21GYWN0b3JYKSwKICAgICAgICAgICAgICAgICAgICAgIGlu dChxcHJpbnRlclJlY3QuaGVpZ2h0KCkgLyB6b29tRmFjdG9yWSkpOwogCi0gICAgcHJpbnRDb250 ZXh0LmJlZ2luKHBhZ2VSZWN0LndpZHRoKCkpOworICAgIHByaW50Q29udGV4dC5iZWdpbihwYWdl UmVjdC53aWR0aCgpLCBwYWdlUmVjdC5oZWlnaHQoKSk7CiAKICAgICBwcmludENvbnRleHQuY29t cHV0ZVBhZ2VSZWN0cyhwYWdlUmVjdCwgLyogaGVhZGVySGVpZ2h0ICovIDAsIC8qIGZvb3Rlckhl aWdodCAqLyAwLCAvKiB1c2VyU2NhbGVGYWN0b3IgKi8gMS4wLCBwYWdlSGVpZ2h0KTsKIAo=